GNU bug report logs - #51679
29.0.50; [PATCH] Fix resize of xwidgets on GTK

Previous Next

Package: emacs;

Reported by: Po Lu <luangruo <at> yahoo.com>

Date: Mon, 8 Nov 2021 05:32:01 UTC

Severity: normal

Tags: patch

Found in version 29.0.50

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51679 in the body.
You can then email your comments to 51679 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#51679; Package emacs. (Mon, 08 Nov 2021 05:32:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Po Lu <luangruo <at> yahoo.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 08 Nov 2021 05:32:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; [PATCH] Fix resize of xwidgets on GTK
Date: Mon, 08 Nov 2021 13:31:17 +0800
[Message part 1 (text/plain, inline)]
gtk_container_resize_children doesn't always work, and the canonical way
to force a re-allocation is to just call gtk_widget_queue_allocate.

[0001-Fix-resize-of-xwidgets-on-GTK.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51679; Package emacs. (Mon, 08 Nov 2021 05:35:01 GMT) Full text and rfc822 format available.

Message #8 received at 51679 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 51679 <at> debbugs.gnu.org
Subject: Re: bug#51679: 29.0.50; [PATCH] Fix resize of xwidgets on GTK
Date: Mon, 08 Nov 2021 06:34:26 +0100
Thanks; applied to Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





bug marked as fixed in version 29.1, send any further explanations to 51679 <at> debbugs.gnu.org and Po Lu <luangruo <at> yahoo.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Mon, 08 Nov 2021 05:35:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51679; Package emacs. (Mon, 08 Nov 2021 05:42:02 GMT) Full text and rfc822 format available.

Message #13 received at 51679 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 51679 <at> debbugs.gnu.org
Subject: Re: bug#51679: 29.0.50; [PATCH] Fix resize of xwidgets on GTK
Date: Mon, 08 Nov 2021 13:41:17 +0800
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Thanks; applied to Emacs 29.

This is a trivial solution to problem that also exists in Emacs 28, so
perhaps it could be applied there too?

Thanks.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51679; Package emacs. (Mon, 08 Nov 2021 06:44:02 GMT) Full text and rfc822 format available.

Message #16 received at 51679 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 51679 <at> debbugs.gnu.org
Subject: Re: bug#51679: 29.0.50; [PATCH] Fix resize of xwidgets on GTK
Date: Mon, 08 Nov 2021 07:43:35 +0100
Po Lu <luangruo <at> yahoo.com> writes:

> This is a trivial solution to problem that also exists in Emacs 28, so
> perhaps it could be applied there too?

It's probably not a regression, though?  So it may be too late to put it
into Emacs 28.  Eli, what's your opinion?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51679; Package emacs. (Mon, 08 Nov 2021 06:59:02 GMT) Full text and rfc822 format available.

Message #19 received at 51679 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 51679 <at> debbugs.gnu.org
Subject: Re: bug#51679: 29.0.50; [PATCH] Fix resize of xwidgets on GTK
Date: Mon, 08 Nov 2021 14:57:56 +0800
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

>> This is a trivial solution to problem that also exists in Emacs 28, so
>> perhaps it could be applied there too?

> It's probably not a regression, though?  So it may be too late to put it
> into Emacs 28.  Eli, what's your opinion?

The bug this change fixes existed way back in Emacs 25, FWIW.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51679; Package emacs. (Mon, 08 Nov 2021 13:08:02 GMT) Full text and rfc822 format available.

Message #22 received at 51679 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: luangruo <at> yahoo.com, 51679 <at> debbugs.gnu.org
Subject: Re: bug#51679: 29.0.50; [PATCH] Fix resize of xwidgets on GTK
Date: Mon, 08 Nov 2021 15:07:31 +0200
> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Cc: 51679 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
> Date: Mon, 08 Nov 2021 07:43:35 +0100
> 
> Po Lu <luangruo <at> yahoo.com> writes:
> 
> > This is a trivial solution to problem that also exists in Emacs 28, so
> > perhaps it could be applied there too?
> 
> It's probably not a regression, though?  So it may be too late to put it
> into Emacs 28.  Eli, what's your opinion?

I don't know.  xwidget code has a relatively high probability of
causing crashes, but if the original code already causes trouble,
maybe it's okay.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51679; Package emacs. (Tue, 09 Nov 2021 03:25:02 GMT) Full text and rfc822 format available.

Message #25 received at 51679 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 51679 <at> debbugs.gnu.org
Subject: Re: bug#51679: 29.0.50; [PATCH] Fix resize of xwidgets on GTK
Date: Tue, 09 Nov 2021 04:24:33 +0100
Po Lu <luangruo <at> yahoo.com> writes:

>>> This is a trivial solution to problem that also exists in Emacs 28, so
>>> perhaps it could be applied there too?
>
>> It's probably not a regression, though?  So it may be too late to put it
>> into Emacs 28.  Eli, what's your opinion?
>
> The bug this change fixes existed way back in Emacs 25, FWIW.

OK, then I'd rather not push it to emacs-28 -- it the bug's existed that
long, it doesn't seem to be vital to fix it in Emacs 28.1 now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51679; Package emacs. (Tue, 09 Nov 2021 03:26:02 GMT) Full text and rfc822 format available.

Message #28 received at 51679 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 51679 <at> debbugs.gnu.org
Subject: Re: bug#51679: 29.0.50; [PATCH] Fix resize of xwidgets on GTK
Date: Tue, 09 Nov 2021 11:25:24 +0800
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> OK, then I'd rather not push it to emacs-28 -- it the bug's existed that
> long, it doesn't seem to be vital to fix it in Emacs 28.1 now.

Fair enough, thanks.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 07 Dec 2021 12:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 111 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.