GNU bug report logs - #51702
29.0.50; [PATCH] Fix xwidget buffer name being stuck on something nonsensical

Previous Next

Package: emacs;

Reported by: Po Lu <luangruo <at> yahoo.com>

Date: Tue, 9 Nov 2021 06:40:01 UTC

Severity: normal

Tags: patch

Found in version 29.0.50

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51702 in the body.
You can then email your comments to 51702 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#51702; Package emacs. (Tue, 09 Nov 2021 06:40:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Po Lu <luangruo <at> yahoo.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 09 Nov 2021 06:40:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; [PATCH] Fix xwidget buffer name being stuck on something
 nonsensical
Date: Tue, 09 Nov 2021 14:39:32 +0800
[Message part 1 (text/plain, inline)]
Thanks.

[0001-Always-set-xwidget-title-if-the-event-was-load-finis.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51702; Package emacs. (Tue, 09 Nov 2021 06:48:01 GMT) Full text and rfc822 format available.

Message #8 received at 51702 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 51702 <at> debbugs.gnu.org
Subject: Re: bug#51702: 29.0.50; [PATCH] Fix xwidget buffer name being stuck
 on something nonsensical
Date: Tue, 09 Nov 2021 07:46:55 +0100
Po Lu <luangruo <at> yahoo.com> writes:

> Thanks.

Pushed.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




bug marked as fixed in version 29.1, send any further explanations to 51702 <at> debbugs.gnu.org and Po Lu <luangruo <at> yahoo.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Tue, 09 Nov 2021 06:48:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51702; Package emacs. (Tue, 09 Nov 2021 06:56:01 GMT) Full text and rfc822 format available.

Message #13 received at 51702 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 51702 <at> debbugs.gnu.org
Subject: Re: bug#51702: 29.0.50; [PATCH] Fix xwidget buffer name being stuck
 on something nonsensical
Date: Tue, 09 Nov 2021 14:54:48 +0800
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Pushed.

Thanks, and I really hope I'm not being annoying opening an issue for
each different patch.

Perhaps I should just open an existing "tracking" issue to post changes
to?  Or post them to emacs-devel instead?

Thanks.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51702; Package emacs. (Tue, 09 Nov 2021 12:51:01 GMT) Full text and rfc822 format available.

Message #16 received at 51702 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 51702 <at> debbugs.gnu.org
Subject: Re: bug#51702: 29.0.50;
 [PATCH] Fix xwidget buffer name being stuck on something nonsensical
Date: Tue, 09 Nov 2021 14:50:19 +0200
> Date: Tue, 09 Nov 2021 14:39:32 +0800
> From:  Po Lu via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> >From a943d9b995d701d4ae7029f6f6f3ae91ceb3a29b Mon Sep 17 00:00:00 2001
> From: Po Lu <luangruo <at> yahoo.com>
> Date: Tue, 9 Nov 2021 14:37:47 +0800
> Subject: [PATCH] Always set xwidget title if the event was "load-finished"
> 
> * lisp/xwidget.el (xwidget-webkit-callback): Always set title upon
> load completion.  This prevents loading pages such as "about:blank"
> from not setting the buffer name.
> ---
>  lisp/xwidget.el | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/lisp/xwidget.el b/lisp/xwidget.el
> index fc37798322..905327083b 100644
> --- a/lisp/xwidget.el
> +++ b/lisp/xwidget.el
> @@ -360,9 +360,11 @@ xwidget-webkit-callback
>      (cond ((eq xwidget-event-type 'load-changed)
>             (let ((title (xwidget-webkit-title xwidget)))
>               ;; This funciton will be called multi times, so only
> -             ;; change buffer name when get a valid title. this can
> -             ;; limit buffer-name flicker in mode-line.
> -             (when (> (length title) 0)
> +             ;; change buffer name when the load actually completes
> +             ;; this can limit buffer-name flicker in mode-line.
> +             (when (or (string-equal (nth 3 last-input-event)
> +                                     "load-finished")
> +                       (> (length title) 0))

You've lost the period in the comment there.  And the sentence after
that should be capitalized, of course.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51702; Package emacs. (Tue, 09 Nov 2021 12:59:01 GMT) Full text and rfc822 format available.

Message #19 received at 51702 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 51702 <at> debbugs.gnu.org
Subject: Re: bug#51702: 29.0.50; [PATCH] Fix xwidget buffer name being stuck
 on something nonsensical
Date: Tue, 09 Nov 2021 20:58:10 +0800
[Message part 1 (text/plain, inline)]
Eli Zaretskii <eliz <at> gnu.org> writes:

> You've lost the period in the comment there.

Thanks for this catch.

>And the sentence after that should be capitalized, of course.

Thanks.  I was trying to keep the style of the original comment intact,
but now that you've brought it up I see no harm in changing it.

Please see the attached change.

[0001-Fix-comment-capitalization-in-xwidget.el.patch (text/x-patch, inline)]
From c569e2419886f30940032745da76e99342d0a5d8 Mon Sep 17 00:00:00 2001
From: Po Lu <luangruo <at> yahoo.com>
Date: Tue, 9 Nov 2021 20:57:19 +0800
Subject: [PATCH] Fix comment capitalization in xwidget.el

* lisp/xwidget.el (xwidget-webkit-callback): Rectify comment.
---
 lisp/xwidget.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/xwidget.el b/lisp/xwidget.el
index 905327083b..28add0db0a 100644
--- a/lisp/xwidget.el
+++ b/lisp/xwidget.el
@@ -360,8 +360,8 @@ xwidget-webkit-callback
     (cond ((eq xwidget-event-type 'load-changed)
            (let ((title (xwidget-webkit-title xwidget)))
              ;; This funciton will be called multi times, so only
-             ;; change buffer name when the load actually completes
-             ;; this can limit buffer-name flicker in mode-line.
+             ;; change buffer name when the load actually completes.
+             ;; This can limit buffer-name flicker in mode-line.
              (when (or (string-equal (nth 3 last-input-event)
                                      "load-finished")
                        (> (length title) 0))
-- 
2.31.1


Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51702; Package emacs. (Tue, 09 Nov 2021 13:36:02 GMT) Full text and rfc822 format available.

Message #22 received at 51702 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 51702 <at> debbugs.gnu.org
Subject: Re: bug#51702: 29.0.50; [PATCH] Fix xwidget buffer name being stuck
 on something nonsensical
Date: Tue, 09 Nov 2021 15:35:32 +0200
> From: Po Lu <luangruo <at> yahoo.com>
> Cc: 51702 <at> debbugs.gnu.org
> Date: Tue, 09 Nov 2021 20:58:10 +0800
> 
> >And the sentence after that should be capitalized, of course.
> 
> Thanks.  I was trying to keep the style of the original comment intact,
> but now that you've brought it up I see no harm in changing it.

There's no reason to keep typos and bad style intact ;-)

> diff --git a/lisp/xwidget.el b/lisp/xwidget.el
> index 905327083b..28add0db0a 100644
> --- a/lisp/xwidget.el
> +++ b/lisp/xwidget.el
> @@ -360,8 +360,8 @@ xwidget-webkit-callback
>      (cond ((eq xwidget-event-type 'load-changed)
>             (let ((title (xwidget-webkit-title xwidget)))
>               ;; This funciton will be called multi times, so only
> -             ;; change buffer name when the load actually completes
> -             ;; this can limit buffer-name flicker in mode-line.
> +             ;; change buffer name when the load actually completes.
> +             ;; This can limit buffer-name flicker in mode-line.
>               (when (or (string-equal (nth 3 last-input-event)
>                                       "load-finished")
>                         (> (length title) 0))

I'm happy now.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51702; Package emacs. (Tue, 09 Nov 2021 13:52:01 GMT) Full text and rfc822 format available.

Message #25 received at 51702 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 51702 <at> debbugs.gnu.org
Subject: Re: bug#51702: 29.0.50; [PATCH] Fix xwidget buffer name being stuck
 on something nonsensical
Date: Tue, 09 Nov 2021 21:51:26 +0800
Eli Zaretskii <eliz <at> gnu.org> writes:

> There's no reason to keep typos and bad style intact ;-)

Thanks, point taken.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51702; Package emacs. (Tue, 09 Nov 2021 17:35:01 GMT) Full text and rfc822 format available.

Message #28 received at 51702 <at> debbugs.gnu.org (full text, mbox):

From: Benjamin Riefenstahl <b.riefenstahl <at> turtle-trading.net>
To: Po Lu <luangruo <at> yahoo.com>, 51702 <at> debbugs.gnu.org
Subject: Re: bug#51702: 29.0.50; [PATCH] Fix xwidget buffer name being stuck
 on something nonsensical
Date: Tue, 09 Nov 2021 18:33:56 +0100
Po Lu writes:
> diff --git a/lisp/xwidget.el b/lisp/xwidget.el
> index 905327083b..28add0db0a 100644
> --- a/lisp/xwidget.el
> +++ b/lisp/xwidget.el
> @@ -360,8 +360,8 @@ xwidget-webkit-callback
>      (cond ((eq xwidget-event-type 'load-changed)
>             (let ((title (xwidget-webkit-title xwidget)))
>               ;; This funciton will be called multi times, so only

While you're at it, how about: "This function will be called multiple
times" or even "several times".  ;-)

> -             ;; change buffer name when the load actually completes


Regards, benny




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 08 Dec 2021 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 101 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.