GNU bug report logs - #51731
[PATCH] gnome-tweaks fails to start on core-updates-frozen

Previous Next

Package: guix;

Reported by: Vivien Kraus <vivien <at> planete-kraus.eu>

Date: Tue, 9 Nov 2021 23:11:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51731 in the body.
You can then email your comments to 51731 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-guix <at> gnu.org:
bug#51731; Package guix. (Tue, 09 Nov 2021 23:11:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Vivien Kraus <vivien <at> planete-kraus.eu>:
New bug report received and forwarded. Copy sent to bug-guix <at> gnu.org. (Tue, 09 Nov 2021 23:11:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: bug-guix <at> gnu.org
Subject: [PATCH] gnome-tweaks fails to start on core-updates-frozen
Date: Tue, 09 Nov 2021 23:10:29 +0000
[Message part 1 (text/plain, inline)]
Dear guix,

gnome-tweaks does not start on core-updates-frozen, because it needs
libhandy 1 and is given libhandy 0.0.

Also, it cannot find its own python module, so the python path needs to
be wrapped.

I fixed a couple of linter errors, and applied guix style to
it. However, now the linter complains that we have the "bin" output of
glib in something that would be called "glib" and not "glib:bin"… Should
we still keep the styled output?

Best regards,

Vivien

[0001-gnu-gnome-tweaks-Use-libhandy-1.patch (text/x-patch, attachment)]
[0002-gnu-gnome-tweaks-Set-the-python-path.patch (text/x-patch, attachment)]
[0003-gnu-gnome-tweaks-gobject-introspection-should-be-a-n.patch (text/x-patch, attachment)]
[0004-gnu-gnome-tweaks-Add-bash-minimal-as-an-input-to-wra.patch (text/x-patch, attachment)]
[0005-gnu-gnome-tweaks-Style-it.patch (text/x-patch, attachment)]
[signature.asc (application/pgp-signature, inline)]

Information forwarded to bug-guix <at> gnu.org:
bug#51731; Package guix. (Wed, 10 Nov 2021 17:33:02 GMT) Full text and rfc822 format available.

Message #8 received at 51731 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Vivien Kraus <vivien <at> planete-kraus.eu>, 51731 <at> debbugs.gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [PATCH] gnome-tweaks fails to start on core-updates-frozen
Date: Wed, 10 Nov 2021 18:32:35 +0100
Hi,

Am Dienstag, den 09.11.2021, 23:10 +0000 schrieb Vivien Kraus:
> I fixed a couple of linter errors, and applied guix style to
> it. However, now the linter complains that we have the "bin" output
> of glib in something that would be called "glib" and not "glib:bin"…
> Should we still keep the styled output?
IIUC that's an issue with the linter or perhaps the implementation of
short input lists in general.  I've CC'd Ludo as he is the one who
allowed us to write inputs (list bash sed ...) in the first place,
perhaps he knows what to do here.  We probably ought to convert this to
short-style inputs anyway.

> Subject: [PATCH 1/5] gnu: gnome-tweaks: Use libhandy 1.
Note, libhandy 0.0 only exists on master (and therefore core-updates),
because there are packages still using it.  If there's no more users
post updating gnome-tweaks, it is to be removed!

> Subject: [PATCH 2/5] gnu: gnome-tweaks: Set the python path.
Nice catch, I think this was previously done by a different phase. 
However...
> gnu/packages/gnome.scm (gnome-tweaks)[phases]: Also wrap with
> GUIX_PYTHONPATH.
Please note the phase and perhaps change its name to reflect what it
does.

> Subject: [PATCH 3/5] gnu: gnome-tweaks: gobject-introspection should
> be a native input.
I'm not sure this is the correct move here.  Python uses GI at runtime,
not natively during build.  If gnome-tweaks requires GI at build time,
it's to be added as both inputs.

> Subject: [PATCH 4/5] gnu: gnome-tweaks: Add bash-minimal as an input
> to wrap the program.
Split the long line.  Also perhaps add a comment in the file itself as
to why this is needed if it's not already obvious from best practises
in core-updates-frozen.

> Subject: [PATCH 5/5] gnu: gnome-tweaks: Style it.
This should probably done first, particularly if it helps avoid the
linter complaints you encounter.

In my personal opinion, 1, 3, 4 and 5 could also be done in a single
commit, though YMMV.  Also, I'm not active on core-updates-frozen, so
take everything I said as lexical analysis at best and with sufficient
amounts of salt.

Cheers,
Liliana





Information forwarded to bug-guix <at> gnu.org:
bug#51731; Package guix. (Wed, 10 Nov 2021 20:48:01 GMT) Full text and rfc822 format available.

Message #11 received at 51731 <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 51731 <at> debbugs.gnu.org, Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [PATCH] gnome-tweaks fails to start on core-updates-frozen
Date: Wed, 10 Nov 2021 20:20:38 +0000
[Message part 1 (text/plain, inline)]
Hello,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:
> Am Dienstag, den 09.11.2021, 23:10 +0000 schrieb Vivien Kraus:
>> I fixed a couple of linter errors, and applied guix style to
>> it. However, now the linter complains that we have the "bin" output
>> of glib in something that would be called "glib" and not "glib:bin"…
>> Should we still keep the styled output?
> IIUC that's an issue with the linter or perhaps the implementation of
> short input lists in general.  I've CC'd Ludo as he is the one who
> allowed us to write inputs (list bash sed ...) in the first place,
> perhaps he knows what to do here.  We probably ought to convert this to
> short-style inputs anyway.
Apparently, we shouldn’t apply guix style yet, we will apply it for all
packages at once some day.

>> Subject: [PATCH 1/5] gnu: gnome-tweaks: Use libhandy 1.
> Note, libhandy 0.0 only exists on master (and therefore core-updates),
> because there are packages still using it.  If there's no more users
> post updating gnome-tweaks, it is to be removed!
I tried, but there are 2 problems:
1. I can’t update authenticator (gnu/packages/gnome.scm), because
upstream switched to Rust and I don’t know how to package that;
2. Geary needs it too (and gmime 2, which we could drop the same way),
but it’s a pain to upgrade. I went a long way, but there’s some vala
code that acts on strings as if they were arrays and I don’t know what
happens: maybe a newer vala is required, or the glib string type does
not apply for some reason.

However, I can provide an upgrade for seahorse (and its dependency
gcr). That’s a start, I guess.
:)

>> Subject: [PATCH 2/5] gnu: gnome-tweaks: Set the python path.
> Nice catch, I think this was previously done by a different phase. 
> However...
>> gnu/packages/gnome.scm (gnome-tweaks)[phases]: Also wrap with
>> GUIX_PYTHONPATH.
> Please note the phase and perhaps change its name to reflect what it
> does.
Is the 'wrap-gi-typelib-and-python boring name appropriate?

>> Subject: [PATCH 3/5] gnu: gnome-tweaks: gobject-introspection should
>> be a native input.
> I'm not sure this is the correct move here.  Python uses GI at runtime,
> not natively during build.  If gnome-tweaks requires GI at build time,
> it's to be added as both inputs.
It does not, I’ll drop it.

>> Subject: [PATCH 4/5] gnu: gnome-tweaks: Add bash-minimal as an input
>> to wrap the program.
> Split the long line.  Also perhaps add a comment in the file itself as
> to why this is needed if it's not already obvious from best practises
> in core-updates-frozen.
It’s flagged by the linter, because wrapping a program produces a shell
script that needs to be executed.

>> Subject: [PATCH 5/5] gnu: gnome-tweaks: Style it.
> This should probably done first, particularly if it helps avoid the
> linter complaints you encounter.
I’ve dropped the guix style for the reason above.

> In my personal opinion, 1, 3, 4 and 5 could also be done in a single
> commit, though YMMV.  Also, I'm not active on core-updates-frozen, so
> take everything I said as lexical analysis at best and with sufficient
> amounts of salt.
I’ll wait for more desalinated advice, because lumping commits together
is easier than separating a big one.

[0001-gnu-gnome-tweaks-Use-libhandy-1.patch (text/x-patch, attachment)]
[0002-gnu-gnome-tweaks-Set-the-python-path.patch (text/x-patch, attachment)]
[0003-gnu-gnome-tweaks-Add-bash-minimal-as-an-input.patch (text/x-patch, attachment)]
[0004-gnu-gcr-Upgrade-to-3.41.0.patch (text/x-patch, attachment)]
[0005-gnu-seahorse-Upgrade-to-41.0.patch (text/x-patch, attachment)]
[Message part 7 (text/plain, inline)]

Vivien
[signature.asc (application/pgp-signature, inline)]

Information forwarded to bug-guix <at> gnu.org:
bug#51731; Package guix. (Thu, 11 Nov 2021 20:44:01 GMT) Full text and rfc822 format available.

Message #14 received at 51731 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Vivien Kraus <vivien <at> planete-kraus.eu>
Cc: 51731 <at> debbugs.gnu.org, Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [PATCH] gnome-tweaks fails to start on core-updates-frozen
Date: Thu, 11 Nov 2021 21:43:37 +0100
Hi,

Am Mittwoch, den 10.11.2021, 20:20 +0000 schrieb Vivien Kraus:
> Apparently, we shouldn’t apply guix style yet, we will apply it for
> all packages at once some day.
I don't think it's a rule that you can't at all; rather that you
shouldn't when you're not already touching that package.  Then again,
I'll leave the decision to you and the experts who actually work on
core-updates-frozen :)

> > Note, libhandy 0.0 only exists on master (and therefore core-
> > updates), because there are packages still using it.  If there's no
> > more users post updating gnome-tweaks, it is to be removed!
> I tried, but there are 2 problems:
> 1. I can’t update authenticator (gnu/packages/gnome.scm), because
> upstream switched to Rust and I don’t know how to package that;
> 2. Geary needs it too (and gmime 2, which we could drop the same
> way), but it’s a pain to upgrade. I went a long way, but there’s some
> vala code that acts on strings as if they were arrays and I don’t
> know what happens: maybe a newer vala is required, or the glib string
> type does not apply for some reason.
Fair enough, that's a few users more than I remembered.

> > > Subject: [PATCH 2/5] gnu: gnome-tweaks: Set the python path.
> > Nice catch, I think this was previously done by a different phase. 
> > However...
> > > gnu/packages/gnome.scm (gnome-tweaks)[phases]: Also wrap with
> > > GUIX_PYTHONPATH.
> > Please note the phase and perhaps change its name to reflect what
> > it
> > does.
> Is the 'wrap-gi-typelib-and-python boring name appropriate?
Good enough for me, there's some similar phase names flying around in
gnome.scm.

> > > Subject: [PATCH 4/5] gnu: gnome-tweaks: Add bash-minimal as an
> > > input to wrap the program.
> > Split the long line.  Also perhaps add a comment in the file itself
> > as to why this is needed if it's not already obvious from best
> > practises in core-updates-frozen.
> It’s flagged by the linter, because wrapping a program produces a
> shell script that needs to be executed.
"Flagged by the linter" is not a good description in a commit message
or elsewhere.  I think a few packages on c-u-frozen might have a
comment along the lines of "; for wrap-program" or similar.

Cheers





Information forwarded to bug-guix <at> gnu.org:
bug#51731; Package guix. (Sat, 13 Nov 2021 09:30:01 GMT) Full text and rfc822 format available.

Message #17 received at 51731 <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 51731 <at> debbugs.gnu.org, Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [PATCH] gnome-tweaks fails to start on core-updates-frozen
Date: Sat, 13 Nov 2021 09:06:26 +0000
[Message part 1 (text/plain, inline)]
Hello!

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:
>> > > Subject: [PATCH 4/5] gnu: gnome-tweaks: Add bash-minimal as an
>> > > input to wrap the program.
>> > Split the long line.  Also perhaps add a comment in the file itself
>> > as to why this is needed if it's not already obvious from best
>> > practises in core-updates-frozen.
>> It’s flagged by the linter, because wrapping a program produces a
>> shell script that needs to be executed.
> "Flagged by the linter" is not a good description in a commit message
> or elsewhere.  I think a few packages on c-u-frozen might have a
> comment along the lines of "; for wrap-program" or similar.
I wrote "to execute the wrapper program" in a comment.

I also updated it to the core-updates-frozen-batched-changes merge,
because we need an older meson now, and libsoup2 for seahorse.

Vivien

[0001-gnu-gnome-tweaks-Use-libhandy-1.patch (text/x-patch, attachment)]
[0002-gnu-gnome-tweaks-Set-the-python-path.patch (text/x-patch, attachment)]
[0003-gnu-gnome-tweaks-Add-bash-minimal-as-an-input.patch (text/x-patch, attachment)]
[0004-gnu-gnome-tweaks-Use-meson-0.59.patch (text/x-patch, attachment)]
[0005-gnu-gcr-Upgrade-to-3.41.0.patch (text/x-patch, attachment)]
[0006-gnu-seahorse-Use-libsoup-2.patch (text/x-patch, attachment)]
[0007-gnu-seahorse-Upgrade-to-41.0.patch (text/x-patch, attachment)]
[signature.asc (application/pgp-signature, inline)]

Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Mon, 15 Nov 2021 11:14:02 GMT) Full text and rfc822 format available.

Notification sent to Vivien Kraus <vivien <at> planete-kraus.eu>:
bug acknowledged by developer. (Mon, 15 Nov 2021 11:14:02 GMT) Full text and rfc822 format available.

Message #22 received at 51731-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Vivien Kraus <vivien <at> planete-kraus.eu>
Cc: 51731-done <at> debbugs.gnu.org,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: bug#51731: [PATCH] gnome-tweaks fails to start on
 core-updates-frozen
Date: Mon, 15 Nov 2021 12:13:37 +0100
Hi!

Vivien Kraus <vivien <at> planete-kraus.eu> skribis:

> I also updated it to the core-updates-frozen-batched-changes merge,
> because we need an older meson now, and libsoup2 for seahorse.

I applied the whole series as commit
6e40c00ad192bb625074a1e3fd49930a47528a81:

  6e40c00ad1 gnu: seahorse: Upgrade to 41.0.
  bfa3bf0ffc gnu: seahorse: Use libsoup 2.
  56f456315f gnu: gcr: Upgrade to 3.41.0.
  b699a4f186 gnu: gnome-tweaks: Add bash-minimal as an input.
  7978b6454b gnu: gnome-tweaks: Set the python path.
  e0b6318a5a gnu: gnome-tweaks: Use libhandy 1.

Ricardo had already pushed this:

  4c4f982c33 gnu: gnome-tweaks: Use meson 0.59.

Thanks!

Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 13 Dec 2021 12:24:09 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 96 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.