GNU bug report logs - #51736
29.0.50; [PATCH] Fix context menus appearing in the wrong location in xwidgets

Previous Next

Package: emacs;

Reported by: Po Lu <luangruo <at> yahoo.com>

Date: Wed, 10 Nov 2021 01:26:02 UTC

Severity: normal

Tags: patch

Found in version 29.0.50

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51736 in the body.
You can then email your comments to 51736 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#51736; Package emacs. (Wed, 10 Nov 2021 01:26:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Po Lu <luangruo <at> yahoo.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 10 Nov 2021 01:26:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; [PATCH] Fix context menus appearing in the wrong location
 in xwidgets
Date: Wed, 10 Nov 2021 09:24:54 +0800
[Message part 1 (text/plain, inline)]
Thanks.

[0001-Set-embedder-correctly-to-fix-menus-appearing-in-the.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51736; Package emacs. (Wed, 10 Nov 2021 05:31:01 GMT) Full text and rfc822 format available.

Message #8 received at 51736 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: 51736 <at> debbugs.gnu.org
Subject: bug#51736: Re: 29.0.50; [PATCH] Fix context menus appearing in the
 wrong location in xwidgets
Date: Wed, 10 Nov 2021 13:30:40 +0800
Hmm, if nobody has a comment on this I'll push this change, because the
problem this solves is a pretty frustrating annoyance.

Does that look OK?  Thanks.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51736; Package emacs. (Wed, 10 Nov 2021 05:58:02 GMT) Full text and rfc822 format available.

Message #11 received at 51736 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 51736 <at> debbugs.gnu.org
Subject: Re: bug#51736: Re: 29.0.50; [PATCH] Fix context menus appearing in
 the wrong location in xwidgets
Date: Wed, 10 Nov 2021 06:57:26 +0100
Po Lu <luangruo <at> yahoo.com> writes:

> Hmm, if nobody has a comment on this I'll push this change, because the
> problem this solves is a pretty frustrating annoyance.
>
> Does that look OK?  Thanks.

Looks fine to me; please go ahead and push.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51736; Package emacs. (Wed, 10 Nov 2021 05:58:02 GMT) Full text and rfc822 format available.

Message #14 received at 51736 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: 51736 <at> debbugs.gnu.org
Subject: Re: bug#51736: 29.0.50; [PATCH] Fix context menus appearing in the
 wrong location in xwidgets
Date: Wed, 10 Nov 2021 13:57:38 +0800
Po Lu <luangruo <at> yahoo.com> writes:

> Hmm, if nobody has a comment on this I'll push this change, because the
> problem this solves is a pretty frustrating annoyance.
>
> Does that look OK?  Thanks.

I pushed it.  If this is the wrong procedure for these things, please
let me know, apologies in advance.

Thanks.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51736; Package emacs. (Wed, 10 Nov 2021 06:01:02 GMT) Full text and rfc822 format available.

Message #17 received at 51736 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 51736 <at> debbugs.gnu.org
Subject: Re: bug#51736: Re: 29.0.50; [PATCH] Fix context menus appearing in
 the wrong location in xwidgets
Date: Wed, 10 Nov 2021 13:59:39 +0800
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Looks fine to me; please go ahead and push.

Lars, I (or git, I'm not sure) got mighty confused and pushed the wrong
branch/worktree to master.  How do I rectify this problem?  Thanks, and
many apologies.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51736; Package emacs. (Wed, 10 Nov 2021 06:02:01 GMT) Full text and rfc822 format available.

Message #20 received at 51736 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 51736 <at> debbugs.gnu.org
Subject: Re: bug#51736: Re: 29.0.50; [PATCH] Fix context menus appearing in
 the wrong location in xwidgets
Date: Wed, 10 Nov 2021 07:01:37 +0100
Po Lu <luangruo <at> yahoo.com> writes:

>> Looks fine to me; please go ahead and push.
>
> Lars, I (or git, I'm not sure) got mighty confused and pushed the wrong
> branch/worktree to master.  How do I rectify this problem?  Thanks, and
> many apologies.

Oops.  😀

I think you just have to revert the commits.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51736; Package emacs. (Wed, 10 Nov 2021 06:03:02 GMT) Full text and rfc822 format available.

Message #23 received at 51736 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 51736 <at> debbugs.gnu.org
Subject: Re: bug#51736: Re: 29.0.50; [PATCH] Fix context menus appearing in
 the wrong location in xwidgets
Date: Wed, 10 Nov 2021 14:02:35 +0800
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Oops.  😀
>
> I think you just have to revert the commits.

Thanks, how do I do that?  (Also, could my use of multiple git worktrees
cause this problem?)

I.E. can I do a reset and a force-push?




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51736; Package emacs. (Wed, 10 Nov 2021 06:05:01 GMT) Full text and rfc822 format available.

Message #26 received at 51736 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 51736 <at> debbugs.gnu.org
Subject: Re: bug#51736: Re: 29.0.50; [PATCH] Fix context menus appearing in
 the wrong location in xwidgets
Date: Wed, 10 Nov 2021 07:04:10 +0100
Po Lu <luangruo <at> yahoo.com> writes:

> Thanks, how do I do that?  (Also, could my use of multiple git worktrees
> cause this problem?)

git revert on each of the five commits.

> I.E. can I do a reset and a force-push?

No, that wouldn't allow people tracking the tree to continue working, if
I understand correctly.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




bug marked as fixed in version 29.1, send any further explanations to 51736 <at> debbugs.gnu.org and Po Lu <luangruo <at> yahoo.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Wed, 10 Nov 2021 06:20:01 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 08 Dec 2021 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 101 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.