GNU bug report logs - #51765
[PATCH]: gnu: Add python-gwcs

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51765 in the body.
You can then email your comments to 51765 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH]: gnu: Add python-gwcs
Date: Thu, 11 Nov 2021 13:17:49 +0000

[Message part 1 (text/plain, inline)]

successfully built
/gnu/store/w870dhpqfq5ycggj9510kj1y54wqgz7v-python-gwcs-0.16.1.drv


-- 
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.

[0001-gnu-Add-python-gwcs.patch (text/x-patch, attachment)]

Message #8 received at 51765 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 51765 <at> debbugs.gnu.org
Date: Sun, 26 Dec 2021 19:01:53 +0000

Hi Guix team!

Just a gentle ping for this patch, thanks.

-- 
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.

Message #11 received at 51765 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: 51765 <at> debbugs.gnu.org
Subject: Re: bug#51765: [PATCH]: gnu: Add python-gwcs
Date: Sun, 26 Dec 2021 20:55:44 +0100

Hello,

> /gnu/store/w870dhpqfq5ycggj9510kj1y54wqgz7v-python-gwcs-0.16.1.drv

Sorry for the delay! Looks like the 0.18.0 release is out there. The
build dependency python-pytest-arraydiff also fails to build. Could you
please have a look?

Thanks,

Mathieu

Message #14 received at 51765 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 51765 <at> debbugs.gnu.org
Subject: Re: bug#51765: [PATCH]: gnu: Add python-gwcs
Date: Sun, 26 Dec 2021 20:47:40 +0000

Hi,

As it depends on astropy and it's failing right now, this patch list
may be reviewed first:

https://issues.guix.gnu.org/52768

I'll update gwcs to the 0.18.0 when this issue is resovled:

phase `check' succeeded after 0.0 seconds
starting phase `sanity-check'
validating 'pytest-arraydiff'
/gnu/store/hcg67xxfvlgg2kga73f026bzs9ck97lh-python-pytest-arraydiff-0.3/lib/python3.9/site-packages
...checking requirements: ERROR: pytest-arraydiff==0.3 The 'pytest'
distribution was not found and is required by pytest-arraydiff
error: in phase 'sanity-check': uncaught exception:
%exception #<&invoke-error program: "python" arguments:
("/gnu/store/nwwr89v2vyg1hs48i49m083vhczsgh3m-sanity-check.py"
"/gnu/store/hcg67xxfvlgg2kga73f026bzs9ck97lh-python-pytest-arraydiff-0.3/lib/python3.9/site-packages")
exit-status: 1 term-signal: #f stop-signal: #f>
phase `sanity-check' failed after 0.1 seconds
command "python"
"/gnu/store/nwwr89v2vyg1hs48i49m083vhczsgh3m-sanity-check.py"
"/gnu/store/hcg67xxfvlgg2kga73f026bzs9ck97lh-python-pytest-arraydiff-0.3/lib/python3.9/site-packages"
failed with status 1
builder for `/gnu/store/aa1hlq988yfk816xf0mk6d8lkp0hrmzh-python-pytest-arraydiff-0.3.drv'
failed with exit code 1
build of /gnu/store/aa1hlq988yfk816xf0mk6d8lkp0hrmzh-python-pytest-arraydiff-0.3.drv
failed
View build log at
'/var/log/guix/drvs/aa/1hlq988yfk816xf0mk6d8lkp0hrmzh-python-pytest-arraydiff-0.3.drv.bz2'.
guix build: error: build of
`/gnu/store/aa1hlq988yfk816xf0mk6d8lkp0hrmzh-python-pytest-arraydiff-0.3.drv'
failed

On Sun, 26 Dec 2021 at 19:55, Mathieu Othacehe <othacehe <at> gnu.org> wrote:
>
>
> Hello,
>
> > /gnu/store/w870dhpqfq5ycggj9510kj1y54wqgz7v-python-gwcs-0.16.1.drv
>
> Sorry for the delay! Looks like the 0.18.0 release is out there. The
> build dependency python-pytest-arraydiff also fails to build. Could you
> please have a look?
>
> Thanks,
>
> Mathieu



-- 

… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.

Message #17 received at 51765 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: 51765 <at> debbugs.gnu.org
Subject: Re: bug#51765: [PATCH]: gnu: Add python-gwcs
Date: Sun, 26 Dec 2021 21:55:11 +0100

Hey,

> I'll update gwcs to the 0.18.0 when this issue is resovled:

Nicolas just took care of it :).

Thanks,

Mathieu

Message #20 received at 51765 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 51765 <at> debbugs.gnu.org
Cc: Mathieu Othacehe <othacehe <at> gnu.org>
Subject: Re: bug#51765: [PATCH]: gnu: Add python-gwcs
Date: Sun, 2 Jan 2022 22:48:10 +0000

Hi Guix team and Happy New 2022 Year!

The update took more time then I expected, but eventually it's
finished with some extra modification and new patch list.

Sharlatan Hellseher (6):
  gnu: python-asdf: Update to 2.8.3
  gnu: Add asdf-transform-schemas
  gnu: Add asdf-coordinates-schemas
  gnu: Add asdf-astropy
  gnu: Add asdf-wcs-schemas
  gnu: Add gwcs

 gnu/packages/astronomy.scm | 209 +++++++++++++++++++++++++++++++++----
 1 file changed, 191 insertions(+), 18 deletions(-)


base-commit: 01ec5efff7cf95cae69493bd4ccfdd21a38770ae

On Sun, 26 Dec 2021 at 20:55, Mathieu Othacehe <othacehe <at> gnu.org> wrote:
>
>
> Hey,
>
> > I'll update gwcs to the 0.18.0 when this issue is resovled:
>
> Nicolas just took care of it :).
>
> Thanks,
>
> Mathieu



-- 

… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.

Message #23 received at 51765 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 51765 <at> debbugs.gnu.org
Date: Sun, 2 Jan 2022 22:48:24 +0000

[Message part 1 (text/plain, inline)]

-- 
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.

[0001-gnu-python-asdf-Update-to-2.8.3.patch (text/x-patch, attachment)]

Message #26 received at 51765 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 51765 <at> debbugs.gnu.org
Date: Sun, 2 Jan 2022 22:48:35 +0000

[Message part 1 (text/plain, inline)]

-- 
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.

[0002-gnu-Add-asdf-transform-schemas.patch (text/x-patch, attachment)]

Message #29 received at 51765 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 51765 <at> debbugs.gnu.org
Date: Sun, 2 Jan 2022 22:48:46 +0000

[Message part 1 (text/plain, inline)]

-- 
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.

[0003-gnu-Add-asdf-coordinates-schemas.patch (text/x-patch, attachment)]

Message #32 received at 51765 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 51765 <at> debbugs.gnu.org
Date: Sun, 2 Jan 2022 22:49:18 +0000

[Message part 1 (text/plain, inline)]

-- 
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.

[0004-gnu-Add-asdf-astropy.patch (text/x-patch, attachment)]

Message #35 received at 51765 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 51765 <at> debbugs.gnu.org
Date: Sun, 2 Jan 2022 22:49:25 +0000

[Message part 1 (text/plain, inline)]

-- 
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.

[0005-gnu-Add-asdf-wcs-schemas.patch (text/x-patch, attachment)]

Message #38 received at 51765 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 51765 <at> debbugs.gnu.org
Date: Sun, 2 Jan 2022 22:49:33 +0000

[Message part 1 (text/plain, inline)]

-- 
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.

[0006-gnu-Add-gwcs.patch (text/x-patch, attachment)]

Message #41 received at 51765 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>, 51765 <at> debbugs.gnu.org
Subject: Re:
Date: Tue, 04 Jan 2022 02:41:29 +0000

Hi Sharlatan,

I am commenting on the second patch and will comment on the others in
this same message.

> +    (arguments
> +     (list
> +      ;; FIXME: (Sharlatan-20211229T160902+0000): tests run via tox
> +      #:tests? #f))

The procedure is more or less the same for all Astropy related
packages. They use tox as an abstraction for pytest. You can run tests
by overriding the check phase:

>     (arguments
>      `(#:phases
>        (modify-phases %standard-phases
>          (replace 'check
>            (lambda* (#:key inputs outputs tests? #:allow-other-keys)
>              (when tests?
>                (add-installed-pythonpath inputs outputs)
>                (invoke "python" "-m" "pytest")))))))

I also had to add a few more native inputs:

>     (native-inputs
>      (list python-jsonschema
>            python-numpy
>            python-pytest
>            python-pyyaml
>            python-semantic-version
>            python-setuptools-scm))

It should work all the same for the remaining packages in the series.

There's no need to add a comment about the copyright holder:

> +    ;; Copyright (C) 2021 Association of Universities for Research
> in Astronomy (AURA)
> +    ;;  
> https://github.com/asdf-format/asdf-transform-schemas/blob/master/LICENSE

Some of the other patches like 3 and 4 do not follow description
standards like missing full sentences and full stop. You can run `guix
lint` in the packages to catch some linting errors.

In patch 6, gexp is being used without ungexp. In that case it
shouldn't be used. `(arguments (list ...))` should be `(arguments `())`
when gexp isn't being used, same for the other patches too. gwcs
license is bsd-3 according to copyright headers and the LICENSE file in
the license/ directory. Inputs in patches 5 and 6 may also have to be
propagated if they are libraries.

Message #44 received at 51765 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 51765 <at> debbugs.gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: Re:
Date: Tue, 4 Jan 2022 21:39:21 +0000

Hi!

Thank you for fead back @Vinicius Monego !

I've added aditional changes to all mentioned patches but I've not
created patch list from scratch. Let me know if would be easy to merge
patches first.

Sharlatan Hellseher (5):
  gnu: asdf-transform-schemas: Enable tests
  gnu: asdf-coordinates-schemas: Enable tests
  gnu: asdf-astropy: Enable tests
  gnu: asdf-wcs-schemas: Enable tests
  gnu: gwcs: Refactor package

 gnu/packages/astronomy.scm | 101 +++++++++++++++++++++----------------
 1 file changed, 57 insertions(+), 44 deletions(-)


base-commit: 4c812db049d5c9f2c438748e180f9486ad221b0a
prerequisite-patch-id: 56820d9ea09a7a53f0c576466db455e706707db2
prerequisite-patch-id: ad03d8286b6789e5c16216f66766ffa403ba2e87
prerequisite-patch-id: 7ada40e42ec009357b74914aa3ed3e31bc0924aa
prerequisite-patch-id: 18f6a0a2503f7359d051f10cfe01e421a3c20511
prerequisite-patch-id: dabf500576aec3742492c67f9a80fabf56872502
prerequisite-patch-id: ee0536ce1c726c3c7cea82067b7bc983d785139c


On Tue, 4 Jan 2022 at 02:41, Vinicius Monego <monego <at> posteo.net> wrote:
>
> Hi Sharlatan,
>
> I am commenting on the second patch and will comment on the others in
> this same message.
>
> > +    (arguments
> > +     (list
> > +      ;; FIXME: (Sharlatan-20211229T160902+0000): tests run via tox
> > +      #:tests? #f))
>
> The procedure is more or less the same for all Astropy related
> packages. They use tox as an abstraction for pytest. You can run tests
> by overriding the check phase:
>
> >     (arguments
> >      `(#:phases
> >        (modify-phases %standard-phases
> >          (replace 'check
> >            (lambda* (#:key inputs outputs tests? #:allow-other-keys)
> >              (when tests?
> >                (add-installed-pythonpath inputs outputs)
> >                (invoke "python" "-m" "pytest")))))))
>
> I also had to add a few more native inputs:
>
> >     (native-inputs
> >      (list python-jsonschema
> >            python-numpy
> >            python-pytest
> >            python-pyyaml
> >            python-semantic-version
> >            python-setuptools-scm))
>
> It should work all the same for the remaining packages in the series.
>
> There's no need to add a comment about the copyright holder:
>
> > +    ;; Copyright (C) 2021 Association of Universities for Research
> > in Astronomy (AURA)
> > +    ;;
> > https://github.com/asdf-format/asdf-transform-schemas/blob/master/LICENSE
>
> Some of the other patches like 3 and 4 do not follow description
> standards like missing full sentences and full stop. You can run `guix
> lint` in the packages to catch some linting errors.
>
> In patch 6, gexp is being used without ungexp. In that case it
> shouldn't be used. `(arguments (list ...))` should be `(arguments `())`
> when gexp isn't being used, same for the other patches too. gwcs
> license is bsd-3 according to copyright headers and the LICENSE file in
> the license/ directory. Inputs in patches 5 and 6 may also have to be
> propagated if they are libraries.
>


-- 

… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.

Message #47 received at 51765 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 51765 <at> debbugs.gnu.org
Date: Tue, 4 Jan 2022 21:39:56 +0000

[Message part 1 (text/plain, inline)]

-- 
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.

[0001-gnu-asdf-transform-schemas-Enable-tests.patch (text/x-patch, attachment)]

Message #50 received at 51765 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 51765 <at> debbugs.gnu.org
Date: Tue, 4 Jan 2022 21:40:07 +0000

[Message part 1 (text/plain, inline)]

-- 
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.

[0002-gnu-asdf-coordinates-schemas-Enable-tests.patch (text/x-patch, attachment)]

Message #53 received at 51765 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 51765 <at> debbugs.gnu.org
Date: Tue, 4 Jan 2022 21:40:16 +0000

[Message part 1 (text/plain, inline)]

-- 
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.

[0003-gnu-asdf-astropy-Enable-tests.patch (text/x-patch, attachment)]

Message #56 received at 51765 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 51765 <at> debbugs.gnu.org
Date: Tue, 4 Jan 2022 21:40:25 +0000

[Message part 1 (text/plain, inline)]

-- 
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.

[0004-gnu-asdf-wcs-schemas-Enable-tests.patch (text/x-patch, attachment)]

Message #59 received at 51765 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 51765 <at> debbugs.gnu.org
Date: Tue, 4 Jan 2022 21:40:40 +0000

[Message part 1 (text/plain, inline)]

-- 
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.

[0005-gnu-gwcs-Refactor-package.patch (text/x-patch, attachment)]

Message #62 received at 51765 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>, 51765 <at> debbugs.gnu.org
Subject: Re:
Date: Tue, 04 Jan 2022 23:01:15 +0000

Em ter, 2022-01-04 às 21:39 +0000, Sharlatan Hellseher escreveu:
> Hi!
> 
> Thank you for fead back @Vinicius Monego !
> 
> I've added aditional changes to all mentioned patches but I've not
> created patch list from scratch. Let me know if would be easy to
> merge
> patches first.
> 

The best way is to rebase to and amend the commits in the series and
send it from scratch again formatted with v2, v3, etc using --reroll-
count=2 in git format-patch.

You can also submit the patches using `git send-email --
to="NNN <at> debbugs.gnu.org" <patches>` where NNN is the ID of the issue,
here 51765. Check [1] to see how to configure it.

If you can merge them somehow it is preferable.

[1] https://git-send-email.io/

Message #65 received at 51765 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 51765 <at> debbugs.gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: Re:
Date: Fri, 14 Jan 2022 23:40:07 +0000

Hi Guix team!

I've setup git send-email (finally!) but strugled with rebase and
amend my old commit into new ones.
I've pul lates changes from upstream add combined changes per commit:

Sharlatan Hellseher (6):
  gnu: python-asdf: Update to 2.8.3
  gnu: Add asdf-transform-schemas
  gnu: Add asdf-coordinates-schemas
  gnu: Add asdf-astropy
  gnu: Add asdf-wcs-schemas
  gnu: Add gwcs

 gnu/packages/astronomy.scm | 222 ++++++++++++++++++++++++++++++++++---
 1 file changed, 204 insertions(+), 18 deletions(-)


base-commit: 056935506b8b5550ebeb3acfc1d0c3b4f11b6a2e

On Tue, 4 Jan 2022 at 23:01, Vinicius Monego <monego <at> posteo.net> wrote:
>
> Em ter, 2022-01-04 às 21:39 +0000, Sharlatan Hellseher escreveu:
> > Hi!
> >
> > Thank you for fead back @Vinicius Monego !
> >
> > I've added aditional changes to all mentioned patches but I've not
> > created patch list from scratch. Let me know if would be easy to
> > merge
> > patches first.
> >
>
> The best way is to rebase to and amend the commits in the series and
> send it from scratch again formatted with v2, v3, etc using --reroll-
> count=2 in git format-patch.
>
> You can also submit the patches using `git send-email --
> to="NNN <at> debbugs.gnu.org" <patches>` where NNN is the ID of the issue,
> here 51765. Check [1] to see how to configure it.
>
> If you can merge them somehow it is preferable.
>
> [1] https://git-send-email.io/
>
>


-- 

… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.

Message #68 received at 51765 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 51765 <at> debbugs.gnu.org
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Subject: [PATCH 2/6] gnu: Add asdf-transform-schemas
Date: Fri, 14 Jan 2022 23:40:21 +0000

* gnu/packages/astronomy.scm: (python-asdf-transform-schemas): New variable.
---
 gnu/packages/astronomy.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
index f1392c55e3..957f4d9a88 100644
--- a/gnu/packages/astronomy.scm
+++ b/gnu/packages/astronomy.scm
@@ -1299,6 +1299,40 @@ (define-public python-asdf
 implementation of the ASDF Standard.")
     (license license:bsd-3)))
 
+(define-public python-asdf-transform-schemas
+  (package
+    (name "python-asdf-transform-schemas")
+    (version "0.2.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "asdf_transform_schemas" version))
+       (sha256
+        (base32 "1gmzd81hw4ppsvzrc91wcbjpcw9hhv9gavllv7nyi7qjb54c837g"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda* (#:key inputs outputs tests? #:allow-other-keys)
+             (when tests?
+               (add-installed-pythonpath inputs outputs)
+               (invoke "python" "-m" "pytest")))))))
+    (native-inputs
+     (list python-pytest
+           python-semantic-version
+           python-setuptools-scm))
+    (propagated-inputs
+     (list python-asdf))
+    (home-page "https://github.com/asdf-format/asdf-transform-schemas")
+    (synopsis "ASDF schemas for transforms")
+    (description
+     "This package provides ASDF schemas for validating transform tags.  Users
+should not need to install this directly; instead, install an implementation
+package such as asdf-astropy, which includes asdf-transform-schemas as a
+dependency.")
+    (license license:bsd-3)))
+
 (define-public python-astroalign
   (package
     (name "python-astroalign")
-- 
2.34.0

Message #71 received at 51765 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 51765 <at> debbugs.gnu.org
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Subject: [PATCH 3/6] gnu: Add asdf-coordinates-schemas
Date: Fri, 14 Jan 2022 23:40:22 +0000

* gnu/packages/astronomy.scm: (python-asdf-coordinates-schemas): New variable.
---
 gnu/packages/astronomy.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
index 957f4d9a88..e3b81cbad2 100644
--- a/gnu/packages/astronomy.scm
+++ b/gnu/packages/astronomy.scm
@@ -1333,6 +1333,37 @@ (define-public python-asdf-transform-schemas
 dependency.")
     (license license:bsd-3)))
 
+(define-public python-asdf-coordinates-schemas
+  (package
+    (name "python-asdf-coordinates-schemas")
+    (version "0.1.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "asdf_coordinates_schemas" version))
+       (sha256
+        (base32 "0ahwhsz5jzljnpkfd2kvspirg823lnj5ip9sfkd9cx09z1nlz8jg"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda* (#:key inputs outputs tests? #:allow-other-keys)
+             (when tests?
+               (add-installed-pythonpath inputs outputs)
+               (invoke "python" "-m" "pytest")))))))
+    (native-inputs
+     (list python-pytest
+           python-semantic-version
+           python-setuptools-scm))
+    (propagated-inputs
+     (list python-asdf))
+    (home-page "https://github.com/asdf-format/asdf-coordinates-schemas")
+    (synopsis "ASDF coordinates schemas")
+    (description
+     "This package provides ASDF schemas for validating coordinates tags.")
+    (license license:bsd-3)))
+
 (define-public python-astroalign
   (package
     (name "python-astroalign")
-- 
2.34.0

Message #74 received at 51765 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 51765 <at> debbugs.gnu.org
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Subject: [PATCH 1/6] gnu: python-asdf: Update to 2.8.3
Date: Fri, 14 Jan 2022 23:40:20 +0000

* gnu/packages/astronomy.scm: (python-asdf): Update to 2.8.3
  Refactor package style.
  [inputs]->[propagated-inputs]: To satisfy sanity checks of other
  packages depended on python-asdf. Add new input python-jmespath
---
 gnu/packages/astronomy.scm | 37 +++++++++++++++++++------------------
 1 file changed, 19 insertions(+), 18 deletions(-)

diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
index a7a07fa3a8..f1392c55e3 100644
--- a/gnu/packages/astronomy.scm
+++ b/gnu/packages/astronomy.scm
@@ -1269,34 +1269,35 @@ (define-public python-sep
 (define-public python-asdf
   (package
     (name "python-asdf")
-    (version "2.7.4")
+    (version "2.8.3")
     (source
      (origin
        (method url-fetch)
        (uri (pypi-uri "asdf" version))
        (sha256
-        (base32 "1mj52l2m8pbhiqacgjakjpvqi8kyx470yw151lcsswbq5wp0rsc6"))))
+        (base32 "0i4vq1hsympjgb1yvn4ql0gm8j1mki9ggmj03533kmg0nbzp03yy"))))
     (build-system python-build-system)
     (arguments
-     ;; TODO: (Sharlatan-20210207T165820+0000): Tests depend on astropy, astropy
-     ;; depends on asdf. Disable circular dependence.
-     `(#:tests? #f))
+     ;; NOTE: (Sharlatan-20211229T201059+0000): Tests depend on astropy and
+     ;; gwcs, astropy gwcs depend on asdf. Disable circular dependence.
+     (list #:tests? #f))
     (native-inputs
-     `(("packaging" ,python-packaging)
-       ("semantic-version" ,python-semantic-version)
-       ("setuptools-scm" ,python-setuptools-scm)))
-     (inputs
-      `(("importlib-resources" ,python-importlib-resources)
-        ("jsonschema" ,python-jsonschema)
-        ("numpy" ,python-numpy)
-        ("pyyaml" ,python-pyyaml)))
-     (home-page "https://github.com/asdf-format/asdf")
-     (synopsis "Python tools to handle ASDF files")
-     (description
-      "The Advanced Scientific Data Format (ASDF) is a next-generation
+     (list python-setuptools-scm
+           python-semantic-version
+           python-packaging))
+    (propagated-inputs
+     (list python-importlib-resources
+           python-jsonschema
+           python-jmespath
+           python-numpy
+           python-pyyaml))
+    (home-page "https://github.com/asdf-format/asdf")
+    (synopsis "Python tools to handle ASDF files")
+    (description
+     "The Advanced Scientific Data Format (ASDF) is a next-generation
 interchange format for scientific data.  This package contains the Python
 implementation of the ASDF Standard.")
-     (license license:bsd-3)))
+    (license license:bsd-3)))
 
 (define-public python-astroalign
   (package
-- 
2.34.0

Message #77 received at 51765 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 51765 <at> debbugs.gnu.org
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Subject: [PATCH 4/6] gnu: Add asdf-astropy
Date: Fri, 14 Jan 2022 23:40:23 +0000

* gnu/packages/astronomy.scm: (python-asdf-astropy): New variable.
---
 gnu/packages/astronomy.scm | 42 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
index e3b81cbad2..64a643b977 100644
--- a/gnu/packages/astronomy.scm
+++ b/gnu/packages/astronomy.scm
@@ -1364,6 +1364,48 @@ (define-public python-asdf-coordinates-schemas
      "This package provides ASDF schemas for validating coordinates tags.")
     (license license:bsd-3)))
 
+(define-public python-asdf-astropy
+  (package
+    (name "python-asdf-astropy")
+    (version "0.1.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "asdf_astropy" version))
+       (sha256
+        (base32 "0bzgah7gskvnz6jcrzipvzixv8k2jzjkskqwxngzwp4nxgjbcvi4"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda* (#:key inputs outputs tests? #:allow-other-keys)
+             (when tests?
+               (add-installed-pythonpath inputs outputs)
+               (invoke "python" "-m" "pytest")))))))
+    (native-inputs
+     (list python-coverage
+           python-h5py
+           python-matplotlib
+           python-pandas
+           python-pytest-astropy
+           python-scipy
+           python-semantic-version
+           python-setuptools-scm))
+    (propagated-inputs
+     (list python-asdf
+           python-asdf-coordinates-schemas
+           python-asdf-transform-schemas
+           python-astropy
+           python-numpy
+           python-packaging))
+    (home-page "https://github.com/astropy/asdf-astropy")
+    (synopsis "ASDF serialization support for astropy")
+    (description
+     "This package includes plugins that provide ASDF serialization support for
+astropy objects.")
+    (license license:bsd-3)))
+
 (define-public python-astroalign
   (package
     (name "python-astroalign")
-- 
2.34.0

Message #80 received at 51765 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 51765 <at> debbugs.gnu.org
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Subject: [PATCH 5/6] gnu: Add asdf-wcs-schemas
Date: Fri, 14 Jan 2022 23:40:24 +0000

* gnu/packages/astronomy.scm: (python-asdf-wcs-schemas): New variable.
---
 gnu/packages/astronomy.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
index 64a643b977..b025b86736 100644
--- a/gnu/packages/astronomy.scm
+++ b/gnu/packages/astronomy.scm
@@ -1406,6 +1406,38 @@ (define-public python-asdf-astropy
 astropy objects.")
     (license license:bsd-3)))
 
+(define-public python-asdf-wcs-schemas
+  (package
+    (name "python-asdf-wcs-schemas")
+    (version "0.1.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "asdf_wcs_schemas" version))
+       (sha256
+        (base32 "0khyab9mnf2lv755as8kwhk3lqqpd3f4291ny3b9yp3ik86fzhz1"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda* (#:key inputs outputs tests? #:allow-other-keys)
+             (when tests?
+               (add-installed-pythonpath inputs outputs)
+               (invoke "python" "-m" "pytest")))))))
+    (native-inputs
+     (list python-pytest
+           python-setuptools-scm
+           python-semantic-version))
+    (propagated-inputs
+     (list python-asdf))
+    (home-page "https://github.com/asdf-format/asdf-wcs-schemas")
+    (synopsis "ASDF WCS Schemas")
+    (description
+     "This package provides ASDF schemas for validating World Coordinate
+System (WCS) tags.")
+    (license license:bsd-3)))
+
 (define-public python-astroalign
   (package
     (name "python-astroalign")
-- 
2.34.0

Message #83 received at 51765 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 51765 <at> debbugs.gnu.org
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Subject: [PATCH 6/6] gnu: Add gwcs
Date: Fri, 14 Jan 2022 23:40:25 +0000

* gnu/packages/astronomy.scm: (python-gwcs): New variable.
---
 gnu/packages/astronomy.scm | 46 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
index b025b86736..60dd968838 100644
--- a/gnu/packages/astronomy.scm
+++ b/gnu/packages/astronomy.scm
@@ -1487,3 +1487,49 @@ (define-public python-skyfield
      "Skyfield computes positions for the stars, planets, and satellites in
 orbit around the Earth.")
     (license license:expat)))
+
+(define-public python-gwcs
+  (package
+    (name "python-gwcs")
+    (version "0.18.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "gwcs" version))
+       (sha256
+        (base32 "194j49m8xjjzv9pp8cnj06igz8sdxb0nphyybcc7mhigw0f0kr30"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda* (#:key inputs outputs tests? #:allow-other-keys)
+             (when tests?
+               (add-installed-pythonpath inputs outputs)
+               (invoke "python" "-m" "pytest")))))))
+    (native-inputs
+     (list python-jsonschema
+           python-jmespath
+           python-pytest
+           python-pytest-doctestplus
+           python-pyyaml
+           python-semantic-version
+           python-setuptools-scm))
+    (propagated-inputs
+     (list python-asdf
+           python-asdf-astropy
+           python-astropy
+           python-asdf-wcs-schemas
+           python-numpy
+           python-scipy))
+    (home-page "https://gwcs.readthedocs.io/en/latest/")
+    (synopsis "Generalized World Coordinate System")
+    (description
+     "Generalized World Coordinate System (GWCS) is an Astropy affiliated package
+providing tools for managing the World Coordinate System of astronomical data.
+
+GWCS takes a general approach to the problem of expressing transformations
+between pixel and world coordinates.  It supports a data model which includes the
+entire transformation pipeline from input coordinates (detector by default) to
+world coordinates.  It is tightly integrated with Astropy.")
+   (license license:bsd-3)))
-- 
2.34.0

Message #88 received at 51765-done <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>, 51765-done <at> debbugs.gnu.org
Subject: Re: [PATCH 1/6] gnu: python-asdf: Update to 2.8.3
Date: Sun, 30 Jan 2022 15:07:03 +0000

Hi,

Em sex, 2022-01-14 às 23:40 +0000, Sharlatan Hellseher escreveu:
> * gnu/packages/astronomy.scm: (python-asdf): Update to 2.8.3
>   Refactor package style.
>   [inputs]->[propagated-inputs]: To satisfy sanity checks of other
>   packages depended on python-asdf. Add new input python-jmespath
> ---
>  gnu/packages/astronomy.scm | 37 +++++++++++++++++++-----------------
> -
>  1 file changed, 19 insertions(+), 18 deletions(-)
> 
> diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
> index a7a07fa3a8..f1392c55e3 100644
> --- a/gnu/packages/astronomy.scm
> +++ b/gnu/packages/astronomy.scm
> @@ -1269,34 +1269,35 @@ (define-public python-sep
>  (define-public python-asdf
>    (package
>      (name "python-asdf")
> -    (version "2.7.4")
> +    (version "2.8.3")
>      (source
>       (origin
>         (method url-fetch)
>         (uri (pypi-uri "asdf" version))
>         (sha256
> -        (base32
> "1mj52l2m8pbhiqacgjakjpvqi8kyx470yw151lcsswbq5wp0rsc6"))))
> +        (base32
> "0i4vq1hsympjgb1yvn4ql0gm8j1mki9ggmj03533kmg0nbzp03yy"))))
>      (build-system python-build-system)
>      (arguments
> -     ;; TODO: (Sharlatan-20210207T165820+0000): Tests depend on
> astropy, astropy
> -     ;; depends on asdf. Disable circular dependence.
> -     `(#:tests? #f))
> +     ;; NOTE: (Sharlatan-20211229T201059+0000): Tests depend on
> astropy and
> +     ;; gwcs, astropy gwcs depend on asdf. Disable circular
> dependence.
> +     (list #:tests? #f))
>      (native-inputs
> -     `(("packaging" ,python-packaging)
> -       ("semantic-version" ,python-semantic-version)
> -       ("setuptools-scm" ,python-setuptools-scm)))
> -     (inputs
> -      `(("importlib-resources" ,python-importlib-resources)
> -        ("jsonschema" ,python-jsonschema)
> -        ("numpy" ,python-numpy)
> -        ("pyyaml" ,python-pyyaml)))
> -     (home-page "https://github.com/asdf-format/asdf")
> -     (synopsis "Python tools to handle ASDF files")
> -     (description
> -      "The Advanced Scientific Data Format (ASDF) is a next-
> generation
> +     (list python-setuptools-scm
> +           python-semantic-version
> +           python-packaging))
> +    (propagated-inputs
> +     (list python-importlib-resources
> +           python-jsonschema
> +           python-jmespath
> +           python-numpy
> +           python-pyyaml))
> +    (home-page "https://github.com/asdf-format/asdf")
> +    (synopsis "Python tools to handle ASDF files")
> +    (description
> +     "The Advanced Scientific Data Format (ASDF) is a next-
> generation
>  interchange format for scientific data.  This package contains the
> Python
>  implementation of the ASDF Standard.")
> -     (license license:bsd-3)))
> +    (license license:bsd-3)))
>  
>  (define-public python-astroalign
>    (package

Ideally this change should be in two separate commits: one to propagate
inputs and another to update, but I'm going to leave this one as is for
this time.

I also made the following changes:

- Adjusted commit messages
- Set schema variables as non-public
- Changed descriptions
- Moved gwcs definition closer to the other variables
- Updated your copyright line
  
and pushed the whole series, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.