GNU bug report logs - #51769
28.0.60; package-install-file unable to kill temp buffer after installing a file

Previous Next

Package: emacs;

Reported by: Thanh Vuong <thanhvg <at> gmail.com>

Date: Thu, 11 Nov 2021 15:51:01 UTC

Severity: normal

Tags: moreinfo

Found in version 28.0.60

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51769 in the body.
You can then email your comments to 51769 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#51769; Package emacs. (Thu, 11 Nov 2021 15:51:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Thanh Vuong <thanhvg <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 11 Nov 2021 15:51:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thanh Vuong <thanhvg <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.60; package-install-file unable to kill temp buffer after
 installing a file
Date: Thu, 11 Nov 2021 08:18:57 -0700
Start `emacs -Q`

`M-x`: `package-install-file` choose any proper el file, for example the
test file `simple-single-1.3.el` that comes with Emacs source code.

After the file is installed, Emacs will complain about modified buffer
to be kill: "Buffer simple-single-1.3.el.el has been modified; Kill
anyway? (yes or no)".

The file is not modified and its buffer should be killed properly.

I suspect this commit 606b783acb3388249c38264f8e37e08af832e1ea which
added this line:
`(set-visited-file-name file)`
(https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/emacs-lisp/package.el?h=master#n2204)
to `package-install-file` causes this regression.


Thanks






In GNU Emacs 28.0.60 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo 
version 1.16.0, Xaw3d scroll bars)
of 2021-10-12 built on x230x
Repository revision: f223ac6ef92b7cf69048c81ff58b5c983c7d25da
Repository branch: emacs-28
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Ubuntu 20.04.3 LTS

Configured using:
'configure --prefix=/home/thanh/emacs28 --with-native-compilation
--with-x-toolkit=lucid --with-xft --without-gconf --without-gsettings
--with-modules --with-rsvg'

Configured features:
CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS HARFBUZZ JPEG JSON LIBOTF
LIBSELINUX LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER
PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XAW3D XDBE
XIM XPM LUCID ZLIB

Important settings:
value of $LANG: en_CA.UTF-8
value of $XMODIFIERS: @im=ibus
locale-coding-system: utf-8-unix

Major mode: Messages

Minor modes in effect:
tooltip-mode: t
global-eldoc-mode: t
show-paren-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
buffer-read-only: t
line-number-mode: t
indent-tabs-mode: t
transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail
rmail-loaddefs time-date mm-decode mm-bodies mm-encode mailabbrev
gmm-utils mailheader sendmail mail-utils cus-edit pp cus-start cus-load
wid-edit compile text-property-search comint ansi-color ring find-func
easy-mmode autoload radix-tree lisp-mnt mail-parse rfc2231 rfc2047
rfc2045 mm-util ietf-drums mail-prsvr bug-reference package browse-url
url url-proxy url-privacy url-expand url-methods url-history url-cookie
url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq
eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map
url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib
iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks
lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd
tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice button loaddefs faces cus-face macroexp files
window text-properties overlay sha1 md5 base64 format env code-pages
mule custom widget hashtable-print-readable backquote threads dbusbind
inotify dynamic-setting font-render-setting cairo x-toolkit x multi-tty
make-network-process native-compile emacs)

Memory information:
((conses 16 112704 8184)
(symbols 48 9769 0)
(strings 32 29822 1891)
(string-bytes 1 979421)
(vectors 16 18098)
(vector-slots 8 366708 11788)
(floats 8 35 16)
(intervals 56 282 0)
(buffers 992 13))




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51769; Package emacs. (Fri, 12 Nov 2021 03:46:01 GMT) Full text and rfc822 format available.

Message #8 received at 51769 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Thanh Vuong <thanhvg <at> gmail.com>
Cc: 51769 <at> debbugs.gnu.org
Subject: Re: bug#51769: 28.0.60; package-install-file unable to kill temp
 buffer after installing a file
Date: Fri, 12 Nov 2021 04:44:53 +0100
Thanh Vuong <thanhvg <at> gmail.com> writes:

> `M-x`: `package-install-file` choose any proper el file, for example the
> test file `simple-single-1.3.el` that comes with Emacs source code.
>
> After the file is installed, Emacs will complain about modified buffer
> to be kill: "Buffer simple-single-1.3.el.el has been modified; Kill
> anyway? (yes or no)".
>
> The file is not modified and its buffer should be killed properly.

I've now installed a fix I think should fix this in emacs-28 -- can you
check?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Added tag(s) moreinfo. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Fri, 12 Nov 2021 03:46:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51769; Package emacs. (Fri, 12 Nov 2021 05:39:01 GMT) Full text and rfc822 format available.

Message #13 received at 51769 <at> debbugs.gnu.org (full text, mbox):

From: Thanh Vuong <thanhvg <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 51769 <at> debbugs.gnu.org
Subject: Re: bug#51769: 28.0.60; package-install-file unable to kill temp
 buffer after installing a file
Date: Thu, 11 Nov 2021 22:38:22 -0700
Confirm it is fixed, thanks a lot for the quick fix.

On 2021-11-11 8:44 p.m., Lars Ingebrigtsen wrote:
> I've now installed a fix I think should fix this in emacs-28 -- can you
> check?
>




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51769; Package emacs. (Fri, 12 Nov 2021 06:08:02 GMT) Full text and rfc822 format available.

Message #16 received at 51769 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Thanh Vuong <thanhvg <at> gmail.com>
Cc: 51769 <at> debbugs.gnu.org
Subject: Re: bug#51769: 28.0.60; package-install-file unable to kill temp
 buffer after installing a file
Date: Fri, 12 Nov 2021 07:07:12 +0100
Thanh Vuong <thanhvg <at> gmail.com> writes:

> Confirm it is fixed, thanks a lot for the quick fix.

Thanks for checking; I'm closing this bug report, then.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




bug marked as fixed in version 29.1, send any further explanations to 51769 <at> debbugs.gnu.org and Thanh Vuong <thanhvg <at> gmail.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Fri, 12 Nov 2021 06:08:03 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 10 Dec 2021 12:24:11 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 99 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.