GNU bug report logs - #51771
[PATCH 1/2] gnu: linux: Support numbers and strings in options.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: phodina <phodina@HIDDEN>; Keywords: patch; dated Thu, 11 Nov 2021 19:03:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 51771 <at> debbugs.gnu.org:


Received: (at 51771) by debbugs.gnu.org; 11 Nov 2021 19:05:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 11 14:05:09 2021
Received: from localhost ([127.0.0.1]:42277 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mlFNl-0007HA-J7
	for submit <at> debbugs.gnu.org; Thu, 11 Nov 2021 14:05:09 -0500
Received: from mail-40133.protonmail.ch ([185.70.40.133]:32699)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <phodina@HIDDEN>) id 1mlFNk-0007Gv-98
 for 51771 <at> debbugs.gnu.org; Thu, 11 Nov 2021 14:05:08 -0500
Date: Thu, 11 Nov 2021 19:04:55 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
 s=protonmail; t=1636657497;
 bh=4xkg+sbw1YMYlI7d94HvNgdBNy96UCXqW/L5tfND77Q=;
 h=Date:To:From:Reply-To:Subject:From;
 b=gNdl61wyTjaKCNUkH7f1nytWv0HYnJUu5Dz3JGrDDLGbKlsqCVt8duQtIBfBd1zKu
 OohbZA2q1CyLCURSAqJXFIOEwiNhRpMYk75ER8IScu7opnSboFSjBa0Nn1shhXrkgy
 oXIAs2USIn4n+1IYRJ9VVIsFIOyKQJIcwIyPks5I=
To: "51771 <at> debbugs.gnu.org" <51771 <at> debbugs.gnu.org>
From: phodina <phodina@HIDDEN>
Subject: [PATCH 2/2] gnu: Add linux-libre-with-waydroid.
Message-ID: <vT1t7q1nSybGdcbnNv0gBkOmsLDQKTpuvLjBmsObWL0vH3rxO_vtPlSdqRKap4nKqivgnqL4pQi0LUmjJ66XJMqDTdAOmmgyn3Pcg3BMmO8=@protonmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED,
 DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no
 autolearn=disabled version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 mailout.protonmail.ch
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 51771
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Reply-To: phodina <phodina@HIDDEN>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* gnu/packages/linux.scm (linux-libre-with-waydroid,
* waydroid-extra-linux-options): New variables.

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index ffbaed0c57..2ec9c88ecb 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -722,6 +722,14 @@ (define %bpf-extra-linux-options
     ;; kheaders module
     ("CONFIG_IKHEADERS" . #t)))

+(define %waydroid-extra-linux-options
+  `(;; Modules required for waydroid:
+   ("CONFIG_ASHMEM" . m)
+   ("CONFIG_ANDROID" . #t)
+   ("CONFIG_ANDROID_BINDER_IPC" . m)
+   ("CONFIG_ANDROID_BINDERFS" . #f)
+   ("CONFIG_ANDROID_BINDER_DEVICES" . "binder,hwbinder,vndbinder")))
+
 (define (config->string options)
   (string-join (map (match-lambda
                       ((option . 'm)
@@ -1147,6 +1155,24 @@ (define-public linux-libre-mips64el-fuloong2e
                       `(("CONFIG_OVERLAY_FS" . m))
                       %default-extra-linux-options)))

+(define-public linux-libre-with-waydroid
+  (let ((base-linux-libre
+         (make-linux-libre*
+          linux-libre-5.14-version
+          linux-libre-5.14-gnu-revision
+          linux-libre-5.14-source
+          '("x86_64-linux" "i686-linux" "armhf-linux"
+            "aarch64-linux" "riscv64-linux")
+          #:extra-version "linux"
+          #:configuration-file kernel-config
+          #:extra-options
+          (append %waydroid-extra-linux-options
+                  %default-extra-linux-options))))
+    (package
+      (inherit base-linux-libre)
+         (name "linux-libre-waydroid")
+      (inputs `(("cpio" ,cpio) ,@(package-inputs base-linux-libre))))))
+
 (define-public linux-libre-with-bpf
   (let ((base-linux-libre
          (make-linux-libre*
--
2.33.0




Information forwarded to guix-patches@HIDDEN:
bug#51771; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 11 Nov 2021 19:02:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 11 14:02:40 2021
Received: from localhost ([127.0.0.1]:42272 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mlFLM-0007Cd-5s
	for submit <at> debbugs.gnu.org; Thu, 11 Nov 2021 14:02:40 -0500
Received: from lists.gnu.org ([209.51.188.17]:36984)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <phodina@HIDDEN>) id 1mlFLK-0007CV-JK
 for submit <at> debbugs.gnu.org; Thu, 11 Nov 2021 14:02:39 -0500
Received: from eggs.gnu.org ([209.51.188.92]:40356)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <phodina@HIDDEN>)
 id 1mlFLK-000520-DB
 for guix-patches@HIDDEN; Thu, 11 Nov 2021 14:02:38 -0500
Received: from mail-40134.protonmail.ch ([185.70.40.134]:10038)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <phodina@HIDDEN>)
 id 1mlFLI-0003WO-4O
 for guix-patches@HIDDEN; Thu, 11 Nov 2021 14:02:37 -0500
Date: Thu, 11 Nov 2021 19:02:25 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
 s=protonmail; t=1636657349;
 bh=dq/FrSS9G4eExtVA+nekZaRbYw0/c2vXdsrIC89IkJo=;
 h=Date:To:From:Reply-To:Subject:From;
 b=RWS76s5z4mW03A/DGOmUyHQptVyt5AwdCFUbupLng4rWjQONLNc6uis7pNsz4DPfc
 MpZvZfBwtDrFSj9qV5fKhgS4Lsz8Ha90eWQ8Afr9nYEXQTE6kqBU7L6tAl/dKrh0JG
 5eDxKI0e3jWvALFkklqzBi0flw5yOe5hgjpdnCg8=
To: Guix Patches <guix-patches@HIDDEN>
From: phodina <phodina@HIDDEN>
Subject: [PATCH 1/2] gnu: linux: Support numbers and strings in options.
Message-ID: <iOvT9g1d7_K-thdi2Zsdn4SxPyMuPrPFP6k121oLlG67EGRxi5tPyWOE8vb3jvCfsgZPQ13b7dKWRdVdAY6VCXV0goFY5AYOPBRV4nsvdRA=@protonmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED,
 DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no
 autolearn=disabled version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 mailout.protonmail.ch
Received-SPF: pass client-ip=185.70.40.134;
 envelope-from=phodina@HIDDEN; helo=mail-40134.protonmail.ch
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Reply-To: phodina <phodina@HIDDEN>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

Hi,

this patch should add support for waydroid which requires certain options i=
n the kernel enabled.

In order to enable the features the lambda-match has to be extended to supp=
ort numbers and strings.

However, the kernel compiles and I can reconfigure the system, + reboot. Bu=
t I do not see /dev/binder device. Details are in the last mail.

Petr

* gnu/packages/linux.scm: Match numbers and strings in options.

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index f386139638..ffbaed0c57 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -729,7 +729,11 @@ (define (config->string options)
                       ((option . #t)
                        (string-append option "=3Dy"))
                       ((option . #f)
-                       (string-append option "=3Dn")))
+                       (string-append option "=3Dn"))
+                      ((option . number)
+                       (string-append option "=3D" number))
+                      ((option . string)
+                       (string-append option "=3D\"" string "\"")))
                     options)
                "\n"))

--
2.33.0




Acknowledgement sent to phodina <phodina@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#51771; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Thu, 11 Nov 2021 19:15:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.