GNU bug report logs - #51775
Rebased wip-pinebook-pro branch

Previous Next

To reply to this bug, email your comments to 51775 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: "janneke <at> gnu.org" <janneke <at> gnu.org>, Guix Patches <guix-patches <at> gnu.org>,
 Vagrant Cascadian <vagrant <at> debian.org>
Subject: Rebased wip-pinebook-pro branch
Date: Thu, 11 Nov 2021 21:02:50 +0000

[Message part 1 (text/plain, inline)]

Hi,

Thanks for the amazing work on Pinebook Pro!

Here are the patches rebased on linux-libre-5.10 on Guix master.

I also saw another issue regarding HW graphics support. [1]

Should I also rebase the changes from there?
Kind regards
Petr

[1] http://issues.guix.gnu.org/40835

[Message part 2 (text/html, inline)]

[0002-gnu-Add-linux-libre-arm-pinebook-pro-5.10.patch (text/x-patch, attachment)]

[0001-gnu-Add-patches-for-pinebook-pro.patch (text/x-patch, attachment)]

Message #8 received at 51775 <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> debian.org>
To: phodina <at> protonmail.com
Cc: 51775 <at> debbugs.gnu.org, janneke <at> gnu.org
Subject: Re: Rebased wip-pinebook-pro branch
Date: Thu, 11 Nov 2021 21:30:09 -0800

[Message part 1 (text/plain, inline)]

On 2021-11-11, phodina <at> protonmail.com wrote:
> Thanks for the amazing work on Pinebook Pro!
>
> Here are the patches rebased on linux-libre-5.10 on Guix master.
...
> Should I also rebase the changes from there?

I stopped working on the wip-pinebook-pro branch in May 2021:

  Pinebook Pro no longer WIP
  https://lists.gnu.org/archive/html/guix-devel/2021-05/msg00032.html

All the features that seemed important were merged into guix's master
branch at that time, with only very small and minor patches to
linux-libre. I've since tested several other features, such as
NVMe. Some of the quirks seem to have gotten less bad over time, as
support has improved upstream.

I'm not sure it's worth adding a large patchset to support a 5.10.x
linux-libre kernel at this point... What features are missing from the
default kernel?

What guix master branch does lack is decent documentation for the
pinebook-pro; there is a system image configuration but I have not tried
it out so cannot speak to how well it works.


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 51775 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Vagrant Cascadian <vagrant <at> debian.org>
Cc: 51775 <at> debbugs.gnu.org, phodina <at> protonmail.com, janneke <at> gnu.org
Subject: Re: [bug#51775] Rebased wip-pinebook-pro branch
Date: Tue, 16 Nov 2021 21:20:00 +0200

[Message part 1 (text/plain, inline)]

On Thu, Nov 11, 2021 at 09:30:09PM -0800, Vagrant Cascadian wrote:
> On 2021-11-11, phodina <at> protonmail.com wrote:
> > Thanks for the amazing work on Pinebook Pro!
> >
> > Here are the patches rebased on linux-libre-5.10 on Guix master.
> ...
> > Should I also rebase the changes from there?
> 
> I stopped working on the wip-pinebook-pro branch in May 2021:
> 
>   Pinebook Pro no longer WIP
>   https://lists.gnu.org/archive/html/guix-devel/2021-05/msg00032.html
> 
> All the features that seemed important were merged into guix's master
> branch at that time, with only very small and minor patches to
> linux-libre. I've since tested several other features, such as
> NVMe. Some of the quirks seem to have gotten less bad over time, as
> support has improved upstream.
> 
> I'm not sure it's worth adding a large patchset to support a 5.10.x
> linux-libre kernel at this point... What features are missing from the
> default kernel?
> 
> What guix master branch does lack is decent documentation for the
> pinebook-pro; there is a system image configuration but I have not tried
> it out so cannot speak to how well it works.
> 
> 
> live well,
>   vagrant

The pinebook pro boots from the SD card first if it's present, right? I
have one sitting next to me, I can take some time and build an image and
test it out.


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 51775 <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> debian.org>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 51775 <at> debbugs.gnu.org, phodina <at> protonmail.com, janneke <at> gnu.org
Subject: Re: [bug#51775] Rebased wip-pinebook-pro branch
Date: Tue, 16 Nov 2021 15:22:15 -0800

[Message part 1 (text/plain, inline)]

On 2021-11-16, Efraim Flashner wrote:
> On Thu, Nov 11, 2021 at 09:30:09PM -0800, Vagrant Cascadian wrote:
>> What guix master branch does lack is decent documentation for the
>> pinebook-pro; there is a system image configuration but I have not tried
>> it out so cannot speak to how well it works.

> The pinebook pro boots from the SD card first if it's present, right? I
> have one sitting next to me, I can take some time and build an image and
> test it out.

Pretty sure the hard-coded bootrom boot order is SPI -> eMMC -> microSD
-> ... other stuff

So it depends on what else you have installed. I've never installed
u-boot to SPI and yanked the eMMC to keep updates easier to fix when
regressions happen; the u-boot loaded from microSD boots off of NVMe
nicely...


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 51775 <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Vagrant Cascadian <vagrant <at> debian.org>
Cc: 51775 <at> debbugs.gnu.org, Efraim Flashner <efraim <at> flashner.co.il>,
 janneke <at> gnu.org
Subject: Re: [bug#51775] Rebased wip-pinebook-pro branch
Date: Wed, 17 Nov 2021 10:38:42 +0000

Hi,

On Wednesday, November 17th, 2021 at 12:22 AM, Vagrant Cascadian <vagrant <at> debian.org> wrote:

> On 2021-11-16, Efraim Flashner wrote:
>
> > On Thu, Nov 11, 2021 at 09:30:09PM -0800, Vagrant Cascadian wrote:
> >
> > > What guix master branch does lack is decent documentation for the
> > >
> > > pinebook-pro; there is a system image configuration but I have not tried
> > >
> > > it out so cannot speak to how well it works.

I've used the system image configuration the build image for my Pinebook Pro.

It works, though I experience issue when I reboot the system the output on the screen is just some garbage. It has to be turned off completely. Then after cold boot it displays everything properly.

So I started to investigate which patch I'm missing and found this wip-pinebook-pro branch.
>
> > The pinebook pro boots from the SD card first if it's present, right? I
> >
> > have one sitting next to me, I can take some time and build an image and
> >
> > test it out.
>
> Pretty sure the hard-coded bootrom boot order is SPI -> eMMC -> microSD
>
> -> ... other stuff
>
Yes there is bootrom which launches the u-boot. I've updated mine to latest version and it let's me select, though boots first eMMC.

> So it depends on what else you have installed. I've never installed
>
> u-boot to SPI and yanked the eMMC to keep updates easier to fix when
>
> regressions happen; the u-boot loaded from microSD boots off of NVMe
>
> nicely...
>
> live well,
>
> vagrant

So the way forward would be to check with mainline which patches are already accepted, right?

Also I agree it makes no sense to support 5.10 version of the kernel.

Petr

Message #20 received at 51775 <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> debian.org>
To: phodina <phodina <at> protonmail.com>
Cc: 51775 <at> debbugs.gnu.org, Efraim Flashner <efraim <at> flashner.co.il>,
 janneke <at> gnu.org
Subject: Re: [bug#51775] Rebased wip-pinebook-pro branch
Date: Wed, 17 Nov 2021 08:53:25 -0800

[Message part 1 (text/plain, inline)]

On 2021-11-17, phodina <at> protonmail.com wrote:
> On Wednesday, November 17th, 2021 at 12:22 AM, Vagrant Cascadian <vagrant <at> debian.org> wrote:
>> On 2021-11-16, Efraim Flashner wrote:
>> > On Thu, Nov 11, 2021 at 09:30:09PM -0800, Vagrant Cascadian wrote:
>> > > What guix master branch does lack is decent documentation for the
>> > > pinebook-pro; there is a system image configuration but I have not tried
>> > > it out so cannot speak to how well it works.
>
> I've used the system image configuration the build image for my Pinebook Pro. 
>
> It works, though I experience issue when I reboot the system the
> output on the screen is just some garbage. It has to be turned off
> completely. Then after cold boot it displays everything properly.
>
> So I started to investigate which patch I'm missing and found this
> wip-pinebook-pro branch.

I also experienced that behavior using wip-pinebook-pro back in the
day... so I don't think you'll find a solution there.


> So the way forward would be to check with mainline which patches are
> already accepted, right?
>
> Also I agree it makes no sense to support 5.10 version of the kernel. 

Sure, though I don't see any newer branches on:

  https://gitlab.manjaro.org/tsys/linux-pinebook-pro

Which is where the patches on wip-pinebook-pro came from...

So my guess is there hasn't been much activity unless someone else is
doing the upstreaming work.


live well,
  vagrant

p.s. no need to encrypt messages to me when also sending the same
messages to the public bug tracker! :)

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 51775 <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> debian.org>
To: Philip McGrath <philip <at> philipmcgrath.com>, Ludovic Courtès <ludo <at> gnu.org>
Cc: guix-devel <at> gnu.org, 51775 <at> debbugs.gnu.org
Subject: Re: default tar format for "make dist" and patch file length
Date: Fri, 19 Nov 2021 21:21:29 -0800

[Message part 1 (text/plain, inline)]

On 2021-11-19, Philip McGrath wrote:
> On 11/19/21 09:54, Ludovic Courtès wrote:
>> Vagrant Cascadian <vagrant <at> debian.org> skribis:
>>> So, I guess I'm leaning towards making the guix lint check a little more
>>> lenient.
>>>
>>> Thoughts?
>> 
>> That sounds even better, I’m all for it (changing (guix lint) + fixing
>> the two remaining issues)!

Submitted the guix lint change as https://issues.guix.gnu.org/51775


> It might also help to change the warning given by the check.
>
> When a program called "lint" tells me that something is too long, I 
> understand that to mean that what I've done is generally considered bad 
> style, but there might be a very good reason to do it in some specific 
> case. For example, I might exceed a line length guideline to avoid 
> inserting linebreaks into a URL.

That's a good point!


> If instead `guix lint` is telling us about a hard limit that will break 
> things, I think it should say so clearly.

Not sure how to convey succinctly, but here's an attempt at a patch
(which ironically also probably makes the line a bit too long in the
code):

diff --git a/guix/lint.scm b/guix/lint.scm
index ac2e7b3841..6464fb751a 100644
--- a/guix/lint.scm
+++ b/guix/lint.scm
@@ -968,7 +968,7 @@ (define (starts-with-package-name? file-name)
                              max)
                           (make-warning
                            package
-                           (G_ "~a: file name is too long")
+                           (G_ "~a: file name is too long and may break release tarball generation")
                            (list (basename patch))
                            #:field 'patch-file-names)
                           #f))
diff --git a/tests/lint.scm b/tests/lint.scm
index 9a91dd5426..d4c3d62aaf 100644
--- a/tests/lint.scm
+++ b/tests/lint.scm
@@ -509,7 +509,7 @@ (define hsab (string-append (assoc-ref inputs
"hsab")
 (test-equal "patches: file name too long"
   (string-append "x-"
                  (make-string 100 #\a)
-                 ".patch: file name is too long")
+                 ".patch: file name is too long and may break release tarball generation")
   (single-lint-warning-message
    (let ((pkg (dummy-package
                "x"


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.