GNU bug report logs - #51778
29.0.50; gnus-search uses `message' instead of `gnus-message'

Previous Next

Packages: emacs, gnus;

Reported by: "Jose A. Ortega Ruiz" <mail <at> jao.io>

Date: Thu, 11 Nov 2021 22:00:01 UTC

Severity: normal

Found in version 29.0.50

Done: Eric Abrahamsen <eric <at> ericabrahamsen.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51778 in the body.
You can then email your comments to 51778 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org, bugs <at> gnus.org:
bug#51778; Package emacs,gnus. (Thu, 11 Nov 2021 22:00:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to "Jose A. Ortega Ruiz" <mail <at> jao.io>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org, bugs <at> gnus.org. (Thu, 11 Nov 2021 22:00:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Jose A. Ortega Ruiz" <mail <at> jao.io>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; gnus-search uses `message' instead of `gnus-message'
Date: Thu, 11 Nov 2021 21:59:15 +0000
[Message part 1 (text/plain, inline)]
Hi,

In gnus-search, there are several logs (some of them quite verbose when
one's iterating over long lists of groups) using `message'.  I think
that it'd be better to use `gnus-message' instead, with levels as
appropriate.  That way one can avoid (or enable!) them via gnus-verbose.

I'm attaching a patch changing them all to level 7, since they looked
like debug messages to me; but it's just a suggestion.

Thanks!
jao

[0001-Use-gnus-message-for-logging-in-gnus-search.patch (text/x-diff, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org, bugs <at> gnus.org:
bug#51778; Package emacs,gnus. (Fri, 12 Nov 2021 01:24:02 GMT) Full text and rfc822 format available.

Message #8 received at 51778 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: "Jose A. Ortega Ruiz" <mail <at> jao.io>
Cc: Debbugs control <control <at> debbugs.gnu.org>, 51778 <at> debbugs.gnu.org
Subject: Re: bug#51778: 29.0.50; gnus-search uses `message' instead of
 `gnus-message'
Date: Thu, 11 Nov 2021 17:23:42 -0800
merge 51335
quit

"Jose A. Ortega Ruiz" <mail <at> jao.io> writes:

> Hi,
>
> In gnus-search, there are several logs (some of them quite verbose when
> one's iterating over long lists of groups) using `message'.  I think
> that it'd be better to use `gnus-message' instead, with levels as
> appropriate.  That way one can avoid (or enable!) them via gnus-verbose.
>
> I'm attaching a patch changing them all to level 7, since they looked
> like debug messages to me; but it's just a suggestion.

Yes, this is an excellent suggestion, and should be part of the work
ongoing in bug#51335.

Thanks!




Information forwarded to bug-gnu-emacs <at> gnu.org, bugs <at> gnus.org:
bug#51778; Package emacs,gnus. (Fri, 12 Nov 2021 01:28:01 GMT) Full text and rfc822 format available.

Message #11 received at 51778 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: "Jose A. Ortega Ruiz" <mail <at> jao.io>
Cc: 51778 <at> debbugs.gnu.org
Subject: Re: bug#51778: 29.0.50; gnus-search uses `message' instead of
 `gnus-message'
Date: Thu, 11 Nov 2021 17:26:53 -0800
Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> merge 51335
> quit

Obviously I still don't know how this works, anyway this should be
rolled in with bug#51335.




Information forwarded to bug-gnu-emacs <at> gnu.org, bugs <at> gnus.org:
bug#51778; Package emacs,gnus. (Fri, 12 Nov 2021 03:37:01 GMT) Full text and rfc822 format available.

Message #14 received at 51778 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: "Jose A. Ortega Ruiz" <mail <at> jao.io>, 51778 <at> debbugs.gnu.org
Subject: Re: bug#51778: 29.0.50; gnus-search uses `message' instead of
 `gnus-message'
Date: Fri, 12 Nov 2021 04:36:09 +0100
Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> merge 51335
>> quit
>
> Obviously I still don't know how this works, anyway this should be
> rolled in with bug#51335.

I think "forcemerge" works better...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Reply sent to Eric Abrahamsen <eric <at> ericabrahamsen.net>:
You have taken responsibility. (Fri, 03 Dec 2021 17:29:01 GMT) Full text and rfc822 format available.

Notification sent to "Jose A. Ortega Ruiz" <mail <at> jao.io>:
bug acknowledged by developer. (Fri, 03 Dec 2021 17:29:01 GMT) Full text and rfc822 format available.

Message #19 received at 51778-done <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: "Jose A. Ortega Ruiz" <mail <at> jao.io>, 51778-done <at> debbugs.gnu.org
Subject: Re: bug#51778: 29.0.50; gnus-search uses `message' instead of
 `gnus-message'
Date: Fri, 03 Dec 2021 09:28:12 -0800
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>>
>>> merge 51335
>>> quit
>>
>> Obviously I still don't know how this works, anyway this should be
>> rolled in with bug#51335.
>
> I think "forcemerge" works better...

I haven't had time to sit and work on the larger project of logging,
etc, so I'm doing some spot fixes first.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 01 Jan 2022 12:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 77 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.