GNU bug report logs - #51779
[PATCH] Add phonesim 1.21

Previous Next

Package: guix-patches;

Reported by: Demis Balbach <db <at> minikn.xyz>

Date: Thu, 11 Nov 2021 22:26:01 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51779 in the body.
You can then email your comments to 51779 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#51779; Package guix-patches. (Thu, 11 Nov 2021 22:26:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Demis Balbach <db <at> minikn.xyz>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 11 Nov 2021 22:26:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Demis Balbach <db <at> minikn.xyz>
To: guix-patches <at> gnu.org
Cc: Demis Balbach <db <at> minikn.xyz>
Subject: [PATCH] Add phonesim 1.21
Date: Thu, 11 Nov 2021 23:14:57 +0100
---
 gnu/packages/telephony.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
index a2765ee99f..77914fb4d7 100644
--- a/gnu/packages/telephony.scm
+++ b/gnu/packages/telephony.scm
@@ -20,6 +20,7 @@
 ;;; Copyright © 2020, 2021 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
 ;;; Copyright © 2020 Vincent Legoll <vincent.legoll <at> gmail.com>
 ;;; Copyright © 2021 LibreMiami <packaging-guix <at> libremiami.org>
+;;; Copyright © 2021 Demis Balbach <db <at> minikn.xyz>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -94,6 +95,35 @@ (define-module (gnu packages telephony)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system qt))
 
+(define-public phonesim
+  (package
+    (name "phonesim")
+    (version "1.21")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://git.kernel.org/pub/scm/network/ofono/phonesim.git")
+                    (commit "a7c844d45b047b2dae5b0877816c346fce4c47b9")))
+              (sha256
+               (base32
+                "0rc1c2vr03dmi1dr3skj57v77ga9c22g29xs1qiphqms4isby9cq"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags
+       (list "--enable-maintainer-mode"
+             "CC=gcc")))
+    (native-inputs
+     `(("automake" ,automake)
+       ("autoconf" ,autoconf)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("qtbase" ,qtbase-5)
+       ("qtdeclarative" ,qtdeclarative)))
+    (synopsis "Phone Simulator for modem testing")
+    (description "Phone Simulator for modem testing")
+    (home-page "https://git.kernel.org/pub/scm/network/ofono/phonesim.git")
+    (license license:gpl2+)))
+
 (define-public libilbc
   (package
     (name "libilbc")
-- 
2.33.0





Information forwarded to guix-patches <at> gnu.org:
bug#51779; Package guix-patches. (Fri, 12 Nov 2021 15:06:01 GMT) Full text and rfc822 format available.

Message #8 received at 51779 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Demis Balbach <db <at> minikn.xyz>
Cc: 51779 <at> debbugs.gnu.org
Subject: Re: [bug#51779] [PATCH] Add phonesim 1.21
Date: Fri, 12 Nov 2021 16:05:35 +0100
Demis,

Thanks for the patch!  Here are a few low-hanging thoughts (not a full 
review):

Check the git log for commits adding new packages for the expected 
'change-log-style' commit message.

On 2021-11-11 23:14, Demis Balbach wrote:
> +     `(#:configure-flags
> +       (list "--enable-maintainer-mode"

This is unusual enough to require a comment explaining why it's here.

> +             "CC=gcc")))

This breaks cross-compilation: the cross GCC is called something like 
'x86_64-blah-bloo-gcc', not 'gcc'.  There's a helper in (guix utils) 
IIRC that returns the right cc for the target:

  (string-append "CC=" ,(cc-for-target))

> +    (description "Phone Simulator for modem testing")

This should be at least several lines of complete sentences ("Phonesim 
simulates blah...").

Kind regards,

T G-R

Sent from a Web browser.  Excuse or enjoy my brevity.




Information forwarded to guix-patches <at> gnu.org:
bug#51779; Package guix-patches. (Fri, 12 Nov 2021 19:20:02 GMT) Full text and rfc822 format available.

Message #11 received at 51779 <at> debbugs.gnu.org (full text, mbox):

From: <db <at> minikn.xyz>
To: <51779 <at> debbugs.gnu.org>
Subject: [PATCH] Add phonesim 1.21
Date: Fri, 12 Nov 2021 20:19:03 +0100
Hello Tobias,

thank you for your input. This is my first attempt at submitting a patch
through a mailing list. I expected some mistakes. On top of that, my
guile is bad as well (I'm just starting with it).

> Check the git log for commits adding new packages for the expected
> 'change-log-style' commit message.

Thanks. I think it should have been `[PATCH] gnu: Add phonesim'. How can
I change that?

> This is unusual enough to require a comment explaining why it's here.

The short answer is - I don't know. I copied it from the source:

https://git.kernel.org/pub/scm/network/ofono/phonesim.git/tree/bootstrap-con
figure

I should also mention that I do not have any experience with the
application. I never used it nor do I really understand what it does. I
just submitted a patch because it is part of what needs to be done in
order to get bluetooth headsets fully working in Guix (with microphone),
see

https://wiki.archlinux.org/title/Bluetooth_headset#HFP_not_working_with_Puls
eAudio

This is beside the point, but I'm mentioning it to give a little
background why I may not be able to give insight on why things are done
a certain way.

That being said, here is the new patch version:

---
 gnu/packages/telephony.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
index a2765ee99f..6e3c69ce91 100644
--- a/gnu/packages/telephony.scm
+++ b/gnu/packages/telephony.scm
@@ -20,6 +20,7 @@
 ;;; Copyright C 2020, 2021 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
 ;;; Copyright C 2020 Vincent Legoll <vincent.legoll <at> gmail.com>
 ;;; Copyright C 2021 LibreMiami <packaging-guix <at> libremiami.org>
+;;; Copyright C 2021 Demis Balbach <db <at> minikn.xyz>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -87,6 +88,7 @@ (define-module (gnu packages telephony)
   #:use-module (gnu packages bison)
   #:use-module (gnu packages flex)
   #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix utils)
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix git-download)
@@ -94,6 +96,37 @@ (define-module (gnu packages telephony)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system qt))

+(define-public phonesim
+  (package
+    (name "phonesim")
+    (version "1.21")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url
"https://git.kernel.org/pub/scm/network/ofono/phonesim.git")
+                    (commit "a7c844d45b047b2dae5b0877816c346fce4c47b9")))
+              (sha256
+               (base32
+                "0rc1c2vr03dmi1dr3skj57v77ga9c22g29xs1qiphqms4isby9cq"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags
+       (list "--enable-maintainer-mode"
+             "CC=" ,(cc-for-target))))
+    (native-inputs
+     `(("automake" ,automake)
+       ("autoconf" ,autoconf)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("qtbase" ,qtbase-5)
+       ("qtdeclarative" ,qtdeclarative)))
+    (synopsis "Phone Simulator for modem testing")
+    (description "Phonesim is a modem emulator that oFono uses for
development
+and testing. This allows oFono to be used by any host without requiring
special
+GSM (or other) hardware.")
+    (home-page "https://git.kernel.org/pub/scm/network/ofono/phonesim.git")
+    (license license:gpl2+)))
+
 (define-public libilbc
   (package
     (name "libilbc")
--
2.33.0

Greetings,

Demis.





Information forwarded to guix-patches <at> gnu.org:
bug#51779; Package guix-patches. (Sat, 13 Nov 2021 10:02:01 GMT) Full text and rfc822 format available.

Message #14 received at 51779 <at> debbugs.gnu.org (full text, mbox):

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: db <at> minikn.xyz, 51779 <at> debbugs.gnu.org
Cc: dev <at> jpoiret.xyz
Subject: Re: [bug#51779] [PATCH] Add phonesim 1.21
Date: Sat, 13 Nov 2021 10:01:26 +0000
Hello Demis,

About the ChangeLog style, it is documented at [1], and it mostly
concerns the contents of the commit message.  In the case of this patch,
I think it should be

--8<---------------cut here---------------start------------->8---
gnu: Add phonesim.

* gnu/packages/telephony.scm (phonesim): Add new variable.
--8<---------------cut here---------------end--------------->8---

You can take a look at the complete commit messages in the git log to
get a feel for what needs to be included in them.

As for the patch, it looks good to me, but I'm no expert yet.  Glad to
see your first contribution though!

[1] https://www.gnu.org/prep/standards/html_node/Change-Logs.html

Best,
Josselin Poiret




Information forwarded to guix-patches <at> gnu.org:
bug#51779; Package guix-patches. (Tue, 23 Nov 2021 18:39:01 GMT) Full text and rfc822 format available.

Message #17 received at 51779 <at> debbugs.gnu.org (full text, mbox):

From: Demis Balbach <db <at> minikn.xyz>
To: 51779 <at> debbugs.gnu.org
Subject: [PATCH] Add phonesim 1.21
Date: Tue, 23 Nov 2021 19:37:51 +0100
> You can take a look at the complete commit messages in the git log to
> get a feel for what needs to be included in them.

Thank you Josselin.

I'm still quite unfamiliar with patches through mailing lists: Do I have
to change anything in this patch for it to get merged, or should I just
keep the naming convention in mind for future patches?

Greetings,

Demis.




Information forwarded to guix-patches <at> gnu.org:
bug#51779; Package guix-patches. (Tue, 23 Nov 2021 18:56:01 GMT) Full text and rfc822 format available.

Message #20 received at 51779 <at> debbugs.gnu.org (full text, mbox):

From: Demis Balbach <db <at> minikn.xyz>
To: 51779 <at> debbugs.gnu.org
Subject: [PATCH] Add phonesim 1.21
Date: Tue, 23 Nov 2021 19:55:21 +0100
This is the new patch after changing the commit message.

* gnu/packages/telephony.scm (phonesim): Add new variable.
---
 gnu/packages/telephony.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
index a2765ee99f..6e3c69ce91 100644
--- a/gnu/packages/telephony.scm
+++ b/gnu/packages/telephony.scm
@@ -20,6 +20,7 @@
 ;;; Copyright © 2020, 2021 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
 ;;; Copyright © 2020 Vincent Legoll <vincent.legoll <at> gmail.com>
 ;;; Copyright © 2021 LibreMiami <packaging-guix <at> libremiami.org>
+;;; Copyright © 2021 Demis Balbach <db <at> minikn.xyz>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -87,6 +88,7 @@ (define-module (gnu packages telephony)
   #:use-module (gnu packages bison)
   #:use-module (gnu packages flex)
   #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix utils)
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix git-download)
@@ -94,6 +96,37 @@ (define-module (gnu packages telephony)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system qt))

+(define-public phonesim
+  (package
+    (name "phonesim")
+    (version "1.21")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://git.kernel.org/pub/scm/network/ofono/phonesim.git")
+                    (commit "a7c844d45b047b2dae5b0877816c346fce4c47b9")))
+              (sha256
+               (base32
+                "0rc1c2vr03dmi1dr3skj57v77ga9c22g29xs1qiphqms4isby9cq"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags
+       (list "--enable-maintainer-mode"
+             "CC=" ,(cc-for-target))))
+    (native-inputs
+     `(("automake" ,automake)
+       ("autoconf" ,autoconf)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("qtbase" ,qtbase-5)
+       ("qtdeclarative" ,qtdeclarative)))
+    (synopsis "Phone Simulator for modem testing")
+    (description "Phonesim is a modem emulator that oFono uses for development
+and testing. This allows oFono to be used by any host without requiring special
+GSM (or other) hardware.")
+    (home-page "https://git.kernel.org/pub/scm/network/ofono/phonesim.git")
+    (license license:gpl2+)))
+
 (define-public libilbc
   (package
     (name "libilbc")
--
2.34.0

Cheers,

Demis.




Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Sun, 05 Dec 2021 20:58:01 GMT) Full text and rfc822 format available.

Notification sent to Demis Balbach <db <at> minikn.xyz>:
bug acknowledged by developer. (Sun, 05 Dec 2021 20:58:02 GMT) Full text and rfc822 format available.

Message #25 received at 51779-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Demis Balbach <db <at> minikn.xyz>
Cc: 51779-done <at> debbugs.gnu.org
Subject: Re: [bug#51779] [PATCH] Add phonesim 1.21
Date: Sun, 05 Dec 2021 21:57:32 +0100
Hello,

Demis Balbach <db <at> minikn.xyz> writes:

> * gnu/packages/telephony.scm (phonesim): Add new variable.

I fixed the commit message and applied your patch. Thank you.

Regards,
-- 
Nicolas Goaziou




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 03 Jan 2022 12:24:09 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 75 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.