GNU bug report logs - #51791
[PATCH 0/2]: Update guile-bash

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51791 in the body.
You can then email your comments to 51791 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: david larsson <david.larsson <at> selfhosted.xyz>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2]: Update guile-bash
Date: Fri, 12 Nov 2021 14:56:27 +0100

Hi,

The following 2 patches update the guile-bash source url and home-page, 
and adds a patch for it that does 2 things:
  - fixes a bug, see below
  - enables reading newline- or null-separated arguments via stdin to 
guile-bash-defined bash functions.

The bug is that guile-bash can't read string args with whitespaces in 
it. Example:
------------------------
~$ enable -f ~/.guix-profile/lib/bash/libguile-bash.so scm
~$ scm /tmp/printargs
~$ printargs "apa bepa" cepa
In procedure printargs: scm-function called from Bash with args (apa 
bepa cepa) failed to match signature (file1 file2)
~$ cat /tmp/printargs
(use-modules
 (gnu bash))
(define-bash-function (printargs file1 file2)
    (display file1)
    (display "\n")
    (display file2)
    (display "\n"))
-------------------------

After this patch, you can read args "as normal", or via stdin that are 
either newline- or null-separated:
-------------------------
~$ printargs "apa bepa" cepa
apa bepa
cepa
~$ echo "$apa"
aba
aca
~$ printf '%s\0' "$apa" bepa | printargs -z
aba
aca
bepa
~$ echo "$apa" | printargs
aba
aca
-------------------------

Best regards,
David

Message #8 received at 51791 <at> debbugs.gnu.org (full text, mbox):

From: david larsson <david.larsson <at> selfhosted.xyz>
To: 51791 <at> debbugs.gnu.org
Cc: Guix-patches <guix-patches-bounces+david.larsson=selfhosted.xyz <at> gnu.org>
Subject: Re: [bug#51791] [PATCH 1/2]: Update guile-bash
Date: Fri, 12 Nov 2021 15:00:20 +0100

[Message part 1 (text/plain, inline)]

On 2021-11-12 14:56, david larsson wrote:
> Hi,
> 
> The following 2 patches update the guile-bash source url and
> home-page, and adds a patch for it that does 2 things:
>   - fixes a bug, see below
>   - enables reading newline- or null-separated arguments via stdin to
> guile-bash-defined bash functions.
> 
> The bug is that guile-bash can't read string args with whitespaces in
> it. Example:
> ------------------------
> ~$ enable -f ~/.guix-profile/lib/bash/libguile-bash.so scm
> ~$ scm /tmp/printargs
> ~$ printargs "apa bepa" cepa
> In procedure printargs: scm-function called from Bash with args (apa
> bepa cepa) failed to match signature (file1 file2)
> ~$ cat /tmp/printargs
> (use-modules
>  (gnu bash))
> (define-bash-function (printargs file1 file2)
>     (display file1)
>     (display "\n")
>     (display file2)
>     (display "\n"))
> -------------------------
> 
> After this patch, you can read args "as normal", or via stdin that are
> either newline- or null-separated:
> -------------------------
> ~$ printargs "apa bepa" cepa
> apa bepa
> cepa
> ~$ echo "$apa"
> aba
> aca
> ~$ printf '%s\0' "$apa" bepa | printargs -z
> aba
> aca
> bepa
> ~$ echo "$apa" | printargs
> aba
> aca
> -------------------------
> 
> Best regards,
> David

[0001-gnu-guile-bash-Update-source-url.patch (text/x-diff, attachment)]

Message #11 received at 51791 <at> debbugs.gnu.org (full text, mbox):

From: david larsson <david.larsson <at> selfhosted.xyz>
To: 51791 <at> debbugs.gnu.org
Cc: Guix-patches <guix-patches-bounces+david.larsson=selfhosted.xyz <at> gnu.org>
Subject: Re: [bug#51791] [PATCH 1/2]: Update guile-bash
Date: Fri, 12 Nov 2021 15:01:00 +0100

[Message part 1 (text/plain, inline)]

On 2021-11-12 14:56, david larsson wrote:
> Hi,
> 
> The following 2 patches update the guile-bash source url and
> home-page, and adds a patch for it that does 2 things:
>   - fixes a bug, see below
>   - enables reading newline- or null-separated arguments via stdin to
> guile-bash-defined bash functions.
> 
> The bug is that guile-bash can't read string args with whitespaces in
> it. Example:
> ------------------------
> ~$ enable -f ~/.guix-profile/lib/bash/libguile-bash.so scm
> ~$ scm /tmp/printargs
> ~$ printargs "apa bepa" cepa
> In procedure printargs: scm-function called from Bash with args (apa
> bepa cepa) failed to match signature (file1 file2)
> ~$ cat /tmp/printargs
> (use-modules
>  (gnu bash))
> (define-bash-function (printargs file1 file2)
>     (display file1)
>     (display "\n")
>     (display file2)
>     (display "\n"))
> -------------------------
> 
> After this patch, you can read args "as normal", or via stdin that are
> either newline- or null-separated:
> -------------------------
> ~$ printargs "apa bepa" cepa
> apa bepa
> cepa
> ~$ echo "$apa"
> aba
> aca
> ~$ printf '%s\0' "$apa" bepa | printargs -z
> aba
> aca
> bepa
> ~$ echo "$apa" | printargs
> aba
> aca
> -------------------------
> 
> Best regards,
> David

[0002-gnu-guile-bash-Add-patch-that-fixes-reading-args.patch (text/x-diff, attachment)]

Message #14 received at 51791 <at> debbugs.gnu.org (full text, mbox):

From: david larsson <david.larsson <at> selfhosted.xyz>
To: 51791 <at> debbugs.gnu.org
Cc: Guix-patches <guix-patches-bounces+david.larsson=selfhosted.xyz <at> gnu.org>
Subject: Re: [bug#51791] [PATCH 2/2]: Update guile-bash
Date: Fri, 12 Nov 2021 16:50:25 +0100

[Message part 1 (text/plain, inline)]

On 2021-11-12 14:56, david larsson wrote:
> Hi,
> 
> The following 2 patches update the guile-bash source url and
> home-page, and adds a patch for it that does 2 things:
>   - fixes a bug, see below
>   - enables reading newline- or null-separated arguments via stdin to
> guile-bash-defined bash functions.
> 
> The bug is that guile-bash can't read string args with whitespaces in
> it. Example:
> ------------------------
> ~$ enable -f ~/.guix-profile/lib/bash/libguile-bash.so scm
> ~$ scm /tmp/printargs
> ~$ printargs "apa bepa" cepa
> In procedure printargs: scm-function called from Bash with args (apa
> bepa cepa) failed to match signature (file1 file2)
> ~$ cat /tmp/printargs
> (use-modules
>  (gnu bash))
> (define-bash-function (printargs file1 file2)
>     (display file1)
>     (display "\n")
>     (display file2)
>     (display "\n"))
> -------------------------
> 
> After this patch, you can read args "as normal", or via stdin that are
> either newline- or null-separated:
> -------------------------
> ~$ printargs "apa bepa" cepa
> apa bepa
> cepa
> ~$ echo "$apa"
> aba
> aca
> ~$ printf '%s\0' "$apa" bepa | printargs -z
> aba
> aca
> bepa
> ~$ echo "$apa" | printargs
> aba
> aca
> -------------------------
> 
> Best regards,
> David

[0002-gnu-guile-bash-Add-patch-that-fixes-reading-args.patch (text/x-diff, attachment)]

Message #17 received at 51791 <at> debbugs.gnu.org (full text, mbox):

From: david larsson <david.larsson <at> selfhosted.xyz>
To: 51791 <at> debbugs.gnu.org
Cc: Guix-patches <guix-patches-bounces+david.larsson=selfhosted.xyz <at> gnu.org>
Subject: Re: [bug#51791] [PATCH 2/2 v2]: Update guile-bash
Date: Fri, 26 Nov 2021 20:16:12 +0100

[Message part 1 (text/plain, inline)]

Forgot to update gnu/local.mk with the patch file for guile-bash so 
fixing that with this new patch.

[0002-gnu-guile-bash-Add-patch-that-fixes-reading-args.patch (text/x-diff, attachment)]

Message #20 received at 51791 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 51791 <at> debbugs.gnu.org
Cc: david.larsson <at> selfhosted.xyz
Subject: [PATCH 0/2]: Update guile-bash
Date: Wed, 01 Dec 2021 08:20:04 +0100

Hi David,

thank you for the update!  What is the upstream status of this 
patch?  Has it been sent to upstream?  Is upstream development 
continuing?  (That’s what the new home-page implies.)

-- 
Ricardo

Message #23 received at 51791 <at> debbugs.gnu.org (full text, mbox):

From: david larsson <david.larsson <at> selfhosted.xyz>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 51791 <at> debbugs.gnu.org
Subject: Re: [PATCH 0/2]: Update guile-bash
Date: Wed, 01 Dec 2021 11:28:55 +0100

On 2021-12-01 08:20, Ricardo Wurmus wrote:
> Hi David,
> 
> thank you for the update!  What is the upstream status of this patch?
> Has it been sent to upstream?  Is upstream development continuing?
> (That’s what the new home-page implies.)

I have sent a patch a couple weeks ago via sr.ht (my fork is here: 
https://git.sr.ht/~methuselah-0/guile-bash) to the author but no 
response so far.

The latest patch is from 6 years ago so development has probably not 
restarted.

I still think it would be good to change the upstream to sr.ht because 
it very much looks like it's the original author's repository (username 
is kaction) and it has all the change history - versus as it is now 
where I think software heritage is used when building it from source (or 
maybe a cached version on the build farms).

Best regards,
David

Message #26 received at 51791 <at> debbugs.gnu.org (full text, mbox):

From: david larsson <david.larsson <at> selfhosted.xyz>
To: 51791 <at> debbugs.gnu.org
Cc: Guix-patches <guix-patches-bounces+david.larsson=selfhosted.xyz <at> gnu.org>
Subject: Re: [bug#51791] [PATCH 0/2]: Update guile-bash
Date: Wed, 15 Dec 2021 12:54:53 +0100

If anyone wants to install a guile-bash that can read arguments with 
whitespace, and newlines, you can install it like this:

wget -O /tmp/patch.temp http://paste.debian.net/plain/1223545 ; guix 
package --with-patch=guile-bash=/tmp/patch.temp -i guile-bash


Then prepare it like this for example:

------------------------------------------
$ export GUILE_AUTO_COMPILE=0
$ enable -f ~/.guix-profile/lib/bash/libguile-bash.so scm
$ cat <<'EOF'>/tmp/printargs.scm
(use-modules
 (gnu bash))
(define-bash-function (printargs file1 file2)
    (display file1)
    (display "\n")
    (display file2)
    (display "\n"))
EOF
$ scm /tmp/printargs.scm
-------------------------

And then use the guile function from bash like this:

-------------------------
~$ printargs "apa bepa" cepa
apa bepa
cepa
~$ echo "$apa"
aba
aca
~$ printf '%s\0' "$apa" bepa | printargs -z
aba
aca
bepa
~$ echo "$apa" | printargs
aba
aca
-------------------------


Closing this bug now.

Message #31 received at 51791-done <at> debbugs.gnu.org (full text, mbox):

From: david larsson <david.larsson <at> selfhosted.xyz>
To: 51791-done <at> debbugs.gnu.org
Subject: done
Date: Wed, 15 Dec 2021 12:55:23 +0100

done

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.