GNU bug report logs - #51795
[PATCH]: gnu: Add imppg

Previous Next

Package: guix-patches;

Reported by: Sharlatan Hellseher <sharlatanus <at> gmail.com>

Date: Fri, 12 Nov 2021 21:24:01 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51795 in the body.
You can then email your comments to 51795 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#51795; Package guix-patches. (Fri, 12 Nov 2021 21:24:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Sharlatan Hellseher <sharlatanus <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 12 Nov 2021 21:24:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH]: gnu: Add imppg
Date: Fri, 12 Nov 2021 21:22:48 +0000
[Message part 1 (text/plain, inline)]
successfully built /gnu/store/14nqbnzy6k91x8l98c9hid6l1dxcza60-imppg-0.6.4.drv


-- 
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.
[0001-gnu-Add-imppg.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#51795; Package guix-patches. (Sat, 13 Nov 2021 01:51:02 GMT) Full text and rfc822 format available.

Message #8 received at 51795 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: 51795 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add imppg
Date: Sat, 13 Nov 2021 01:49:44 +0000
Hi Sharlatan,

Em sex, 2021-11-12 às 21:21 +0000, Sharlatan Hellseher escreveu:
> * gnu/packages/astronomy.scm: (imppg): New variable.
> ---
>  gnu/packages/astronomy.scm | 53
> ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 53 insertions(+)
> 
> diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
> index fc8959faad..57f62dc24d 100644
> --- a/gnu/packages/astronomy.scm
> +++ b/gnu/packages/astronomy.scm
> @@ -32,6 +32,7 @@ (define-module (gnu packages astronomy)
>    #:use-module (gnu packages)
>    #:use-module (gnu packages algebra)
>    #:use-module (gnu packages autotools)
> +  #:use-module (gnu packages boost)
>    #:use-module (gnu packages check)
>    #:use-module (gnu packages compression)
>    #:use-module (gnu packages curl)
> @@ -56,6 +57,7 @@ (define-module (gnu packages astronomy)
>    #:use-module (gnu packages qt)
>    #:use-module (gnu packages version-control)
>    #:use-module (gnu packages video)
> +  #:use-module (gnu packages wxwidgets)
>    #:use-module (gnu packages xiph)
>    #:use-module (gnu packages xml)
>    #:use-module (gnu packages xorg)
> @@ -986,6 +988,57 @@ (define-public sgp4
>  It can be used to calculate the trajectory of satellites.")
>        (license license:asl2.0))))
>  
> +(define-public imppg
> +  (package
> +    (name "imppg")
> +    (version "0.6.4")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url (string-append
> "https://github.com/GreatAttractor/" name))

AFAIK we don't use 'name' in the url anymore, it should be hardcoded.

> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> "04synbmyz0hkipl1cdc26nr42r57v494yjw8pi4jx0jrxrawgj9h"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:tests? #f ; No test provided
> +       #:phases
> +       (modify-phases %standard-phases
> +         (replace 'configure
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (mkdir-p "build")
> +             (chdir "build")
> +             (invoke
> +              "cmake"
> +              "-G" "Unix Makefiles"
> +              "-DCMAKE_BUILD_TYPE=Release"
> +              (string-append "-DCMAKE_INSTALL_PREFIX=" (assoc-ref
> outputs "out"))
> +              ".."))))))

This is unusual. Why are we overriding the configure phase? I could
build the package just fine with the standard phase.

CMAKE_BUILD_TYPE can be set to Release using '#:build-type "Release"'.
Other CMake variables can be changed in #:configure-flags.

AFAIK Guix also avoids setting CMAKE_BUILD_TYPE to "Release" without a
good reason, such as debug symbols being too large.

> +    (native-inputs
> +     `(("boost" ,boost)
> +       ("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("cfitsio" ,cfitsio)
> +       ("freeimage" ,freeimage)
> +       ("glew" ,glew)
> +       ("wxwidgets" ,wxwidgets)))
> +    (home-page "https://github.com/GreatAttractor/imppg")
> +    (synopsis "Astronomical Image Post-Proccessor (ImPPG)")
> +    (description
> +     "ImPPG performs Lucy-Richardson deconvolution, unsharp masking,
> brightness
> +normalization and tone curve adjustment.  It can also apply
> previously specified
> +processing settings to multiple images.  All operations are
> performed using
> +32-bit floating-point arithmetic.
> +
> +Supported input formats: FITS, BMP, JPEG, PNG, TIFF (most of bit
> depths and
> +compression methods), TGA and more.  Images are processed in
> grayscale and can be
> +saved as: BMP 8-bit; PNG 8-bit; TIFF 8-bit, 16-bit, 32-bit floating-
> point (no
> +compression, LZW- or ZIP-compressed), FITS 8-bit, 16-bit, 32-bit
> +floating-point.")

Description exceeded 78 columns in 3 lines.

> +     (license license:gpl3+)))
> +
>  (define-public indi
>    (package
>      (name "indi")

LGTM otherwise!





Information forwarded to guix-patches <at> gnu.org:
bug#51795; Package guix-patches. (Sat, 13 Nov 2021 10:03:02 GMT) Full text and rfc822 format available.

Message #11 received at 51795 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 51795 <at> debbugs.gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: Re: [PATCH] gnu: Add imppg
Date: Sat, 13 Nov 2021 10:01:44 +0000
[Message part 1 (text/plain, inline)]
Hi Vinicius,

Thank you for your fead back, I've updated patch with your suggestions.

successfully built /gnu/store/43jw7kaqriz7vb2vslkqjv3sn21gwdpf-imppg-0.6.4.drv

On Sat, 13 Nov 2021 at 01:49, Vinicius Monego <monego <at> posteo.net> wrote:
>
> Hi Sharlatan,
>
> Em sex, 2021-11-12 às 21:21 +0000, Sharlatan Hellseher escreveu:
> > * gnu/packages/astronomy.scm: (imppg): New variable.
> > ---
> >  gnu/packages/astronomy.scm | 53
> > ++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 53 insertions(+)
> >
> > diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
> > index fc8959faad..57f62dc24d 100644
> > --- a/gnu/packages/astronomy.scm
> > +++ b/gnu/packages/astronomy.scm
> > @@ -32,6 +32,7 @@ (define-module (gnu packages astronomy)
> >    #:use-module (gnu packages)
> >    #:use-module (gnu packages algebra)
> >    #:use-module (gnu packages autotools)
> > +  #:use-module (gnu packages boost)
> >    #:use-module (gnu packages check)
> >    #:use-module (gnu packages compression)
> >    #:use-module (gnu packages curl)
> > @@ -56,6 +57,7 @@ (define-module (gnu packages astronomy)
> >    #:use-module (gnu packages qt)
> >    #:use-module (gnu packages version-control)
> >    #:use-module (gnu packages video)
> > +  #:use-module (gnu packages wxwidgets)
> >    #:use-module (gnu packages xiph)
> >    #:use-module (gnu packages xml)
> >    #:use-module (gnu packages xorg)
> > @@ -986,6 +988,57 @@ (define-public sgp4
> >  It can be used to calculate the trajectory of satellites.")
> >        (license license:asl2.0))))
> >
> > +(define-public imppg
> > +  (package
> > +    (name "imppg")
> > +    (version "0.6.4")
> > +    (source
> > +     (origin
> > +       (method git-fetch)
> > +       (uri (git-reference
> > +             (url (string-append
> > "https://github.com/GreatAttractor/" name))
>
> AFAIK we don't use 'name' in the url anymore, it should be hardcoded.
>
> > +             (commit (string-append "v" version))))
> > +       (file-name (git-file-name name version))
> > +       (sha256
> > +        (base32
> > "04synbmyz0hkipl1cdc26nr42r57v494yjw8pi4jx0jrxrawgj9h"))))
> > +    (build-system cmake-build-system)
> > +    (arguments
> > +     `(#:tests? #f ; No test provided
> > +       #:phases
> > +       (modify-phases %standard-phases
> > +         (replace 'configure
> > +           (lambda* (#:key outputs #:allow-other-keys)
> > +             (mkdir-p "build")
> > +             (chdir "build")
> > +             (invoke
> > +              "cmake"
> > +              "-G" "Unix Makefiles"
> > +              "-DCMAKE_BUILD_TYPE=Release"
> > +              (string-append "-DCMAKE_INSTALL_PREFIX=" (assoc-ref
> > outputs "out"))
> > +              ".."))))))
>
> This is unusual. Why are we overriding the configure phase? I could
> build the package just fine with the standard phase.
>
> CMAKE_BUILD_TYPE can be set to Release using '#:build-type "Release"'.
> Other CMake variables can be changed in #:configure-flags.
>
> AFAIK Guix also avoids setting CMAKE_BUILD_TYPE to "Release" without a
> good reason, such as debug symbols being too large.
>
> > +    (native-inputs
> > +     `(("boost" ,boost)
> > +       ("pkg-config" ,pkg-config)))
> > +    (inputs
> > +     `(("cfitsio" ,cfitsio)
> > +       ("freeimage" ,freeimage)
> > +       ("glew" ,glew)
> > +       ("wxwidgets" ,wxwidgets)))
> > +    (home-page "https://github.com/GreatAttractor/imppg")
> > +    (synopsis "Astronomical Image Post-Proccessor (ImPPG)")
> > +    (description
> > +     "ImPPG performs Lucy-Richardson deconvolution, unsharp masking,
> > brightness
> > +normalization and tone curve adjustment.  It can also apply
> > previously specified
> > +processing settings to multiple images.  All operations are
> > performed using
> > +32-bit floating-point arithmetic.
> > +
> > +Supported input formats: FITS, BMP, JPEG, PNG, TIFF (most of bit
> > depths and
> > +compression methods), TGA and more.  Images are processed in
> > grayscale and can be
> > +saved as: BMP 8-bit; PNG 8-bit; TIFF 8-bit, 16-bit, 32-bit floating-
> > point (no
> > +compression, LZW- or ZIP-compressed), FITS 8-bit, 16-bit, 32-bit
> > +floating-point.")
>
> Description exceeded 78 columns in 3 lines.
>
> > +     (license license:gpl3+)))
> > +
> >  (define-public indi
> >    (package
> >      (name "indi")
>
> LGTM otherwise!
>


-- 

… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.
[0001-gnu-Add-imppg.patch (text/x-patch, attachment)]

Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Sun, 05 Dec 2021 11:39:02 GMT) Full text and rfc822 format available.

Notification sent to Sharlatan Hellseher <sharlatanus <at> gmail.com>:
bug acknowledged by developer. (Sun, 05 Dec 2021 11:39:02 GMT) Full text and rfc822 format available.

Message #16 received at 51795-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: 51795-done <at> debbugs.gnu.org
Subject: Re: [bug#51795] [PATCH]: gnu: Add imppg
Date: Sun, 05 Dec 2021 12:38:33 +0100
Hello,

Sharlatan Hellseher <sharlatanus <at> gmail.com> writes:

> successfully built
> /gnu/store/14nqbnzy6k91x8l98c9hid6l1dxcza60-imppg-0.6.4.drv

Thank you.

I applied it with the following minor change:

> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url (string-append "https://github.com/GreatAttractor/" name))

I hard-coded name into URL.

Regards,
-- 
Nicolas Goaziou




Information forwarded to guix-patches <at> gnu.org:
bug#51795; Package guix-patches. (Sun, 12 Dec 2021 01:19:02 GMT) Full text and rfc822 format available.

Message #19 received at 51795 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 51795 <at> debbugs.gnu.org
Date: Sun, 12 Dec 2021 01:18:31 +0000
[Message part 1 (text/plain, inline)]
-- 
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.
[0002-gnu-Add-msgpack-v4.patch (text/x-patch, attachment)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 09 Jan 2022 12:24:10 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 69 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.