GNU bug report logs - #51800
29.0.50; vc-{cvs,dav,rcs,sccs}-responsible-p should not return t

Previous Next

Package: emacs;

Reported by: TAKAHASHI Yoshio <yfb02119 <at> nifty.com>

Date: Sat, 13 Nov 2021 01:26:02 UTC

Severity: normal

Found in version 29.0.50

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51800 in the body.
You can then email your comments to 51800 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#51800; Package emacs. (Sat, 13 Nov 2021 01:26:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to TAKAHASHI Yoshio <yfb02119 <at> nifty.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sat, 13 Nov 2021 01:26:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: TAKAHASHI Yoshio <yfb02119 <at> nifty.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; vc-{cvs,dav,rcs,sccs}-responsible-p should not return t
Date: Sat, 13 Nov 2021 10:24:20 +0900
Hi,

vc-*-responsible-p should not return t.
it should return nil or path string.

for example, `vc-rcs-responsible-p' returns the result of
`file-directory-p', that is t or nil.
if it returns t, the caller, `vc-backend-for-registration', raises an
error, because it expects SEQUENCE.

-- 
tkh




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51800; Package emacs. (Sun, 14 Nov 2021 01:40:01 GMT) Full text and rfc822 format available.

Message #8 received at 51800 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: TAKAHASHI Yoshio <yfb02119 <at> nifty.com>
Cc: 51800 <at> debbugs.gnu.org
Subject: Re: bug#51800: 29.0.50; vc-{cvs,dav,rcs,sccs}-responsible-p should
 not return t
Date: Sun, 14 Nov 2021 02:39:06 +0100
TAKAHASHI Yoshio <yfb02119 <at> nifty.com> writes:

> vc-*-responsible-p should not return t.
> it should return nil or path string.
>
> for example, `vc-rcs-responsible-p' returns the result of
> `file-directory-p', that is t or nil.
> if it returns t, the caller, `vc-backend-for-registration', raises an
> error, because it expects SEQUENCE.

Yup.  I've now fixed this in Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




bug marked as fixed in version 29.1, send any further explanations to 51800 <at> debbugs.gnu.org and TAKAHASHI Yoshio <yfb02119 <at> nifty.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sun, 14 Nov 2021 01:40:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 12 Dec 2021 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 97 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.