GNU bug report logs - #51807
[PATCH] Fix customization group of python-forward-sexp-function

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51807 in the body.
You can then email your comments to 51807 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix customization group of python-forward-sexp-function
Date: Sat, 13 Nov 2021 10:54:18 +0100

[Message part 1 (text/plain, inline)]

Tags: patch

Version: 28.0.60

python-forward-sexp-function was introduced in 2021-07-31 "Add new user
option python-forward-sexp-function" (2dcb0f8f52); due to where it was
inserted in python.el, it is currently sorted in the python-flymake
customization group, which AFAICT is not what we want.

Here are the "design considerations" that went into this patch:

1. Should the defcustom be moved?

I'm leaning toward yes; as things stand it was lost in the middle of
unrelated flymake code.  IMO the places that make the most sense are
either (1) the ";;; Navigation" subsection or (2) closer to the
definition of python-mode, where the option is actually used.

Of course, it could also be left in its current position, and have an
explicit :group clause.  Which leads to…

2. Should the defcustom have an explicit :group clause?

I'm leaning toward no: (1) it's not needed if we move it to an earlier
subsection, (2) M-s o defcustom\|:group shows that a bunch of options
use implicit groups already, (3) AFAICT the repo history shows a clear
trend toward removing "redundant" :group clauses.


Thanks for your time.


In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.16.0)
 of 2021-10-30 built on amdahl30
Repository revision: c30f95078c0735447c0bf293f2e6f573bc7057a3
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12013000
System Description: openSUSE Tumbleweed

Configured using:
 'configure --with-cairo --with-gconf'

[0001-Fix-customization-group-of-python-forward-sexp-funct.patch (text/patch, attachment)]

Message #8 received at 51807 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
Cc: 51807 <at> debbugs.gnu.org
Subject: Re: bug#51807: [PATCH] Fix customization group of
 python-forward-sexp-function
Date: Sun, 14 Nov 2021 02:30:21 +0100

Kévin Le Gouguec <kevin.legouguec <at> gmail.com> writes:

> python-forward-sexp-function was introduced in 2021-07-31 "Add new user
> option python-forward-sexp-function" (2dcb0f8f52); due to where it was
> inserted in python.el, it is currently sorted in the python-flymake
> customization group, which AFAICT is not what we want.

Thanks; applied to Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #13 received at 51807 <at> debbugs.gnu.org (full text, mbox):

From: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 51807 <at> debbugs.gnu.org
Subject: Re: bug#51807: [PATCH] Fix customization group of
 python-forward-sexp-function
Date: Sun, 14 Nov 2021 09:38:06 +0100

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Kévin Le Gouguec <kevin.legouguec <at> gmail.com> writes:
>
>> python-forward-sexp-function was introduced in 2021-07-31 "Add new user
>> option python-forward-sexp-function" (2dcb0f8f52); due to where it was
>> inserted in python.el, it is currently sorted in the python-flymake
>> customization group, which AFAICT is not what we want.
>
> Thanks; applied to Emacs 29.

Thanks!

I know we don't want to shake up the release branch too much, but this
user option has just been added for Emacs 28; wouldn't it make sense to
fix the customization group there too?

Message #16 received at 51807 <at> debbugs.gnu.org (full text, mbox):

From: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
To: 51807 <at> debbugs.gnu.org
Subject: Re: bug#51807: [PATCH] Fix customization group of
 python-forward-sexp-function
Date: Sun, 14 Nov 2021 17:55:36 +0100

found 51807 28.0.60
thanks

Kévin Le Gouguec <kevin.legouguec <at> gmail.com> writes:

> Tags: patch
>
> Version: 28.0.60

(
    Not sure why Debbugs did not seem to recognize this Version
    pseudo-header.

    For some reason I went with submit-emacs-patch instead of
    report-emacs-bug ("because I had a patch", I guess); the former does
    not add the version to the subject, so I figured I would use a
    pseudo-header; and then submit-emacs-patch's lambda in
    message-send-hook inserted the Tags pseudo-header as well as the
    extra blank line, which maybe is the issue?

    🤷

    Hopefully fixed this blunder by bcc'ing control <at> debbugs.gnu.org with
    this message.
)

Message #21 received at 51807 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
Cc: 51807 <at> debbugs.gnu.org
Subject: Re: bug#51807: [PATCH] Fix customization group of
 python-forward-sexp-function
Date: Sun, 14 Nov 2021 18:52:11 +0100

Kévin Le Gouguec <kevin.legouguec <at> gmail.com> writes:

> I know we don't want to shake up the release branch too much, but this
> user option has just been added for Emacs 28; wouldn't it make sense to
> fix the customization group there too?

Even though the potential for breakage is very small, I'd rather leave
it as is in emacs-28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.