GNU bug report logs - #51838
[PATCH 00/11] guix: node-build-system: Support compiling add-ons with node-gyp.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Philip McGrath <philip@HIDDEN>; Keywords: patch; dated Sun, 14 Nov 2021 12:43:01 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 2 Dec 2021 21:18:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Dec 02 16:18:13 2021
Received: from localhost ([127.0.0.1]:49459 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mstT3-00047U-5H
	for submit <at> debbugs.gnu.org; Thu, 02 Dec 2021 16:18:13 -0500
Received: from mail-qv1-f51.google.com ([209.85.219.51]:41925)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1mstSy-000479-5u
 for 51838 <at> debbugs.gnu.org; Thu, 02 Dec 2021 16:18:11 -0500
Received: by mail-qv1-f51.google.com with SMTP id m17so799582qvx.8
 for <51838 <at> debbugs.gnu.org>; Thu, 02 Dec 2021 13:18:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=message-id:date:mime-version:user-agent:subject:content-language:to
 :cc:references:from:in-reply-to:content-transfer-encoding;
 bh=ZCvym2FkD/kbTY+dCBJ8PFsE5pcXkg050AwuiraxPu4=;
 b=LqEDwf6HRwQVysjAd7saRPKhoOtYCKjcGCziIVnpqIt2VjxIAylyLWtvyvP+wH/5D9
 mDH8138LU/cVH9McPiGUM8SZrkBIJfBZdqC0haOQyBYNHyWPXTgCgO/rXr0uArrskDoX
 PHWPLcdubt7fqus7mmhweHGQLeV/SVAc5YApaGXgWCHBjxhBQPwG8MjsRvdZRJfwDne1
 2IXRT4ZTQTcjbWsErsSU797tfufmYXnWHXQ6VikRXIWUZDz4K7020WHqJERNqt9mXbbP
 /48as3U2DzXyiZneU+QIO1/ctDxBycPWTZeio19KHGbziDJK2dIWJpXTIeGT/Sdn2UCC
 qoYg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
 :content-language:to:cc:references:from:in-reply-to
 :content-transfer-encoding;
 bh=ZCvym2FkD/kbTY+dCBJ8PFsE5pcXkg050AwuiraxPu4=;
 b=zE7ozGbDjP8tGow8MWT1LZ0s/qTS0D52unMkQilOyOAjSDPxxkFOaTbArhpQFykbS2
 qtrll2+xC7xpmNr6xuGpqiSP9Ioouks1/3OW5idLjM/y7+6MicKRj82k4W+3c8cxJsxd
 Rb+zIEyXgIrFm47LBy8kkoA1t6diVijOBJMKtrOkhZg8H2jYzHP3y5fQPPdDnYoZqA95
 50df6XZ4NQrxb/TwQsPc4wEuaS8+srYZ9K7RQ3zCiQh2S0KNjE6kGJpRmYpSh75vONFc
 466k30Nk9wBzvqAuAxEBADPg+uaOzNEhpwF+/IIDycjCCYAjHQIJKufJA8Wg4i+l8qBY
 wwBg==
X-Gm-Message-State: AOAM5317p7RouWHvLAJtiPYarW0yOG1VZGsvp4Sb5dCvYKTqr+aguylc
 DI3Mp5Hh6CHn20oeX1zVUn7lgA==
X-Google-Smtp-Source: ABdhPJw3hCLnBzjB05zT9LARhSuTQlLH/3742/Dds7KoJ3Wsv7On5rG7KrCNc5IXerqo06lkIxixUg==
X-Received: by 2002:a0c:f8cc:: with SMTP id h12mr15856634qvo.122.1638479882615; 
 Thu, 02 Dec 2021 13:18:02 -0800 (PST)
Received: from [192.168.45.36] (c-73-125-89-242.hsd1.fl.comcast.net.
 [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id g19sm762345qtg.82.2021.12.02.13.18.02
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 02 Dec 2021 13:18:02 -0800 (PST)
Message-ID: <ade747ac-725f-81c4-d65e-c7c6fdfd2adb@HIDDEN>
Date: Thu, 2 Dec 2021 16:18:01 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.1
Subject: Re: bug#51838: [PATCH 00/11] guix: node-build-system: Support
 compiling add-ons with node-gyp.
Content-Language: en-US
To: Timothy Sample <samplet@HIDDEN>, Jelle Licht <jlicht@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
 <20211120043406.952350-10-philip@HIDDEN> <86tug39lps.fsf@HIDDEN>
 <87pmqkm5u1.fsf_-_@HIDDEN>
From: Philip McGrath <philip@HIDDEN>
In-Reply-To: <87pmqkm5u1.fsf_-_@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.6 (/)
X-Debbugs-Envelope-To: 51838
Cc: 51838 <at> debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.4 (/)

On 11/28/21 14:35, Timothy Sample wrote:
> Jelle Licht <jlicht@HIDDEN> writes:
>>  From what I have seen package-lock.json offers us no benefits (because
>> we track exact dependency information via the guix store) and can (as
>> you have seen) prevent builds from working. My 2c: always remove it in a
>> phase in the build system.
> 
> I’m inclined to agree with Jelle and Liliana.  I can’t imagine a
> situation in which we would want the lock files.  We could be wrong, but
> we can always adjust the build system later if something surprising
> happens (e.g., ‘#:keep-lock-file?’ or whatever).

This makes sense to me. Should we also delete "yarn.lock" (respected as 
of npm v7)[1] and "npm-shrinkwrap.json"[2]? It seems like the same 
reasons probably apply. We might want to handle 
"node_modules/.package-lock.json"[3], too, but that seems less likely to 
exist.

-Philip

[1]: 
https://blog.npmjs.org/post/621733939456933888/npm-v7-series-why-keep-package-lockjson.html
[2]: 
https://docs.npmjs.com/cli/v8/configuring-npm/package-lock-json#package-lockjson-vs-npm-shrinkwrapjson
[3]: 
https://docs.npmjs.com/cli/v8/configuring-npm/package-lock-json#package-lockjson-vs-npm-shrinkwrapjson




Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 28 Nov 2021 19:59:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 28 14:59:42 2021
Received: from localhost ([127.0.0.1]:36395 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mrQKs-0002eW-9C
	for submit <at> debbugs.gnu.org; Sun, 28 Nov 2021 14:59:42 -0500
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:51773)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <samplet@HIDDEN>) id 1mrQKq-0002eG-6R
 for 51838 <at> debbugs.gnu.org; Sun, 28 Nov 2021 14:59:40 -0500
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.nyi.internal (Postfix) with ESMTP id C00A25C00AE;
 Sun, 28 Nov 2021 14:59:34 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute5.internal (MEProxy); Sun, 28 Nov 2021 14:59:34 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=0DIN/f9osEv9HSArYNlyI1uIeawvVxWOh0faRvpiG
 fU=; b=YQ+sh7adHCjtsfJDlp0H/IdN8anpPXzlYsxotGlRWZwhlfbiyF4homIIp
 A+/SHYbyaUs5lABr69KxCI4ihjbsxgIKYzR8r+HLnKpQuRFVVUb4O1nBrUN5szcK
 q2L2P+1mIaeMIy7PfZrQVYcxbYFkgdqaU3a5/jIgG/JRuZHmygwjp1ik6MiXcKVM
 AEYSwsz9hE/LXr7Za6+BESRpmQ3qf/LkOoFXydju3qECIsb8E9zt0euvDbbwZxmV
 CL3+7sBpfBGE8XJOKMiME6KU6uBvGtSIWc//YG1Sxv6yfPIdWcFS927BPycdxJQo
 fHrT09zLA/ljJwzZ3U0Bx0VWJs1VQ==
X-ME-Sender: <xms:pt-jYVczLsRB2dwkftnb944RnG_mA_LEmWSabZ9wbgWm3GgZ37i6gA>
 <xme:pt-jYTMi9heOFTnBeI8xDvJVS3YMH7H37k1wgxxVVNEA4SobWVy4rAWI30JTx3mMx
 Zv-IkfyFBgmEeauZQ>
X-ME-Received: <xmr:pt-jYei56g7V_XWW-EDyc57u5n-HY9h9OAZ-VqvNax4305kB89xsS0hLsCggFp1e6pKsqiqMGWM2u8vwEracFA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrheeigddufeefucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufhfffgjkfgfgggtgfesthhqredttderjeenucfhrhhomhepvfhimhho
 thhhhicuufgrmhhplhgvuceoshgrmhhplhgvthesnhhghihrohdrtghomheqnecuggftrf
 grthhtvghrnhepvdelvefhheegudevjedvfedtveeileffveehveejgefgteetteejteel
 tdefueevnecuffhomhgrihhnpehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd
 enucfrrghrrghmpehmrghilhhfrhhomhepshgrmhhplhgvthesnhhghihrohdrtghomh
X-ME-Proxy: <xmx:pt-jYe8DuxNHi1PiFE0gTd476s6UlxTdeJU-XSjNhHK3tDUdzb-_Vw>
 <xmx:pt-jYRsrwYojQtR-yzm-1AT_HABBcvWjc7GkClrnQ5QLFPBRRXldgw>
 <xmx:pt-jYdE4xEgTU9-OwNZ6HwpgDPG8JFeqiaEvNa6WRgUMH1Wo3MCiUg>
 <xmx:pt-jYa5gXpko30kTLewv7Tm8FdhwMc7NkSQZ5HVGKMJS4uzoW6e2uQ>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
 28 Nov 2021 14:59:34 -0500 (EST)
From: Timothy Sample <samplet@HIDDEN>
To: Pierre Langlois <pierre.langlois@HIDDEN>
Subject: Re: bug#51838: [PATCH 00/11] guix: node-build-system: Support
 compiling add-ons with node-gyp.
References: <20211114125830.45427-1-philip@HIDDEN>
 <20211114130409.49241-1-philip@HIDDEN>
 <20211114130409.49241-2-philip@HIDDEN>
 <48018e12484d19466d9c6f253a8d7ebeae93e947.camel@HIDDEN>
 <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <87tug6bnen.fsf@HIDDEN> <87czmqk29d.fsf@HIDDEN>
Date: Sun, 28 Nov 2021 14:59:33 -0500
In-Reply-To: <87czmqk29d.fsf@HIDDEN> (Pierre Langlois's message of "Tue, 23
 Nov 2021 20:54:26 +0000")
Message-ID: <87ilwcm4pm.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 51838
Cc: 51838 <at> debbugs.gnu.org, Philip McGrath <philip@HIDDEN>,
 Liliana Marie Prikler <liliana.prikler@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hello,

Pierre Langlois <pierre.langlois@HIDDEN> writes:

> Hi Timothy,
>
> Timothy Sample <samplet@HIDDEN> writes:
>
>> More importantly, is the general plan that we merge these changes,
>> and then Pierre rebases their Tree-sitter changes on top these?
>>
>> Pierre, maybe you could weigh in here?
>
> The overall approach looks good to me, it's better than what I
> originally proposed for sure :-).  That being said, I'm not very
> familiar with the Node.js ecosystem so I don't know if it's necessarily
> the right way, but I suspect the correct way for node isn't very Guix-y
> so I'm not too worried about that.

The whole Node.js bundles NPM, which bundles node-gyp, which bundles a
fork of GYP [1] is not very Guix-y at all, no.  :/  This is one of those
problems (like bootstrapping GCC) that will take years of incremental
improvements and side projects and all that.

[1] Not to get too off topic, but isn=E2=80=99t =E2=80=9Cgyp=E2=80=9D a slu=
r?  How did Google
ever call something that?

> It's on my TODO list to take another look at the patches as well :-),
> then yes, I'm planning on rebasing my tree-sitter series on top.

Excellent!

>> Sorry if I missed something.  I assume everything is OK, but I want to
>> be sure before I start digging into the details of the patches =E2=80=93
>> especially those first few more complicated ones.  :)
>
> Thanks for taking a look!

I have an idea to simplify the patch series a bit: if we can answer my
question here <https://issues.guix.gnu.org/51838#57> and come to a
conclusion about deleting lock files
<https://issues.guix.gnu.org/51838#58>, I could merge the
=E2=80=98#:absent-dependencies=E2=80=99 part of the patch series.  I think =
this might
make future re-rolls easier and help rein in the scope a bit.

Thoughts?  Philip?

Thanks!


-- Tim




Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 28 Nov 2021 19:35:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 28 14:35:26 2021
Received: from localhost ([127.0.0.1]:36379 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mrPxO-00023z-E5
	for submit <at> debbugs.gnu.org; Sun, 28 Nov 2021 14:35:26 -0500
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:34585)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <samplet@HIDDEN>) id 1mrPxN-00023m-At
 for 51838 <at> debbugs.gnu.org; Sun, 28 Nov 2021 14:35:25 -0500
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id D12345C003B;
 Sun, 28 Nov 2021 14:35:19 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Sun, 28 Nov 2021 14:35:19 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=qBg2r6P6LM409FwY+KLvxrRWFYNRixQf8GIJX024n
 OQ=; b=KUff2xpcSp9lQsuk6ods83y3lJ2zDyNjTI9zpiww4rxGBW9d5/uqrxgUC
 bEmHtZkzVxdk3hAtDjtJVGDXIFiG84Bja5S5/E8c5BiP0vEbM0Cii6+vPbT8RDmJ
 M/HzPhDMxd2X/ca6DA10Zs8yHw9QYNiIucOaVkI5cSWUk+6heqhRaCIxf0SP57Fj
 zuK8ZpKiPKFAbHvpqbpVdhGFBZwj+BATxDz3KfnBre1rBTNxginjioPxZFKgn7DO
 3sQVt6fEeITz8tCSeqyBsAnVDltmgJgJ9GXF7nnMIYFwQSRtLyYuRE9ejOXRJgcw
 7pAeErWHqQTROdjYM4dLJaF6ST2dw==
X-ME-Sender: <xms:99mjYepd9CS5sLjeOg-CwPw4FuNiOxBRAI3oFqjxEiH6nCi_4my-SA>
 <xme:99mjYcpUGhDUzofgZZe8TCoJFMkuHUJIKCF3vfgAHDxlagwGtucX9hhURu7jjVVAY
 z0I9ppvT_2yuJxQ_A>
X-ME-Received: <xmr:99mjYTPu-9AjGaCMz2onoKsKeLjTNpX8j0ioO7nLj4g_UQ6LbYC1OsNt2zuBWJo2pz5LD7n6APnefct9pNm5Dg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrheeigdduvdekucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufhfffgjkfgfgggtgfesthhqredttderjeenucfhrhhomhepvfhimhho
 thhhhicuufgrmhhplhgvuceoshgrmhhplhgvthesnhhghihrohdrtghomheqnecuggftrf
 grthhtvghrnhepieduuefhgeegleelveehgedugfeuhfeikefftdevieelgfelhfdvtdfg
 ieehtefgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh
 epshgrmhhplhgvthesnhhghihrohdrtghomh
X-ME-Proxy: <xmx:99mjYd6pLWlL6N2Sh0p01ageAtTaCmEH1ACPMf5Bh-_zgmUhX3JyIg>
 <xmx:99mjYd6L-icQoG7pvBjM1U_hz-721LeE2R6So3--KHQmgDAJbF2s4Q>
 <xmx:99mjYdid5RSt_4UW6UC16aEKF50SXXkNNBV0PRqNpNa7pzxOydaWtQ>
 <xmx:99mjYdH2C5rE_eakCI9hrGA5qQmZSNaaygqpX84W6lwgh4yO8Eiz9Q>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
 28 Nov 2021 14:35:19 -0500 (EST)
From: Timothy Sample <samplet@HIDDEN>
To: Jelle Licht <jlicht@HIDDEN>
Subject: Re: bug#51838: [PATCH 00/11] guix: node-build-system: Support
 compiling add-ons with node-gyp.
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
 <20211120043406.952350-10-philip@HIDDEN>
 <86tug39lps.fsf@HIDDEN>
Date: Sun, 28 Nov 2021 14:35:18 -0500
In-Reply-To: <86tug39lps.fsf@HIDDEN> (Jelle Licht's message of "Tue, 23 Nov
 2021 12:04:47 +0100")
Message-ID: <87pmqkm5u1.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 51838
Cc: 51838 <at> debbugs.gnu.org, Philip McGrath <philip@HIDDEN>,
 Liliana Marie Prikler <liliana.prikler@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hello!

Jelle Licht <jlicht@HIDDEN> writes:

> Philip McGrath <philip@HIDDEN> writes:
>
>> Add a new phase `#:delete-package-lock` to remove the
>> problematic "package-lock.json".
>
> package-lock.json lists exact versions _and integrity hashes_; since it
> seems unlikely that after node-build-system's finaggling we end up with
> an identical hash, we will always have a mismatch and fetch 'proper'
> sources online accordingly. As far as npm + package-lock.json are
> concerned, we don't have them properly installed.
>
> From what I have seen package-lock.json offers us no benefits (because
> we track exact dependency information via the guix store) and can (as
> you have seen) prevent builds from working. My 2c: always remove it in a
> phase in the build system.

I=E2=80=99m inclined to agree with Jelle and Liliana.  I can=E2=80=99t imag=
ine a
situation in which we would want the lock files.  We could be wrong, but
we can always adjust the build system later if something surprising
happens (e.g., =E2=80=98#:keep-lock-file?=E2=80=99 or whatever).


-- Tim




Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 28 Nov 2021 19:28:07 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 28 14:28:07 2021
Received: from localhost ([127.0.0.1]:36373 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mrPqJ-0001sb-Jk
	for submit <at> debbugs.gnu.org; Sun, 28 Nov 2021 14:28:07 -0500
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:37179)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <samplet@HIDDEN>) id 1mrPqG-0001rr-Gx
 for 51838 <at> debbugs.gnu.org; Sun, 28 Nov 2021 14:28:05 -0500
Received: from compute6.internal (compute6.nyi.internal [10.202.2.46])
 by mailout.nyi.internal (Postfix) with ESMTP id 0159B5C013E;
 Sun, 28 Nov 2021 14:27:58 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute6.internal (MEProxy); Sun, 28 Nov 2021 14:27:58 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=gbMgWU/TQTRjWYFIWByj2K5buZGSp9UB9RihvXRJ5
 9M=; b=S28OYgey13Wu80/dQXVyzfHD/fdrPmrYMKTph6Nwowjd88wq8cPjdnW10
 XqUW8pP1OyGJ7+9H3lssC3GqpSLoYDFjdS29vLCquicYWKrM0S6nePALyjST6MXj
 NR8Gk4em0UaWCO+Pvm41Lq8n8sHRZZPcaaN8J3dCrlDPfUuaUy/6fYqeb6JBMmx8
 diTb+mWgwt9EcDozCjsukHS6sQXrF2/qaEqjXnQvzumuMRggjTxlcImxh6SJIBe7
 vVQEB6Kvtwo0do6Fa8rsjmeFvTbiQjUqDNOI6y+FWAwgVYsteW5r3Ch0T/p4QrVq
 p3DQd9rO4CS7NH1R2ZHWWYC+/sCGQ==
X-ME-Sender: <xms:PdijYWbdg5ClmqlQd52FCvorsUUW-X7aBBU9wdUbO9q3Q2IMWpPOOw>
 <xme:PdijYZYEDdfT84Jf4V2csGR9jOHe3q639VrXaZcLAGSdwopGGkytI4nj7BxBjCfcd
 Hak2J-UW6EHnKMeJA>
X-ME-Received: <xmr:PdijYQ8QUogt0DD3Ry0YDkQ8O2DNQQxGUR3jdUkiZoBtLOcArlHIuFFkVJqB7jKjEj2alQ3sE2ZrQmrwgtuG0Q>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrheeigdduvdeiucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufhfffgjkfgfgggtgfesthhqredttderjeenucfhrhhomhepvfhimhho
 thhhhicuufgrmhhplhgvuceoshgrmhhplhgvthesnhhghihrohdrtghomheqnecuggftrf
 grthhtvghrnhepieduuefhgeegleelveehgedugfeuhfeikefftdevieelgfelhfdvtdfg
 ieehtefgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh
 epshgrmhhplhgvthesnhhghihrohdrtghomh
X-ME-Proxy: <xmx:PdijYYq8Fdr2x7TVUnAnaNG1nHyDmsscqu3cfpUV0JIFyu0r-F8lDQ>
 <xmx:PdijYRoHIRo41nsUfPQP-VNQlM6z-xJanFNNRHRI30HSPThdMoru9g>
 <xmx:PdijYWT-T2U61oGHPk7NYp6cPUoTIkDssbUu4A9lX7EbIOprTMVAVA>
 <xmx:PdijYSAPMK7VAqcliIxEY8qBbycZNLlhf10WqDTZuFioVVdGT2Nrnw>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
 28 Nov 2021 14:27:57 -0500 (EST)
From: Timothy Sample <samplet@HIDDEN>
To: Philip McGrath <philip@HIDDEN>
Subject: Re: bug#51838: [PATCH 00/11] guix: node-build-system: Support
 compiling add-ons with node-gyp.
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
 <20211120043406.952350-5-philip@HIDDEN>
Date: Sun, 28 Nov 2021 14:27:56 -0500
In-Reply-To: <20211120043406.952350-5-philip@HIDDEN> (Philip
 McGrath's message of "Fri, 19 Nov 2021 23:33:45 -0500")
Message-ID: <87tufwm66b.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 51838
Cc: 51838 <at> debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hi Philip,

Philip McGrath <philip@HIDDEN> writes:

> -  (define (resolve-dependencies package-meta meta-key)
> -    (fold (lambda (key+value acc)
> -            (match key+value
> -              ('@ acc)
> -              ((key . value) (acons key (hash-ref index key value) acc))=
))
> +  (define (resolve-dependencies meta-alist meta-key)
> +    (match (assoc-ref meta-alist meta-key)
> +      (#f
> +       '())
> +      (('@ . orig-deps)
> +       (fold (match-lambda*
> +               (('@ acc)
> +                acc)
> +                (((key . value) acc)
> +                 (if (member key absent-dependencies)
> +                     acc
> +                     (acons key (hash-ref index key value) acc))))
>            '()
> -          (or (assoc-ref package-meta meta-key) '())))
> +          orig-deps))))

There=E2=80=99s a lot of refactoring going here in addition to change at ha=
nd.
To me, it needlessly obscures the actual change (which is just the check
for membership in 'absent-dependencies', AFAICS).

>    (with-atomic-file-replacement "package.json"
>      (lambda (in out)
> -      (let ((package-meta (read-json in)))
> -        (assoc-set! package-meta "dependencies"
> -                    (append
> -                     '(@)
> -                     (resolve-dependencies package-meta "dependencies")
> -                     (resolve-dependencies package-meta "peerDependencie=
s")))
> -        (assoc-set! package-meta "devDependencies"
> -                    (append
> -                     '(@)
> -                     (resolve-dependencies package-meta "devDependencies=
")))
> +      ;; It is unsafe to rely on 'assoc-set!' to update an
> +      ;; existing assosciation list variable:
> +      ;; see 'info "(guile)Adding or Setting Alist Entries"'.

Good catch!

> +      (let* ((package-meta (read-json in))
> +             (alist (match package-meta
> +                      ((@ . alist) alist)))

Why do we have to unwrap (and then re-wrap later on) the alist?  It
would be nice to explain that in the changelog.  Maybe it=E2=80=99s just me=
, but
I can=E2=80=99t figure it out!  :)

Thanks!


-- Tim




Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 23 Nov 2021 21:09:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 23 16:09:55 2021
Received: from localhost ([127.0.0.1]:52397 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mpd35-00067Q-CL
	for submit <at> debbugs.gnu.org; Tue, 23 Nov 2021 16:09:55 -0500
Received: from mout.gmx.net ([212.227.17.20]:41233)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <pierre.langlois@HIDDEN>) id 1mpd31-000677-KP
 for 51838 <at> debbugs.gnu.org; Tue, 23 Nov 2021 16:09:53 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1637701779;
 bh=yOPHf0Dkn7OLFqAaFEaiZZ90ybOW5WFtI0oOUu0e/n0=;
 h=X-UI-Sender-Class:References:From:To:Cc:Subject:Date:In-reply-to;
 b=Y5ubfdoM0M5OqVtWgC5JmAfieOVQnEz0/4suZXZ9N47UqKUB8GrmYMmrbqbV99Z9c
 XHgnBQ44F8YKaLg6JbMaj/RS7/9DRIBDHkcq5MvGEIcaVP7vjWN6RJjQkMDYsOW8mr
 6ydZcJQLQ+LAlpb3i1MFkPK8qD3hLCUv8/fJXstU=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from labiere ([82.69.64.142]) by mail.gmx.net (mrgmx105
 [212.227.17.174]) with ESMTPSA (Nemesis) id 1Mxm3K-1mQvgj0K2I-00zDD2; Tue, 23
 Nov 2021 22:09:39 +0100
References: <20211114125830.45427-1-philip@HIDDEN>
 <20211114130409.49241-1-philip@HIDDEN>
 <20211114130409.49241-2-philip@HIDDEN>
 <48018e12484d19466d9c6f253a8d7ebeae93e947.camel@HIDDEN>
 <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <87tug6bnen.fsf@HIDDEN>
User-agent: mu4e 1.6.10; emacs 27.2
From: Pierre Langlois <pierre.langlois@HIDDEN>
To: Timothy Sample <samplet@HIDDEN>
Subject: Re: bug#51838: [PATCH 00/11] guix: node-build-system: Support
 compiling add-ons with node-gyp.
Date: Tue, 23 Nov 2021 20:54:26 +0000
In-reply-to: <87tug6bnen.fsf@HIDDEN>
Message-ID: <87czmqk29d.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Provags-ID: V03:K1:jHm32sgjaI+KguHwQBpbxAGPYWGnZEQDhuAGfzT43xZQP11p95a
 GOVvh0q7cL4IN/6rUvO8FWk9M/PYdJOGQQSYgk0TfeBeXo5apJOHgy+J1voTPT5sN1ugS+f
 5N/qinX89fWGxp9TCdqHNACivGwLcPcQ52W7Q4Ki5q46tX6lnd65Wb40yPkWW37XmhL01pA
 cnGYztzcOCdgt4tsm+jjg==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:Wp8yutE+c7I=:Q+SOXaP0rdK0l4RuPi7Rss
 eeFwBwpMbqa6AOCBrFLeWw9CNEqqg0xtIWunbvO4hZgmqWCKTg6fRppKsRgB9qd5Zhw4qehoi
 Py4XJnh7Yz2lXS6//idwNSZI1KKesRYvs04fkS9VqmyJUxtXoxmBNVmWP5qik4w4Y+L95hVIb
 vWkM0XIB06D0T9edoAKqKqxtE7Xba0iiHYNf8i/XmrSb5ZehCnir2XwE+XH5zOVlT6RokyR8m
 m1iBNwqZO6PCkAwrzloKwMxsNTDhGwR1blsg4qENOWmU6Hfxi3ppv/qG5bH2kryelBZkNYOg5
 2qXDbfaNvouROpizjkjtJI9DkvRrRpBj2XL8CbqL6bN0AwtJza9V2/2trVTzFikqN7aLNUHVL
 NbMZ+k5Per28bddOGxhw/uThAC7C05gNx9DtSqQgzapAWLkHaDPj360sap4eR/U3DoulOgiy5
 i0gKdtcj3li+6CDJeeTiH4LIGSLqmMydi74g9Dzje5Rc2Q0dXaEzlhDCpg2rU5lkobfNexVOp
 YpJw6e43460xItPR29CUa8u0y1vUoU/oTLoQvbCmJUIj92oDGfaS0+sZf5vW3pgBLS+MWEelc
 tLQiQPugRH3WVun4nK0QOVU3WZDUAF8ce+EVObDFnOB3FdkAqSxU2sluQeSv/lvUsra9F+ZD2
 1oN+X/ePfjkTO0DuhTIT07mPUeYtLj7QwWKd3JAXRMEtVhW38uXNvE/zlhfhHX8s7QZxU1ZeR
 C9efUGjLO2HIu9jMxa2Nf7mEC7YuUL+1pB5pnYsVaAVRTAV95eXl3iSPo5jXgNq3+XAHFwt+7
 llT9yvA/7LMybomD/pgW3PUD5FOLA9bDpRjIrXd/53MGhcWm+CUiJS7bwIsQAhd5yR7kcI1cY
 yFXhXVQDUc826eEMO5IoFvyhmGUwDnC+2dlV1VzvxoEqvhxLUz3Da0rO9na76jV7x0rjnFMWI
 PKbUhjyVdLFSQHpx/+Krh4pU70tp6kfsr0sKxIQTnXdIpCB4lMuRSLbOzTtgF9TwUZv/7UePe
 M1WgOoOTYuQv8+wCIYnEvX1IZZmXtMecYhKN+oxF3Qqs9pSxblz13r5hMyNcda/V5bp1z90Tr
 xS7EPAXMxNvWU4=
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 51838
Cc: 51838 <at> debbugs.gnu.org, Pierre Langlois <pierre.langlois@HIDDEN>,
 Philip McGrath <philip@HIDDEN>,
 Liliana Marie Prikler <liliana.prikler@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi Timothy,

Timothy Sample <samplet@HIDDEN> writes:

> Hi Philip,
>
> There are some really valuable changes in here, thanks!  I would like to
> start understanding and reviewing the changes so that we can get some of
> this good stuff merged in.  However, I have one question that I couldn=E2=
=80=99t
> answer from reading here or at <https://issues.guix.gnu.org/49946>: is
> there an agreement between you and Pierre that these patches are the
> =E2=80=9Cright=E2=80=9D way to do native addons for Node.js.  More import=
antly, is the
> general plan that we merge these changes, and then Pierre rebases their
> Tree-sitter changes on top these?
>
> Pierre, maybe you could weigh in here?

The overall approach looks good to me, it's better than what I
originally proposed for sure :-).  That being said, I'm not very
familiar with the Node.js ecosystem so I don't know if it's necessarily
the right way, but I suspect the correct way for node isn't very Guix-y
so I'm not too worried about that.

It's on my TODO list to take another look at the patches as well :-),
then yes, I'm planning on rebasing my tree-sitter series on top.

> Sorry if I missed something.  I assume everything is OK, but I want to
> be sure before I start digging into the details of the patches =E2=80=93
> especially those first few more complicated ones.  :)

Thanks for taking a look!

Pierre

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAmGdWI4YHHBpZXJyZS5s
YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31UeigH/27lKcqCARHJuK4pZ6W1nT9M
Jn3dN6+VYNp2MZHlQ2OVQopytBCxMKuQoBnmakt9ifanZknzHWo1E5qOMuAJH16S
mV8/rmZphJTafMuq2ZVhE5iibt4ICgnDwtGi5s0jsl0Ku75I6AFImcC88NpXmkWC
PlesI3gG6IpSV5uMJ/Fk4ufCSzXA8V+zpTHmQo0fayplEVfLGYySdluLP3H3+LIV
4s+3L2zaIhl1jUNO1djieBOCXYHqXuBMEiDyNLqVGQqCRbW+CYb8odB0QfRPG544
pJSg04xhclJkhkfsbOX1+7UzsmWHB0kgHPJELEZnwzN0aCgh/YcXL8awHFUa/Jc=
=9JOK
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 23 Nov 2021 11:04:52 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 23 06:04:52 2021
Received: from localhost ([127.0.0.1]:50124 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mpTbY-00038e-HO
	for submit <at> debbugs.gnu.org; Tue, 23 Nov 2021 06:04:52 -0500
Received: from mail1.fsfe.org ([217.69.89.151]:43316)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jlicht@HIDDEN>) id 1mpTbW-00038V-Ns
 for 51838 <at> debbugs.gnu.org; Tue, 23 Nov 2021 06:04:51 -0500
From: Jelle Licht <jlicht@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fsfe.org; s=2021100501;
 t=1637665488;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=j60BIbJDK2epTa9wOXyv0+27FtnEnPK4dGFIEpdrjtI=;
 b=FoMbfGJ1miW37o7ZLqn6WrLNwFMEehRSPLyL3ew95fIs3nZzUTqpBmWJViTjQe/ns5WTxM
 3jrnUB0JE9l5UaMwZAagQK85wtLJHvffxA1kGwY5E1RFis4n1bLlSI9WjSCpS5Yiq30fLd
 ig+owB8NVj+C7GiHkFi8Xm17AXrVc1A=
To: Philip McGrath <philip@HIDDEN>, 51838 <at> debbugs.gnu.org
Subject: Re: [bug#51838] [PATCH v2 10/26] gnu:
 node-llparse-builder-bootstrap: Use #:absent-dependencies.
In-Reply-To: <20211120043406.952350-10-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
 <20211120043406.952350-10-philip@HIDDEN>
Date: Tue, 23 Nov 2021 12:04:47 +0100
Message-ID: <86tug39lps.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 51838
Cc: Liliana Marie Prikler <liliana.prikler@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hey Philip,

Philip McGrath <philip@HIDDEN> writes:

> gnu/packages/node.scm (node-llparse-builder-bootstrap)[arguments]: Add
> `#:absent-dependencies`. Stop deleting the `'configure` phase.
> Add a new phase `#:delete-package-lock` to remove the
> problematic "package-lock.json".
> ---
>  gnu/packages/node.scm | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
> index 98a51276e7..9d4903a8ca 100644
> --- a/gnu/packages/node.scm
> +++ b/gnu/packages/node.scm
> @@ -479,9 +479,21 @@ (define-public node-llparse-builder-bootstrap
>      (arguments
>       `(#:node ,node-bootstrap
>         #:tests? #f
> +       #:absent-dependencies
> +       `("@types/mocha"
> +         "@types/node"
> +         "mocha"
> +         "ts-node"
> +         "tslint"
> +         "typescript")
>         #:phases
>         (modify-phases %standard-phases
> -         (delete 'configure)
> +         (add-before 'configure 'remove-package-lock
> +           ;; Having package-lock.json seems to cause npm
> +           ;; to look for things on the internet in the configure phase,
> +           ;; even if we have them properly installed.

package-lock.json lists exact versions _and integrity hashes_; since it
seems unlikely that after node-build-system's finaggling we end up with
an identical hash, we will always have a mismatch and fetch 'proper'
sources online accordingly. As far as npm + package-lock.json are
concerned, we don't have them properly installed.

From what I have seen package-lock.json offers us no benefits (because
we track exact dependency information via the guix store) and can (as
you have seen) prevent builds from working. My 2c: always remove it in a
phase in the build system. It's simply a preference though, so your
please go with what you think is the right choice. You might want to
update the comment nonetheless so it's clear we know what's going on.

> +           (lambda args
> +             (delete-file-recursively "package-lock.json")))
>           (replace 'build
>             (lambda* (#:key inputs #:allow-other-keys)
>               (let ((esbuild (string-append (assoc-ref inputs "esbuild")
> -- 
> 2.32.0




Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 20:24:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 20 15:24:55 2021
Received: from localhost ([127.0.0.1]:43735 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moWut-0005yi-EF
	for submit <at> debbugs.gnu.org; Sat, 20 Nov 2021 15:24:55 -0500
Received: from mail-wr1-f65.google.com ([209.85.221.65]:40523)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liliana.prikler@HIDDEN>) id 1moWuq-0005yT-Pa
 for 51838 <at> debbugs.gnu.org; Sat, 20 Nov 2021 15:24:53 -0500
Received: by mail-wr1-f65.google.com with SMTP id r8so24526021wra.7
 for <51838 <at> debbugs.gnu.org>; Sat, 20 Nov 2021 12:24:52 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=message-id:subject:from:to:date:in-reply-to:references:user-agent
 :mime-version:content-transfer-encoding;
 bh=LMCl0VbOSdMz37jfugUvbbfC6nb8ZgdE89pH2x9C/BA=;
 b=Tk06Y9gKxBP3Me5tmKGPhmqI6/4V5EGbCQZNNfrd7TGRdlbWuS4tbRocrfECkszsC7
 Ihl7DNyRcA9qkM5r6inbHebMTToUfir4PeKYIbHokmBNUGId8ngVV8aSYbUHkK88cEUd
 /GZArcUYTc1//EwR7OHqsotyN+xusXPLyNJNMDzCAQnCw+UmCzAZAY1MPtAmMEt4lxUd
 F73XuUanLSekuHc0Y1CB9NvIuVB5ORQ+zjoo2yR3OwBWP0wdFRKy4N5gDsJbpiShOQsZ
 UWl4LoYIp+Mi6D+A1kDYgp2gYfWMYcEXdwlu/pH1Drr34E1Ny0Hc+RB6GhmA1lzohp+g
 U6gA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to
 :references:user-agent:mime-version:content-transfer-encoding;
 bh=LMCl0VbOSdMz37jfugUvbbfC6nb8ZgdE89pH2x9C/BA=;
 b=gxEXCwWGr70pSs/AWT5RHjplRuoxKm+0l+VUCxXdjw5HGXQ1q/0ihP5WQ8fREO7AOy
 Pb5UK4rezcSqOCtPKu8P3PIFSiedPZORqONil9AJDrmsSy+lwD3u3rlrHdYBDzv8pcb1
 1NJVWRR3iBD4wqdK3BdStjfZWzqANAfdDZl2kZwEepxmQQJV1RqwxM1XJtgrqbYKGxGr
 GEdpI+xFPOfiVTq33FeNbSozFtqBiqJ3SsZrVUYKteYrwXwpYxDXigu56yeyBiGKrYfO
 3CbTcip+gQ90mzi3nUyUkM/3gtYRCPtM+HQrJOmZ27KpC1pPDNusVkxl05uFzsxWsyog
 fQbQ==
X-Gm-Message-State: AOAM531t1A0JFCAN1xyoT2PYgtaPvwggNfEr/gWM1qkrZwpP2P9zU/bL
 CLKPYvFU53Dcai/ZFt2yma4=
X-Google-Smtp-Source: ABdhPJz3A+3n4RrV2iQZLuqtmeTAtVPR2iBoiabz2YxgEKDsLk68RYTIXgh6nXxKDzIo51daHkIVdg==
X-Received: by 2002:adf:efc6:: with SMTP id i6mr21655526wrp.428.1637439886793; 
 Sat, 20 Nov 2021 12:24:46 -0800 (PST)
Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
 [85.127.52.93])
 by smtp.gmail.com with ESMTPSA id d7sm3566513wrw.87.2021.11.20.12.24.46
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 20 Nov 2021 12:24:46 -0800 (PST)
Message-ID: <62e2afb290ae88cc8bb42ccc26683f9d9435bbf5.camel@HIDDEN>
Subject: Re: [bug#51838] [PATCH v2 05/26] guix: node-build-system: Add
 #:absent-dependencies argument.
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
To: Philip McGrath <philip@HIDDEN>, 51838 <at> debbugs.gnu.org
Date: Sat, 20 Nov 2021 21:24:44 +0100
In-Reply-To: <37768a63-5a4a-b604-2542-e8890fd68a16@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
 <20211120043406.952350-5-philip@HIDDEN>
 <8c07272b588fc059f3c445fe1f33c63cce8f31f1.camel@HIDDEN>
 <37768a63-5a4a-b604-2542-e8890fd68a16@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.2 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi,

Am Samstag, den 20.11.2021, 12:04 -0500 schrieb Philip McGrath:
> To the best of my understanding, npm doesn't inspect the js files at
> all by default, so no. (A package.json file might define a build
> script that does more checks.) I think a missing and undeclared
> dependency manifests itself as a runtime error when the require()
> function is evaluated.
Sheesh.

> > In the resolve-dependencies subprocedure, we could check whether we
> > have a matching input somewhere and only include the dependency if
> > we do.  WDYT?
> 
> I thought about this, but it seems to me there are two problems.
> First, I'm very unsure about this, but, in the last few days, I've
> gotten the impression there may be some "package.json" packages that
> don't correspond directly to Guix packages. I don't really understand
> how that works, but I think it may have something to do with npm
> packages that can run either on Node.js or on the web and need to use
> some functionality that's part of the Node.js core but not the web
> platform (or vice versa?). I could be wrong about that, but I've
> tried, especially in v2, to only have the build-side code do things
> I'm confident are correct in all cases.
What does "not directly correspond to Guix packages" mean here?  At the
very least Node must have a way of finding them, probably somewhere in
lib/, no?

While I did say we may want to rewrite these dependencies in
‘configure’, perhaps we can find a middle ground in which we only do so
when a given argument is there.  ant-build-system does that for
instance, so as to cope with packages that actually have no ant build
spec.  WDYT?

> The other issue is that deleting packages with no matching input by 
> default would replicate some of the drawbacks of the current
> `(delete 'configure)` approach. I think it's better to have an
> explicit list of dependencies that Guix is deleting. If eventually we
> package all of the missing dependencies for Guix, it would be much
> easier to find the packages that ought to use it. And, in the highly
> dynamic JavaScript world, I'm reluctant to give up one of the few
> static checks we have. If a missing package that really was required
> were automatically deleted from "package.json", it seems the failure
> mode would by a mysterious runtime error, potentially many steps down
> a dependency chain.
I get where you're coming from, but OTOH if you were to change parts of
the package to suit your own needs – like adding or omitting some
inputs, you now have two places to change, and they're in a tricky
relationship with another.  I think this is setting up some very error-
prone boilerplate.

I hope that in most cases the test suite will cover the important use
cases, but that's not always possible (e.g. with flaky tests,
networking, missing test inputs...)  Furthermore, for better or for
worse, stack traces did become the gold standard of debugging long ago,
so even packages missing "deep down" would probably soon be dug out if
they lead to hard errors.  Soft errors in Javascript though...





Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 20:09:11 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 20 15:09:11 2021
Received: from localhost ([127.0.0.1]:43729 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moWfe-0005LZ-SZ
	for submit <at> debbugs.gnu.org; Sat, 20 Nov 2021 15:09:11 -0500
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:39865)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <samplet@HIDDEN>) id 1moWfU-0005Ke-SZ
 for 51838 <at> debbugs.gnu.org; Sat, 20 Nov 2021 15:09:01 -0500
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.nyi.internal (Postfix) with ESMTP id D2D095C00DA;
 Sat, 20 Nov 2021 15:08:55 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute5.internal (MEProxy); Sat, 20 Nov 2021 15:08:55 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-type:date:from:message-id
 :mime-version:references:subject:to:x-me-proxy:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=5pi7ZfFUtz3Ntyyr0
 qNDE0DYvEuBsFhXRhIwcgItI4U=; b=HvLMgjnh/Qo1h37Ynf5U3CuzftkfY53up
 hMFVPahhRD8U7pod2AORBIv3OKeYkigPZoXOSsKPjz0XoNYzwfSxxE4wFYY81oNp
 jnYCDxHOVnyrnh50K7P63C6TzEUxPCWQqEhEsUX53kizOjpAPvW+gTa3A41U21lU
 ZZihk9o7WrTdiRtNliI6TmXCbDkN+/5HtOeoZpVXdiJLHkpYA8Di8q7FJIa/v9Fb
 yqWzwAXVwJp/0Ni+6W/JyUddIJ12hP6Bx22m+fv5R3Oo3acnOrlbYTJQQW8L+Yhr
 dz7D/mcUQG5bmX/HM/BUGhMuhU84cBLbKGGymYweCry8wHwKCb2Dg==
X-ME-Sender: <xms:11WZYQzB0bprYDGjY2D2d0ZXCbTALa3XarMf_jodbPA7J2fqOps3iA>
 <xme:11WZYUQWxqWR79KOfF85uelNxhXHjrfmP5QViMBeWVWMPN2mA4EBdcqKhe5aWj0t_
 7oZQ1nlW3C3PhWOkA>
X-ME-Received: <xmr:11WZYSXraAOAxYV5dLFlXXVjypVCVMsb9E7zy7ifFgGIyknd5T_b5X09xyQtVE5qE5u2QgMQ5g4xsbUv36qHaA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrgedtgddufeefucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvuffffhfkfgggtgesthdtredttdertdenucfhrhhomhepvfhimhhothhh
 hicuufgrmhhplhgvuceoshgrmhhplhgvthesnhhghihrohdrtghomheqnecuggftrfgrth
 htvghrnheptdeigeegueegiedtvdfhudeiudeiledutddvffehgeekhfefheejtddvkeeg
 keevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsh
 grmhhplhgvthesnhhghihrohdrtghomh
X-ME-Proxy: <xmx:11WZYejI7te5X3ga6G4RQTGni4HJQgyAIqT-GwzqT-C9h0tLSBQilA>
 <xmx:11WZYSC_TxvlJylIzoLJS0HhEJuUjB58cnLyecXZiPm7oukq9YGFAw>
 <xmx:11WZYfK8EblyTiK0ar8UhUZRSdmYtRqdPSE66C3J1RMf1SZkDlxNWg>
 <xmx:11WZYT4Jb2EGTay87dPvQGfyCeQ5LuKsJI5FcreIjbHeBJjigzbh9Q>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat,
 20 Nov 2021 15:08:55 -0500 (EST)
From: Timothy Sample <samplet@HIDDEN>
To: Philip McGrath <philip@HIDDEN>
Subject: Re: [bug#51838] [PATCH v2 04/26] gnu: node: Add an npmrc file to
 set nodedir.
Date: Sat, 20 Nov 2021 12:38:06 -0500
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
 <20211120043406.952350-4-philip@HIDDEN>
Message-ID: <87czmubne1.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 51838
Cc: 51838 <at> debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hi!

Just a little typo:

Philip McGrath <philip@HIDDEN> writes:

> * gnu/packages/node.scm (node, node-lis)[arguments]: Add a phase

node-lis should be node-lts.


-- Tim




Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 20:09:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 20 15:09:10 2021
Received: from localhost ([127.0.0.1]:43723 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moWfP-0005Kd-R1
	for submit <at> debbugs.gnu.org; Sat, 20 Nov 2021 15:09:10 -0500
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:41169)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <samplet@HIDDEN>) id 1moWfO-0005KF-96
 for 51838 <at> debbugs.gnu.org; Sat, 20 Nov 2021 15:08:54 -0500
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.nyi.internal (Postfix) with ESMTP id 3FD795C00D5;
 Sat, 20 Nov 2021 15:08:49 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute4.internal (MEProxy); Sat, 20 Nov 2021 15:08:49 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:message-id:mime-version:references:subject:to
 :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
 fm1; bh=drjm6TKiBGlj07b5FfV83MEeAs3KmWlQq3uGaDqsKuI=; b=fWa/heri
 eXQQ4xe4rkiDkR5rIDf2QF/AMO5vCKN8U6ocQFOFIR1hBjYH79HhRlF2cq1Tbj+Y
 8epkXAFJrZ/Vsb5qRhbrdNn8r7xWsG3swdpnJ3XEIxIaM9bsksxtuJkFnwsWoLRm
 lodnX0ME6Wlveh8ut/joTpSQpkWABLTdv9CYezyGJvPIKw1KRC2oaDUGBJBEtTST
 pUbZBTwNgeQSGBUFHmWSKlRZ+VLyxwgBYOPh7cyy1vKogPRPBcPN4CT4k0pUAhUp
 zDQpuZsoW/kWbEGmTZgfSBClYdSqL840CdPZFd+zcNea+LGQEoR0dQolo+fcp5Yf
 S2yfDmVdHsTAKA==
X-ME-Sender: <xms:0VWZYZeQ2WoMq-mR9bJQaUSNfrW8RpDV9_CEz0E_tfJEI5k2RsIeDQ>
 <xme:0VWZYXNWtHtcuCQI8Al61_CgNIT_PnuMoEpdTFfcG9k53LQqlgxk7TNjVXWpA3V_C
 FT0iWvSqA7MRAxTIg>
X-ME-Received: <xmr:0VWZYSh52BSy7HjSAvordj2pWts2hSmDI8SjchfcZDkj0yKWcDEUQ6pMB4mzB8ljmoGBrjUp-SQS8uchOZaaew>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrgedtgddufeegucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvuffffhfkfgggtgfgsehtqhertddtreejnecuhfhrohhmpefvihhmohht
 hhihucfurghmphhlvgcuoehsrghmphhlvghtsehnghihrhhordgtohhmqeenucggtffrrg
 htthgvrhhnpeefieeufffhuedujedttdekvdetffevudeigeefvdekkefhkeetgfehtdeu
 gfffkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe
 hsrghmphhlvghtsehnghihrhhordgtohhm
X-ME-Proxy: <xmx:0VWZYS_yyAKnWI4eki9M_LLRXeSpXVyuQrTTmZWdORwsa-lBlZquwQ>
 <xmx:0VWZYVscvfotTFukSyqsVt1NGX0hzfrW99XoKGlg6odNVO8fWeqIJg>
 <xmx:0VWZYRFxyTjdMVK4nHdUlSFDqeA-o_ntYP5iVGrRgho_zRdcAbIlHw>
 <xmx:0VWZYWV0dHfvE3gM_-vWPGq88mwkqJWrMQsn2Pr55o59oGWMkfPsQg>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat,
 20 Nov 2021 15:08:48 -0500 (EST)
From: Timothy Sample <samplet@HIDDEN>
To: Philip McGrath <philip@HIDDEN>
Subject: Re: bug#51838: [PATCH 00/11] guix: node-build-system: Support
 compiling add-ons with node-gyp.
Date: Sat, 20 Nov 2021 14:55:31 -0500
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
 <20211120043406.952350-18-philip@HIDDEN>
 <15a8348b0c5b080d590f68cc14bca99afd5d7834.camel@HIDDEN>
 <ce2b636c-741e-99aa-2eaa-dfe9a13160d9@HIDDEN>
Message-ID: <87ilwmbne7.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 51838
Cc: 51838 <at> debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello,

Philip McGrath <philip@HIDDEN> writes:

> On 11/20/21 02:46, Liliana Marie Prikler wrote:
>> Am Freitag, den 19.11.2021, 23:33 -0500 schrieb Philip McGrath:
>>> * guix/build-system/node.scm (lower): Add an optional #:libuv?
>>> argument to tell the build system to add the version of libuv
>>> used as an input to the #:node package as an additional implicit
>>> input, so that packages needing libuv always get the correct version.
>> Would it change something if we always had libuv as implicit input?  I
>> don't think it'd do much for closure size, but it might impact implicit
>> package search as proposed by my solution to the #:absent-dependencies
>> thing.
>
> From a Guix perspective, I don't think it would make much difference,
> since libuv is always needed by node itself. Maybe it would require
> more grafting than would be needed otherwise?
>
> But I think the recommendation for authors of node add-ons is to avoid
> libuv unless it's really needed, because it has fewer stability=20
> guarantees that other Node.js APIs.

My assumption is that most packages would ignore the libuv headers, and
they wouldn=E2=80=99t retain a reference to it (except via Node.js itself).
Hence, I don=E2=80=99t think it would make any difference either to graftin=
g or
closure size to just always add it.


-- Tim




Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 20:08:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 20 15:08:49 2021
Received: from localhost ([127.0.0.1]:43719 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moWfJ-0005KH-GR
	for submit <at> debbugs.gnu.org; Sat, 20 Nov 2021 15:08:49 -0500
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:60829)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <samplet@HIDDEN>) id 1moWfH-0005Jn-OL
 for 51838 <at> debbugs.gnu.org; Sat, 20 Nov 2021 15:08:48 -0500
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.nyi.internal (Postfix) with ESMTP id B400C5C00CD;
 Sat, 20 Nov 2021 15:08:42 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute5.internal (MEProxy); Sat, 20 Nov 2021 15:08:42 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:message-id:mime-version:references:subject:to
 :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
 fm1; bh=swpPuVGvY/xlFAj3O5KVz6DKvUWtSER2V2nbE1xvCrQ=; b=Zi168FYe
 WAH1yYXAIXM7C9QW31Y/l91IRgonG/rXHXJqVII+aPF2hiaHCqzLFipQjao3/+tm
 ESu9EVp2N2zmDmtWXxf4GA8EjeCPR7bXWX0e4nHfy0zfn+eAwMskBctxX0DrMW6B
 lWegEgfC3IrEupeg7jZK5PhXhI+Zt8lXxxh7w4x7t9V8Zc9UXn2fjBRY6QES+cbN
 wWmRfzwgexDGMmry32bryDY02Pq5vGHTctrV22goACFIYOehZSVvCQKtuP1v8XNx
 G00MvCETFDtKoC3rXokFDTCeEB+WsoKptA0mFuWi4Cox0hYnGRWzBkq04Sofoq3d
 h/BM4lxAPrlo0g==
X-ME-Sender: <xms:ylWZYceexyNigaNLWE-hCtJgBvYh7yoml1Ne3Hh7d2HGtdRxWmsmVw>
 <xme:ylWZYeOAD84fqXxcEddRa-IzzJTX95FzyMZs2OBLAFwVpZvB0JDqtJcePMiXxPBrw
 MlIQh89BpHlvD_HLw>
X-ME-Received: <xmr:ylWZYdgqCk2fix_cVnrYHPy8tZRVyfzsn_nhY3KUV46UhlSBIAgkQGSmtP5jmQroNZsbxYdPiF6a-otbYK3uYA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrgedtgddufeefucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvuffffhfkfgggtgfgsehtqhertddtreejnecuhfhrohhmpefvihhmohht
 hhihucfurghmphhlvgcuoehsrghmphhlvghtsehnghihrhhordgtohhmqeenucggtffrrg
 htthgvrhhnpeefieeufffhuedujedttdekvdetffevudeigeefvdekkefhkeetgfehtdeu
 gfffkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe
 hsrghmphhlvghtsehnghihrhhordgtohhm
X-ME-Proxy: <xmx:ylWZYR-61QN55rWY87hLDj7ySgeN-SaZrZv9U9Lc8SoNW1a1ldFxhQ>
 <xmx:ylWZYYvdD1o9DgkYFA47jlQ0xFr0JVBqaazamHhRdDRWg8yKUI_keQ>
 <xmx:ylWZYYHS1uBTt0WHopQpwsN213gt9_-lWfffumnxaFJ2LOicCsZWTw>
 <xmx:ylWZYVVK-H_ZAV1GPd_-dLyseBl1Cp8pK2KAhKhlmIq2MHUnPc4sEQ>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat,
 20 Nov 2021 15:08:42 -0500 (EST)
From: Timothy Sample <samplet@HIDDEN>
To: Philip McGrath <philip@HIDDEN>
Subject: Re: bug#51838: [PATCH 00/11] guix: node-build-system: Support
 compiling add-ons with node-gyp.
Date: Sat, 20 Nov 2021 15:04:51 -0500
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
 <20211120043406.952350-5-philip@HIDDEN>
 <8c07272b588fc059f3c445fe1f33c63cce8f31f1.camel@HIDDEN>
 <37768a63-5a4a-b604-2542-e8890fd68a16@HIDDEN>
Message-ID: <87o86ebnee.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 51838
Cc: 51838 <at> debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hello,

Philip McGrath <philip@HIDDEN> writes:

> On 11/20/21 02:41, Liliana Marie Prikler wrote:
>
>> In the resolve-dependencies subprocedure, we could check whether we
>> have a matching input somewhere and only include the dependency if we
>> do.  WDYT?
>
> [...]
>
> The other issue is that deleting packages with no matching input by
> default would replicate some of the drawbacks of the current `(delete=20
> 'configure)` approach. I think it's better to have an explicit list of
> dependencies that Guix is deleting. If eventually we package all of
> the missing dependencies for Guix, it would be much easier to find the=20
> packages that ought to use it. And, in the highly dynamic JavaScript
> world, I'm reluctant to give up one of the few static checks we
> have. If a missing package that really was required were automatically
> deleted from "package.json", it seems the failure mode would by a
> mysterious runtime error, potentially many steps down a dependency
> chain.

This is well put.  I actually experimented with a similar approach when
we updated the Node.js build system.  This is a big improvement over
deleting the configure phase, which would never scale to more than a
handful of packages.  Having a build-time check that ensures all the
developer-declared dependencies are available (save the =E2=80=9Cabsent=E2=
=80=9D ones)
will be very helpful when we are maintaining hundreds of JavaScript
packages.  :)

For the patch itself, it would be better to move a lot of your commit
message into a comment somewhere in the build system code.  If we had a
section in the manual for Node packages, it would go there, but alas....
I think most people would be happy to see a comment in the build system
code and be saved from having to poke around with =E2=80=98git blame=E2=80=
=99.


-- Tim




Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 20:08:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 20 15:08:45 2021
Received: from localhost ([127.0.0.1]:43715 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moWfF-0005Jy-77
	for submit <at> debbugs.gnu.org; Sat, 20 Nov 2021 15:08:45 -0500
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:40529)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <samplet@HIDDEN>) id 1moWf9-0005JZ-Nv
 for 51838 <at> debbugs.gnu.org; Sat, 20 Nov 2021 15:08:43 -0500
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.nyi.internal (Postfix) with ESMTP id 7F1E45C00DD;
 Sat, 20 Nov 2021 15:08:34 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute5.internal (MEProxy); Sat, 20 Nov 2021 15:08:34 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:message-id:mime-version:references:subject:to
 :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
 fm1; bh=HsUQuTj0Bte0NUdR0NSSDfi09hAe/fMsh+rhFccJNfI=; b=XGtRi+/f
 kH3UFZ+zBI+XQJ0zCQZfS4lMRm7AZhzPFKbdCPXG7We4hY9D9pZJybkMSh968Fmf
 AI8DhwZ11Tu9kxPK28TlAZeJkGHlO9TWWyzFd8pAh8FxsIdvIK9dGu0+QwyCZFCh
 97sVbiqBCaUVDhx+3QWXOftA/OdOVcpFoQx+2VwUFVxsMSX4XkD0EqbJJXAFxXjE
 5Ep99ZnjZCTdh4tmuBum0r+T5Wjslie6rI1EbPqvFoIlPcD7hEFIGj2D1I2jkOg3
 yAWvxFJu5ONvyQdVApAwtapJ/cwZic/4I18Ez8xlowsEjryq7HvIjUkN+1u+Hk8v
 A6MdLVNEcXcb+Q==
X-ME-Sender: <xms:wlWZYb6vYdACjsw-VGohOc1Q8pkAUDwytv5w1YpAHao85bIr6Pk7EQ>
 <xme:wlWZYQ6kmoxUOkASYrsczaFonc2t1PYHyuPNl52j8TfRrJS0DvL3mgXamacHNeuc2
 iCJbddvAdZh411tIQ>
X-ME-Received: <xmr:wlWZYSfGhCUpui8krLXTVZ6P3ZIJYJoR_REBRhti-ZaYQg5sQ5rkRwCn9fIuzpkIlaWL2QA6SnGh0FPVB8Czvg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrgedtgddufeefucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufhffffkfgggtgfgsehtqhertddtreejnecuhfhrohhmpefvihhmohht
 hhihucfurghmphhlvgcuoehsrghmphhlvghtsehnghihrhhordgtohhmqeenucggtffrrg
 htthgvrhhnpedvtdevuddukeevgefggffhtefhueffkeegkeevudeftedugefgtdefheef
 jeffieenucffohhmrghinhepghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedtne
 curfgrrhgrmhepmhgrihhlfhhrohhmpehsrghmphhlvghtsehnghihrhhordgtohhm
X-ME-Proxy: <xmx:wlWZYcLUZgYeorA_umPGVzSpUjJJcx6nfbW-woBog2wGWEpHFz6uJQ>
 <xmx:wlWZYfKmCrgfOEjVQL2sCXRFXxjm6r1ZstDrp7ZV2QU8V4BuyDyKQg>
 <xmx:wlWZYVwdhTK8QpNWlipSk4wZhbfPvekndBdOf1gWGSacqQn5fh5EvQ>
 <xmx:wlWZYWXg1ILsdtpGt3lqurXMGhFp432o5tQAUQd_AS8aV_J8cPWVdg>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat,
 20 Nov 2021 15:08:33 -0500 (EST)
From: Timothy Sample <samplet@HIDDEN>
To: Philip McGrath <philip@HIDDEN>
Subject: Re: bug#51838: [PATCH 00/11] guix: node-build-system: Support
 compiling add-ons with node-gyp.
References: <20211114125830.45427-1-philip@HIDDEN>
 <20211114130409.49241-1-philip@HIDDEN>
 <20211114130409.49241-2-philip@HIDDEN>
 <48018e12484d19466d9c6f253a8d7ebeae93e947.camel@HIDDEN>
 <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
Date: Sat, 20 Nov 2021 15:08:32 -0500
Message-ID: <87tug6bnen.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 51838
Cc: 51838 <at> debbugs.gnu.org, Pierre Langlois <pierre.langlois@HIDDEN>,
 Liliana Marie Prikler <liliana.prikler@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hi Philip,

There are some really valuable changes in here, thanks!  I would like to
start understanding and reviewing the changes so that we can get some of
this good stuff merged in.  However, I have one question that I couldn=E2=
=80=99t
answer from reading here or at <https://issues.guix.gnu.org/49946>: is
there an agreement between you and Pierre that these patches are the
=E2=80=9Cright=E2=80=9D way to do native addons for Node.js.  More importan=
tly, is the
general plan that we merge these changes, and then Pierre rebases their
Tree-sitter changes on top these?

Pierre, maybe you could weigh in here?

Sorry if I missed something.  I assume everything is OK, but I want to
be sure before I start digging into the details of the patches =E2=80=93
especially those first few more complicated ones.  :)

Thanks!


-- Tim




Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 17:16:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 20 12:16:45 2021
Received: from localhost ([127.0.0.1]:43620 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moTyn-0005h1-22
	for submit <at> debbugs.gnu.org; Sat, 20 Nov 2021 12:16:45 -0500
Received: from mail-qv1-f42.google.com ([209.85.219.42]:46952)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moTym-0005c8-66
 for 51838 <at> debbugs.gnu.org; Sat, 20 Nov 2021 12:16:44 -0500
Received: by mail-qv1-f42.google.com with SMTP id jo22so9289557qvb.13
 for <51838 <at> debbugs.gnu.org>; Sat, 20 Nov 2021 09:16:44 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=message-id:date:mime-version:user-agent:subject:content-language:to
 :references:from:in-reply-to:content-transfer-encoding;
 bh=RpuOT16S+C5qDdRGaHM3A+72/IJ6HAtBPvyOfvbOaJA=;
 b=bwIb+KTSjc+vD8puMCYX4mEtD7yQURNHCgbK5Zt8C7lBNeaN30KBvHzhoSh5+etDif
 1wdoCGaE9PJCMhFIuiaDxlStWqeVH1izyge2Ml7AaQ9txrvF5C7zATF/oeGNcOvLo+mS
 +G51berR2xEvGVjv4y8oBc64h0c10J4CoAFNTTkAEoGRZngLYZ3nLeaQoSQSZPZS4HI1
 yJwbz3Kaaa1VG3z4Xmu0KYnjiZHQ6c0+jG61tMF6CCoSD23ACgi4Lz75cicNt3lmV2ro
 Lk1zhqyg+nNuvKBGhk/b08Iir3wV9sz1jVgA9rR3ta6iwtpP/AjtQkPqrToM5I+ApY+A
 zBEA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
 :content-language:to:references:from:in-reply-to
 :content-transfer-encoding;
 bh=RpuOT16S+C5qDdRGaHM3A+72/IJ6HAtBPvyOfvbOaJA=;
 b=p75OvAiA+DlPn0n2HyhPUcdmbn3S0iMFG1j25raqYQjfyJIAK+lZtSQhcomvsejYyJ
 4NGOr4EtYpfcx2A6wVEju2orAhRrTP7xJMsbFP1oLjfIs4AQdXNWeSh5Lhb8FJ6vDXiT
 91SoudFpQ3B0EIOu4ib73hQYIaDmIlfnxfmxxAp4jpIhuF3TmvkYmc5ygUExOBTeFpWi
 lpqiQfgw0WJ3Q9FMvkmruqTKqiaznpybIahYIvXpYWFC7UpCebtbEePeEPRtu2d0cVA6
 toNtAspGZNBG7nHAtyXhOLDFRqEE0XkN5cJEmxo/iAAfxW0aH2Hqq0bbytciwAjq8D+R
 8CoA==
X-Gm-Message-State: AOAM530o5TiBoGK/4vJkKLbjv78m4V8+7r6VoSRWm7j20FaDAryrO6WE
 iO7uuhZLKdewb9NWGTMYStXfNg==
X-Google-Smtp-Source: ABdhPJxCTZytVa7zxsHJRbS+oTiFJIWnflWHIB6NKHkJGDzKqkG4zJJj3N4p6AkV8LgYazkg7EQxMQ==
X-Received: by 2002:a05:6214:2b05:: with SMTP id
 jx5mr85347033qvb.9.1637428598675; 
 Sat, 20 Nov 2021 09:16:38 -0800 (PST)
Received: from [192.168.45.37] (c-73-125-89-242.hsd1.fl.comcast.net.
 [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id n13sm1885512qkp.19.2021.11.20.09.16.38
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sat, 20 Nov 2021 09:16:38 -0800 (PST)
Message-ID: <ce2b636c-741e-99aa-2eaa-dfe9a13160d9@HIDDEN>
Date: Sat, 20 Nov 2021 12:16:37 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.1
Subject: Re: [bug#51838] [PATCH v2 18/26] guix: node-build-system: Add
 optional #:libuv? argument.
Content-Language: en-US
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>, 51838 <at> debbugs.gnu.org
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
 <20211120043406.952350-18-philip@HIDDEN>
 <15a8348b0c5b080d590f68cc14bca99afd5d7834.camel@HIDDEN>
From: Philip McGrath <philip@HIDDEN>
In-Reply-To: <15a8348b0c5b080d590f68cc14bca99afd5d7834.camel@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.6 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.4 (/)

On 11/20/21 02:46, Liliana Marie Prikler wrote:
> Am Freitag, den 19.11.2021, 23:33 -0500 schrieb Philip McGrath:
>> * guix/build-system/node.scm (lower): Add an optional #:libuv?
>> argument to tell the build system to add the version of libuv
>> used as an input to the #:node package as an additional implicit
>> input, so that packages needing libuv always get the correct version.
> Would it change something if we always had libuv as implicit input?  I
> don't think it'd do much for closure size, but it might impact implicit
> package search as proposed by my solution to the #:absent-dependencies
> thing.

 From a Guix perspective, I don't think it would make much difference, 
since libuv is always needed by node itself. Maybe it would require more 
grafting than would be needed otherwise?

But I think the recommendation for authors of node add-ons is to avoid 
libuv unless it's really needed, because it has fewer stability 
guarantees that other Node.js APIs.





Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 17:09:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 20 12:09:31 2021
Received: from localhost ([127.0.0.1]:43603 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moTrn-00043u-G2
	for submit <at> debbugs.gnu.org; Sat, 20 Nov 2021 12:09:31 -0500
Received: from mail-qk1-f170.google.com ([209.85.222.170]:43569)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moTrm-00043c-4R
 for 51838 <at> debbugs.gnu.org; Sat, 20 Nov 2021 12:09:30 -0500
Received: by mail-qk1-f170.google.com with SMTP id 193so13506642qkh.10
 for <51838 <at> debbugs.gnu.org>; Sat, 20 Nov 2021 09:09:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=message-id:date:mime-version:user-agent:subject:content-language:to
 :references:from:in-reply-to:content-transfer-encoding;
 bh=CHbSz76CPuVnFbmF0MibKnvXiL/xv6F4D74o+342OTw=;
 b=JQvx9mNfecu5OOavsZQdvGZRKr6Y0RdJpesgLBUjlDKqvUWNIJAOCpoRH47MAn6ZGL
 WVr67JftYYn301vj3vIo4U2xmIaHZKKbt7qjL6aKUP9GMZjWRDISotJjQnm1UHkdSFow
 I2FCC2s1mkLGJ99kAPQ7nsWTFMRTGBpVrr8mBWirlgPHwjgN3AWCy2TuIOJRgKOpNqSy
 vk48ccJFZtcEKfzr3Tou0ja7hOTNmUihB3BfpFkyF/0cwRqQHM8GpCyu7Dttq/6UbTHN
 +iOzAJUaZuGRv3x6XLFgfeG/3C6qMhgH9+QSUgWS48/xq1gejMcHnG/iK/hEIpzpVxBb
 aizw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
 :content-language:to:references:from:in-reply-to
 :content-transfer-encoding;
 bh=CHbSz76CPuVnFbmF0MibKnvXiL/xv6F4D74o+342OTw=;
 b=Zi3H4hgPKjzFC0tg8ODGF/B+vVDJzstyT2uXIq5xutVjataR/ET5AWRRSRxXv3dNx0
 olmkoiVSsFcnD1cHj2dD1kaxv+Unma+xnC53Kc31mtqH/WN92Z4MXKl1bfDICW4UJoat
 6uSPJQafhXseYTPBs0fsqhf2qR22lF88saa1zGZA7QOJEvKQqABay2MbkWWmjiodr6ds
 humqX43cFbQAsKQLvq/6ACria2vAEmp6yFy52SetxF10f8kaclnW9RFR4yTwMBG7MT3F
 jy63xD8YWCAeysxTVhHViZ6kCMdEw0hMJeM/HkcOUo/gNA+0WZojZdehalbW6hJBbypN
 3Rxw==
X-Gm-Message-State: AOAM532/PpGn0BfJJSJoASElrP4DpnsZzK+kcTacLOIgq79AIbPBN4ug
 Dbyn3b5sWSXyhnbKRGsdXokZ0Q==
X-Google-Smtp-Source: ABdhPJwg4hMYk97/4BezvNqD2NvtTbSugXURBs2TAh8Iv9roBhaOxo/4WAgZ+XW/4XeKEFvvxZOrqQ==
X-Received: by 2002:a05:620a:2153:: with SMTP id
 m19mr38109617qkm.77.1637428164753; 
 Sat, 20 Nov 2021 09:09:24 -0800 (PST)
Received: from [192.168.45.37] (c-73-125-89-242.hsd1.fl.comcast.net.
 [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id j13sm1781006qkp.111.2021.11.20.09.09.24
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sat, 20 Nov 2021 09:09:24 -0800 (PST)
Message-ID: <f5e6dc2c-6f71-ee6c-bad3-7aa744a4c6f9@HIDDEN>
Date: Sat, 20 Nov 2021 12:09:23 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.1
Subject: Re: [bug#51838] [PATCH v2 10/26] gnu: node-llparse-builder-bootstrap:
 Use #:absent-dependencies.
Content-Language: en-US
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>, 51838 <at> debbugs.gnu.org
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
 <20211120043406.952350-10-philip@HIDDEN>
 <f4f2a0c7a6c6c8c650a2aec6698ce28765b321eb.camel@HIDDEN>
From: Philip McGrath <philip@HIDDEN>
In-Reply-To: <f4f2a0c7a6c6c8c650a2aec6698ce28765b321eb.camel@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.6 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.4 (/)

On 11/20/21 02:44, Liliana Marie Prikler wrote:
> Am Freitag, den 19.11.2021, 23:33 -0500 schrieb Philip McGrath:
>>          (modify-phases %standard-phases
>> -         (delete 'configure)
>> +         (add-before 'configure 'remove-package-lock
>> +           ;; Having package-lock.json seems to cause npm
>> +           ;; to look for things on the internet in the configure
>> phase,
>> +           ;; even if we have them properly installed.
>> +           (lambda args
>> +             (delete-file-recursively "package-lock.json")))
> I think a simple delete-file ought to work.  This should also be done
> by configure or similar, compare cargo-build-system.

Yes, I thought about having the build system automatically delete 
"package-lock.json", but I'm not 100% sure it's always a problem to have 
it, or if there might even be some circumstance where we want to keep 
it. I'd prefer to wait until we see a significant number of node 
packages deleting their "package-lock.json" files before trying to 
abstract over the pattern.




Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 17:05:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 20 12:05:02 2021
Received: from localhost ([127.0.0.1]:43593 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moTnR-0003vJ-QY
	for submit <at> debbugs.gnu.org; Sat, 20 Nov 2021 12:05:02 -0500
Received: from mail-qv1-f48.google.com ([209.85.219.48]:43641)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moTnP-0003v5-Jx
 for 51838 <at> debbugs.gnu.org; Sat, 20 Nov 2021 12:05:00 -0500
Received: by mail-qv1-f48.google.com with SMTP id j9so9298873qvm.10
 for <51838 <at> debbugs.gnu.org>; Sat, 20 Nov 2021 09:04:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=message-id:date:mime-version:user-agent:subject:content-language:to
 :references:from:in-reply-to:content-transfer-encoding;
 bh=8XqaUeUuQGNTZ8xdOgb7pwod65g/pmsW7ZAJJGjAFeQ=;
 b=koW2E5I4UhhpzuS7kPKRdYScQijmc4yGhpedqSOse9CQAN/571op9EtTSWDoGTtbsB
 l5r+Saicc8sgWPOkHzGXEbyHkXt7wNnbaD8Nc/q1cm8fhpGLd8jFfLQHA7fR8wfuIvPe
 tVwSCRYRmkcuRO3PpwHlLy0RzeuDVL/s6Ddx2mLYa5EeJvrH9HodtRKyMrqpzN/Rm45h
 ZywyGm72V8pI2W/YG1inldlE6cCFhcyKRt/RfZGH/Ig3IwAIIIFhL1scf5jgcDjK4QCI
 G7DCfEvcZm18zVEELNBb7bFpigSedR1DsCpb0uHN+jdCgk58Gxx3p8IwbP8YYFeA3AEO
 5pYw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
 :content-language:to:references:from:in-reply-to
 :content-transfer-encoding;
 bh=8XqaUeUuQGNTZ8xdOgb7pwod65g/pmsW7ZAJJGjAFeQ=;
 b=oU/ttwgnktgpE/MHu3SrC0hIx+J0S4uBBdGei2N0T6c44F6lfucX7rl2CvxGomayhb
 WQGlfY1A9PQMlTbuySYxNXYXyOJVS7gv1PzUOmPhSfMMjoFKwISFZnVG0OhgD0rehJnu
 2HkvFwLnhrHmAYF/3upOTXsCiBX3i9NfOolp24/r9qaBh4xiC+2/ZT4YchBywypyZRh0
 1GKM1lYdDgyK6d1pDAqkMBhEnd3PaoUMfnUtKkeckb0+jJiKlgcWnTSKS4q16TKG5KUp
 C3Nqer3fXUJbz3XpoEzl4uZztHk2YdipU8bFLdxKgUHOdQWb/H00bxQc6WlTmfHdTO1I
 kXgQ==
X-Gm-Message-State: AOAM530eqjgfg52szg4zHGtkkKH3WvxJlCMOeJfp/4Qx5psGMSzaagIA
 tDp2yVjGVhXJVjqZlJnpRGBo0w==
X-Google-Smtp-Source: ABdhPJyaURNfjk/Eco7v9qcFXRqW63NjYDZF4mMXYapvjrpeH2e5heTZ6EBSwvEfmyzZz3fuzLBQzQ==
X-Received: by 2002:a05:6214:8f2:: with SMTP id
 dr18mr84731962qvb.56.1637427890966; 
 Sat, 20 Nov 2021 09:04:50 -0800 (PST)
Received: from [192.168.45.37] (c-73-125-89-242.hsd1.fl.comcast.net.
 [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id bi6sm1773917qkb.29.2021.11.20.09.04.50
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sat, 20 Nov 2021 09:04:50 -0800 (PST)
Message-ID: <37768a63-5a4a-b604-2542-e8890fd68a16@HIDDEN>
Date: Sat, 20 Nov 2021 12:04:49 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.1
Subject: Re: [bug#51838] [PATCH v2 05/26] guix: node-build-system: Add
 #:absent-dependencies argument.
Content-Language: en-US
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>, 51838 <at> debbugs.gnu.org
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
 <20211120043406.952350-5-philip@HIDDEN>
 <8c07272b588fc059f3c445fe1f33c63cce8f31f1.camel@HIDDEN>
From: Philip McGrath <philip@HIDDEN>
In-Reply-To: <8c07272b588fc059f3c445fe1f33c63cce8f31f1.camel@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.6 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.4 (/)

Hi,

On 11/20/21 02:41, Liliana Marie Prikler wrote:
> Hi,
> 
> Am Freitag, den 19.11.2021, 23:33 -0500 schrieb Philip McGrath:
>> Many of Guix's Node.js packages are built without some of the
>> dependencies they specify in their "package-lock.json" files,
>> either because we don't have them packaged yet (e.g. test
>> utilities) or because we don't want them (e.g. to reduce the
>> closure size). Previously, Guix package definitions would work
>> around this situation by deleting the `'configure`
>> phase (i.e. the initial `npm install`).
>>
>> This commit adds an optional #:absent-dependencies argument to
>> `node-build-system` to list Node.js packages that should be
>> removed from the "package.json" file.Retaining the `'configure`
>> phase avoids skipping checks for the dependencies that are
>> intended to be present and other actions performed by `npm
>> install`, such as automatically building native add-ons with
>> `node-gyp` when the "gypfile" key is present.
>>
>> [...]
> This is a somewhat decent approach, but I wonder whether we could
> improve this.  Does nodejs complain if a dependency exists in the code,
> but is not present in the packages.json?

To the best of my understanding, npm doesn't inspect the js files at all 
by default, so no. (A package.json file might define a build script that 
does more checks.) I think a missing and undeclared dependency manifests 
itself as a runtime error when the require() function is evaluated.

> In the resolve-dependencies subprocedure, we could check whether we
> have a matching input somewhere and only include the dependency if we
> do.  WDYT?

I thought about this, but it seems to me there are two problems. First, 
I'm very unsure about this, but, in the last few days, I've gotten the 
impression there may be some "package.json" packages that don't 
correspond directly to Guix packages. I don't really understand how that 
works, but I think it may have something to do with npm packages that 
can run either on Node.js or on the web and need to use some 
functionality that's part of the Node.js core but not the web platform 
(or vice versa?). I could be wrong about that, but I've tried, 
especially in v2, to only have the build-side code do things I'm 
confident are correct in all cases.

The other issue is that deleting packages with no matching input by 
default would replicate some of the drawbacks of the current `(delete 
'configure)` approach. I think it's better to have an explicit list of 
dependencies that Guix is deleting. If eventually we package all of the 
missing dependencies for Guix, it would be much easier to find the 
packages that ought to use it. And, in the highly dynamic JavaScript 
world, I'm reluctant to give up one of the few static checks we have. If 
a missing package that really was required were automatically deleted 
from "package.json", it seems the failure mode would by a mysterious 
runtime error, potentially many steps down a dependency chain.




Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 07:48:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 20 02:48:42 2021
Received: from localhost ([127.0.0.1]:41556 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moL74-0005Nh-57
	for submit <at> debbugs.gnu.org; Sat, 20 Nov 2021 02:48:42 -0500
Received: from mail-wm1-f68.google.com ([209.85.128.68]:52787)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liliana.prikler@HIDDEN>) id 1moL70-0005NS-HO
 for 51838 <at> debbugs.gnu.org; Sat, 20 Nov 2021 02:48:40 -0500
Received: by mail-wm1-f68.google.com with SMTP id o29so10476433wms.2
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 23:48:38 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=message-id:subject:from:to:date:in-reply-to:references:user-agent
 :mime-version:content-transfer-encoding;
 bh=bYn7miIgDwESJHdUKUiJdSebcn/5pu1in5/H+uYHHuw=;
 b=EXcFBnRCQDYB/dvk6pdLnlm0jG+8Zcl/WjNuldW+s0sCqQqbfmENIUgJ3gH0YQynuv
 B7YQbuHN7mLUBb677jovqR8RM/+DNoG6zD7pnnmkSP3hfadr986Bp+qX7yNhV8zCLWme
 57xdz0RYxsF77fLPTYh1Qvy+oeot07P7Gh74vUIVUYsf/7fU8z840k5qwFSdJrjwKMdz
 bT0UttDKiwwq0FC3+WaeTjjRcqv0RYc4Y/0SIF2y+7BRaDT+zrpEjItMRFk53XEjK+da
 GwJm7hBn22GLNqfyWl/MnDJFr7gr0vabsEUkeBcVhabrQl0NfcZI7KOVxVFJL1GDDQb8
 3NIQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to
 :references:user-agent:mime-version:content-transfer-encoding;
 bh=bYn7miIgDwESJHdUKUiJdSebcn/5pu1in5/H+uYHHuw=;
 b=TaTvrEP5OszNTbrYKhn9CxqKKBT9IQFPSP4xysgZXawSknWEVbSAVhuw7vM1hVPTNh
 0ZfZ/rxLWR3OwRvE7Dywkpu2rqdqsYnKCwib4KoBjCHJDdYf6m/NhILU2rENYKC+aNtq
 bRwdrm6yNSqumdcizKI/TDzekhuHmSivf+t04xh+rJEr7JhuYVi+oEGh9hDxMfL5rI1H
 IG5ELsjyi52UtPNP3ewCJRiLbc4bN0F1TGa/UjhGCOz0o37A1U8drqueVQABhOHJsoLX
 Gsb/5HCIiiyPX5ZgCWIUscDfP+vcnIo6XOc4Ce9LoFBR/9Y2eW2cucXF7yTQ3FDZUsZo
 WcSQ==
X-Gm-Message-State: AOAM531CI4ukRI39qe71rP/9Dfe0OJiMVs67nDk2G6pTrb1Ij5m0Y+9v
 UdKd+XFoUAJ3pzS/1rV+EBM=
X-Google-Smtp-Source: ABdhPJyqyVrPeDQWWxTnL+4y68vQM6dzfDXzZMtsNHQrJdO1Nmr9Lkb3TfN+M55fTsBZ3kMsweRZzA==
X-Received: by 2002:a1c:a5c7:: with SMTP id o190mr8077089wme.186.1637394512641; 
 Fri, 19 Nov 2021 23:48:32 -0800 (PST)
Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
 [85.127.52.93])
 by smtp.gmail.com with ESMTPSA id n13sm1985082wrt.44.2021.11.19.23.48.32
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 19 Nov 2021 23:48:32 -0800 (PST)
Message-ID: <76798c0422cb0e7eb0bfd11baa6af6a31688bf2f.camel@HIDDEN>
Subject: Re: [bug#51838] [PATCH v2 26/26] gnu: Add node-sqlite3.
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
To: Philip McGrath <philip@HIDDEN>, 51838 <at> debbugs.gnu.org
Date: Sat, 20 Nov 2021 08:48:31 +0100
In-Reply-To: <20211120043406.952350-26-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
 <20211120043406.952350-26-philip@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Warning, this patch does not just add node-sqlite3!

Am Freitag, den 19.11.2021, 23:34 -0500 schrieb Philip McGrath:
> * gnu/packages/node-xyz.scm (node-sqlite3): New variable.
> ---
>  gnu/packages/node-xyz.scm | 107
> ++++++++++++++++++++++++++++++++++++--
>  1 file changed, 104 insertions(+), 3 deletions(-)
> 
> diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
> index 60dbfc163c..a56281fe18 100644
> --- a/gnu/packages/node-xyz.scm
> +++ b/gnu/packages/node-xyz.scm
> @@ -615,7 +615,8 @@ (define-public node-addon-api
>         (sha256
>          (base32
> "1bhvfi2m9nxfz418s619914vmidcnrzbjv6l9nid476c3zlpazch"))))
>      (inputs
> -     `(("python" ,python)))
> +     `(("python" ,python)
> +       ("node-safe-buffer" ,node-safe-buffer)))
>      (build-system node-build-system)
>      (arguments
>       `(#:absent-dependencies
> @@ -630,8 +631,7 @@ (define-public node-addon-api
>           "eslint-plugin-promise"
>           "fs-extra"
>           "path"
> -         "pre-commit"
> -         "safe-buffer")
> +         "pre-commit")
>         #:phases
>         (modify-phases %standard-phases
>           (add-after 'unpack 'skip-js-tests
> @@ -660,3 +660,104 @@ (define-public node-addon-api
>  @code{libuv} (included in a project via @code{#include <uv.h>}) are
> not
>  ABI-stable across Node.js major versions.")
>      (license license:expat)))
> +
> +(define-public node-sqlite3
> +  (package
> +    (name "node-sqlite3")
> +    (version "5.0.2")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/mapbox/node-sqlite3")
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> "0sbbzzli282nxyfha10zx0k5m8hdp0sf3ipl59khjb7wm449j86h"))
> +       (snippet
> +        (with-imported-modules '((guix build utils))
> +          #~(begin
> +              (use-modules (guix build utils))
> +              ;; unbundle sqlite
> +              '(for-each delete-file-recursively
> +                         (find-files "deps" gzip-file?)))))))
> +    (inputs
> +     `(("node-addon-api" ,node-addon-api)
> +       ("python" ,python)
> +       ("sqlite" ,sqlite)))
> +    (build-system node-build-system)
> +    (arguments
> +     `(#:tests?
> +       #f ; FIXME: tests depend on node-mocha
> +       #:modules
> +       ((guix build node-build-system)
> +        (guix build json)
> +        (srfi srfi-1)
> +        (ice-9 match)
> +        (guix build utils))
> +       #:libuv? #t
> +       #:absent-dependencies
> +       `(;; Normally, this is "built" using @mapbox/node-pre-gyp,
> +         ;; which publishes or downloads pre-built binaries
> +         ;; or falls back to building from source.
> +         ;; Here, we patch out all of that and just build directly.
> +         ;; It would be better to patch a version of @mapbox/node-
> pre-gyp
> +         ;; that always builds from source, as Debian does,
> +         ;; but there are a number of dependencies that need
> +         ;; to be packaged or removed.
> +         "@mapbox/node-pre-gyp"
> +         "node-pre-gyp" ;; deprecated name still used in some places
> +         "aws-sdk"
> +         "@mapbox/cloudfriend"
> +         ;; Confusingly, this is only a dependency beceuse of
> +         ;; @mapbox/node-pre-gyp: with that removed,
> +         ;; npm will use its own copy:
> +         "node-gyp"
> +         ;; These we'd like, we just don't have them yet:
> +         "eslint"
> +         "mocha")
> +       #:phases
> +       (modify-phases %standard-phases
> +         ;; We need this step even if we do replace @mapbox/node-
> pre-gyp
> +         ;; because the package expects to build its bundled sqlite
> +         (add-before 'configure 'npm-config-sqlite
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (setenv "npm_config_sqlite" (assoc-ref inputs
> "sqlite"))))
> +         (add-after 'patch-dependencies 'avoid-node-pre-gyp
> +           (lambda args
> +             (with-atomic-file-replacement "package.json"
> +               (lambda (in out)
> +                 (let* ((js (read-json in))
> +                        (alist (match js
> +                                 (('@ . alist) alist)))
> +                        (scripts-alist (match (assoc-ref alist
> "scripts")
> +                                         (('@ . alist) alist)))
> +                        (scripts-alist
> +                         ;; install script would use node-pre-gyp
> +                         (assoc-remove! scripts-alist "install"))
> +                        (alist
> +                         (assoc-set! alist "scripts" (cons '@
> scripts-alist)))
> +                        (alist
> +                         ;; causes `npm install` (our 'configure
> phase)
> +                         ;; run the appropriate parts of node-gyp
> +                         (assoc-set! alist "gypfile" #t))
> +                        (binary-alist (match (assoc-ref alist
> "binary")
> +                                        (('@ . alist) alist)))
> +                        (js (cons '@ alist)))
> +                   ;; compensate for lack of @mapbox/node-pre-gyp
> +                   (setenv "GYP_DEFINES"
> +                           (string-append
> +                            "module_name="
> +                            (assoc-ref binary-alist "module_name")
> +                            " "
> +                            "module_path="
> +                            (assoc-ref binary-alist "module_path")))
> +                   (write-json js
> +                               out)))))))))
> +    (home-page "https://github.com/mapbox/node-sqlite3")
> +    (synopsis "Asynchronous, non-blocking SQLite3 bindings for
> Node.js")
> +    (description
> +     "The Node.js add-on @code{node-sqlite3} provides a set of a
> asynchronous,
> +non-blocking bindings for SQLite3, written in modern C++ and tested
> for memory
> +leaks.")
> +     (license license:bsd-3)))





Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 07:47:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 20 02:47:02 2021
Received: from localhost ([127.0.0.1]:41552 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moL5R-0005Iz-Rx
	for submit <at> debbugs.gnu.org; Sat, 20 Nov 2021 02:47:01 -0500
Received: from mail-wr1-f68.google.com ([209.85.221.68]:43879)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liliana.prikler@HIDDEN>) id 1moL5P-0005IT-Tw
 for 51838 <at> debbugs.gnu.org; Sat, 20 Nov 2021 02:47:00 -0500
Received: by mail-wr1-f68.google.com with SMTP id t30so22086073wra.10
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 23:46:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=message-id:subject:from:to:date:in-reply-to:references:user-agent
 :mime-version:content-transfer-encoding;
 bh=6rQyB8bAoYXjm/1QMtgnjDlPc/AlY1JOLxhwC+MJcz0=;
 b=JLgCN+aT3qrGC9KoACY35cXMUzwHoewu//M5Y2Dam29Z9zjz9v5KC8OftLCgNkSr6/
 VnX1I1RBIpz1QKSmjzbl0pH04HiWbqDNJ6qRlX22+H6LLUW2NIR5X1BKKe227mdrbsnF
 pWwVmQ+/YZ2nRN8xSZlf3p3kkFXuX0nZt9sPGJX1Owufg2rn/o2iUZuxS+zhRZiGnG7C
 YZlOd3rmCzWNFsMnQhJiGk0va4cwH/25PK50V2/eN/i53FZNwAr2VkU70+vXdmqEQlR2
 7p57k0d7LGDD7yEOHHnIr6hRkfbV2OmSFDewWHRzFW0EgiayxneXRqHGg1tUpJUfZetx
 etSg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to
 :references:user-agent:mime-version:content-transfer-encoding;
 bh=6rQyB8bAoYXjm/1QMtgnjDlPc/AlY1JOLxhwC+MJcz0=;
 b=29s2oZyhyjv5MJSE/qyuSkMZb3zBQXa7mPMgGeW8YjByD6P5R18h3xxGSV3wcNJa+7
 3kYphOyU70u4iSjn5hT3lMpw+UE20HVojcTw8Na+LqxF343EAReY5/dV11mdxAWiOQnW
 VktLTWW0rKzIzVXANwtCNITUo2MWxc/ghuUaQgx3ydIIb3GNbU07jJWKwY/udrxowVPm
 JCq750KRxQHTniVXuEc6wJEsyb27FGT4VOkL3DtFltmf7BBLAPPMVTn0Kb+5/sNM2/l8
 QfTmVeJak3gA59zJ/CrqWZuwjv0rHJTn1ADdyuZvm0mPSPI9UVhD8yAhp8dsC/mOqtN4
 iDXw==
X-Gm-Message-State: AOAM533hgC7x3St75fK03ayUeLY/auw6slwwa1sWrEkoxLTr6FQczg8h
 mcAm+StL/CTznUrXPMODfl0=
X-Google-Smtp-Source: ABdhPJzKI21jEisAeMVrxpszom3cC4rPbI2KAWnOJSLrIUxWkY0XjPArsu9NtvMIrISYgjBXXzrYgg==
X-Received: by 2002:a05:6000:181:: with SMTP id
 p1mr15371040wrx.292.1637394414195; 
 Fri, 19 Nov 2021 23:46:54 -0800 (PST)
Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
 [85.127.52.93])
 by smtp.gmail.com with ESMTPSA id f15sm2388026wmg.30.2021.11.19.23.46.53
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 19 Nov 2021 23:46:53 -0800 (PST)
Message-ID: <15a8348b0c5b080d590f68cc14bca99afd5d7834.camel@HIDDEN>
Subject: Re: [bug#51838] [PATCH v2 18/26] guix: node-build-system: Add
 optional #:libuv? argument.
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
To: Philip McGrath <philip@HIDDEN>, 51838 <at> debbugs.gnu.org
Date: Sat, 20 Nov 2021 08:46:53 +0100
In-Reply-To: <20211120043406.952350-18-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
 <20211120043406.952350-18-philip@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Am Freitag, den 19.11.2021, 23:33 -0500 schrieb Philip McGrath:
> * guix/build-system/node.scm (lower): Add an optional #:libuv?
> argument to tell the build system to add the version of libuv
> used as an input to the #:node package as an additional implicit
> input, so that packages needing libuv always get the correct version.
Would it change something if we always had libuv as implicit input?  I
don't think it'd do much for closure size, but it might impact implicit
package search as proposed by my solution to the #:absent-dependencies
thing.





Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 07:44:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 20 02:44:38 2021
Received: from localhost ([127.0.0.1]:41548 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moL38-0005E9-Ea
	for submit <at> debbugs.gnu.org; Sat, 20 Nov 2021 02:44:38 -0500
Received: from mail-wr1-f67.google.com ([209.85.221.67]:38871)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liliana.prikler@HIDDEN>) id 1moL36-0005Du-AJ
 for 51838 <at> debbugs.gnu.org; Sat, 20 Nov 2021 02:44:36 -0500
Received: by mail-wr1-f67.google.com with SMTP id u18so22152571wrg.5
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 23:44:36 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=message-id:subject:from:to:date:in-reply-to:references:user-agent
 :mime-version:content-transfer-encoding;
 bh=mI4W1TU16O+PeaBqWs9z22++R8p4j7AU8Y6zc7ZSRnM=;
 b=IONoHOyEs2dwLpvXMiRIqQNAXKBnr2d+1vK99aI/98LdPs+44WtRx/gS5P1555jDS3
 WrlMiHm7LMNg+0nh62Qip+T+Sl/kurptOT9l/FQRxwtic4TFRfcul4KNABVD+0SjD1bE
 hhD3rIy8o+Gbzeog7LMQeBTwxpWYkVYR+AbwYjpaGR4Ih1EEacKgNhHL7CUYcgzElEK3
 7V7TVsVw5VH4jViIO0W68yC/62/SKI07fI1Bt0YbS/7v/fe1i3V/friFrJYpVnVpgBxs
 YYKdyXCey0oPA3QmyiPmvSTZ8N3oLcoTA2/IBjd9Wbbc9HgcW5VXFiUJb4LyFoitkNTx
 Kmqw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to
 :references:user-agent:mime-version:content-transfer-encoding;
 bh=mI4W1TU16O+PeaBqWs9z22++R8p4j7AU8Y6zc7ZSRnM=;
 b=bSKnGVLllhmZpPIJmJKkPHnx4127UZXdRAEKz3gdY7rIT50NWi44pzZnwV6uwFK1OL
 30CSs9ldg06w6qX6ADOhCog7lTGYseT3ZIt8/KACWghOYjejcKRT95gU+e8vA2hyoBrT
 k+AmXSDINKUQUaceNA4fKyZ71zdlrJwJuv83DPleUFhx9752aNAOpnqYUe0EbcBBysEI
 dcf7oxcu9sSJrClahweIAla+5ZmRLlCZE8EXal8Y6rC5QUbp+/B3BNQzOv07KjUZ4b+F
 ovU8tu3nfdV1x49vXAkJHD2GSO8m5WvaQg+HoO/guolwVK71HVVam4GANFfe4f9sjgkA
 e75Q==
X-Gm-Message-State: AOAM531mvvDhDHasqW8ffwlLBYDhCZunP9kc4tLKtYNCghAEi7S+B0Xp
 oOV4xomLFoeOb90oBFrz7fo=
X-Google-Smtp-Source: ABdhPJyJ/9bnOUDpbg00xZHr53Ar4SaFF0s6CJvuKu4AFSpJHNZqd8PL2qwT31+zCwZhxcnJUzz/3Q==
X-Received: by 2002:adf:f54c:: with SMTP id j12mr16028154wrp.20.1637394270701; 
 Fri, 19 Nov 2021 23:44:30 -0800 (PST)
Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
 [85.127.52.93])
 by smtp.gmail.com with ESMTPSA id o10sm2344090wri.15.2021.11.19.23.44.30
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 19 Nov 2021 23:44:30 -0800 (PST)
Message-ID: <f4f2a0c7a6c6c8c650a2aec6698ce28765b321eb.camel@HIDDEN>
Subject: Re: [bug#51838] [PATCH v2 10/26] gnu:
 node-llparse-builder-bootstrap: Use #:absent-dependencies.
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
To: Philip McGrath <philip@HIDDEN>, 51838 <at> debbugs.gnu.org
Date: Sat, 20 Nov 2021 08:44:29 +0100
In-Reply-To: <20211120043406.952350-10-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
 <20211120043406.952350-10-philip@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Am Freitag, den 19.11.2021, 23:33 -0500 schrieb Philip McGrath:
> gnu/packages/node.scm (node-llparse-builder-bootstrap)[arguments]:
> Add `#:absent-dependencies`. Stop deleting the `'configure` phase.
> Add a new phase `#:delete-package-lock` to remove the
> problematic "package-lock.json".
> ---
>  gnu/packages/node.scm | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
> index 98a51276e7..9d4903a8ca 100644
> --- a/gnu/packages/node.scm
> +++ b/gnu/packages/node.scm
> @@ -479,9 +479,21 @@ (define-public node-llparse-builder-bootstrap
>      (arguments
>       `(#:node ,node-bootstrap
>         #:tests? #f
> +       #:absent-dependencies
> +       `("@types/mocha"
> +         "@types/node"
> +         "mocha"
> +         "ts-node"
> +         "tslint"
> +         "typescript")
>         #:phases
>         (modify-phases %standard-phases
> -         (delete 'configure)
> +         (add-before 'configure 'remove-package-lock
> +           ;; Having package-lock.json seems to cause npm
> +           ;; to look for things on the internet in the configure
> phase,
> +           ;; even if we have them properly installed.
> +           (lambda args
> +             (delete-file-recursively "package-lock.json")))
I think a simple delete-file ought to work.  This should also be done
by configure or similar, compare cargo-build-system.





Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 07:43:25 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 20 02:43:25 2021
Received: from localhost ([127.0.0.1]:41543 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moL1x-0005Bp-4q
	for submit <at> debbugs.gnu.org; Sat, 20 Nov 2021 02:43:25 -0500
Received: from mail-wr1-f68.google.com ([209.85.221.68]:46595)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liliana.prikler@HIDDEN>) id 1moL1w-0005BT-2k
 for 51838 <at> debbugs.gnu.org; Sat, 20 Nov 2021 02:43:24 -0500
Received: by mail-wr1-f68.google.com with SMTP id u1so22099059wru.13
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 23:43:23 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=message-id:subject:from:to:date:in-reply-to:references:user-agent
 :mime-version:content-transfer-encoding;
 bh=npFrBIEmwZWaXMzaPbkyHXud5TakDgJydB5ST9Koym0=;
 b=musSsfZDqVr+RldhCesTJ6DhgQ7jt9rYY8v0QB7ktoj0A1Ky3tZCE04Jt0Yiwt1Z2t
 2BhvC0IqkY8ZIpxYvugkLWJfmo1AB7BMLfxcOi/lPTnrDDZ1t1ko05CKxokGEZhzIjCQ
 auoug7QNzTyMDtyIsOzqSwYC2qHJ6g5wNql5AoLznv+a6KyYPoWjWKudSeU6F3wT6+bk
 SdGma752w2JZcvQb+8C4T1PQhDsqrKthLoqqlJUVaAbNG8is+Trzu5VYNuv8U7PxcbjB
 Idis2e3ZALDkRddb5SqjIz1WdDIDygL07DP43c0hXCzabyBci9IW+wHYhJrMOw29pHFh
 G6lA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to
 :references:user-agent:mime-version:content-transfer-encoding;
 bh=npFrBIEmwZWaXMzaPbkyHXud5TakDgJydB5ST9Koym0=;
 b=soOcT9x4AZ3MNITQhYSQnthZU68KjYKJVvCU6tiHpbwqBQY2i+MBsxWizADqDTaGYG
 VFzKmZG6ylH7igvcr/Of2F9MdHYEIMv7CRvUz9zD2RYMoW4WZRjFJCIvI+XbNlPcH/mN
 21+FRrgaBa/0jyG049+DJfwRL2eZlAmHvQJHkX0fKhy9qYfGiOQQlnD0g3goaj+3m9ff
 HKK8nx0FnApM1x4heeyPUd/k/5CJX0KDyxXMMESWdWN/2Igx51CNMkdhhNnQ0crjzODh
 CK2bjDK/hODVTnaVQSAOdu7n4TLFTc7bhEzQaRfd8bX4prOV/NWbWdsiL+tAZmIKvBNP
 6syw==
X-Gm-Message-State: AOAM530mnx89/viH/6MexqA5/yvG4Si7E1yKH0H+T81+FQfqsAd81V9f
 tm6KEdHvRfc0m9ugsv4tkg4=
X-Google-Smtp-Source: ABdhPJzT34D+5X7pxQYYZjqfMjwdilIJY/l0WF7QtevhB8cgR3/LqMntj4EFUFTxdCYiMbJ5h9Recw==
X-Received: by 2002:a05:6000:18ac:: with SMTP id
 b12mr14389748wri.355.1637394198384; 
 Fri, 19 Nov 2021 23:43:18 -0800 (PST)
Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
 [85.127.52.93])
 by smtp.gmail.com with ESMTPSA id k15sm1913158wrx.53.2021.11.19.23.43.17
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 19 Nov 2021 23:43:18 -0800 (PST)
Message-ID: <5be9db7833c1a64d84ac29205ea39c93fff18d24.camel@HIDDEN>
Subject: Re: [bug#51838] [PATCH v2 06/26] gnu: node-semver-bootstrap: Use
 #:absent-dependencies.
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
To: Philip McGrath <philip@HIDDEN>, 51838 <at> debbugs.gnu.org
Date: Sat, 20 Nov 2021 08:43:17 +0100
In-Reply-To: <20211120043406.952350-6-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
 <20211120043406.952350-6-philip@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Am Freitag, den 19.11.2021, 23:33 -0500 schrieb Philip McGrath:
> gnu/packages/node.scm (node-semver-bootstrap)[arguments]: Add
> `#:absent-dependencies`. Stop deleting the `'configure` phase.
> ---
>  gnu/packages/node.scm | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
> index 0f67fe79c2..6c958eebec 100644
> --- a/gnu/packages/node.scm
> +++ b/gnu/packages/node.scm
> @@ -330,9 +330,8 @@ (define-public node-semver-bootstrap
>      (arguments
>       `(#:node ,node-bootstrap
>         #:tests? #f
> -       #:phases
> -       (modify-phases %standard-phases
> -         (delete 'configure))))
> +       #:absent-dependencies
> +       '("tap")))
>      (home-page "https://github.com/npm/node-semver")
>      (properties '((hidden? . #t)))
>      (synopsis "Parses semantic versions strings")
Not deleting configure SGTM, but recall my note about #:absent-
dependencies.





Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 07:41:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 20 02:41:56 2021
Received: from localhost ([127.0.0.1]:41536 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moL0W-00058M-J4
	for submit <at> debbugs.gnu.org; Sat, 20 Nov 2021 02:41:56 -0500
Received: from mail-wr1-f67.google.com ([209.85.221.67]:34481)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liliana.prikler@HIDDEN>) id 1moL0U-000584-3w
 for 51838 <at> debbugs.gnu.org; Sat, 20 Nov 2021 02:41:54 -0500
Received: by mail-wr1-f67.google.com with SMTP id d5so22182067wrc.1
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 23:41:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=message-id:subject:from:to:date:in-reply-to:references:user-agent
 :mime-version:content-transfer-encoding;
 bh=JAplla7tb92R7PlPcqHDAPhz/SJUhC38rC6ejofCWWg=;
 b=mBF/nXIhSgvpqQvIqyFOSxqeTqx9GFIqnhETeH0TzZiQWrYdk1rAsG3V6A4TUgkMuO
 QwWRaNiOHEHSmAO6LopBT3RPxw0AyC9O66oNA0tUblRrOaoZXyXe6ISWl8RJHMRKYPuM
 fj1osmChlZWMcVrr2KTwNiAEj0ggYr0pySfWC49mpZRbVpHNvTRrCumNESlqPHVaOPyv
 krzSLeDAh+oCHaI/QkXMCSPPGZBRFMlydRJnGMwiWfRM7UZRECiCG5je1FpPWqUGos35
 KUFZaA5Dt/i+ibfTNDW+bNcK3oAC6Bj+aTvDlVWhxrbZh8kSDcaym5OAkZqPsnltvWC/
 XFvw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to
 :references:user-agent:mime-version:content-transfer-encoding;
 bh=JAplla7tb92R7PlPcqHDAPhz/SJUhC38rC6ejofCWWg=;
 b=FREcAMqZmFTm6es+34/JEVKxWG8B/6rKhRaWUZ/Te/ENx6i5O8E5xsLQlQYX/5cHJq
 7iUC64chDyS0tQwLYe2pl+xa4GNo32R5hOzJldKuD07GudebtWGsxscD5RRzugcBXQfm
 NqIIn1TbFBlKzuAvx/qfL+NjyrnpRgDT0s50SbR1xmtbel8/rpPoqWHCmKwhA4HoYRwZ
 AvdLfGZsicZeBytI+RNCJaECXMxU/CgdFW73PHEGHn55KR7XtuAjJ9h0sRtIuLs6uPk7
 Cfj6uI5//g2xFdt7oBjRaMI+809Ci+W9hAgddTOHYFVxRrrZRfW+QxXSu+DT12EZhCjP
 D0Mw==
X-Gm-Message-State: AOAM530i+GITXa/mfT630Blib99Uhfn7ZXk9iz7eVJICayxhqTHMXG3P
 3x2IrS1+43qMs0lChY98n2M=
X-Google-Smtp-Source: ABdhPJxU6Ii6mBzm0IYxOEboyJwkUw8SzLgwzBjjx7VBKyhL6Y4yE6XsXTzWfaOWzEQTF21oky8UvQ==
X-Received: by 2002:a5d:6a4d:: with SMTP id t13mr15395488wrw.104.1637394108075; 
 Fri, 19 Nov 2021 23:41:48 -0800 (PST)
Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
 [85.127.52.93])
 by smtp.gmail.com with ESMTPSA id q24sm4703782wmj.21.2021.11.19.23.41.47
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 19 Nov 2021 23:41:47 -0800 (PST)
Message-ID: <8c07272b588fc059f3c445fe1f33c63cce8f31f1.camel@HIDDEN>
Subject: Re: [bug#51838] [PATCH v2 05/26] guix: node-build-system: Add
 #:absent-dependencies argument.
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
To: Philip McGrath <philip@HIDDEN>, 51838 <at> debbugs.gnu.org
Date: Sat, 20 Nov 2021 08:41:46 +0100
In-Reply-To: <20211120043406.952350-5-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
 <20211120043406.952350-5-philip@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi,

Am Freitag, den 19.11.2021, 23:33 -0500 schrieb Philip McGrath:
> Many of Guix's Node.js packages are built without some of the
> dependencies they specify in their "package-lock.json" files,
> either because we don't have them packaged yet (e.g. test
> utilities) or because we don't want them (e.g. to reduce the
> closure size). Previously, Guix package definitions would work
> around this situation by deleting the `'configure`
> phase (i.e. the initial `npm install`).
> 
> This commit adds an optional #:absent-dependencies argument to
> `node-build-system` to list Node.js packages that should be
> removed from the "package.json" file.Retaining the `'configure`
> phase avoids skipping checks for the dependencies that are
> intended to be present and other actions performed by `npm
> install`, such as automatically building native add-ons with
> `node-gyp` when the "gypfile" key is present.
> 
> [...]
This is a somewhat decent approach, but I wonder whether we could
improve this.  Does nodejs complain if a dependency exists in the code,
but is not present in the packages.json?

In the resolve-dependencies subprocedure, we could check whether we
have a matching input somewhere and only include the dependency if we
do.  WDYT?





Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 07:29:00 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 20 02:29:00 2021
Received: from localhost ([127.0.0.1]:41509 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moKo0-0004kl-M6
	for submit <at> debbugs.gnu.org; Sat, 20 Nov 2021 02:29:00 -0500
Received: from mail-wr1-f68.google.com ([209.85.221.68]:41753)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liliana.prikler@HIDDEN>) id 1moKny-0004kV-SC
 for 51838 <at> debbugs.gnu.org; Sat, 20 Nov 2021 02:28:59 -0500
Received: by mail-wr1-f68.google.com with SMTP id a9so22091510wrr.8
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 23:28:58 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=message-id:subject:from:to:cc:date:in-reply-to:references
 :user-agent:mime-version:content-transfer-encoding;
 bh=5W6sKBcd4PijG9yMdlKQ1HcIi9yx1ZpEBpZMwWqBSRA=;
 b=KcxSI1FVuL/qGLMJTosdRzO7AHw9xZ0a7/5FHOWl2DuZA4SPguq3U9il7Z7Vl1JZX5
 /LCB3KM8vgj8+mFVgTa2tzBaW4UxrKdP3fr0l6ARdgMXuNJK25AmZEAQohBu5PK+McgP
 IeX41OJv9o97tqj3SwWsuZ0GLfvgZ9LnJrqB0GqnLY62xkEXGGwAlkAM9JpTYAu6B7da
 Z/eEacKTXMJClNBmRtV4waFVXosXUmPorh6JwngZToLinjNMQyqIfcEGFADUAfhtaC4d
 3b3fpPGAAbnQGUAxUply+ILR3yJT13dZyruYb/3Gx0POdMloZ3YhzdQLYH1PctY0oQ1b
 UU1Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
 :references:user-agent:mime-version:content-transfer-encoding;
 bh=5W6sKBcd4PijG9yMdlKQ1HcIi9yx1ZpEBpZMwWqBSRA=;
 b=iC9y+U28Y6+Y7MFCKGMXXIs8zGS3RXphr4rlAu0YIUBAI0uDKqLp6XuC/lkq6jjjMp
 kimVBJ71pBDgVY8e7toNVUV1DjtJ5ypP3zJmXPwHUjxJGLWpJPw19IvIaDgiHr578u7T
 dvdLL48XND+zD+gHulEQTL4/kWA1yAGDC3eMZK1v55V/9NnwOAeq7kVuddXl2lRPwHLo
 c2y1wbBcjH38+Uqlk6WjuxpTVT55qL7GDXsgSBuPqeZIF95ECcfdKQN/yDBwGCjQH1dm
 SpQLi5u9Jvkw09a/XCt1rZf043LTrkZj9PTptfNzDPTGhB3w1Llsgz9nq5lsoaLynOlr
 fbrA==
X-Gm-Message-State: AOAM532I7T1HhzEabQjX4Vc4KTzgqm9pmkZyErk8lDbhi66cSWjsbJT8
 h0i830eJIOnQde4fAoPn23U=
X-Google-Smtp-Source: ABdhPJyOry0aTuDU5UodwokkXFvC9u7HOYO25NTk7PdP+O7p+5Rk7WPsXJmoyyCrgtciGJjnBzfmCQ==
X-Received: by 2002:a5d:6781:: with SMTP id v1mr14993118wru.239.1637393333056; 
 Fri, 19 Nov 2021 23:28:53 -0800 (PST)
Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
 [85.127.52.93])
 by smtp.gmail.com with ESMTPSA id l5sm2205010wrs.59.2021.11.19.23.28.52
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 19 Nov 2021 23:28:52 -0800 (PST)
Message-ID: <9da7a60ca57b06facf82142260fe44ba54096708.camel@HIDDEN>
Subject: Re: [PATCH 03/11] guix: node-build-system: Support compiling
 add-ons with node-gyp.
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
To: Philip McGrath <philip@HIDDEN>, 51838 <at> debbugs.gnu.org
Date: Sat, 20 Nov 2021 08:28:51 +0100
In-Reply-To: <cd45b636-33cd-880b-02a4-fbee854e8659@HIDDEN>
References: <20211114125830.45427-1-philip@HIDDEN>
 <20211114130409.49241-1-philip@HIDDEN>
 <20211114130409.49241-2-philip@HIDDEN>
 <48018e12484d19466d9c6f253a8d7ebeae93e947.camel@HIDDEN>
 <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <cd45b636-33cd-880b-02a4-fbee854e8659@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 51838
Cc: Pierre Langlois <pierre.langlois@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Am Samstag, den 20.11.2021, 00:10 -0500 schrieb Philip McGrath:
> On 11/19/21 23:26, Philip McGrath wrote> In v2 of this series (which 
> will follow this email)
> 
> I'm not sure what went wrong, but I, at least, received these
> patches 
> out of order. Let me know if I should resend them as v3. They are 
> definitely in the right order here: 
> https://gitlab.com/philip1/guix-patches/-/tree/guix-issue-51838-v2
> 
> -Philip
Our mumi frontend to debbugs should be able to deliver them to you as
one convenient mbox: 
https://issues.guix.gnu.org/issue/51838/patch-set/2

Cheers





Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 05:10:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 20 00:10:39 2021
Received: from localhost ([127.0.0.1]:41321 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moIe7-0000bL-4d
	for submit <at> debbugs.gnu.org; Sat, 20 Nov 2021 00:10:39 -0500
Received: from mail-qv1-f41.google.com ([209.85.219.41]:34411)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moIe5-0000b7-Bm
 for 51838 <at> debbugs.gnu.org; Sat, 20 Nov 2021 00:10:37 -0500
Received: by mail-qv1-f41.google.com with SMTP id i13so8571637qvm.1
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 21:10:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=message-id:date:mime-version:user-agent:subject:content-language
 :from:to:cc:references:in-reply-to:content-transfer-encoding;
 bh=8ETjUkt/+R/YazU/9KhMWMKEyPVSc7uWFrLfCDXaUAY=;
 b=i9Kw15/N8XytFQlqIGSNF98cgVYrZ4kgOCPoaNPx6JBGQd9gYsUIJIGcSlriCdMJC4
 kjuoaZm6xBorLNQHcJjInqfWiJOVkJmvrfAwGMsy7c9bFiHUjfirkcIKy8ht/PkrP0zu
 BiJDfLQce3/VIgIJiweQsPiMLEHwq6Lwz/ayfz1fkxArZgbfGuUffsWMWqAhRVuLBr/X
 NR8jDcWd2jJEjWzEoWU2TxgkbMPVj99lb96kbmmhDD4dk2sBm8wwfpPUKqP18OCOXf/f
 Nnj9eZ2JxmuBCJ3jw48+IhIhutmvEbd03uheP/Ki6js/ZPxrR8b+TDwB7QmtDHY2ZBib
 6Gnw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
 :content-language:from:to:cc:references:in-reply-to
 :content-transfer-encoding;
 bh=8ETjUkt/+R/YazU/9KhMWMKEyPVSc7uWFrLfCDXaUAY=;
 b=x1XNOu6T7JyO8RDM05At5S3j45ubyMSVMV/qe0H4AEB14epPP1VRQ71xkVfJCMwWtF
 5yPs6yBZBAxw1p4tHafP+qj0UxYCcqRuueHsHtGr6+bV6jm0nTghy4MTa8iFNQePRV3k
 zy2H9qbvpcX9/aIObg6LsmbBx8aGHBkEi8CGSC30y3PedX2Po0zraWoqLNRYTuIfz0Jt
 w+lb/RLmhycb+al43Vx9zfkCK5FcGsxje8kYZ94CKuEk3TSkzqQFWN3ZTO/7kzpnvUA9
 gyq8oURUShug5YO7gONqC6QGx8mpjbvhDDmEzhqzue8TgHL++CM/O/+BQ24NnlvTcF+I
 iRbA==
X-Gm-Message-State: AOAM533veFF1W20hhqGDv5Z26B2K/TbjSrIS3fLDr3uPKA7PeXlAqFuJ
 gfV6StgAAeOx65Jk95urjJZ6pQ==
X-Google-Smtp-Source: ABdhPJzBsFyxesf8gkYb1sFWoSa9utYwJ8LYV+2sjK1CfwU+R7hnaq8UTeLg5nXa2k4W+BkJS89lBw==
X-Received: by 2002:ad4:5bc4:: with SMTP id t4mr80383300qvt.3.1637385031897;
 Fri, 19 Nov 2021 21:10:31 -0800 (PST)
Received: from [192.168.45.37] (c-73-125-89-242.hsd1.fl.comcast.net.
 [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id o9sm1044868qtk.81.2021.11.19.21.10.31
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 19 Nov 2021 21:10:31 -0800 (PST)
Message-ID: <cd45b636-33cd-880b-02a4-fbee854e8659@HIDDEN>
Date: Sat, 20 Nov 2021 00:10:31 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.1
Subject: Re: [PATCH 03/11] guix: node-build-system: Support compiling add-ons
 with node-gyp.
Content-Language: en-US
From: Philip McGrath <philip@HIDDEN>
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>, 51838 <at> debbugs.gnu.org
References: <20211114125830.45427-1-philip@HIDDEN>
 <20211114130409.49241-1-philip@HIDDEN>
 <20211114130409.49241-2-philip@HIDDEN>
 <48018e12484d19466d9c6f253a8d7ebeae93e947.camel@HIDDEN>
 <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
In-Reply-To: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.6 (/)
X-Debbugs-Envelope-To: 51838
Cc: Pierre Langlois <pierre.langlois@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.4 (/)

On 11/19/21 23:26, Philip McGrath wrote> In v2 of this series (which 
will follow this email)

I'm not sure what went wrong, but I, at least, received these patches 
out of order. Let me know if I should resend them as v3. They are 
definitely in the right order here: 
https://gitlab.com/philip1/guix-patches/-/tree/guix-issue-51838-v2

-Philip




Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 04:35:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 23:35:30 2021
Received: from localhost ([127.0.0.1]:41278 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moI66-00080k-BP
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:35:30 -0500
Received: from mail-qk1-f174.google.com ([209.85.222.174]:41596)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moI57-0007sW-2P
 for 51838 <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:38 -0500
Received: by mail-qk1-f174.google.com with SMTP id t83so12349557qke.8
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 20:34:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=feDGPCoF9k7nqW0jkPTEDiu1HOZFsAcDjCrWloKVQvk=;
 b=HIaF6RyQkFk93zH2+cXt9G1evPrix5tgtIBtz3L4VSrLkKyiwjiNymRuXcaWZUIjH2
 bijSeXZ3S3mpgYqMIyEuBzbTA0QBudSP0wlj2aFHc4Gnt5BeMbbNIMmfKReQXaa4B4J+
 iyJ3Fcmg4Isva057a7XtOJuQNt6yPG9wwV7/aMpCX5B9ErkIO71uqDdOj7JAWJV16e27
 DMPeH8mM+BOEC9kLXzSlyhv4cayuqo3sneMsT9sxw34995ORDDgQTvAtmaxTqm0KHnkZ
 wLQEVHvx9X8qgVn7wt8f824x3KXoTiG9KhvhFoMwWMmMLh/MygHur3QrrHadq03/fHfJ
 sbrA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=feDGPCoF9k7nqW0jkPTEDiu1HOZFsAcDjCrWloKVQvk=;
 b=noOcXsu29RDOBBAdF+inVl7EDKYJMh7x1362773hRW8F1XsOLQ27ulbjql1LbAMAXm
 h7hOlG0xZShPpUcDyyfpVxcOoYiLrU01FrjqjQy3rriHVEQw0MRBJgymm7g5bqsuv0iL
 TDuBwt2YlfWlyXIJ7MWK0jqXCuaUt/ow5vR8h4F0FsO+tLJgkd8AGHHJCjTD+YnJjOmm
 QoL/bA4qYbGCQmdcty+QAt10lCrFxQymrF8AgMN2FeqdWLxzTjGGcgnnYcm0yyt1aOc9
 qsv9Ae+Zw3UQQFHskVaAoj/dZYAt1pjhXe2lUyacmsTeFNe8E+Mb2/MR8YwqVRXvj6El
 +QFg==
X-Gm-Message-State: AOAM5303OrNSjMvQrNpTEgyJ5DoZGlvlKs82G+4u4fYuP5LG9v5zEkuU
 b/v7JM5UKFgMu1JWV8chVKsn4FAX55/lgmgb
X-Google-Smtp-Source: ABdhPJw9u8j8gBGO3nBRPE8Xr0L/Xfyq25DZAzfk5q52LYZAK9SmKW+jAF8Q2qJi2/xMvgW5LlR9hA==
X-Received: by 2002:a37:8ac7:: with SMTP id
 m190mr31769331qkd.273.1637382863594; 
 Fri, 19 Nov 2021 20:34:23 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id o5sm881710qkl.50.2021.11.19.20.34.23
 for <51838 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 19 Nov 2021 20:34:23 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH v2 17/26] gnu: node-irc: Use #:absent-dependencies.
Date: Fri, 19 Nov 2021 23:33:57 -0500
Message-Id: <20211120043406.952350-17-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211120043406.952350-1-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
MIME-Version: 1.0
X-Debbugs-CC: Pierre Langlois <pierre.langlois@HIDDEN>
X-Debbugs-CC: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

gnu/packages/node-xyz.scm (node-irc)[arguments]: Add
`#:absent-dependencies`. Stop deleting the `'configure` phase.
---
 gnu/packages/node-xyz.scm | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
index 9646c14243..998d0a9a90 100644
--- a/gnu/packages/node-xyz.scm
+++ b/gnu/packages/node-xyz.scm
@@ -394,12 +394,12 @@ (define-public node-irc
                 "1ln4qfx20jbwg4cp8lp0vf27m5281z2sz16d15xd6150n26cbi4x"))))
     (build-system node-build-system)
     (arguments
-     '(#:tests? #f                      ; FIXME: tests depend on node-faucet
-       #:phases
-       (modify-phases %standard-phases
-         ;; The default configure phase fails due to various packages
-         ;; being missing, as we don't have them packaged yet.
-         (delete 'configure))))
+     '(#:absent-dependencies
+       `("ansi-color"
+         "faucet"
+         "jscs"
+         "tape")
+       #:tests? #f))
     (inputs
      `(("node-irc-colors" ,node-irc-colors)))
     (home-page "https://github.com/martynsmith/node-irc")
-- 
2.32.0





Information forwarded to liliana.prikler@HIDDEN, guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 04:35:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 23:35:30 2021
Received: from localhost ([127.0.0.1]:41276 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moI66-00080d-18
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:35:30 -0500
Received: from mail-qt1-f176.google.com ([209.85.160.176]:46741)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moI5C-0007tB-EX
 for 51838 <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:38 -0500
Received: by mail-qt1-f176.google.com with SMTP id m25so11393259qtq.13
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 20:34:34 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=FlWDIicS3Q3yKZ0NRTXIzyixRW10lYA3Fo1yCGKwnBw=;
 b=Z1Oo3Zk4HbA4gQCzJggRx7pLd/38ruJqwT1IrwaBxFFQts4nezLX7eerLBjcxnMoUC
 +rCIS0mcK/4/oSHFvofbh4hgDDe0dVD5LQcPRHQMpYu/c2brt5pwtTlBm7xAdph68mmx
 5Bx9i9K4he4nGGcRKb4/15ahJHNTU7kIYlXTFW3NuRKkDAOeeGw1BlLWdK15QxkDXOJC
 UzWKpfsT98x10Ig1puWY1C2Mj11AQMV8Ix1LzFKyvs+vl/wJDVab4wuKjkMVPQSTh72e
 w5IXY49vvt40iNqFMqWI8Pkz9XqPiOpCN2eeh/51owB0gWRrtvX6oHcHxQCiZ902tgyx
 fWPw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=FlWDIicS3Q3yKZ0NRTXIzyixRW10lYA3Fo1yCGKwnBw=;
 b=MEZVISFBtvgov+QXwDKQcaba1e7/C0a/tKrouhZiu6vXyUUZvydW0soa6vRtRdVR7j
 i2s3rpI8WuN+oC+yKgqm9zyZ8uftdkN16phLlKWt6aSsQty631jKhccSiRlcJ75CZRmV
 33wXijKYgH3Hkk0y6l00Mfh0Phl4Z4ukgm+wdu0g2CtZpnEfd2rsmR+A7izmw1+Sx/Qs
 nXh5RaDOBjRSGYuA19CiS7WeD8G41KWJX+lmUDLzasHtUISvo7e2UQVS5hxILW4XbInI
 mH1pPWUEYzJPpS6bqJQR9Hu9Aq56bRwmVTtvAvQC0zxHZBJhnY9W/sx0XSc6/KxVqcs5
 vjuA==
X-Gm-Message-State: AOAM532Bc0zk8lne+ef963R9EepHzRzSII9k1GjyV+w0BUKk51xTNH0A
 yf6mqDBJUHzWJtbNoI+Ymajq2KNcoQ6sRNRi
X-Google-Smtp-Source: ABdhPJxFBV1M9ghBI4LHTI/OaweXsZaPZ+THDXQZTzXx4y9kLI4F6D6Vl2k2BU32TQ34jjZ6YaCHbA==
X-Received: by 2002:a05:622a:144f:: with SMTP id
 v15mr11815837qtx.340.1637382868937; 
 Fri, 19 Nov 2021 20:34:28 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id v1sm976061qtw.65.2021.11.19.20.34.28
 for <51838 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 19 Nov 2021 20:34:28 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH v2 23/26] gnu: Add node-nan.
Date: Fri, 19 Nov 2021 23:34:03 -0500
Message-Id: <20211120043406.952350-23-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211120043406.952350-1-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
MIME-Version: 1.0
X-Debbugs-CC: Pierre Langlois <pierre.langlois@HIDDEN>
X-Debbugs-CC: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

* gnu/packages/node-xyz.scm (node-nan): New variable.
---
 gnu/packages/node-xyz.scm | 44 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
index 3e06413908..ed169c0778 100644
--- a/gnu/packages/node-xyz.scm
+++ b/gnu/packages/node-xyz.scm
@@ -553,3 +553,47 @@ (define-public node-irc
     (description "@code{node-irc} is an IRC client library for Node.js.
 It has functions for joining, parting, talking, and many other IRC commands.")
     (license license:gpl3+)))
+
+(define-public node-nan
+  (package
+    (name "node-nan")
+    (version "2.15.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/nodejs/nan")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "18xslh9va5ld872scrp5y4251ax9s3c6qh0lnl1200lpzbsxy7yd"))))
+    (build-system node-build-system)
+    (arguments
+     `(#:tests?
+       ;; tests need tap and other dependencies
+       #f
+       #:absent-dependencies
+       '("bindings"
+         "commander"
+         "glob"
+         "request"
+         "node-gyp" ;; would be needed for tests
+         "tap"
+         "xtend")))
+    (inputs
+     `(("readable-stream" ,node-readable-stream)))
+    (home-page "https://github.com/nodejs/nan")
+    (synopsis "Native Abstractions for Node.js")
+    (description "A header file filled with macro and utility goodness for
+making add-on development for Node.js easier across versions 0.8, 0.10, 0.12,
+1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15 and 16.
+
+Thanks to the crazy changes in V8 (and some in Node core), keeping native
+addons compiling happily across versions, particularly 0.10 to 0.12 to 4.0, is
+a minor nightmare.  The goal of this project is to store all logic necessary
+to develop native Node.js addons without having to inspect
+@code{NODE_MODULE_VERSION} and get yourself into a macro-tangle.
+
+This project also contains some helper utilities that make addon development a
+bit more pleasant.")
+    (license license:expat)))
-- 
2.32.0





Information forwarded to liliana.prikler@HIDDEN, guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 04:35:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 23:35:30 2021
Received: from localhost ([127.0.0.1]:41274 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moI65-00080W-Jo
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:35:29 -0500
Received: from mail-qt1-f178.google.com ([209.85.160.178]:38772)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moI5F-0007tV-3Z
 for 51838 <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:37 -0500
Received: by mail-qt1-f178.google.com with SMTP id 8so11466890qtx.5
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 20:34:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=WO8s9NCuN9JV8ZYvkNbzd1OfSKcdPXBimR5oLXIt/XY=;
 b=KSX8pCGLL5aol0E+9OHiXz15D3kbJZAeyNj7kEaglBQdr43O/VttyjEXfyPRi/a3ob
 rtXvLTLzi4eCBmw+YV+sFbv+R6D6xriyirdsvGwBryiJRonzzpxk+SvFRT2aY7H47neN
 Og/AjQlQdDS0/mvrI7XddQroGgfSyxlwvGur+NqYZ6bdG6tdGAWFal1wYR7fcUC28A8f
 e7nv+zIcDgL6SXYu4dr+lnQ+4QzlD6Pqn59O/Fgg/cfiKenTpxHaz5+f3P3fT877gZbN
 r8hYE5/KJzS+iW6u3elzY0F0xEsRu8akYDNRcoqwAaItet7cQOCgHSsUpGLvy/aBs6vu
 MQUQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=WO8s9NCuN9JV8ZYvkNbzd1OfSKcdPXBimR5oLXIt/XY=;
 b=Hs4EYnnfEKwKMqvGDrIZLKc9fRa6q1686jxHs/fP51kC6jMwag7DE7DNfY3+jcwuKz
 artlTftWyxTyRP1H1SNY27A5+vvVhQNEinQB7R8oWbk0M/m7a+2cvQQddbbN9iBZUTz9
 AB+4624W0dCN5p2mV0dJW3cyJnz/DcWfRzT2U2P4zSc9rQYTbs+ZzWGhZgN0q4FcKEaW
 t4YWUvR1DSa6n8DmFxouBRe6qrVkXH8X6FISkVn6W7qrT2IArd+iNe+TTA58+NGuCzJB
 KNnQaeMdg0O1pNBzyDhqI1DTSgkq/WD59t9VPbmrlVRQX81yQDs0zAmMyFekSa+q+4W5
 1Gww==
X-Gm-Message-State: AOAM531up8qzIU8hjnOefOaBcPNGdXIJB3KXdYNkwcTWW4LgM1DegNEh
 LgzoCKnkXut8y451/41cVY5WTn0T3W2IqAvq
X-Google-Smtp-Source: ABdhPJz9TTt4Gz5O7CRlB4A81JcI3OB95iJtT4FUd7ha9Z5+tLM2r/r4aB+GbsgEMWYDOTTXh2xQmg==
X-Received: by 2002:a05:622a:1705:: with SMTP id
 h5mr12273010qtk.331.1637382871589; 
 Fri, 19 Nov 2021 20:34:31 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id v125sm990885qki.63.2021.11.19.20.34.31
 for <51838 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 19 Nov 2021 20:34:31 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH v2 26/26] gnu: Add node-sqlite3.
Date: Fri, 19 Nov 2021 23:34:06 -0500
Message-Id: <20211120043406.952350-26-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211120043406.952350-1-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
MIME-Version: 1.0
X-Debbugs-CC: Pierre Langlois <pierre.langlois@HIDDEN>
X-Debbugs-CC: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.6 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.4 (/)

* gnu/packages/node-xyz.scm (node-sqlite3): New variable.
---
 gnu/packages/node-xyz.scm | 107 ++++++++++++++++++++++++++++++++++++--
 1 file changed, 104 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
index 60dbfc163c..a56281fe18 100644
--- a/gnu/packages/node-xyz.scm
+++ b/gnu/packages/node-xyz.scm
@@ -615,7 +615,8 @@ (define-public node-addon-api
        (sha256
         (base32 "1bhvfi2m9nxfz418s619914vmidcnrzbjv6l9nid476c3zlpazch"))))
     (inputs
-     `(("python" ,python)))
+     `(("python" ,python)
+       ("node-safe-buffer" ,node-safe-buffer)))
     (build-system node-build-system)
     (arguments
      `(#:absent-dependencies
@@ -630,8 +631,7 @@ (define-public node-addon-api
          "eslint-plugin-promise"
          "fs-extra"
          "path"
-         "pre-commit"
-         "safe-buffer")
+         "pre-commit")
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'skip-js-tests
@@ -660,3 +660,104 @@ (define-public node-addon-api
 @code{libuv} (included in a project via @code{#include <uv.h>}) are not
 ABI-stable across Node.js major versions.")
     (license license:expat)))
+
+(define-public node-sqlite3
+  (package
+    (name "node-sqlite3")
+    (version "5.0.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/mapbox/node-sqlite3")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0sbbzzli282nxyfha10zx0k5m8hdp0sf3ipl59khjb7wm449j86h"))
+       (snippet
+        (with-imported-modules '((guix build utils))
+          #~(begin
+              (use-modules (guix build utils))
+              ;; unbundle sqlite
+              '(for-each delete-file-recursively
+                         (find-files "deps" gzip-file?)))))))
+    (inputs
+     `(("node-addon-api" ,node-addon-api)
+       ("python" ,python)
+       ("sqlite" ,sqlite)))
+    (build-system node-build-system)
+    (arguments
+     `(#:tests?
+       #f ; FIXME: tests depend on node-mocha
+       #:modules
+       ((guix build node-build-system)
+        (guix build json)
+        (srfi srfi-1)
+        (ice-9 match)
+        (guix build utils))
+       #:libuv? #t
+       #:absent-dependencies
+       `(;; Normally, this is "built" using @mapbox/node-pre-gyp,
+         ;; which publishes or downloads pre-built binaries
+         ;; or falls back to building from source.
+         ;; Here, we patch out all of that and just build directly.
+         ;; It would be better to patch a version of @mapbox/node-pre-gyp
+         ;; that always builds from source, as Debian does,
+         ;; but there are a number of dependencies that need
+         ;; to be packaged or removed.
+         "@mapbox/node-pre-gyp"
+         "node-pre-gyp" ;; deprecated name still used in some places
+         "aws-sdk"
+         "@mapbox/cloudfriend"
+         ;; Confusingly, this is only a dependency beceuse of
+         ;; @mapbox/node-pre-gyp: with that removed,
+         ;; npm will use its own copy:
+         "node-gyp"
+         ;; These we'd like, we just don't have them yet:
+         "eslint"
+         "mocha")
+       #:phases
+       (modify-phases %standard-phases
+         ;; We need this step even if we do replace @mapbox/node-pre-gyp
+         ;; because the package expects to build its bundled sqlite
+         (add-before 'configure 'npm-config-sqlite
+           (lambda* (#:key inputs #:allow-other-keys)
+             (setenv "npm_config_sqlite" (assoc-ref inputs "sqlite"))))
+         (add-after 'patch-dependencies 'avoid-node-pre-gyp
+           (lambda args
+             (with-atomic-file-replacement "package.json"
+               (lambda (in out)
+                 (let* ((js (read-json in))
+                        (alist (match js
+                                 (('@ . alist) alist)))
+                        (scripts-alist (match (assoc-ref alist "scripts")
+                                         (('@ . alist) alist)))
+                        (scripts-alist
+                         ;; install script would use node-pre-gyp
+                         (assoc-remove! scripts-alist "install"))
+                        (alist
+                         (assoc-set! alist "scripts" (cons '@ scripts-alist)))
+                        (alist
+                         ;; causes `npm install` (our 'configure phase)
+                         ;; run the appropriate parts of node-gyp
+                         (assoc-set! alist "gypfile" #t))
+                        (binary-alist (match (assoc-ref alist "binary")
+                                        (('@ . alist) alist)))
+                        (js (cons '@ alist)))
+                   ;; compensate for lack of @mapbox/node-pre-gyp
+                   (setenv "GYP_DEFINES"
+                           (string-append
+                            "module_name="
+                            (assoc-ref binary-alist "module_name")
+                            " "
+                            "module_path="
+                            (assoc-ref binary-alist "module_path")))
+                   (write-json js
+                               out)))))))))
+    (home-page "https://github.com/mapbox/node-sqlite3")
+    (synopsis "Asynchronous, non-blocking SQLite3 bindings for Node.js")
+    (description
+     "The Node.js add-on @code{node-sqlite3} provides a set of a asynchronous,
+non-blocking bindings for SQLite3, written in modern C++ and tested for memory
+leaks.")
+     (license license:bsd-3)))
-- 
2.32.0





Information forwarded to liliana.prikler@HIDDEN, guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 04:35:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 23:35:29 2021
Received: from localhost ([127.0.0.1]:41272 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moI65-00080O-7S
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:35:29 -0500
Received: from mail-qv1-f48.google.com ([209.85.219.48]:38826)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moI5E-0007tJ-0B
 for 51838 <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:36 -0500
Received: by mail-qv1-f48.google.com with SMTP id a24so8535739qvb.5
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 20:34:35 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=GOfT5efxp3W1RoTTbqJYi7kpaw3hg0vmi3aqGO2Gvjc=;
 b=A2qh4WevwlhA8VavqPGECiWD1VhxuTVIX+SOO9jDJSR9CUtXQDhufY7H0cEZuYQvQw
 WkpUP5kwyfoRUJDuY30qNUAWG8PwJ9T6HXHdt0jNYiYfNnbnl4TIvh0BOgcd5UKzKdrW
 iyWsH/zoxFsBsBEgaR0Wkfgg0u6y3N9rsrqwBLl6d1ilFikftxYmHSkgIuwTPGHzMh0c
 buS+oS9zPec0uYChKsIdE7FuWg1CW1GYIuNveRfGWjxoL1Q0gFKBxbBehbyT72KnbQFy
 Sd9dNJxRZ1Q+r+tTqO7jAneaWffT72q4v6RRxH/o9Q75U1WnclISken9e9c+WJgfokFF
 iaug==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=GOfT5efxp3W1RoTTbqJYi7kpaw3hg0vmi3aqGO2Gvjc=;
 b=UnOdCQQWtoAvJ1FgmLvLL3Acauo/SLEXO5N4k+UYWYwpQKY5YhsX6feRVc0TH6aC2q
 Xm6eHIKtNlO4b4KHG/sLGHF0QDRXO1SBeEN9R0P0Tm5A2HpvUboY2tzmHEds534r9NBC
 q9n6bn2HAZk/ZcB8jhdDp+S4wiQbuHvUNTkF4NsWESH2KC5h7jfV4bwkerFFB5QO2tq6
 9ZTUNv+bM2+H8CnQcvcUopUwR3+GG55m85vhlMJIaR24p5EQwR26LxS2GEfafF++QRqv
 bq/SDUYpdm5MCccz4oSo/vWs85TvYdL7NcyRRd0VfDQvCizepEUaLx9gNNLLcSKngI8L
 GTng==
X-Gm-Message-State: AOAM530Cn4kHIZ5v9ztvuz5DZI4fhZZhQxITBgO8VXTnCL6t6g3a0ofp
 o118n/73WieUU445aaQbNO5xqp8GdMKKZU4V
X-Google-Smtp-Source: ABdhPJyke8fmg9SD61EFLJwrxFYmUsj1+owgKkN55uM1aVCl0G6qJGnaAkrvO540VcXcccrtgIGVmQ==
X-Received: by 2002:a05:6214:1cc2:: with SMTP id
 g2mr78979102qvd.56.1637382870616; 
 Fri, 19 Nov 2021 20:34:30 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id i23sm886364qkl.101.2021.11.19.20.34.30
 for <51838 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 19 Nov 2021 20:34:30 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH v2 25/26] gnu: Add node-addon-api.
Date: Fri, 19 Nov 2021 23:34:05 -0500
Message-Id: <20211120043406.952350-25-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211120043406.952350-1-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
MIME-Version: 1.0
X-Debbugs-CC: Pierre Langlois <pierre.langlois@HIDDEN>
X-Debbugs-CC: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

* gnu/packages/node-xyz.scm (node-addon-api): New variable.
---
 gnu/packages/node-xyz.scm | 63 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 63 insertions(+)

diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
index ed169c0778..60dbfc163c 100644
--- a/gnu/packages/node-xyz.scm
+++ b/gnu/packages/node-xyz.scm
@@ -22,6 +22,9 @@
 
 (define-module (gnu packages node-xyz)
   #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (gnu packages sqlite)
+  #:use-module (gnu packages python)
+  #:use-module (guix gexp)
   #:use-module (guix packages)
   #:use-module (guix git-download)
   #:use-module (guix build-system node))
@@ -597,3 +600,63 @@ (define-public node-nan
 This project also contains some helper utilities that make addon development a
 bit more pleasant.")
     (license license:expat)))
+
+(define-public node-addon-api
+  (package
+    (name "node-addon-api")
+    (version "4.2.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/nodejs/node-addon-api")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1bhvfi2m9nxfz418s619914vmidcnrzbjv6l9nid476c3zlpazch"))))
+    (inputs
+     `(("python" ,python)))
+    (build-system node-build-system)
+    (arguments
+     `(#:absent-dependencies
+       `("benchmark"
+         "bindings"
+         "clang-format"
+         "eslint"
+         "eslint-config-semistandard"
+         "eslint-config-standard"
+         "eslint-plugin-import"
+         "eslint-plugin-node"
+         "eslint-plugin-promise"
+         "fs-extra"
+         "path"
+         "pre-commit"
+         "safe-buffer")
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'skip-js-tests
+           ;; We can't run the js-based tests,
+           ;; but we can still do the C++ parts
+           (lambda args
+             (substitute* "package.json"
+               (("\"test\": \"node test\"")
+                "\"test\": \"echo stopping after pretest on Guix\"")))))))
+    (home-page "https://github.com/nodejs/node-addon-api")
+    (synopsis "Node.js API (Node-API) header-only C++ wrappers")
+    (description "This module contains header-only C++ wrapper classes which
+simplify the use of the C based Node-API provided by Node.js when using C++.
+It provides a C++ object model and exception handling semantics with low
+overhead.
+
+Node-API is an ABI stable C interface provided by Node.js for building native
+addons.  It is intended to insulate native addons from changes in the
+underlying JavaScript engine and allow modules compiled for one version to run
+on later versions of Node.js without recompilation.  The @code{node-addon-api}
+module, which is not part of Node.js, preserves the benefits of the Node-API
+as it consists only of inline code that depends only on the stable API
+provided by Node-API.
+
+It is important to remember that @emph{other} Node.js interfaces such as
+@code{libuv} (included in a project via @code{#include <uv.h>}) are not
+ABI-stable across Node.js major versions.")
+    (license license:expat)))
-- 
2.32.0





Information forwarded to liliana.prikler@HIDDEN, guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 04:35:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 23:35:29 2021
Received: from localhost ([127.0.0.1]:41270 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moI64-00080M-Rh
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:35:29 -0500
Received: from mail-qk1-f179.google.com ([209.85.222.179]:34743)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moI5D-0007tC-92
 for 51838 <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:35 -0500
Received: by mail-qk1-f179.google.com with SMTP id t6so12402723qkg.1
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 20:34:35 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=ksEw0RUVS1ywZrLGvlpoJrIb2+18MJYfN6pWtlV3BM4=;
 b=G00+cUOKXXo7IGQ1q1QGklDwPq2lYp8KWh9S4hEuKU0UtBlb3GzVrVUyTDlJ9+Rf6P
 ANJNqcLvaDiCL0xJXSMo40Vh+GnIf+XxK0pY8BXG5gQgBOvy/0eem7U6jgNWtqpfpmEw
 +6xwr3OtiF5FbqX2NL0n/AyUUQuDRdoenbiIgmjLxzvwlhp0ZFhR+HLTX08yX3Oi8cp9
 6Usx94ltf5StBYxF3gIUnTIhqam8/OOgglwvfdQwHCvjt+0qVqcLNtn1TUXIXJTUaVDf
 yZAysS192Tvnv83BOV4aaDYtYEAGTe4cZSTW170yBAyOqZ+a2gSGyTSDl+y8ghriiXlR
 EcrQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=ksEw0RUVS1ywZrLGvlpoJrIb2+18MJYfN6pWtlV3BM4=;
 b=hxdwX2vxsdL9q+UQI/CCHjZGhi1o/yiUah/mvKAukY45XCk98EtMmhCLQAC9hfcV1P
 F2fAFO8AmVwVG+6lJwNVWBXz7LA12UI54vixxMhXWRYQujvOmtH7VcKpBByHWhiIErtK
 Hs6YmGigADqc0tXmG2MXRlOyreSdZCXjgmxqpKogO50BuTJm7eAiKVpPIbi5O/GADMcH
 +Dqeo5GONDPHKLD/QRR7jCvsFpfRzAHHOzTL58wp6iyXCeZCNEezXwGdu4q0NEjB48KH
 gMrlTgd0pt8qqxEyC3p/gQ9EAkVjrSm2z/u4FA1esQotUMpiqioN+K8AlkvP8XoFWgyU
 jdBg==
X-Gm-Message-State: AOAM531DgSYdC1lkuFIp76RQ6cxug33g6J1Q2saYiYhho+yXq5Pyz6VN
 B8vJ2Q+uznvXvGtJBO75kwdUkVHLNIfRHDRK
X-Google-Smtp-Source: ABdhPJyXg1qmjwY3Hs7Q6YiGPgqfvbUhg12BlMc19Yef9dpBt2CrU2szXB4/JAdPR/v4QgiAfHKRvA==
X-Received: by 2002:a37:e206:: with SMTP id g6mr33909809qki.61.1637382869725; 
 Fri, 19 Nov 2021 20:34:29 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id s20sm924596qtc.75.2021.11.19.20.34.29
 for <51838 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 19 Nov 2021 20:34:29 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH v2 24/26] gnu: Add node-openzwave-shared.
Date: Fri, 19 Nov 2021 23:34:04 -0500
Message-Id: <20211120043406.952350-24-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211120043406.952350-1-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
MIME-Version: 1.0
X-Debbugs-CC: Pierre Langlois <pierre.langlois@HIDDEN>
X-Debbugs-CC: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

* gnu/packages/zwave.scm (node-openzwave-shared): New variable.
---
 gnu/packages/zwave.scm | 67 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 67 insertions(+)

diff --git a/gnu/packages/zwave.scm b/gnu/packages/zwave.scm
index 2019ec32df..8757ddecf2 100644
--- a/gnu/packages/zwave.scm
+++ b/gnu/packages/zwave.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2019 Ludovic Courtès <ludo@HIDDEN>
+;;; Copyright © 2021 Philip McGrath <philip@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -21,11 +22,14 @@ (define-module (gnu packages zwave)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix git-download)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system node)
   #:use-module (gnu packages)
   #:use-module (gnu packages base)
+  #:use-module (gnu packages node-xyz)
   #:use-module (gnu packages libusb)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages perl)
+  #:use-module (gnu packages python)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages xml))
 
@@ -88,3 +92,66 @@ (define-public open-zwave
 and respond to devices on a Z-Wave network, without requiring in-depth
 knowledge of the Z-Wave protocol.")
     (license license:lgpl3+)))
+
+(define-public node-openzwave-shared
+  (package
+    (name "node-openzwave-shared")
+    (version "1.7.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/OpenZWave/node-openzwave-shared")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1bqqy12dzqj05j9wsh50dmn84dddmhz0gjzvd3y20z4hpy1v8rsc"))))
+    (inputs
+     `(("open-zwave" ,open-zwave)
+       ("node-nan" ,node-nan)))
+    (native-inputs
+     `(("which" ,which)
+       ("python" ,python)
+       ("pkg-config" ,pkg-config)))
+    (build-system node-build-system)
+    (arguments
+     `(#:libuv?
+       #t
+       #:phases
+       (modify-phases %standard-phases
+         (replace 'build
+           (lambda* (#:key inputs #:allow-other-keys)
+             (define node-dir
+               (assoc-ref inputs "node"))
+             (invoke (string-append node-dir "/bin/npx")
+                     "--call"
+                     (string-append
+                      node-dir
+                      "/lib/node_modules/npm/bin/node-gyp-bin/node-gyp"
+                      " "
+                      "rebuild")))))))
+    (home-page "https://github.com/OpenZWave/node-openzwave-shared")
+    (synopsis "Node.js bindings for OpenZWave")
+    (description
+     "With the @code{node-openzwave-shared} package, you can easily control
+and manage your Z-Wave devices (lights, dimmers, blinds, you name it) from
+within Node.js applications.  This library also supports secure
+devices (e.g. door locks) that require encryption.  All widely used Node.js
+versions are supported with the help of @code{node-nan}.
+
+This library is currently able to:
+@itemize @bullet
+@item
+scan a Z-Wave network and report on connected devices;
+@item
+write values to Z-Wave nodes;
+@item
+monitor the network for changes;
+@item
+heal nodes and/or the network; and
+@item
+perform management tasks: add or remove nodes, replace failed nodes,
+manage their group associations, etc.
+@end itemize")
+    (license license:isc)))
-- 
2.32.0





Information forwarded to liliana.prikler@HIDDEN, guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 04:34:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 23:34:42 2021
Received: from localhost ([127.0.0.1]:41225 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moI5K-0007w1-F5
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:42 -0500
Received: from mail-qk1-f181.google.com ([209.85.222.181]:36586)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moI5B-0007t1-Bt
 for 51838 <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:33 -0500
Received: by mail-qk1-f181.google.com with SMTP id i9so12371535qki.3
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 20:34:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=RWVeazkP2j3GU7pQskCDix0dS4jhUU4VJh2ldcV7US8=;
 b=W6mKN8yIwktDM7IihGIMiBTMzALFdFWQTQ2yPHFywmQLGLs5KedfYEjoCPFxrPlO9y
 mA2ajgt6Mt2f9MdNK5BrMySFvwiy4b40pr185SHXceuc8eMiYUCpPZ17LvEbdgwHTQvl
 9poZXEMDMF07L6q3VELFlYeNbsgA/8qnqoRVX467ZIF4KMcdsZzBflMdK6Dmv647ij8u
 RpFttDoTmopIb2LlOz2idsFXrjKVcscpLclZlo6aBIWSN/qKOukefaLEeEpAInu23vAD
 c82ro9GY9vvmGG6UAjPlDSGDJPn96PuOfHzHF6jskALzV5J+VoKrsUjdCO6QIjmUhWjD
 zPPA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=RWVeazkP2j3GU7pQskCDix0dS4jhUU4VJh2ldcV7US8=;
 b=h8IaQ4UhM0jlcM0DmJjZ9i2lcmFLCCUG42yBCdkXHAe8/M/fUDCiCsnGP68FmNfy+z
 idtyhUBdZ9KJSrOlcEwS6LgQ03HeOWsh40coZGlo81JTMJry55y/2P5YPZmNX7tn/XlD
 nVqS2lk363ItDffQrt+Iij1AukpqKruQHghoFwpsaxbHbtJofuTQzfeGlC7VUAbRsgKd
 s/ngTDgdHFnbyNWhI4kExzFe8wDWxzOc4BRX/ainM70dJas7djw9q56XpivnN7AAVS8a
 PoF8+4heBvgirP3uzASJ8PDjY3PGNV10rzeXJtNdO6vwQCAAtuHI7hCSfbsEqC3lSvZp
 3nXA==
X-Gm-Message-State: AOAM532zdGeJJ/Uod9dcKkKHtOdMkDSi5YKHg+3gVdEeHAZoPYhy6RZd
 RaZfdIO/2syjL/Jpc1ydykinewNo2Cs38DgZ
X-Google-Smtp-Source: ABdhPJzrhibziejxPMYFUeKCKLGwAMK1xqkKw2ZOVlq2pfcpQaK2GJp1yq4d+SNQr/IdAIlactv63w==
X-Received: by 2002:a05:620a:1455:: with SMTP id
 i21mr20103668qkl.62.1637382867962; 
 Fri, 19 Nov 2021 20:34:27 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id de13sm974633qkb.81.2021.11.19.20.34.27
 for <51838 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 19 Nov 2021 20:34:27 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH v2 22/26] gnu: Add node-readable-stream.
Date: Fri, 19 Nov 2021 23:34:02 -0500
Message-Id: <20211120043406.952350-22-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211120043406.952350-1-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
MIME-Version: 1.0
X-Debbugs-CC: Pierre Langlois <pierre.langlois@HIDDEN>
X-Debbugs-CC: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

* gnu/packages/node-xyz.scm (node-readable-stream): New variable.
---
 gnu/packages/node-xyz.scm | 54 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)

diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
index c6cce64f7d..3e06413908 100644
--- a/gnu/packages/node-xyz.scm
+++ b/gnu/packages/node-xyz.scm
@@ -444,6 +444,60 @@ (define-public node-string-decoder
 Node-core.")
     (license license:expat)))
 
+(define-public node-readable-stream
+  (package
+    (name "node-readable-stream")
+    (version "3.6.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/nodejs/readable-stream")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0ybl4cdgsm9c5jq3xq8s01201jk8w0yakh63hlclsfbcdfqhd9ri"))))
+    (build-system node-build-system)
+    (arguments
+     `(#:absent-dependencies
+       `("@babel/cli"
+         "@babel/core"
+         "@babel/polyfill"
+         "@babel/preset-env"
+         "airtap"
+         "assert"
+         "bl"
+         "deep-strict-equal"
+         "events.once"
+         "glob"
+         "gunzip-maybe"
+         "hyperquest"
+         "lolex"
+         "nyc"
+         "pump"
+         "rimraf"
+         "tap"
+         "tape"
+         "tar-fs"
+         "util-promisify")
+       #:tests? #f))
+    (inputs
+     `(("node-util-deprecate" ,node-util-deprecate)
+       ("node-string-decoder" ,node-string-decoder)
+       ("node-inherits" ,node-inherits)))
+    (home-page
+     "https://github.com/nodejs/readable-stream")
+    (synopsis
+     "Node.js core streams for userland")
+    (description
+     "This package is a mirror of the streams implementations in Node.js.
+
+If you want to guarantee a stable streams base, regardless of what version of
+Node you (or the users of your libraries) are using, use
+@code{readable-stream} only and avoid the @code{stream} module in Node-core.")
+    (license license:expat)))
+
 (define-public node-irc-colors
   (package
     (name "node-irc-colors")
-- 
2.32.0





Information forwarded to liliana.prikler@HIDDEN, guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 04:34:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 23:34:42 2021
Received: from localhost ([127.0.0.1]:41223 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moI5K-0007vu-4R
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:42 -0500
Received: from mail-qk1-f173.google.com ([209.85.222.173]:37467)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moI5A-0007sv-K3
 for 51838 <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:32 -0500
Received: by mail-qk1-f173.google.com with SMTP id o63so12379397qkb.4
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 20:34:32 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=h92M6cwNYqgQ6JGJIf9VzYOMEG4L/N3bg93emHyzF0U=;
 b=ZvFK7oLNjM/C0yzqClLM8RR4sdIvsv4y84Am72BOsMBE/KiKgH7jskRqDUOnBjA5US
 dWHWJSzxDCZcjjToNIbEKSEskxTRtU91TNLZ5metuteW5Gd7CIEcWvmoesIp5CYNtykt
 5s8WlpWOfvStoLxWNHymvAzdg5t1GY3+bRt34DPKIDVE6N89wXeU3gn/Ez+VH6uPYWB/
 BVEy6hVLFcF/YPxBl0BJN0vBNAQsD2AgPuAVSR8ORlvlnYccqo+HByF4nUJ5Spk9gJPU
 r5BRWrlbvzv6F/qO2kOu9m8z5AHCO8+Wb3aw1kRO98/7d2ySAPUrLsV6ac2N34OkYWMq
 hfHg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=h92M6cwNYqgQ6JGJIf9VzYOMEG4L/N3bg93emHyzF0U=;
 b=cJ61uw/Moym4IryZZI52ZCPBKeopofhjE5tgHT5IPYnhWGBzWRFvP15tmPwUO5hVub
 FOny/dDEm74OlIVGQ9aahReKNy4kmX/KhEnOhWdFGwLTZNM1CmW5iFufbJXgSCepTvTU
 j07TS+SMbjvt2jokur/pcpNrQtwYjHuqLKqM169uOMId4fYsDFGqP7Gs0DXJPtEgLqZF
 0M/TQBHa4Pil/H4wBJcoIO46FUjHgnWgBoL9ms2MtwCS2WzzYBWL8bjKkrppf4SERsWm
 q/s+jKUWyxKk93c5ruiSmza3nf/AGw/i+6Yb2Ei6pZJiFh+t865XK5isTQN01af2zKMs
 3+HA==
X-Gm-Message-State: AOAM532lZ5zEKvhX2ORk1mvz1W7IEXOHdJTKtPGe20MM8eJa7cv9e1Vf
 71r+t5itXjwsJ0k76bQgVFNzu3U3citfOKLS
X-Google-Smtp-Source: ABdhPJxXPSnn3CTMvQDjNmwrWd2LZaEvtlqh9ZiwPx18NMseUVSnuAxdyuKWIIo2JX5iQmD6nbRO8A==
X-Received: by 2002:a05:620a:4f4:: with SMTP id
 b20mr33327636qkh.471.1637382867083; 
 Fri, 19 Nov 2021 20:34:27 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id p10sm998323qtw.97.2021.11.19.20.34.26
 for <51838 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 19 Nov 2021 20:34:26 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH v2 21/26] gnu: Add node-string-decoder.
Date: Fri, 19 Nov 2021 23:34:01 -0500
Message-Id: <20211120043406.952350-21-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211120043406.952350-1-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
MIME-Version: 1.0
X-Debbugs-CC: Pierre Langlois <pierre.langlois@HIDDEN>
X-Debbugs-CC: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

* gnu/packages/node-xyz.scm (node-string-decoder): New variable.
---
 gnu/packages/node-xyz.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
index 6dff0ddba5..c6cce64f7d 100644
--- a/gnu/packages/node-xyz.scm
+++ b/gnu/packages/node-xyz.scm
@@ -410,6 +410,40 @@ (define-public node-safe-buffer
 available.")
     (license license:expat)))
 
+(define-public node-string-decoder
+  (package
+    (name "node-string-decoder")
+    (version "1.3.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/nodejs/string_decoder")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0xxvyya9fl9rlkqwmxzqzbz4rdr3jgw4vf37hff7cgscxkhg266k"))))
+    (build-system node-build-system)
+    (arguments
+     '(#:absent-dependencies
+       '("tap"
+         "core-util-is"
+         "babel-polyfill")
+       ;; FIXME: Tests depend on node-tap
+       #:tests? #f))
+    (inputs
+     `(("node-safe-buffer" ,node-safe-buffer)
+       ("node-inherits" ,node-inherits)))
+    (home-page
+     "https://github.com/nodejs/string_decoder")
+    (synopsis
+     "Node.js core @code{string_decoder} for userland")
+    (description
+     "This package is a mirror of the @code{string_decoder} implementation in
+Node-core.")
+    (license license:expat)))
+
 (define-public node-irc-colors
   (package
     (name "node-irc-colors")
-- 
2.32.0





Information forwarded to liliana.prikler@HIDDEN, guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 04:34:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 23:34:42 2021
Received: from localhost ([127.0.0.1]:41221 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moI5J-0007vn-Oh
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:42 -0500
Received: from mail-qt1-f178.google.com ([209.85.160.178]:33580)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moI59-0007sr-NL
 for 51838 <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:31 -0500
Received: by mail-qt1-f178.google.com with SMTP id n15so11505813qta.0
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 20:34:31 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=pLwK59KfKzSeilA++Kp0Cllh4FKRX2jv0tBtW2Jiti8=;
 b=a5sBjs27NBVchqsZu2CFswcMq9dLTYp9SaUgeuQaJP+eStmpgcXPKTKpnx1isiFxaW
 J36MBht5Zx05HzNYytB16wqN+DRLgwam8LjywvqSOa7JhG/wAKxNMIN4yI7cSpUl0Lo8
 VzhJXQfRdKAoSdBf3yoWcaKyIeq/9BfTNaJ86f+n9l6fdVpKlwtj37gLkNB4JB/aM0yq
 MqpGEYn/9PJHJbXV6ZITa2FAlowd9eKoPLSFrojVLqO8mu2VSmTneVwRnQsaDixiu3k7
 PS4+9AT2SRVqXqoKtv1BgCGI557VCVaDjWBoNlfYfzObbKmdHDZKGxZIE6OhtdiHbsrN
 ydnw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=pLwK59KfKzSeilA++Kp0Cllh4FKRX2jv0tBtW2Jiti8=;
 b=JpooDk4EiRTljjWXuDvz0fC1uodGL2277WbizVv4m14S2lSriD9JyW70z3AoH02bUl
 xNYGvIApB5Z3T+YdBfyPEX0B+0sCM9YTCbjLc+BFki0MpPuVskO3Y3u2uXyZX2UtRCwX
 H0rGGJt86l+rWyqM/R/Y24ISdn1fsC/T5nS1PzjOyn2lRujIXXofqWOJCmJrFEVjsXxr
 FhcD2bo2qL84qlU339hkN9sVFFu583VHQz2xkmkd/dEesz3MJ4DV2w0trME8c2Y90QS6
 rq/8gFN7WgtVM4eo680no5AsWMB89wo3BHRmoX+bGwOYzOtqE+pyKvzFSaE1AU1MF4xV
 yjzg==
X-Gm-Message-State: AOAM531voSkVWuK9lMH96Uzu+u0pIV6x4Zw5Fzm5hyf8bdtkFyABTXi6
 t2tkNO2/3Wn0z8iHAQiRcXLF8AOZDMS5zxte
X-Google-Smtp-Source: ABdhPJx257mEKXcGQUoFcGhgXLrTN4eDim04odXgKdO48JMjdwMCFyiEJhh+/9Zjq8fQxLagojftJA==
X-Received: by 2002:a05:622a:11d0:: with SMTP id
 n16mr12094382qtk.111.1637382866203; 
 Fri, 19 Nov 2021 20:34:26 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id m15sm924432qkp.76.2021.11.19.20.34.25
 for <51838 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 19 Nov 2021 20:34:26 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH v2 20/26] gnu: Add node-safe-buffer.
Date: Fri, 19 Nov 2021 23:34:00 -0500
Message-Id: <20211120043406.952350-20-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211120043406.952350-1-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
MIME-Version: 1.0
X-Debbugs-CC: Pierre Langlois <pierre.langlois@HIDDEN>
X-Debbugs-CC: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.6 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.4 (/)

* gnu/packages/node-xyz.scm (node-safe-buffer): New variable.
---
 gnu/packages/node-xyz.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
index 9d8bf27852..6dff0ddba5 100644
--- a/gnu/packages/node-xyz.scm
+++ b/gnu/packages/node-xyz.scm
@@ -382,6 +382,34 @@ (define-public node-inherits
 @code{inherits()}.")
     (license license:isc)))
 
+(define-public node-safe-buffer
+  (package
+    (name "node-safe-buffer")
+    (version "5.2.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/feross/safe-buffer")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0r26m0nl41h90ihnl2xf0cqs6z9z7jb87dl5j8yqb7887r9jlbpi"))))
+    (build-system node-build-system)
+    (arguments
+     '(#:absent-dependencies
+       '("tape"
+         "standard")
+       #:tests? #f))
+    (home-page
+     "https://github.com/feross/safe-buffer")
+    (synopsis "Safer Node.js Buffer API")
+    (description "A safe drop-in replacement the Node.js @code{Buffer} API
+that works in all versions of Node.js, using the built-in implementation when
+available.")
+    (license license:expat)))
+
 (define-public node-irc-colors
   (package
     (name "node-irc-colors")
-- 
2.32.0





Information forwarded to liliana.prikler@HIDDEN, guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 04:34:41 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 23:34:41 2021
Received: from localhost ([127.0.0.1]:41219 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moI5J-0007vd-6d
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:41 -0500
Received: from mail-qk1-f177.google.com ([209.85.222.177]:43687)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moI58-0007sj-PQ
 for 51838 <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:31 -0500
Received: by mail-qk1-f177.google.com with SMTP id 193so12338812qkh.10
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 20:34:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=TkzUiJnNGw9ur1c48y1bhJnpwmx0e71utk5vh1CJDY4=;
 b=giHkzWWiWMZCJqQpz6go9hSJdgJzEHl6ltud5sHdgJLb+M+Rm2cnoV4892EbP37JtR
 Q8McW1GeNBroTiefn/9BG5fhdSAyS76+iDrPmlyV8QJB/lnZv8OOtAEB70e49DONbBFl
 rG8pgtyXxgH9QBxKYqZP9X53xVKkbdkiOyrQTgWDtSFAlQNO8FvZH0qMVae3I7yyK58/
 jAybYQ53s+JVsfvviMwhxHvTYgX/aRKaIvR40ocHlzko5aR/1F6EgOBSZxKQ03m5fGIx
 O7M+lL6y7wsB6Rp3kIfklvTBJT4vjdLUwXMNTmtMm4cny4UV1zD53fGZtMrbAp4gcX94
 xv3w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=TkzUiJnNGw9ur1c48y1bhJnpwmx0e71utk5vh1CJDY4=;
 b=1To668jwHezHylpUV/Vdzv31Z2peNzs6YLwunsldGr7LJe9AIQhGPmx8lnqcNjdsre
 AqoMfjQkSHOOAGxoEmVgOKyoQ07ue59c1IK2LZZfQ16D3YTjMxChAkTQJ4LO658cqoVb
 f5ZUKO6lfeUAJwmDM6yGd9oQATgkDx/H2/6q3c+QrQ3pltznUabP8eXPuP7ym8WRjTY7
 8Hav/hdcD58Iil0bukt39Eh0g7qRGzB+MG4Deu7icPqoiz1jrRtdbQ2e3N4FBaxdQpoN
 JRWAJp/4u4zHbI0lQMNAtI3fUW7kN59e7C94933k7vOHtRWac4YORfSAkjWKGSEVnPtc
 uMJg==
X-Gm-Message-State: AOAM530C0y64V+StgvkZgHQB1sfgdZUCPl2MfrgUfTYVOrbrh4JHabmQ
 nBZjAbTnbE4ClMX/HedBh3tTbc8UTICsPuDj
X-Google-Smtp-Source: ABdhPJxRzXIPXFZtHgDI2DsgO4FNmm9M1yyDF0EUcTbZN0v/wZjCrpO4d5lwKpbC2KGHchlynXqVhw==
X-Received: by 2002:a37:a014:: with SMTP id j20mr33014572qke.438.1637382865353; 
 Fri, 19 Nov 2021 20:34:25 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id y20sm936473qkj.24.2021.11.19.20.34.25
 for <51838 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 19 Nov 2021 20:34:25 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH v2 19/26] gnu: Add node-inherits.
Date: Fri, 19 Nov 2021 23:33:59 -0500
Message-Id: <20211120043406.952350-19-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211120043406.952350-1-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
MIME-Version: 1.0
X-Debbugs-CC: Pierre Langlois <pierre.langlois@HIDDEN>
X-Debbugs-CC: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

* gnu/packages/node-xyz.scm (node-inherits): New variable.
---
 gnu/packages/node-xyz.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
index 998d0a9a90..9d8bf27852 100644
--- a/gnu/packages/node-xyz.scm
+++ b/gnu/packages/node-xyz.scm
@@ -3,6 +3,7 @@
 ;;; Copyright © 2020 Giacomo Leidi <goodoldpaul@HIDDEN>
 ;;; Copyright © 2021 Noisytoot <noisytoot@HIDDEN>
 ;;; Copyright © 2021 Charles <charles.b.jackson@HIDDEN>
+;;; Copyright © 2021 Philip McGrath <philip@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -352,6 +353,35 @@ (define-public node-once
 if desired.")
     (license license:isc)))
 
+(define-public node-inherits
+  (package
+    (name "node-inherits")
+    (version "2.0.4")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/isaacs/inherits")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0cpsr5yqwkxpbbbbl0rwk4mcby6zbx841k2zb4c3gb1579i5wq9p"))))
+    (build-system node-build-system)
+    (arguments
+     '(#:absent-dependencies
+       '("tap")
+       ;; FIXME: Tests depend on node-tap
+       #:tests? #f))
+    (home-page
+     "https://github.com/isaacs/inherits")
+    (synopsis
+     "Browser-friendly inheritance Node.js")
+    (description
+     "Browser-friendly inheritance fully compatible with standard Node.js
+@code{inherits()}.")
+    (license license:isc)))
+
 (define-public node-irc-colors
   (package
     (name "node-irc-colors")
-- 
2.32.0





Information forwarded to liliana.prikler@HIDDEN, guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 04:34:41 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 23:34:41 2021
Received: from localhost ([127.0.0.1]:41217 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moI5I-0007vU-NT
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:41 -0500
Received: from mail-qv1-f48.google.com ([209.85.219.48]:40928)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moI57-0007sd-RT
 for 51838 <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:30 -0500
Received: by mail-qv1-f48.google.com with SMTP id b11so8515796qvm.7
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 20:34:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=+M7BkILfvaDvHhFF7GYGYSQ2zdft7t4HqBqhL66EJMM=;
 b=IlbqRM7Ir+EgmPyCcb5wQxvAn69io97qsd52ASUhS6x44xWnFyQj1Km0YlomjxJW45
 xjTn/1w6gewYSq46YU31sU9fzUbcL8KORj18bDiS5N6uLUF/Uhjh04XhRgeiZ6RBc6lt
 +V98DNaEQYlT8wja3+y0zvLh/49m6LfGsAPdKwb1s2rgtklgABvWVtiJZb5QbhRzydeK
 Q5AsLamYL7cP/4davkm0NRG2WIKq6cwM/PqFfPt6mYt2OCc8DucBqQK0Pc5e5h/o9JLs
 qBeXTIDRZWhQEjBZOIr44ehCt35kk2JsgSXYqf3gTewhRWMC2F0x3XdDGXKA+jPXRgKL
 hWJA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=+M7BkILfvaDvHhFF7GYGYSQ2zdft7t4HqBqhL66EJMM=;
 b=0OTo4VHHv6HYbZXOF451OvbxIFXiTJ64w/1RjwlV6tRroBgaPutpuZRDPZOC7ixLQZ
 OSpgfj6207r6xh0yGyPneQUW5g6Wf5pveGt7pdEgwy6aLC3X384HL+8YbJ8uSbOffL3T
 zHFMOIX1RG5RjhaHEe6yosbIHB54nkGpQad2MyAE0PEsixdRVqK9Yah4MwZr8JMdruDM
 r6jMc4yfTSP+dgAIrwcG+NSREnZrWa/z8QSvAa8ZVwKZOUMJ3Ls1XHydrBevdo2bJ7G2
 Md9PWaVY+Z7CFDCbwVy++Q215O6qas3l6afA1VJhL2BOQskJONTDjDZ6POgN2jDdSUGv
 dsbQ==
X-Gm-Message-State: AOAM530PaKCtmXPzTmEvj8u1pZvpVts3KRLhv5FXmua0fkaL4iwd2VbR
 GM04g6ByYd6hccWf2JuLJxB+ar3jS9RDvhU0
X-Google-Smtp-Source: ABdhPJzDqMZl+4S4/4dif1/jPOMuXr2sxfNrCuvfCmZZZAkByC0lkF+8iP62keT7lfMMwH39fP0NTg==
X-Received: by 2002:a05:6214:2342:: with SMTP id
 hu2mr71958966qvb.9.1637382864405; 
 Fri, 19 Nov 2021 20:34:24 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id bq36sm932220qkb.6.2021.11.19.20.34.24
 for <51838 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 19 Nov 2021 20:34:24 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH v2 18/26] guix: node-build-system: Add optional #:libuv?
 argument.
Date: Fri, 19 Nov 2021 23:33:58 -0500
Message-Id: <20211120043406.952350-18-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211120043406.952350-1-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
MIME-Version: 1.0
X-Debbugs-CC: Pierre Langlois <pierre.langlois@HIDDEN>
X-Debbugs-CC: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

* guix/build-system/node.scm (lower): Add an optional #:libuv?
argument to tell the build system to add the version of libuv
used as an input to the #:node package as an additional implicit
input, so that packages needing libuv always get the correct version.
---
 guix/build-system/node.scm | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/guix/build-system/node.scm b/guix/build-system/node.scm
index 75ae34508f..f83a7f64ce 100644
--- a/guix/build-system/node.scm
+++ b/guix/build-system/node.scm
@@ -1,6 +1,8 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2016 Jelle Licht <jlicht@HIDDEN>
 ;;; Copyright © 2019 Timothy Sample <samplet@HIDDEN>
+;;; Copyright © 2021 Pierre Langlois <pierre.langlois@HIDDEN>
+;;; Copyright © 2021 Philip McGrath <philip@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -44,12 +46,13 @@ (define (default-node)
 (define* (lower name
                 #:key source inputs native-inputs outputs system target
                 (node (default-node))
+                (libuv? #f)
                 (absent-dependencies ''())
                 #:allow-other-keys
                 #:rest arguments)
   "Return a bag for NAME."
   (define private-keywords
-    '(#:source #:target #:node #:inputs #:native-inputs))
+    '(#:source #:target #:node #:libuv? #:inputs #:native-inputs))
 
   (and (not target)                    ;XXX: no cross-compilation
        (bag
@@ -59,10 +62,18 @@ (define private-keywords
                               `(("source" ,source))
                               '())
                         ,@inputs
-
                         ;; Keep the standard inputs of 'gnu-build-system'.
                         ,@(standard-packages)))
          (build-inputs `(("node" ,node)
+                         ;; Many packages with native addons need
+                         ;; libuv headers. The libuv version must
+                         ;; be exactly the same as for the node
+                         ;; package we are adding implicitly,
+                         ;; so we take care of adding libuv, too.
+                         ,@(if libuv?
+                               `(("libuv" ,@(assoc-ref (package-inputs node)
+                                                       "libuv")))
+                               '())
                          ,@native-inputs))
          (outputs outputs)
          (build node-build)
-- 
2.32.0





Information forwarded to liliana.prikler@HIDDEN, guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 04:34:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 23:34:40 2021
Received: from localhost ([127.0.0.1]:41215 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moI5I-0007vN-EV
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:40 -0500
Received: from mail-qv1-f52.google.com ([209.85.219.52]:39557)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moI56-0007sP-5e
 for 51838 <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:28 -0500
Received: by mail-qv1-f52.google.com with SMTP id gu12so8518777qvb.6
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 20:34:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=ojMLjz/jyFKXXb+hBPomTkZw3w967K/vtlSskEGKkIE=;
 b=VXTwT6F1zUaTRWa2ol9IsBVnofXnwMJ6Eb3gxyl1iOaPEiqtLXczwpderWO7EehQwy
 eUNp8kAnNB4HAK9QRoWeiLYowPloeZBjslqc9a3ikVoCbjFCXh0jnD+j4eZ6c/X21Lx0
 9zC+G9jXNl+Id969d+Hb10qwCgB95SQ8PVkPiemmiOUxCehPi2vJwfVb76D+0LHhiTgd
 SR9UgqzFQ41jf0elbc5FPVtLsoG7Kq0yAuZ8w6JWBKnbJGyIO2Img7ORu5cNddv2f2pJ
 24BRGZA5N3uWTQnEJM90qD/da+CvmmQalwfuWx1dzMn1YSnZrdEaXoUuCWSxpbF/cTYE
 R2rQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=ojMLjz/jyFKXXb+hBPomTkZw3w967K/vtlSskEGKkIE=;
 b=0APXGzQh7aazzIrQY4kLffG3SnQ7Pzqsyx+VXDkHCwRbirv9A+9U6fN9GsfJ2btTDD
 5Xuk28NMufI9dOL5Xa+r2gN9UzSV10KTT1BOoANqnnyEW50Hf6T1N4bZxC4juvdCzIkR
 qiKXIabGChYea9w0a+mxmUKrQI/HJw6UXQ44pduT0azd3R8CNjb23KQJFpaQS6Bx0F8C
 1s+/RUK0UsOVMF/p89yyr4LE4fSIh83kM4ER1C2D1JmLeLzPpK6cUPeDlIxmPxwEhN6y
 Q4A+y8o222Vv9UNAsQHubShumBMQ6ONbD33iAe7RFBKj+d08UMnuk/MKGApLxyvjMLyU
 uX7w==
X-Gm-Message-State: AOAM5333HkSYE3MFnGz8+0+w7MGMrxeWfB5I2v58UVPEn6Z7lucdzrrS
 MiU5WFNkF7xo6X6ae1fEYRffQ5JdGAEESm/l
X-Google-Smtp-Source: ABdhPJzKQ5CTzh9E+TC8BIc2Hl6MY/VkskNBTeAWgE321EmKsky1+EHHziyblIP0fUnXm1iRGswMnQ==
X-Received: by 2002:a05:6214:5195:: with SMTP id
 kl21mr80469822qvb.42.1637382862697; 
 Fri, 19 Nov 2021 20:34:22 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id i6sm948150qti.40.2021.11.19.20.34.22
 for <51838 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 19 Nov 2021 20:34:22 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH v2 16/26] gnu: node-irc-colors: Use #:absent-dependencies.
Date: Fri, 19 Nov 2021 23:33:56 -0500
Message-Id: <20211120043406.952350-16-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211120043406.952350-1-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
MIME-Version: 1.0
X-Debbugs-CC: Pierre Langlois <pierre.langlois@HIDDEN>
X-Debbugs-CC: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

gnu/packages/node-xyz.scm (node-irc-colors)[arguments]: Add
`#:absent-dependencies`. Stop deleting the `'configure` phase.
---
 gnu/packages/node-xyz.scm | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
index eb071320cd..9646c14243 100644
--- a/gnu/packages/node-xyz.scm
+++ b/gnu/packages/node-xyz.scm
@@ -367,12 +367,10 @@ (define-public node-irc-colors
                 "0q3y34rbnlc55jcakmdxkicwazyvyph9r6gaf6hi8k7wj2nfwfli"))))
     (build-system node-build-system)
     (arguments
-     '(#:tests? #f                      ; FIXME: tests depend on node-istanbul
-       #:phases
-       (modify-phases %standard-phases
-         ;; The default configure phase fails due to various packages
-         ;; being missing, as we don't have them packaged yet.
-         (delete 'configure))))
+     '(#:absent-dependencies
+       `("istanbul"
+         "vows")
+       #:tests? #f))
     (home-page "https://github.com/fent/irc-colors.js")
     (synopsis "Node.js module providing color and formatting for IRC")
     (description "@code{node-irc-colors} is a Node.js module that
-- 
2.32.0





Information forwarded to liliana.prikler@HIDDEN, guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 04:34:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 23:34:40 2021
Received: from localhost ([127.0.0.1]:41213 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moI5I-0007vE-27
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:40 -0500
Received: from mail-qv1-f48.google.com ([209.85.219.48]:45860)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moI55-0007sH-5c
 for 51838 <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:27 -0500
Received: by mail-qv1-f48.google.com with SMTP id s9so8505631qvk.12
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 20:34:27 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=Zv0Max/Z0M9eGARhkXdFbG7nRPnZrOIPjGOnHvaOK6E=;
 b=bsS06aMv1gyMb2e+pIkZwEA7Ub/K9G3ks2qHe64E+7biy4RdFSQDSsziASFQU4Prd9
 fZNuE2ABS71H6BVknPovfR6BUEgLbSb9UQKShuC31Tt5dNnaUMbX39gSUdaLFkhazMc/
 mWImi7XEGx6nkwlcy1QP1Vdlgj8I6EPqiSs6nFObOLx9p3Nh+YVBofmm6LMc64bvxIUq
 yF1yM0D9DCOWGHps7CCZJo4ha31YGTEAyFrqOozLBFI0Wc/tApHoEx7r/JvUcfXNAGGc
 JjJnOZ6FeH3E87m5Uok/5MADcAJ+v3tmy3nO2KquuWU2fQ55YoEAFfAixA4L7w0qUgUv
 OkPw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=Zv0Max/Z0M9eGARhkXdFbG7nRPnZrOIPjGOnHvaOK6E=;
 b=PDXdUoB3aIVsYcSFcWS3Lcy6vwSsHqcKgFeubgpPp8+RNW1YrXtaSb1w5+tkOL9qU/
 lNKK7nvuQhXQpcGmdhJiC/N5vs6fFxj5IukDlNu3zgPNeM8zqiuILhFaLKJ4AESdXgxu
 WP7lgy8Dl/Szff97AN2yJGfMfDWCh35ZQWewXFDJVJ47dKsfkckDM6k+FVyHYCZQlL0S
 tACFVWUhzKKGeXmwryPd6IssgJv5YrQiv/tsrsM33NpgsdPwMFQHTrc8pgdiMdva0R9m
 w2+zbFJmBsDxJUBvkbL8NiR58AUnYRMWkSIGN8N4ZR+gEi6sV9Cep03ZPpw0NvfY1YSB
 8JYQ==
X-Gm-Message-State: AOAM533897ZKEQVw2zBSmZC5dmybr7dI1FXRlglxFEdRs7TSGEnPjR1a
 P4o2asM0vwTk/SaDIFIdl2WKD4+/Hc6GEAX9
X-Google-Smtp-Source: ABdhPJx3hn+sWchPaAnUArMi0e8yGTsMF/KcRCm5po8jsmnQsua+wiPdj7E+ydrLbyy6uynSBr01SA==
X-Received: by 2002:ad4:4f2e:: with SMTP id fc14mr80283896qvb.66.1637382861748; 
 Fri, 19 Nov 2021 20:34:21 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id y8sm1051711qko.36.2021.11.19.20.34.21
 for <51838 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 19 Nov 2021 20:34:21 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH v2 15/26] gnu: node-once: Use #:absent-dependencies.
Date: Fri, 19 Nov 2021 23:33:55 -0500
Message-Id: <20211120043406.952350-15-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211120043406.952350-1-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
MIME-Version: 1.0
X-Debbugs-CC: Pierre Langlois <pierre.langlois@HIDDEN>
X-Debbugs-CC: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

gnu/packages/node-xyz.scm (node-once)[arguments]: Add
`#:absent-dependencies`. Stop deleting the `'configure` phase.
---
 gnu/packages/node-xyz.scm | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
index 77577cb315..eb071320cd 100644
--- a/gnu/packages/node-xyz.scm
+++ b/gnu/packages/node-xyz.scm
@@ -338,13 +338,10 @@ (define-public node-once
                 "1z8dcbf28dqdcp4wb0c53wrs90a07nkrax2c9kk26dsk1dhrnxav"))))
     (build-system node-build-system)
     (arguments
-     '(#:tests? #f                      ; FIXME: tests depend on node-tap
-       #:phases
-       (modify-phases %standard-phases
-         ;; The default configure phase fails due to tap being missing, as we do
-         ;; not have tap packaged yet.  It is used only for tests.  This package
-         ;; still works as a dependency of node-glob and node-inflight.
-         (delete 'configure))))
+     '(#:absent-dependencies
+       '("tap")
+       ;; FIXME: Tests depend on node-tap
+       #:tests? #f))
     (inputs
      `(("node-wrappy" ,node-wrappy)))
     (home-page "https://github.com/isaacs/once")
-- 
2.32.0





Information forwarded to liliana.prikler@HIDDEN, guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 04:34:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 23:34:40 2021
Received: from localhost ([127.0.0.1]:41211 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moI5H-0007v6-PT
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:40 -0500
Received: from mail-qk1-f170.google.com ([209.85.222.170]:44645)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moI54-0007rr-6S
 for 51838 <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:26 -0500
Received: by mail-qk1-f170.google.com with SMTP id 132so12346249qkj.11
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 20:34:26 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=rrgarsOG5qrDPqpcA3pfUfNYrtqtmYBYYCZ4jb/3Z+8=;
 b=ZwZYjR+Y/xg2Vl8mlzVG7VZfUjQ6rNcPf6s86Bg2MKtjnTtcAHytbhqLw028krSuj2
 xrQft3DgzYmilpoo4Y6VK6ySVBXfP80N0x7Bmzv8ouKSASf4u0B8Vh4a/XO4nJH6dA0w
 KAQoMvPqkM+sGCt8ndLuUIGiwFipNgEiRKK0pMegiSceaf9jBC0XPfk9ROIQLN/5Ofg0
 dXq1A26Mcr355Rq+15dZ7vTgxYz9sPb4XEJ72/7Whfb796mouYUeYhQzfTDlCDWiWmRT
 Z8jBc+6dX0i4g37AlXPmRWqKTwHQTSBsgq7uEIuPkDKc0kLmowNXK+VkQSBHOT3VvyUW
 kykw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=rrgarsOG5qrDPqpcA3pfUfNYrtqtmYBYYCZ4jb/3Z+8=;
 b=umCUgmfdXhmvPnTl72tceG7V0lTRWGb0Bs1lSvtXrhfUJx6vsZ2YtDO5rt9c0IlBSd
 R9Z/FMYHjHunC0UF1ypt8vHCkZ663nWOFC13/kPjN0EkhrORSunbYFobogs8Hnhv116G
 r4Ou1LNb19QBNyGMhdWB4ZK65L3ao0Al0itJRSJcNGhNb4xOxjCz/aa5ZCmSrf9DRcaC
 kciisyvluInffWCq+yEhcqNfTOKrc/kUw7yATP74k2/ob3TS95GPDQIOhjyDGCtcEmFT
 4sl3Wpg+/d3UbuXzhml3ooQWnF5VzJqLW5qcsInr4hpW/CTKg57nu3YEXyCSxKH6MHvu
 c89A==
X-Gm-Message-State: AOAM531lO/cJzwIIR2y+KIBxgPYS0LUF2hGuJDGyVdVDsz3mw+y+F4+2
 CsKNNKl8ExkvxIKYVU0gQhKMlHDb69THSdzx
X-Google-Smtp-Source: ABdhPJzdZeR8Y3CI1UAASMe2hnPCnPkUsRjaqYa44Jy0/wZmpjh08SNWXwQsr7elj3Mgg7aPDWnUWw==
X-Received: by 2002:a05:620a:4148:: with SMTP id
 k8mr33168024qko.0.1637382860795; 
 Fri, 19 Nov 2021 20:34:20 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id p10sm998213qtw.97.2021.11.19.20.34.20
 for <51838 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 19 Nov 2021 20:34:20 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH v2 14/26] gnu: node-wrappy: Use #:absent-dependencies.
Date: Fri, 19 Nov 2021 23:33:54 -0500
Message-Id: <20211120043406.952350-14-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211120043406.952350-1-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
MIME-Version: 1.0
X-Debbugs-CC: Pierre Langlois <pierre.langlois@HIDDEN>
X-Debbugs-CC: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

gnu/packages/node-xyz.scm (node-wrappy)[arguments]: Add
`#:absent-dependencies`. Stop deleting the `'configure` phase.
---
 gnu/packages/node-xyz.scm | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
index 93a033d33e..77577cb315 100644
--- a/gnu/packages/node-xyz.scm
+++ b/gnu/packages/node-xyz.scm
@@ -316,10 +316,8 @@ (define-public node-wrappy
     (build-system node-build-system)
     (arguments
      '(#:tests? #f ; FIXME: Tests depend on node-tap
-       #:phases
-       (modify-phases %standard-phases
-         ;; The only dependency to check for is tap, which we don't have.
-         (delete 'configure))))
+       #:absent-dependencies
+       '("tap")))
     (home-page "https://github.com/npm/wrappy")
     (synopsis "Callback wrapping utility")
     (description "@code{wrappy} is a utility for Node.js to wrap callbacks.")
-- 
2.32.0





Information forwarded to liliana.prikler@HIDDEN, guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 04:34:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 23:34:39 2021
Received: from localhost ([127.0.0.1]:41209 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moI5H-0007uz-H0
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:39 -0500
Received: from mail-qk1-f180.google.com ([209.85.222.180]:33636)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moI53-0007rc-A4
 for 51838 <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:25 -0500
Received: by mail-qk1-f180.google.com with SMTP id de30so12422967qkb.0
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 20:34:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=mbCEzsxFXNzbUn/m9lxyQ344wUbhcRY3RF9r5hsXjyM=;
 b=fP3PSGZmYi2u8TuJpbNYg2MYu/jRQfciz267d0nSDCDCrgbd3KktP7tWwWZxQmChZw
 aBdzonenOcKztAqo9rOWatCDQQqnrP3giZ3VXjfx95MhyxW2Uhf3fdr7PhKqt/RWsZe+
 yZtkXq2sMIf5K+4YMdTLApP0xpuZSWeGqiAKyJUOalS1cyY/dHlsjYgzzY2f8A3HpeHM
 cFYnX9trFMmW4qE1NWZ1PQrFBfxjsNAnFmkD+k8U4KF4B+ujOEy+gLd/SuYy6gIurz4K
 sTNpoOiZdzYcQxTWd7Zsp3JXvekAGyRmIQY066orM/RkpruTTY7Df10gwcNQ3KxKlx8a
 V7uQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=mbCEzsxFXNzbUn/m9lxyQ344wUbhcRY3RF9r5hsXjyM=;
 b=5lbNm5h6rGuXFbkOT7C3M6a4cTVp284hnh3LR/Sk4JZWLILiGapZ4hKLqKektBQqui
 mBdoovvyUP5CCF5T+1mq2NUEQmC6hpscGl2eR0o9UzwfA7342Drsr8de9lFzxoBDs9Ot
 9BxsDbyZGPJOeWdKq99jfgCsY4u6wT9uxltkRZXGPGpd+6cf1k75GaLKEI9BWm0AWtbo
 GSIfcG6oZTtdHNBu3bgSyZp3zzMrPmDVMOGyaOdNoHhbjbXxe10m9vdrt7iyb0geJlmM
 WAoA8T/F3flKL4nzulitS4ZaZtNUbl4i9gh/00zBM5uHEqUPiiGxUWrHnjbe22YUO4eK
 z5vA==
X-Gm-Message-State: AOAM533k5ZXST1mv2TUbr1KIcdC2pP5POpiismZJNve7qTqR0hcm9nKb
 eCgWOUBbcp6CI/HItBq1GwWV+leNQSOQ23Hw
X-Google-Smtp-Source: ABdhPJxZhZPtu4j5wnS6BHtyW8Tvag9+bqnYQiNBmXyjr5270mJLqE8jPe6u0bJjR91JaRRqNto40g==
X-Received: by 2002:a05:620a:1a19:: with SMTP id
 bk25mr33265705qkb.479.1637382859853; 
 Fri, 19 Nov 2021 20:34:19 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id u17sm1046629qki.2.2021.11.19.20.34.19
 for <51838 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 19 Nov 2021 20:34:19 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH v2 13/26] gnu: node-semver: Use #:absent-dependencies.
Date: Fri, 19 Nov 2021 23:33:53 -0500
Message-Id: <20211120043406.952350-13-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211120043406.952350-1-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
MIME-Version: 1.0
X-Debbugs-CC: Pierre Langlois <pierre.langlois@HIDDEN>
X-Debbugs-CC: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

gnu/packages/node-xyz.scm (node-semver)[arguments]: Add
`#:absent-dependencies`. Stop deleting the `'configure` phase.
---
 gnu/packages/node-xyz.scm | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
index 98c611f227..93a033d33e 100644
--- a/gnu/packages/node-xyz.scm
+++ b/gnu/packages/node-xyz.scm
@@ -289,11 +289,10 @@ (define-public node-semver
                 "06biknqb05r9xsmcflm3ygh50pjvdk84x6r79w43kmck4fn3qn5p"))))
     (build-system node-build-system)
     (arguments
-     '(#:tests? #f ; FIXME: Tests depend on node-tap
-       #:phases
-       (modify-phases %standard-phases
-         ;; The only dependency to check for is tap, which we don't have.
-         (delete 'configure))))
+     '(#:absent-dependencies
+       '("tap")
+       ;; FIXME: Tests depend on node-tap
+       #:tests? #f))
     (home-page "https://github.com/npm/node-semver")
     (synopsis "Parses semantic versions strings")
     (description
-- 
2.32.0





Information forwarded to liliana.prikler@HIDDEN, guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 04:34:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 23:34:39 2021
Received: from localhost ([127.0.0.1]:41207 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moI5H-0007ur-8J
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:39 -0500
Received: from mail-qk1-f181.google.com ([209.85.222.181]:41599)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moI52-0007rQ-A5
 for 51838 <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:24 -0500
Received: by mail-qk1-f181.google.com with SMTP id t83so12349477qke.8
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 20:34:24 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=zB8Q3gHUAjYZf7aD/m+qvVXNE+nk0p2Waz35RtU/tjw=;
 b=fLsQyGmfyLmGeuIRH49f8WMBBBlnSkxFqP0VTxHKHlDMPEQebXAlkWOt+19g4JDZT9
 9QoFP3W4xOYdHKmaBleCLraCvetGuNBQIzfk0R2pioMoevCp0iX1RuzRHel/oPYfeTfe
 AaS3/CY2PmM2KQyY/zdEmFRV4n57dQwSpFAbL0A54lA/fWhlMYnNpM8vIJ8x0oaHauCb
 gKADfYod1eDSNV3lnoSH8bSkFWElxWPiwS0H2sg/gJz21VP4wqqtmGqmM6V4FZimC1Dy
 pI3WukJFA+uvRNBvC84UT3JxvXyc4DQ28PuudvOxjlvAxZYnCUcoHkAmHpqCqiCzDej5
 4QRg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=zB8Q3gHUAjYZf7aD/m+qvVXNE+nk0p2Waz35RtU/tjw=;
 b=69LfDh75lncl3aj1X+36dYe6MW1XZdik6D9MwA7VjfjMG7lcrrjgqoWuhXINKJEN0j
 29xo9RXNAlx0lN+R+o2Ff843Ztz2WC4Oa80hdZGvVPHZnuSYHD5by5j4RyW8xQtTtiWk
 Ol9G3qs82WOb8lmkNj0WEi1YLykSzxzmArbi7vViwYzqH6g1de+6EfCQl21qShOgyvFx
 kivhg1xbNELjmgtW/NI/485eiwTrv8qDI/FrvofGUXr6X2o//sMC+SjmKmk5Lrdx2pdN
 rpQkqzAcTc1/OqsPhlo57o9CuCBKKgTBuF2ZWakM2Gvoe42DTA71Vz8YlO4lXqXEYVhF
 XMzw==
X-Gm-Message-State: AOAM533zbIXFdtap++qLecFmjXqrSjEi5NdlpewMSyYBTvjcurRxqy5v
 LWlwQK1szaDPL8Tu9eZxWQRWE6sOyY5S+e1S
X-Google-Smtp-Source: ABdhPJxTjEsjj/4fFtHxpvIqd3Hwmys5vqTbZZ9bcpQko9on0Yk20/o41ZNwblPAini5r3rfJ1UIJg==
X-Received: by 2002:ae9:e502:: with SMTP id w2mr33476073qkf.315.1637382858806; 
 Fri, 19 Nov 2021 20:34:18 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id t15sm1001590qta.45.2021.11.19.20.34.18
 for <51838 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 19 Nov 2021 20:34:18 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH v2 12/26] gnu: node-llparse-bootstrap: Use
 #:absent-dependencies.
Date: Fri, 19 Nov 2021 23:33:52 -0500
Message-Id: <20211120043406.952350-12-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211120043406.952350-1-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
MIME-Version: 1.0
X-Debbugs-CC: Pierre Langlois <pierre.langlois@HIDDEN>
X-Debbugs-CC: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

gnu/packages/node.scm (node-llparse-bootstrap)[arguments]: Add
`#:absent-dependencies`. Stop deleting the `'configure` phase.
Add a new phase `#:delete-package-lock` to remove the
problematic "package-lock.json".
---
 gnu/packages/node.scm | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index 298b9376a8..6d48816c77 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -609,9 +609,24 @@ (define-public node-llparse-bootstrap
     (arguments
      `(#:node ,node-bootstrap
        #:tests? #f
+       #:absent-dependencies
+       `("@types/debug"
+         "@types/mocha"
+         "@types/node"
+         "esm"
+         "llparse-test-fixture"
+         "mocha"
+         "ts-node"
+         "tslint"
+         "typescript")
        #:phases
        (modify-phases %standard-phases
-         (delete 'configure)
+         (add-before 'configure 'remove-package-lock
+           ;; Having package-lock.json seems to cause npm
+           ;; to look for things on the internet in the configure phase,
+           ;; even if we have them properly installed.
+           (lambda args
+             (delete-file-recursively "package-lock.json")))
          (replace 'build
            (lambda* (#:key inputs #:allow-other-keys)
              (let ((esbuild (string-append (assoc-ref inputs "esbuild")
-- 
2.32.0





Information forwarded to liliana.prikler@HIDDEN, guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 04:34:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 23:34:39 2021
Received: from localhost ([127.0.0.1]:41205 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moI5G-0007uk-VP
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:39 -0500
Received: from mail-qk1-f170.google.com ([209.85.222.170]:39794)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moI51-0007rK-8E
 for 51838 <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:23 -0500
Received: by mail-qk1-f170.google.com with SMTP id bk22so12355561qkb.6
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 20:34:23 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=GkiJa612s69wtsJsqZ9gBQjB+UI22GYIWQ/+REU939c=;
 b=BfhxqGIRm5lJIH5d0tDChwxgUhuoQ+ThzTxTD0KgoKQuBuUNCN9OGwzyuhau5Fgjs2
 UGENd6JZSJsQNsbNOd69qbaS0NXyxrca4jsidVMP4qXQIFt7XM02Jp+Lwnpv7NFNzW7k
 sIQo7COz4O23XfEgGEDWHEVDbfPbZoQVJNNkpmL7d6Gj0gE5jtQ5hU05PtB+vtp7IlGl
 VBNY9iORZLQpgSdmXQ2tLTrnMbz2aD1/AsRxuikw71WKjARPt4+d4OumHLDnesCUQTg5
 PBFlxqdD6Egb4gGKcYbemUvEeDa3+iEUDOEkxMc/GvvcIACUm7I9yL2yLImVJ8xNjnKh
 9TbA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=GkiJa612s69wtsJsqZ9gBQjB+UI22GYIWQ/+REU939c=;
 b=0GumBqXplwhY6SGQvP4q/6WOl2U1+aB9G52Cb9ue7ZAh9DptSm7rXP8evJ1uC3AOK6
 O4xa0/c1FVAR+vB63n0c9iOGy8MYMaQl7DX1YmWTlZp0CEjbCiCXx/liEokPZpXykmrH
 dzxPokmnjmwKh9P5UjWgHwkqUtM1ovsWheoVxmrvGy1ywnUlgiDCUhSEBlwdl2ru00yG
 UiVDGEhRGXNS1vcjqDXmGnfCvXD3puMDORW3DS22j0GuKLAHFiSsNcoy/RD6h9eV43Wi
 zGYN6g8u3kOy0cUjUl644xOuAx8onwHnciRPJSIwVFH7iN5CK0HETT05V0E1O2Vx1KVI
 MElQ==
X-Gm-Message-State: AOAM532q6y1hgGCHU0ljtNJSez16wehRuIwUHoqW3j+SiF6vBzLArNdt
 5Y/oVe2lrYhWdJROg65eDTQGg1KvGaS0/KVc
X-Google-Smtp-Source: ABdhPJzPc1KVEPuwhSzBdyDGOh2unxy19vOYsx1LRC3hTCcu2uWo2qrNV1a4gANc7LoyGq7S6bl3dg==
X-Received: by 2002:ae9:de02:: with SMTP id s2mr34243352qkf.215.1637382857767; 
 Fri, 19 Nov 2021 20:34:17 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id g12sm950763qtk.69.2021.11.19.20.34.17
 for <51838 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 19 Nov 2021 20:34:17 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH v2 11/26] gnu: node-llparse-frontend-bootstrap: Use
 #:absent-dependencies.
Date: Fri, 19 Nov 2021 23:33:51 -0500
Message-Id: <20211120043406.952350-11-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211120043406.952350-1-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
MIME-Version: 1.0
X-Debbugs-CC: Pierre Langlois <pierre.langlois@HIDDEN>
X-Debbugs-CC: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

gnu/packages/node.scm (node-llparse-frontend-bootstrap)[arguments]: Add
`#:absent-dependencies`. Stop deleting the `'configure` phase.
---
 gnu/packages/node.scm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index 9d4903a8ca..298b9376a8 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -547,9 +547,16 @@ (define-public node-llparse-frontend-bootstrap
     (arguments
      `(#:node ,node-bootstrap
        #:tests? #f
+       #:absent-dependencies
+       `("@types/debug"
+         "@types/mocha"
+         "@types/node"
+         "mocha"
+         "ts-node"
+         "tslint"
+         "typescript")
        #:phases
        (modify-phases %standard-phases
-         (delete 'configure)
          (replace 'build
            (lambda* (#:key inputs #:allow-other-keys)
              (let ((esbuild (string-append (assoc-ref inputs "esbuild")
-- 
2.32.0





Information forwarded to liliana.prikler@HIDDEN, guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 04:34:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 23:34:39 2021
Received: from localhost ([127.0.0.1]:41203 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moI5G-0007uY-Gx
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:38 -0500
Received: from mail-qv1-f54.google.com ([209.85.219.54]:35820)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moI50-0007rD-CR
 for 51838 <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:22 -0500
Received: by mail-qv1-f54.google.com with SMTP id g1so8527856qvd.2
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 20:34:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=qnaUEWsjeIbY8vIxJJCzrVMTy4UI+5cVLp2wik/nM4Y=;
 b=GHhalSv+AGIy3mcKxXkqc5LrrhD7L70lF6/NUTNz1M820aDU8Dl9Ph2N+U5IIHYgzP
 W2PAr4qk8GfLGhUlewsjZbSsrFBrUSzZFyNgUfLzCdnr0MvVQfKQ6nbIaBZg7ewknsTc
 CyYkMTWJnFrZu1mvCXNsBwy9fdqhYigp10vk2Bx4WguwGMsWfE7wMFbCjN/KcKv+lV3P
 iUnEJEt1x7flTVBKsvUewSybiaOiApTNgiKYbiFWna3kW0GwB6wLeZ1Cef7GbeyB1OvV
 LOAUtpfh3EnoewHXlTV2JfvBVHL7viTvC2ZxhJLf5mqtOu2jBCrTzfVSXAjk0EgmEkkJ
 +AlQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=qnaUEWsjeIbY8vIxJJCzrVMTy4UI+5cVLp2wik/nM4Y=;
 b=HZw2cJ+UVp5OrOuHagZgO79rQohbfJBNapd2qrn156iLDIlfNdEnu9aDs0BpceoRy5
 E4Nq1/OEFLkSDn57S7DMYTVXqybVyfkqSz158joUQRhDwGgMQxbrHz8k6n6nUgL7Jmur
 pdGmzVXNuTcgC3jwUIWWW/7gaBckE9GKWsD33QPja7zOExEoKlAloW07YJCE+692OOVx
 BUZ/dBV3nYncmrfRxSFQPhhUqGDIpMn8vsre6mLbtgmZNmv3L0+uuAV/JCis8/1n7VKC
 OyOUct7leeu0R5TmH3cADSIwi8CfXjRu3Q/r/QrZBbgcBBW4Kic4P22eze/MKBpPiton
 vk/Q==
X-Gm-Message-State: AOAM532JvzhZIDKS00WIgVeumYP69fz7w4A8jXQX7i/BmO74lkFfGeM/
 2oXohUyH55lUwEAVB//oVsFH0fDUG5wc7sRk
X-Google-Smtp-Source: ABdhPJzwvIk9Rvl7E4ao66+IBoReX9tM1vJJisPrXGqZ6X5gSexukZk7+8uJiIH2JOM9Hji4c2Qamg==
X-Received: by 2002:ad4:5a47:: with SMTP id ej7mr79475676qvb.48.1637382856813; 
 Fri, 19 Nov 2021 20:34:16 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id l10sm1047238qkp.3.2021.11.19.20.34.16
 for <51838 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 19 Nov 2021 20:34:16 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH v2 10/26] gnu: node-llparse-builder-bootstrap: Use
 #:absent-dependencies.
Date: Fri, 19 Nov 2021 23:33:50 -0500
Message-Id: <20211120043406.952350-10-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211120043406.952350-1-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
MIME-Version: 1.0
X-Debbugs-CC: Pierre Langlois <pierre.langlois@HIDDEN>
X-Debbugs-CC: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

gnu/packages/node.scm (node-llparse-builder-bootstrap)[arguments]: Add
`#:absent-dependencies`. Stop deleting the `'configure` phase.
Add a new phase `#:delete-package-lock` to remove the
problematic "package-lock.json".
---
 gnu/packages/node.scm | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index 98a51276e7..9d4903a8ca 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -479,9 +479,21 @@ (define-public node-llparse-builder-bootstrap
     (arguments
      `(#:node ,node-bootstrap
        #:tests? #f
+       #:absent-dependencies
+       `("@types/mocha"
+         "@types/node"
+         "mocha"
+         "ts-node"
+         "tslint"
+         "typescript")
        #:phases
        (modify-phases %standard-phases
-         (delete 'configure)
+         (add-before 'configure 'remove-package-lock
+           ;; Having package-lock.json seems to cause npm
+           ;; to look for things on the internet in the configure phase,
+           ;; even if we have them properly installed.
+           (lambda args
+             (delete-file-recursively "package-lock.json")))
          (replace 'build
            (lambda* (#:key inputs #:allow-other-keys)
              (let ((esbuild (string-append (assoc-ref inputs "esbuild")
-- 
2.32.0





Information forwarded to liliana.prikler@HIDDEN, guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 04:34:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 23:34:38 2021
Received: from localhost ([127.0.0.1]:41201 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moI5G-0007uR-7N
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:38 -0500
Received: from mail-qk1-f176.google.com ([209.85.222.176]:33629)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moI4z-0007r6-2S
 for 51838 <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:21 -0500
Received: by mail-qk1-f176.google.com with SMTP id de30so12422846qkb.0
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 20:34:21 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=N3TFqL8mqVV/RyaIGlY/Q4s7Fe6YpLLescJ+hiM8MXo=;
 b=KucgnifigFyqSnaIMK0hY8XI7UygT7hvRJjeDa4OG2T78iOwYbvazudvW7chFGVgzV
 I9dLv0PCnQAWpnD1Vc6FfaOXophxsj7YRrHQK7E+iCezDTprPDJ12mPEUErgOcdcX95G
 5bBJfF9exLPWvTdILbNcZqP3q248doFxTn/RjPJcFYbPdTcG/Ad/1ZM8cXCTDjGJnI6u
 iRh4XnZrXSZii/yV8DrXZ3useRNtClV0MPpG49+Rwe2AvMl5ZMOIaXO9QRItDehg+Idp
 v368k9+zliIF060x67BlkkW151QvqSH68qOHptkWlh5ohLfSiG1TkYqtWuFS9LCwNFaj
 IRgg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=N3TFqL8mqVV/RyaIGlY/Q4s7Fe6YpLLescJ+hiM8MXo=;
 b=zVp9WKuimWVpabYd6EDau+iWFnvUpiWaEtnxk+aB9Mwf79hwl6ZmhFcRcUzaAXzcEW
 rqUgcTzJ7JxScZTkCXM4ENBC8urbEIe3+88GQBcqGG0yk9di4x0oL+PPSfeQntio4JwV
 dAlTdWaOmFuGrm42+dCN0KQPjAD9ot4/L7C6U7HRZjb0uNgVm3ZwWGhOlj0NEslNaNSv
 vbBJWjr67Gd/3A+nGHlBfmqohcsfgKmEuczuQPhf53eA8M6GNfeLYpnB7FWokZAXokMt
 8jFKz+/QDaTcys929BRv06+XrdduuLbcWhdDqnw/4AJLUe9KNfCbPSj2GQfvqft55nKB
 +ePw==
X-Gm-Message-State: AOAM530o3tTPK9T9fFliFnLtpNYfPhDCQiTC9f+xlIVcqjBL0Jn4FoiJ
 4dc8A5UDAJdj3s+rcDWeHOSFC6e4PsvGlio+
X-Google-Smtp-Source: ABdhPJy/hf3+3pxYfZsIxA2FIZyo0XaL32k10esQZ4KOQOW+bwnfvQooFMxnqfgXZihnqTiIm5AsBw==
X-Received: by 2002:a37:6591:: with SMTP id
 z139mr31552981qkb.178.1637382855638; 
 Fri, 19 Nov 2021 20:34:15 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id i11sm1029415qko.116.2021.11.19.20.34.15
 for <51838 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 19 Nov 2021 20:34:15 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH v2 09/26] gnu: node-debug-bootstrap: Use #:absent-dependencies.
Date: Fri, 19 Nov 2021 23:33:49 -0500
Message-Id: <20211120043406.952350-9-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211120043406.952350-1-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
MIME-Version: 1.0
X-Debbugs-CC: Pierre Langlois <pierre.langlois@HIDDEN>
X-Debbugs-CC: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

gnu/packages/node.scm (node-debug-bootstrap)[arguments]: Add
`#:absent-dependencies`. Stop deleting the `'configure` phase.
---
 gnu/packages/node.scm | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index 2cdae34ae1..98a51276e7 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -416,9 +416,18 @@ (define-public node-debug-bootstrap
     (arguments
      `(#:node ,node-bootstrap
        #:tests? #f
-       #:phases
-       (modify-phases %standard-phases
-         (delete 'configure))))
+       #:absent-dependencies
+       `("brfs"
+         "browserify"
+         "coveralls"
+         "istanbul"
+         "karma"
+         "karma-browserify"
+         "karma-chrome-launcher"
+         "karma-mocha"
+         "mocha"
+         "mocha-lcov-reporter"
+         "xo")))
     (inputs `(("node-ms" ,node-ms-bootstrap)))
     (home-page "https://github.com/visionmedia/debug#readme")
     (properties '((hidden? . #t)))
-- 
2.32.0





Information forwarded to liliana.prikler@HIDDEN, guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 04:34:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 23:34:38 2021
Received: from localhost ([127.0.0.1]:41196 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moI5C-0007ts-JP
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:38 -0500
Received: from mail-qv1-f45.google.com ([209.85.219.45]:41694)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moI4s-0007qV-8t
 for 51838 <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:20 -0500
Received: by mail-qv1-f45.google.com with SMTP id m17so8510206qvx.8
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 20:34:14 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=t5y3hwK9L6+eQR1y3VE4Cmi8oUepPqWpd78oyUMVhug=;
 b=e9JlNauLkF/otmR9LT8ZGJyFquQGd1uvKbSUmV0yICTByX2iwYZtOFziRgNquY6Sft
 6ffXrnX0CSIVo9UKiCOsN2Cv0MxHu8Y6kKPBl1zsLGuEr5UwIXF1OXfFBL9IHhepIM06
 sKJQxq/vdBx1pFGgZVUqPCD19fZOZhyH2KUpmK0+9XUfRQ1FTdL89ExkKXGUqEl1yzyS
 dULl1KYNwFathq+IS4GwCktVF/Ln9vPVh/Ayd1VjLqHFLzk9wskLAYyaXAoC5PBCDt5G
 3wyXZMADv/KD1XWONA7xyzIXhUKI6G6dH/c4Y0jwR8OouZQ9guI7PgLTEPE0+MostEqp
 nH8w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=t5y3hwK9L6+eQR1y3VE4Cmi8oUepPqWpd78oyUMVhug=;
 b=iq6B2WXkD8gWN924K/2Ate+TXB5GjqPDJHW+l2kSyjRgH/KBiZ3otDYEeGJzR0ooxS
 sBS4W6vuhqRjahPAowHbuX+mubj1HorqYqScGUah1ar7BcVMAQ+GPkGVatq52FTq1C0b
 A92lSVypFel+E2rh5QMbawSDOg2/teUysCxDK262PFtRWDE/bneLZeOs0/PsoTOSyLXx
 MRlkURgbEdC92Is2woI2jqWcQcv3rYrsgNweJa3xLLrR6+3Q/88iJ9tOdMBixChuHMj3
 bqckniMvxT5OOW5kww3Xbu/e0ksITbkkxBvl1uM1E9W6M4M8sV2TG7TafmebfhpVIa40
 LkUQ==
X-Gm-Message-State: AOAM533bAaiS26cEm+oVEjw87CqnlscL5GMad9kyJCD7CGd3H8VqL4+e
 iqfXn8Co1jXmJVHnPIeUIsE4fCYOIYeQJEEa
X-Google-Smtp-Source: ABdhPJw5DgPDPPrpPNEjXz4KRcFoxDk6lECIuXsHqynX4b1iQhc08PDSKN/3uYximajibmvw2O4B0A==
X-Received: by 2002:a05:6214:1ccb:: with SMTP id
 g11mr73421196qvd.31.1637382848712; 
 Fri, 19 Nov 2021 20:34:08 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id t11sm1000588qkp.56.2021.11.19.20.34.08
 for <51838 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 19 Nov 2021 20:34:08 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH v2 02/26] gnu: node: Update to 10.24.1 for bootstrapping.
Date: Fri, 19 Nov 2021 23:33:42 -0500
Message-Id: <20211120043406.952350-2-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211120043406.952350-1-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
MIME-Version: 1.0
X-Debbugs-CC: Pierre Langlois <pierre.langlois@HIDDEN>
X-Debbugs-CC: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* gnu/packages/node.scm (node): Update to 10.24.1.
---
 gnu/packages/node.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index 7ebbbc3060..71b66774a6 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -57,14 +57,14 @@ (define-module (gnu packages node)
 (define-public node
   (package
     (name "node")
-    (version "10.24.0")
+    (version "10.24.1")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://nodejs.org/dist/v" version
                                   "/node-v" version ".tar.xz"))
               (sha256
                (base32
-                "1k1srdis23782hnd1ymgczs78x9gqhv77v0am7yb54gqcspp70hm"))
+                "032801kg24j04xmf09m0vxzlcz86sv21s24lv9l4cfv08k1c4byp"))
               (modules '((guix build utils)))
               (snippet
                `(begin
-- 
2.32.0





Information forwarded to liliana.prikler@HIDDEN, guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 04:34:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 23:34:34 2021
Received: from localhost ([127.0.0.1]:41193 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moI5C-0007tk-7s
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:34 -0500
Received: from mail-qk1-f177.google.com ([209.85.222.177]:40751)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moI4x-0007qm-QR
 for 51838 <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:20 -0500
Received: by mail-qk1-f177.google.com with SMTP id p4so12364631qkm.7
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 20:34:19 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=CaP7f29V0VkxYNjFKOmVo4MDTT0lUMh0lH0dVf/o9/c=;
 b=eAraYhgEzd3ruAohZt8odJwECe2UlfSZFAJpWvsGolLGpIPDK47rq7sUUE77gAsN03
 lgM3YmSP5uqsRd5fIVZGWki+eqR/OQDEwGKV7qN8wYMwbQB7m3sRCThK3igmpEWAB6ea
 SCkfCEIFWSnbI+ejyVvxFhAFBU0GNnq08Y+jt+M+Cx5/PZYkBqH6YPbX7r8MZUGwdIY1
 iQM0VDRbUqpc2Wzlis5E1fqszzjAkJZakZVep7WEMMc45t4qOvYPOIQGOQUDdu6fO5ay
 seRdA/5BUINIVBWJAg3RUregMxRdURNITfd4yhmYDmgOAabNEW4I4a1KCW7sKWkEu979
 yOnA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=CaP7f29V0VkxYNjFKOmVo4MDTT0lUMh0lH0dVf/o9/c=;
 b=W53zHhkIphfWfE0bLdY5qGt7ijxa1KCjLm/A9p1SAPOZCfG4wN3akOCC2Et7aHGFFY
 6J71JVDPurMhBOJJfox9VANlqD1GhGnPc1SQDRZ6lwIaWstf3yLxjXQieM6iV36q45Ad
 zjrwtqZXiwEqOfdm/+pFemF3LJp4iso0e8/r+z2pHfX/MEjvWTrHuc/1mCzp+X31Yz/f
 HCtVb0/RQymvILEDSx/+c/ru2/i1KDwrh9Hx61YOJqYeY8XJBk/DlZGpCh3Hzh1oQBgb
 yZXub7RK+01oVfSdDeMrYpS0PRjkZ0sAu+hHnI8mdnGTIHdpFck8kRpjmWxhe+PbjS6s
 XBYg==
X-Gm-Message-State: AOAM530ch7nON0Vfcat0y8lBHlELCKwy1EHl7iQ9UDbulMzoJKE7eIG9
 xObn3Vlp4Hpd5LIH8wwTvmIFHzvQhOHAvw1s
X-Google-Smtp-Source: ABdhPJzlRLdQ2EAcSUqdfVt5GUbqM1DRxvp5U+MCeNxIDXFX2pxGdcsJxfvW+k7uyRLJ2bRCCKWHOA==
X-Received: by 2002:a05:620a:2807:: with SMTP id
 f7mr32877574qkp.424.1637382854367; 
 Fri, 19 Nov 2021 20:34:14 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id y10sm957990qkp.128.2021.11.19.20.34.14
 for <51838 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 19 Nov 2021 20:34:14 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH v2 08/26] gnu: node-binary-search-bootstrap: Use
 #:absent-dependencies.
Date: Fri, 19 Nov 2021 23:33:48 -0500
Message-Id: <20211120043406.952350-8-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211120043406.952350-1-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
MIME-Version: 1.0
X-Debbugs-CC: Pierre Langlois <pierre.langlois@HIDDEN>
X-Debbugs-CC: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

gnu/packages/node.scm (node-binary-search-bootstrap)[arguments]: Add
`#:absent-dependencies`. Stop deleting the `'configure` phase.
---
 gnu/packages/node.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index ca4bf1ad23..2cdae34ae1 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -389,9 +389,9 @@ (define-public node-binary-search-bootstrap
     (arguments
      `(#:node ,node-bootstrap
        #:tests? #f
-       #:phases
-       (modify-phases %standard-phases
-         (delete 'configure))))
+       #:absent-dependencies
+       `("chai"
+         "mocha")))
     (home-page "https://github.com/darkskyapp/binary-search#readme")
     (properties '((hidden? . #t)))
     (synopsis "Tiny binary search function with comparators")
-- 
2.32.0





Information forwarded to liliana.prikler@HIDDEN, guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 04:34:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 23:34:34 2021
Received: from localhost ([127.0.0.1]:41191 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moI5C-0007ti-1G
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:34 -0500
Received: from mail-qk1-f174.google.com ([209.85.222.174]:41589)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moI4w-0007qg-VF
 for 51838 <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:19 -0500
Received: by mail-qk1-f174.google.com with SMTP id t83so12349304qke.8
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 20:34:18 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=ysCUypxPLTqJpCuJaOcxZ4DeIJt4wjdqkdolNkLabpY=;
 b=U/UIpdushqB1UwY+77D9jF56hkaJr63mQ6bU+4a3fn1g5h6eHVwPZPr93lM2vnektr
 i1IFrhoiv0MSstOUf5YLTSWWtIpWwBT2+I2w2g6o2kAw0yi3cy8YP7r00HdSDqkCVJPH
 ClN8Av1llVWUWYjAACobrgl5kTWBsBEKiEKHD+EpJiO+FUKGiPkpvOQVUv4Yfw7HiLg6
 FrTqqSIywuV1HzFjs/EiOIaOU0l4yRz3KyLtEPKtGZ7tuQNJDryMug3Ds41RBfpgtpBq
 5/TX2eLmVHHclQrA5YroQSm2/EG8Yz65ZPh7Ffhh7dEhCz3YUGbuDHRdqaaixu/b2s9x
 XEGg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=ysCUypxPLTqJpCuJaOcxZ4DeIJt4wjdqkdolNkLabpY=;
 b=Jh1oF4atpPXUUdhwlzP8qlkfC/+Fh/Py31HyhPx7vXei+/3Ss9sYab/bvC7e02DmGH
 k6y8RXZZyFPui4T6YD3hcS1ND1eFLs1m+HvdkZNCFb/tcScOCEEl6yfM2ql14ZszmKHp
 036huah3zQH/APFgl/wuKhHpDzJgx0/9mTByV1JCia52RxKP54XVAHMuyKdRhAQ/I7pz
 MfTi3G4Zs8HMIhcDmcE+CI8753BQiCuBRg60E08rhfJOfLKz4CJe2YvjFrrpQyN9ww85
 0P3zudWZl7RwKcinBm4wO8HoYYQQg+v5bWYRSYMZpWlt2mlfKaKjZZWDN+NcErEmrKyX
 AE4A==
X-Gm-Message-State: AOAM532OOFH/tquWDEzFFoS4gsd+zpRte9KWe+Jc7YVtYgoCbj4IWuiA
 K16zz3pwP6Qit8B8Iu2LiHN5BCrGQUMIRVoq
X-Google-Smtp-Source: ABdhPJw6ZiYGOdKhOo8/i9FLIHOueDa0hfuECrreCQ5xDcj2LF0YQSlAD2UNFPawQTmtXqd5J1SnUg==
X-Received: by 2002:a05:620a:2589:: with SMTP id
 x9mr32798844qko.152.1637382853472; 
 Fri, 19 Nov 2021 20:34:13 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id j20sm947890qtj.43.2021.11.19.20.34.13
 for <51838 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 19 Nov 2021 20:34:13 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH v2 07/26] gnu: node-ms-bootstrap: Use #:absent-dependencies.
Date: Fri, 19 Nov 2021 23:33:47 -0500
Message-Id: <20211120043406.952350-7-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211120043406.952350-1-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
MIME-Version: 1.0
X-Debbugs-CC: Pierre Langlois <pierre.langlois@HIDDEN>
X-Debbugs-CC: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

gnu/packages/node.scm (node-ms-bootstrap)[arguments]: Add
`#:absent-dependencies`. Stop deleting the `'configure` phase.
---
 gnu/packages/node.scm | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index 6c958eebec..ca4bf1ad23 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -358,9 +358,12 @@ (define-public node-ms-bootstrap
     (arguments
      `(#:node ,node-bootstrap
        #:tests? #f
-       #:phases
-       (modify-phases %standard-phases
-         (delete 'configure))))
+       #:absent-dependencies
+       `("eslint"
+         "expect.js"
+         "husky"
+         "lint-staged"
+         "mocha")))
     (home-page "https://github.com/zeit/ms#readme")
     (properties '((hidden? . #t)))
     (synopsis "Tiny millisecond conversion utility")
-- 
2.32.0





Information forwarded to liliana.prikler@HIDDEN, guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 04:34:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 23:34:22 2021
Received: from localhost ([127.0.0.1]:41176 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moI4z-0007s6-OZ
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:21 -0500
Received: from mail-qk1-f180.google.com ([209.85.222.180]:37462)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moI4w-0007qd-3n
 for 51838 <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:18 -0500
Received: by mail-qk1-f180.google.com with SMTP id o63so12378915qkb.4
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 20:34:18 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=AMULJXHyOZipuNd58scXr0HRCAdd2zT9ONR4onrNEcY=;
 b=VSAcr/gdx/CbyW+Erhya2JffM1lolCPvELMpm0DUx9k/I7z0vK2nFRLHekSK741i1P
 WXjWj0nSpUVNijshmdqgI+Pyrh3sEVCxJS8Av7M87+5Y78k5sQGDhGwNJ2wTljIGk91e
 pFtNm8ZTQEBuUCU6m0qtO13z9hdIujWkau2Jcjv0Q0RcKsXT6jJtmGsUJCrOMkRrQ4OW
 /rxLsdkuIkVZIbFlKm0zqhL6rDghY1Gm9yeVeyVWLRtETqYuC2Wi8ySv5GoJ11pWkIGX
 8lMQHJu4+b9qeKy8NmVGTaT9jlX0sPfqa8bYkNOi55Ym+oV9aDXiEzOfRFWS2RzpTnOh
 Sa2w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=AMULJXHyOZipuNd58scXr0HRCAdd2zT9ONR4onrNEcY=;
 b=J/eD/q8HJ/T27hMiGKMnGHZbrYbxCzzas0ZHASbmVcaeigdiloRm5MwXNaQdCcfSCo
 CAII4pAsJAKX9CF0PyvgM/2MYOFUtDxX6siokYZ8k7IsjJNr0RVw1M5Fii1NDwTtoz1S
 jCszbUuuEhO6twjS75xfOKKYro+I2pj2WZ4gEzkFt03pSUIDpyV0bzh5KP/f1yOnPkCO
 tJOWfyBSIMiQoJIJBXr64B5HpkMtD05+VMQad1IhlGN/kPOJPJx/VKC73EIDu2j7ILFo
 VmniEmtCR9kvynQeQG6kZmkYh9RdCR8qyVo0N9xXt/KIYh2pdzAG16u7KPXUN/nb6IZY
 uK3A==
X-Gm-Message-State: AOAM530YCWN/lAOEABYYQgRJJXBTSIIg7+hhxRZ1QqJ92diaVGFipXsY
 94N2j0d5CItnXg2paFCi6QxFudeDJCgxlPP7
X-Google-Smtp-Source: ABdhPJyDeQCnvnTClz3zX4nlGI57YOWAMlBdzzra/MlULGf5yC+5DPWu4clyJ/H+LKJ1erhZCjuefg==
X-Received: by 2002:a05:620a:c53:: with SMTP id
 u19mr33860406qki.304.1637382852639; 
 Fri, 19 Nov 2021 20:34:12 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id bi39sm893167qkb.127.2021.11.19.20.34.12
 for <51838 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 19 Nov 2021 20:34:12 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH v2 06/26] gnu: node-semver-bootstrap: Use
 #:absent-dependencies.
Date: Fri, 19 Nov 2021 23:33:46 -0500
Message-Id: <20211120043406.952350-6-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211120043406.952350-1-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
MIME-Version: 1.0
X-Debbugs-CC: Pierre Langlois <pierre.langlois@HIDDEN>
X-Debbugs-CC: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

gnu/packages/node.scm (node-semver-bootstrap)[arguments]: Add
`#:absent-dependencies`. Stop deleting the `'configure` phase.
---
 gnu/packages/node.scm | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index 0f67fe79c2..6c958eebec 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -330,9 +330,8 @@ (define-public node-semver-bootstrap
     (arguments
      `(#:node ,node-bootstrap
        #:tests? #f
-       #:phases
-       (modify-phases %standard-phases
-         (delete 'configure))))
+       #:absent-dependencies
+       '("tap")))
     (home-page "https://github.com/npm/node-semver")
     (properties '((hidden? . #t)))
     (synopsis "Parses semantic versions strings")
-- 
2.32.0





Information forwarded to liliana.prikler@HIDDEN, guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 04:34:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 23:34:21 2021
Received: from localhost ([127.0.0.1]:41174 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moI4z-0007rt-67
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:21 -0500
Received: from mail-qt1-f181.google.com ([209.85.160.181]:35708)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moI4v-0007qb-AU
 for 51838 <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:17 -0500
Received: by mail-qt1-f181.google.com with SMTP id j17so11453011qtx.2
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 20:34:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=rFhMeClAh1FA9n4bk9oFR9mta1Ty4XRgs6HxE0DL8BU=;
 b=XtSL6lqyu4d5CYAsRg62nSMO6LPG8C2L8D0cAItuEaGZ2x9LaM0m4Mib1KvW3L8GKV
 w4Y6s9lW6MRAF1vtl1ZzpllcYbHKLGO5pCV+7GwJdi9d6EJ70dGxbOb/UGTGmcjd5myE
 NDmgbT6rYCjL8oBrx3ExMcAy9/0ORy9b59fwdtNN/sk4c//JLKD8Ya4jEB2fpW/+LFjy
 NI7JKJN1awBv09PLZTmUHL5aaTAnnm0/NlqwoI7N141gj0r6jzROVXGbZ5POQlTl5zE5
 K+IWaADTdqh1Ggb2NKC+RXhy+Ba7mKqiV6vA0bWGMf+lh74Yv+6MLWSYk4b0Wu1mUsdN
 CZtg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=rFhMeClAh1FA9n4bk9oFR9mta1Ty4XRgs6HxE0DL8BU=;
 b=u5UhZ7EZoozhb/X4wGz6Hk8rD3a+AtA5ugwoqFryXNXTr2a+ugWJdTTrVAXkn/o9qF
 lgyATkc2XLEbvy+BevE7YJGsHwaQ0mBHV6xzZNvZmebUKPfa5K1bHy/Qqa/4T1lgXM71
 EjffeC+0i/AsB+bRSRFejuFXC1HfO4zlrOeFs5e8hb2dqPcjDLcu2Gc3AdWN7bDax4aQ
 vHdpoi0HUkf18R82NTqCqxM/9XNr8SMydIF/tF/4HF+eUfST0RPqca8hA2pccAg31D1k
 VSKiXZkfdhmjPuIA3kV0nfCs8FdV+bknrOepwaDTfGBDt2lNP7qwng+CdJNIutwJoyku
 oDQg==
X-Gm-Message-State: AOAM531AVXerKPs5cbeCBlMAn0+czE4V0rzx3YzvKL/P7haVhOlPobXc
 Jhaz/qvHWPfDP2mcT8F85UiVwiwXZtpf7dy7
X-Google-Smtp-Source: ABdhPJw/hOZ8j2dV2l9gXXQjHfNeD1FMQKwMs6Jp4T218VixB47vBD860W1r6wAu1j3QVR+N6MjmdA==
X-Received: by 2002:ac8:7f09:: with SMTP id f9mr1696728qtk.163.1637382851670; 
 Fri, 19 Nov 2021 20:34:11 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id u10sm996300qtx.3.2021.11.19.20.34.11
 for <51838 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 19 Nov 2021 20:34:11 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH v2 05/26] guix: node-build-system: Add #:absent-dependencies
 argument.
Date: Fri, 19 Nov 2021 23:33:45 -0500
Message-Id: <20211120043406.952350-5-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211120043406.952350-1-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
MIME-Version: 1.0
X-Debbugs-CC: Pierre Langlois <pierre.langlois@HIDDEN>
X-Debbugs-CC: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.6 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.4 (/)

Many of Guix's Node.js packages are built without some of the
dependencies they specify in their "package-lock.json" files,
either because we don't have them packaged yet (e.g. test
utilities) or because we don't want them (e.g. to reduce the
closure size). Previously, Guix package definitions would work
around this situation by deleting the `'configure`
phase (i.e. the initial `npm install`).

This commit adds an optional #:absent-dependencies argument to
`node-build-system` to list Node.js packages that should be
removed from the "package.json" file.Retaining the `'configure`
phase avoids skipping checks for the dependencies that are
intended to be present and other actions performed by `npm
install`, such as automatically building native add-ons with
`node-gyp` when the "gypfile" key is present.

* guix/build-system/node.scm (lower, node-build): Add optional
argument #:absent-dependencies with default of ''(). Pass it on
to the build-side code.
* guix/build/node-build-system.scm (patch-dependencies): Respect
the #:absent-dependencies argument, removing specified npm
packages from the "dependencies" or "devDependencies" tables
in "package.json". Also, strictly follow the linearity rules
for `assoc-set!` and friends.
---
 guix/build-system/node.scm       |  3 ++
 guix/build/node-build-system.scm | 55 ++++++++++++++++++++++----------
 2 files changed, 41 insertions(+), 17 deletions(-)

diff --git a/guix/build-system/node.scm b/guix/build-system/node.scm
index 98f63f87ef..75ae34508f 100644
--- a/guix/build-system/node.scm
+++ b/guix/build-system/node.scm
@@ -44,6 +44,7 @@ (define (default-node)
 (define* (lower name
                 #:key source inputs native-inputs outputs system target
                 (node (default-node))
+                (absent-dependencies ''())
                 #:allow-other-keys
                 #:rest arguments)
   "Return a bag for NAME."
@@ -73,6 +74,7 @@ (define* (node-build store name inputs
                      (tests? #t)
                      (phases '(@ (guix build node-build-system)
                                  %standard-phases))
+                     (absent-dependencies ''())
                      (outputs '("out"))
                      (search-paths '())
                      (system (%current-system))
@@ -94,6 +96,7 @@ (define builder
                    #:test-target ,test-target
                    #:tests? ,tests?
                    #:phases ,phases
+                   #:absent-dependencies ,absent-dependencies
                    #:outputs %outputs
                    #:search-paths ',(map search-path-specification->sexp
                                          search-paths)
diff --git a/guix/build/node-build-system.scm b/guix/build/node-build-system.scm
index 70a367618e..32d6807e3e 100644
--- a/guix/build/node-build-system.scm
+++ b/guix/build/node-build-system.scm
@@ -69,30 +69,51 @@ (define (list-modules directory)
               input-paths)
     index))
 
-(define* (patch-dependencies #:key inputs #:allow-other-keys)
+(define* (patch-dependencies #:key inputs absent-dependencies
+                             #:allow-other-keys)
 
   (define index (index-modules (map cdr inputs)))
 
-  (define (resolve-dependencies package-meta meta-key)
-    (fold (lambda (key+value acc)
-            (match key+value
-              ('@ acc)
-              ((key . value) (acons key (hash-ref index key value) acc))))
+  (define (resolve-dependencies meta-alist meta-key)
+    (match (assoc-ref meta-alist meta-key)
+      (#f
+       '())
+      (('@ . orig-deps)
+       (fold (match-lambda*
+               (('@ acc)
+                acc)
+                (((key . value) acc)
+                 (if (member key absent-dependencies)
+                     acc
+                     (acons key (hash-ref index key value) acc))))
           '()
-          (or (assoc-ref package-meta meta-key) '())))
+          orig-deps))))
 
   (with-atomic-file-replacement "package.json"
     (lambda (in out)
-      (let ((package-meta (read-json in)))
-        (assoc-set! package-meta "dependencies"
-                    (append
-                     '(@)
-                     (resolve-dependencies package-meta "dependencies")
-                     (resolve-dependencies package-meta "peerDependencies")))
-        (assoc-set! package-meta "devDependencies"
-                    (append
-                     '(@)
-                     (resolve-dependencies package-meta "devDependencies")))
+      ;; It is unsafe to rely on 'assoc-set!' to update an
+      ;; existing assosciation list variable:
+      ;; see 'info "(guile)Adding or Setting Alist Entries"'.
+      (let* ((package-meta (read-json in))
+             (alist (match package-meta
+                      ((@ . alist) alist)))
+             ;; Other relevant keys may include peerDependenciesMeta
+             ;; and optionalDependencies, but it seems to work out fine
+             ;; just to leave those alone.
+             (alist
+              (assoc-set!
+               alist "dependencies"
+               (append
+                '(@)
+                (resolve-dependencies alist "dependencies")
+                (resolve-dependencies alist "peerDependencies"))))
+             (alist
+              (assoc-set!
+               alist "devDependencies"
+               (append
+                '(@)
+                (resolve-dependencies alist "devDependencies"))))
+             (package-meta (cons '@ alist)))
         (write-json package-meta out))))
   #t)
 
-- 
2.32.0





Information forwarded to liliana.prikler@HIDDEN, guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 04:34:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 23:34:21 2021
Received: from localhost ([127.0.0.1]:41171 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moI4y-0007rl-QU
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:21 -0500
Received: from mail-qk1-f176.google.com ([209.85.222.176]:34726)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moI4u-0007qZ-1X
 for 51838 <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:16 -0500
Received: by mail-qk1-f176.google.com with SMTP id t6so12402135qkg.1
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 20:34:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=laPpxNN++I5Kngpc08bz6Lh1/8GAB9Aqp19GJIgLjfk=;
 b=SLLvjGTOB2lwoFgZqNzxzxbCIYAtG7gzzVeTWU2/PoOsOiy0zxOUOjiFq6giKMMEbR
 NQ30RulGoCpCEEun1ybjdCoiuzV9OxdVuA019FCS3B37jCiciWce9+01efYkVNA2GOVX
 yg7Wj168DEX5HGzh4ZHw+/m6S9paBnHF7xVNeYdfUyLgrKU/sTcD4tnOwZor4yOVW840
 gafO55SxDupWO5cL8M5tY5R3Je/UGMPacaltylIWGroHCiPM0jLoRMOGmRh7pEEHFAJa
 IyGekLlb9NU0pY+KwjIAGE1HJP5oABIcjlbjBkQR0UPfrpS7q/U5yjvaJLP6kqEUW84P
 ywuA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=laPpxNN++I5Kngpc08bz6Lh1/8GAB9Aqp19GJIgLjfk=;
 b=WBqCLv10a1B7l1UBZ49rK/N4Ft5LRJcXqvgTY07YZE74onXnzifUw6FM45wROCgXQs
 kx/TlJk7zyBDwO7MsJr5L7g6w6OXGWdTCuiz6bDbarreFckplCRdcD4GNQHRG5ciyq6K
 gbw5OxZihC5jLEAwoINwKqCfUKcCWOCPmPLiXPrGLsYPSiMoWa5T8pems1ed0TNVI+eq
 A5XlgWaD/RKyQRPA7PZGsGiz5SLYtyMocfarISufvWMF/dIMj8h6yMZXQvixt5d0cjMU
 fHaq+HWKLpcRShGVkFRZvIAyrG7Nl4o/1QIj1PIb04EXQou1EesqydXAKJ6BWwbUc4Ba
 qO+A==
X-Gm-Message-State: AOAM531Y+XQHMFw39govvDFjrdrsHbBQMRyPimNQywPQPSF9bfU1YDEy
 f89hKxKB8zZaLn5zohWhqynmQBB2aJN3svPX
X-Google-Smtp-Source: ABdhPJz3iH5auJ9EBJpru2jWpb60QUNPSVQd/QZh88o+aTWRe/5//WYMsfG2N3Z2QERODaYlL+e2xQ==
X-Received: by 2002:a37:9f84:: with SMTP id
 i126mr33780996qke.249.1637382850464; 
 Fri, 19 Nov 2021 20:34:10 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id v125sm990534qki.63.2021.11.19.20.34.10
 for <51838 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 19 Nov 2021 20:34:10 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH v2 04/26] gnu: node: Add an npmrc file to set nodedir.
Date: Fri, 19 Nov 2021 23:33:44 -0500
Message-Id: <20211120043406.952350-4-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211120043406.952350-1-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
MIME-Version: 1.0
X-Debbugs-CC: Pierre Langlois <pierre.langlois@HIDDEN>
X-Debbugs-CC: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

* gnu/packages/node.scm (node, node-lis)[arguments]: Add a phase
'install-npmrc to create a "built-in" npmrc file that configures
"nodedir" to point to the output store path.
(libnode)[arguments]: Delete the 'install-npmrc phase.
---
 gnu/packages/node.scm | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index a57a74fb81..0f67fe79c2 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -250,7 +250,21 @@ (define-public node
                 (find-files (string-append prefix "/lib/node_modules")
                             (lambda (file stat)
                               (executable-file? file))
-                            #:stat lstat))))))))
+                            #:stat lstat)))))
+         (add-after 'install 'install-npmrc
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out")))
+               (with-output-to-file
+                   ;; Use the config file "primarily for distribution
+                   ;; maintainers" rather than "{prefix}/etc/npmrc",
+                   ;; especially because node-build-system uses --prefix
+                   ;; to install things to their store paths:
+                   (string-append out "/lib/node_modules/npm/npmrc")
+                 (lambda ()
+                   ;; Tell npm (mostly node-gyp) where to find our
+                   ;; installed headers so it doesn't try to
+                   ;; download them from the internet:
+                   (format #t "nodedir=~a\n" out)))))))))
     (native-inputs
      `(;; Runtime dependencies for binaries used as a bootstrap.
        ("c-ares" ,c-ares)
@@ -818,4 +832,5 @@ (define-public libnode
         `(cons* "--shared" "--without-npm" ,flags))
        ((#:phases phases '%standard-phases)
         `(modify-phases ,phases
+           (delete 'install-npmrc)
            (delete 'patch-nested-shebangs)))))))
-- 
2.32.0





Information forwarded to liliana.prikler@HIDDEN, guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 04:34:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 23:34:20 2021
Received: from localhost ([127.0.0.1]:41169 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moI4y-0007re-Du
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:20 -0500
Received: from mail-qv1-f48.google.com ([209.85.219.48]:37439)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moI4t-0007qX-2Y
 for 51838 <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:15 -0500
Received: by mail-qv1-f48.google.com with SMTP id u16so8545834qvk.4
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 20:34:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=vNLOSTWhsUvYl4zbQmT0Z6mwdgkAqlBATEO6lq8SgZA=;
 b=DW/JLx/bsBYpFKBmrZgbkDSDSyHVU8MWjdDIHStgEsg8q8WskYPrB+YDpedxENSK0C
 H6B0xPPTy94CUdrTUbpU3dPBhEoHb5vEgVebS+qwT6xKjLhwExx7KkIS+X6sBTetRrD6
 dUvQh9Nk9TRY4svjwK4XT/Sd/TIedBCgqfzDW20wX4rlWLrIBJqkLaLCZudhvLMaWthS
 qbJ4rfK9VJwb8gNuFzYhnt58XdfJxdIADNeF1a8r+G8wTs+4Wczgs8d19j6kTl6t63Uq
 29V98snJnyF4+DbVQhhnnkdmNBfH9AHXCw7L4A1iexJs/3hHL+vzX+u1Nlw95A3kW4l+
 7ieA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=vNLOSTWhsUvYl4zbQmT0Z6mwdgkAqlBATEO6lq8SgZA=;
 b=02f/71S/GswCodhGWxPxiZN86ZPdcl3A1kD3MGLl59uuYqyIQ+xe88Vjm+tkWnnDUv
 Xx9PJmk0M6/gM8ciwhkwOF3p7iwMaxvBFCGFAwP4I1xHQx4/pfFxnidEh5HQOwGpzSzW
 KBcuXjBu/Phpa+P9e4jJ4iBZM7XFStju538D/eSqhTAzP6h2pWuIx5tnMczPeqHxeiLM
 vE8AQfSXh1FngS8gpmjSXlM+4P0i0iuG4o1yyAvKajHpJy4W0ScnbcIF/5nsOH4WmcZi
 V4cStnIqiAJWUHIVvdNLzVBODR8/QN4rKk7QlLAffJxpfUU/hZvDrXzCqPTDJUtM4Nj2
 ZuMg==
X-Gm-Message-State: AOAM533BHCFP13q4UYuqO2WxZ+ERH4rXhDkVd4GZfhssCNK5PfiPbHTk
 S5UBV2q9ZI6rUIoWJiqaV27DquEjGiyDfmCQ
X-Google-Smtp-Source: ABdhPJwf10H466nobbs1bI7S+iIua4Srz84k9IfIR9qlJTFbCKZHRYv8KRExamq7CLOB6sSU0zA6mA==
X-Received: by 2002:ad4:5e87:: with SMTP id jl7mr78673917qvb.19.1637382849567; 
 Fri, 19 Nov 2021 20:34:09 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id bs7sm974082qkb.79.2021.11.19.20.34.09
 for <51838 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 19 Nov 2021 20:34:09 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH v2 03/26] gnu: node: Patch shebangs in node_modules.
Date: Fri, 19 Nov 2021 23:33:43 -0500
Message-Id: <20211120043406.952350-3-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211120043406.952350-1-philip@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
 <20211120043406.952350-1-philip@HIDDEN>
MIME-Version: 1.0
X-Debbugs-CC: Pierre Langlois <pierre.langlois@HIDDEN>
X-Debbugs-CC: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

* gnu/packages/node.scm (node)[arguments]: Replace 'patch-npm-shebang
and 'patch-node-shebang with a new 'patch-nested-shebangs that also
handles node-gyp and other shebangs under "/lib/node_modules".
[inputs]: Add Python for node-gyp as "python-for-target".
(node-lts)[inputs]: Likewise.
(libnode)[arguments]: Adjust to delete 'patch-nested-shebangs rather
than 'patch-npm-shebang and 'patch-node-shebang.
---
 gnu/packages/node.scm | 34 +++++++++++++++++-----------------
 1 file changed, 17 insertions(+), 17 deletions(-)

diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index 71b66774a6..a57a74fb81 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -237,21 +237,20 @@ (define-public node
                             python
                             (string-append python "3")))
                       "configure" flags))))
-         (add-after 'patch-shebangs 'patch-npm-shebang
-           (lambda* (#:key outputs #:allow-other-keys)
-             (let* ((bindir (string-append (assoc-ref outputs "out")
-                                           "/bin"))
-                    (npm    (string-append bindir "/npm"))
-                    (target (readlink npm)))
-               (with-directory-excursion bindir
-                 (patch-shebang target (list bindir))))))
-         (add-after 'install 'patch-node-shebang
-           (lambda* (#:key outputs #:allow-other-keys)
-             (let* ((bindir (string-append (assoc-ref outputs "out")
-                                           "/bin"))
-                    (npx    (readlink (string-append bindir "/npx"))))
-               (with-directory-excursion bindir
-                 (patch-shebang npx (list bindir)))))))))
+         (add-after 'patch-shebangs 'patch-nested-shebangs
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (let* ((prefix (assoc-ref outputs "out"))
+                    (path (map (lambda (dir)
+                                 (string-append dir "/bin"))
+                               (list prefix
+                                     (assoc-ref inputs "python-for-target")))))
+               (for-each
+                (lambda (file)
+                  (patch-shebang file path))
+                (find-files (string-append prefix "/lib/node_modules")
+                            (lambda (file stat)
+                              (executable-file? file))
+                            #:stat lstat))))))))
     (native-inputs
      `(;; Runtime dependencies for binaries used as a bootstrap.
        ("c-ares" ,c-ares)
@@ -274,6 +273,7 @@ (define-public node
     (inputs
      `(("bash" ,bash-minimal)
        ("coreutils" ,coreutils)
+       ("python-for-target" ,python-wrapper) ;; for node-gyp (supports python3)
        ("c-ares" ,c-ares)
        ("http-parser" ,http-parser)
        ("icu4c" ,icu4c)
@@ -799,6 +799,7 @@ (define-public node-lts
     (inputs
      `(("bash" ,bash-minimal)
        ("coreutils" ,coreutils)
+       ("python-for-target" ,python-wrapper) ;; for node-gyp (supports python3)
        ("c-ares" ,c-ares-for-node)
        ("icu4c" ,icu4c-67)
        ("libuv" ,libuv-for-node)
@@ -817,5 +818,4 @@ (define-public libnode
         `(cons* "--shared" "--without-npm" ,flags))
        ((#:phases phases '%standard-phases)
         `(modify-phases ,phases
-           (delete 'patch-npm-shebang)
-           (delete 'patch-node-shebang)))))))
+           (delete 'patch-nested-shebangs)))))))
-- 
2.32.0





Information forwarded to liliana.prikler@HIDDEN, guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 04:34:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 23:34:15 2021
Received: from localhost ([127.0.0.1]:41161 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moI4s-0007qo-UF
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:15 -0500
Received: from mail-qk1-f182.google.com ([209.85.222.182]:47102)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moI4r-0007qU-KP
 for 51838 <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:34:14 -0500
Received: by mail-qk1-f182.google.com with SMTP id a11so12320990qkh.13
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 20:34:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=KH4RQSW2Vl/+hSZ71LTsM4xePvjwFAevZ9cxlfrinCQ=;
 b=GwjefNglQClkVKWybgbEMQ0rhHnxlW1J7Nn2HXt5dPNZ+8NztORJQvfaYuKhgfuilN
 brEmAgK9/WEaUTfBJXIVrZ4Sog08de/xxB+qTtFIBYFBBPefEytBSlBHBwbOuwFSlnxa
 GTptNYvq6C/ig6961X+/hYa/gefKUNkP82SQayn8I28LA7XBH4cVu5HvgtXFHx4j1TZF
 ZtfvxyGCDk42zT8aUh7lm4cOTwif8BAstKsqqE/ciE6NWudNoJ2+h1m/UGSHOCP4MWjF
 9lcBUPW0u+uh/6o4Xx2r9EKe8FIhjn6LuJVf5TUok+ndr+ljSKpkboVHH7n0Pjs8PnRW
 5RJg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=KH4RQSW2Vl/+hSZ71LTsM4xePvjwFAevZ9cxlfrinCQ=;
 b=N/lzPKhtr+71ll/vJW99LbIoRbwgDCPRAxxCnkfgRTbBt5vje/lgJckM2F2mFOu3L0
 ub5aftQr8i9wkrDEQpWt9uSdcrKnqmfNWLeU+FD8W6+8PahVvAZ9yQyykHoXQI3NK4yG
 YC27J946Tqnt9f/LE+FMMttCxEEudDf3zRx2eAS1U4dtcchLgi/ixMrTqvYr6w/bnYkq
 XC9FHiCJ2reG3TWhRysSbSznACnWKB1ndtyHtkHiIJ1KsNY1ZKkfd/IFbTNigviKoD14
 aZxyGGI3HmCdpmOW1ZqjB8mPzNZfG8O0gRmXpibmS6Rt1dzcVhiKdhnMvNPF6AYKE0Ll
 1v8w==
X-Gm-Message-State: AOAM533oLoRetVZ9f7WoFCjmWswPuT/O4hfietKrSFM2cts6QeHgRpWx
 IyGeO4tEJ/m2Swh4ueLYZplPXwt5zO8uh66g
X-Google-Smtp-Source: ABdhPJzt5m/NcaMytJewB1QWw47WHGoYL33zPtdWYnZAm7OG3KwFN8f7IDw3kR1dde1TjcAUsKhPmw==
X-Received: by 2002:a37:9cf:: with SMTP id 198mr32983015qkj.308.1637382847785; 
 Fri, 19 Nov 2021 20:34:07 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id r20sm1059262qkp.21.2021.11.19.20.34.07
 for <51838 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 19 Nov 2021 20:34:07 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH v2 01/26] gnu: node: Avoid duplicating build phases.
Date: Fri, 19 Nov 2021 23:33:41 -0500
Message-Id: <20211120043406.952350-1-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
MIME-Version: 1.0
X-Debbugs-CC: Pierre Langlois <pierre.langlois@HIDDEN>
X-Debbugs-CC: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 51838
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

* gnu/packages/node.scm (node)[arguments]: Split 'patch-files phase
into 'patch-hardcoded-program-references and
'delete-problematic-tests. Adapt 'patch-hardcoded-program-references
and 'configure to work unmodified on node-lts, but don't try to
share 'delete-problematic-tests, because those details seem to change
too much between node versions.
(node, node-lts)[inputs]: Use bash-minimal rather than bash.
(node-lts)[arguments]: Inherit 'patch-hardcoded-program-references,
and 'configure phases from the bootstrap node.
Remove the 'patch-files phase, keeping its remaining
non-inherited work in a new 'replace-llhttp-sources phase.
---
 gnu/packages/node.scm | 105 +++++++++++++-----------------------------
 1 file changed, 32 insertions(+), 73 deletions(-)

diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index dccf871d2c..7ebbbc3060 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2020, 2021 Pierre Langlois <pierre.langlois@HIDDEN>
 ;;; Copyright © 2020 Ricardo Wurmus <rekado@HIDDEN>
 ;;; Copyright © 2021 Simon Tournier <zimon.toutoune@HIDDEN>
+;;; Copyright © 2021 Philip McGrath <philip@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -105,14 +106,22 @@ (define-public node
        #:test-target "test-ci-js"
        #:phases
        (modify-phases %standard-phases
-         (add-before 'configure 'patch-files
+         (add-before 'configure 'patch-hardcoded-program-references
            (lambda* (#:key inputs #:allow-other-keys)
+
              ;; Fix hardcoded /bin/sh references.
-             (substitute* '("lib/child_process.js"
-                            "lib/internal/v8_prof_polyfill.js"
-                            "test/parallel/test-child-process-spawnsync-shell.js"
-                            "test/parallel/test-stdio-closed.js"
-                            "test/sequential/test-child-process-emfile.js")
+             (substitute*
+                 (let ((common
+                        '("lib/child_process.js"
+                          "lib/internal/v8_prof_polyfill.js"
+                          "test/parallel/test-child-process-spawnsync-shell.js"
+                          "test/parallel/test-stdio-closed.js"
+                          "test/sequential/test-child-process-emfile.js"))
+                       ;; not in bootstap node:
+                       (sigxfsz "test/parallel/test-fs-write-sigxfsz.js"))
+                   (if (file-exists? sigxfsz)
+                       (cons sigxfsz common)
+                       common))
                (("'/bin/sh'")
                 (string-append "'" (assoc-ref inputs "bash") "/bin/sh'")))
 
@@ -122,7 +131,10 @@ (define-public node
                             "test/parallel/test-child-process-exec-env.js")
                (("'/usr/bin/env'")
                 (string-append "'" (assoc-ref inputs "coreutils")
-                               "/bin/env'")))
+                               "/bin/env'")))))
+         (add-after 'patch-hardcoded-program-references
+             'delete-problematic-tests
+           (lambda* (#:key inputs #:allow-other-keys)
 
              ;; FIXME: These tests fail in the build container, but they don't
              ;; seem to be indicative of real problems in practice.
@@ -217,9 +229,13 @@ (define-public node
                (setenv "CXX" ,(cxx-for-target))
                (setenv "PKG_CONFIG" ,(pkg-config-for-target))
                (apply invoke
-                      (string-append (assoc-ref (or native-inputs inputs)
-                                                "python")
-                                     "/bin/python")
+                      (let ((python
+                             (string-append (assoc-ref (or native-inputs inputs)
+                                                       "python")
+                                            "/bin/python")))
+                        (if (file-exists? python)
+                            python
+                            (string-append python "3")))
                       "configure" flags))))
          (add-after 'patch-shebangs 'patch-npm-shebang
            (lambda* (#:key outputs #:allow-other-keys)
@@ -256,7 +272,7 @@ (define-public node
             (variable "NODE_PATH")
             (files '("lib/node_modules")))))
     (inputs
-     `(("bash" ,bash)
+     `(("bash" ,bash-minimal)
        ("coreutils" ,coreutils)
        ("c-ares" ,c-ares)
        ("http-parser" ,http-parser)
@@ -712,66 +728,8 @@ (define-public node-lts
                                    libuv "/lib:"
                                    zlib "/lib"
                                    "'],"))))))
-           (replace 'configure
-             ;; Node's configure script is actually a python script, so we can't
-             ;; run it with bash.
-             (lambda* (#:key outputs (configure-flags '()) native-inputs inputs
-                       #:allow-other-keys)
-               (let* ((prefix (assoc-ref outputs "out"))
-                      (xflags ,(if (%current-target-system)
-                                   `'("--cross-compiling"
-                                     ,(string-append
-                                       "--dest-cpu="
-                                       (match (%current-target-system)
-                                         ((? (cut string-prefix? "arm" <>))
-                                          "arm")
-                                         ((? (cut string-prefix? "aarch64" <>))
-                                          "arm64")
-                                         ((? (cut string-prefix? "i686" <>))
-                                          "ia32")
-                                         ((? (cut string-prefix? "x86_64" <>))
-                                          "x64")
-                                         ((? (cut string-prefix? "powerpc64" <>))
-                                          "ppc64")
-                                         (_ "unsupported"))))
-                                   ''()))
-                      (flags (cons
-                               (string-append "--prefix=" prefix)
-                               (append xflags configure-flags))))
-                 (format #t "build directory: ~s~%" (getcwd))
-                 (format #t "configure flags: ~s~%" flags)
-                 ;; Node's configure script expects the CC environment variable to
-                 ;; be set.
-                 (setenv "CC_host" "gcc")
-                 (setenv "CXX_host" "g++")
-                 (setenv "CC" ,(cc-for-target))
-                 (setenv "CXX" ,(cxx-for-target))
-                 (setenv "PKG_CONFIG" ,(pkg-config-for-target))
-                 (apply invoke
-                        (string-append (assoc-ref (or native-inputs inputs)
-                                                  "python")
-                                       "/bin/python3")
-                        "configure" flags))))
-           (replace 'patch-files
+           (replace 'delete-problematic-tests
              (lambda* (#:key inputs #:allow-other-keys)
-               ;; Fix hardcoded /bin/sh references.
-               (substitute* '("lib/child_process.js"
-                              "lib/internal/v8_prof_polyfill.js"
-                              "test/parallel/test-child-process-spawnsync-shell.js"
-                              "test/parallel/test-fs-write-sigxfsz.js"
-                              "test/parallel/test-stdio-closed.js"
-                              "test/sequential/test-child-process-emfile.js")
-                 (("'/bin/sh'")
-                  (string-append "'" (assoc-ref inputs "bash") "/bin/sh'")))
-
-               ;; Fix hardcoded /usr/bin/env references.
-               (substitute* '("test/parallel/test-child-process-default-options.js"
-                              "test/parallel/test-child-process-env.js"
-                              "test/parallel/test-child-process-exec-env.js")
-                 (("'/usr/bin/env'")
-                  (string-append "'" (assoc-ref inputs "coreutils")
-                                 "/bin/env'")))
-
                ;; FIXME: These tests fail in the build container, but they don't
                ;; seem to be indicative of real problems in practice.
                (for-each delete-file
@@ -810,8 +768,9 @@ (define-public node-lts
                ;; TODO: Regenerate certs instead.
                (for-each delete-file
                          '("test/parallel/test-tls-passphrase.js"
-                           "test/parallel/test-tls-server-verify.js"))
-
+                           "test/parallel/test-tls-server-verify.js"))))
+           (add-after 'delete-problematic-tests 'replace-llhttp-sources
+             (lambda* (#:key inputs #:allow-other-keys)
                ;; Replace pre-generated llhttp sources
                (let ((llhttp (assoc-ref inputs "llhttp")))
                  (copy-file (string-append llhttp "/src/llhttp.c")
@@ -838,7 +797,7 @@ (define-public node-lts
        ("python" ,python)
        ("util-linux" ,util-linux)))
     (inputs
-     `(("bash" ,bash)
+     `(("bash" ,bash-minimal)
        ("coreutils" ,coreutils)
        ("c-ares" ,c-ares-for-node)
        ("icu4c" ,icu4c-67)
-- 
2.32.0





Information forwarded to liliana.prikler@HIDDEN, guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 04:26:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 23:26:14 2021
Received: from localhost ([127.0.0.1]:41151 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moHx8-0007b6-Av
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:26:14 -0500
Received: from mail-qv1-f41.google.com ([209.85.219.41]:35518)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1moHx6-0007aq-8C
 for 51838 <at> debbugs.gnu.org; Fri, 19 Nov 2021 23:26:13 -0500
Received: by mail-qv1-f41.google.com with SMTP id g1so8518244qvd.2
 for <51838 <at> debbugs.gnu.org>; Fri, 19 Nov 2021 20:26:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=message-id:date:mime-version:user-agent:subject:content-language:to
 :cc:references:from:in-reply-to:content-transfer-encoding;
 bh=FvpHoCQ6pAYGr59ljfr0iZSpe4T/ujl1rktP93DEteg=;
 b=Gt3AdPvN7BYOrr19jh0+BMIQpIx/z3607nl/6CmViypfL6UVvbiz1zHAdAIw5GPOM3
 jfQSsiz1BoRJSdaBDm7E2ZrKeIM/jNnqawQoCDlSPdML1dvJ1XUC53VGHeheSV4YesWS
 oJHL375Lo8HBR5XMl0wMA8p/D0JSFXkKnXByaZPjGTxZ43nMBxd3d31uuqjK3qSbsUbm
 qml3z8q1GMNNFLhYwWofxujiitpkFBXiYcRT8D+HDVfWt/3168JJFFnwA+8gy1Cls26k
 IIuDQ5vUJQKPGTD3rGriNwsGBAI+IQ5D+dIri4/qG/vOPAzcCRAoIPedVQeBAXn3fMxl
 DTpA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
 :content-language:to:cc:references:from:in-reply-to
 :content-transfer-encoding;
 bh=FvpHoCQ6pAYGr59ljfr0iZSpe4T/ujl1rktP93DEteg=;
 b=0JBaahkjiqWANUazAecQQQzqHSzYHejF7LgIuYfXy02U1spMF9mYdsFA0VJP+2gfjF
 4IuzeqiX+XB783B7isTcbE27PfJ1MHVZAJ+raYhguQcb2SDfnh0pn7u06ZVl7+ttQ8G5
 A6Qjy1/TrIYK5hhBCDABvJ5OF44KLA/51IresqVi8xQ4VuSMEBWVIQbISU4DXeyK/svB
 82yNczoPdK+NvAVXWixPojG8ZZUlv4rmlFvqt8xTFNdN6dwQXLsUZh+QTOlqxuEEBWpj
 JJKEnZbUQeMii0V4qqtGg8pV6m03eyLAAsG18JliYfqNGZ5eNTObt3bG3KdcoLJYZSwj
 wNfw==
X-Gm-Message-State: AOAM533G8kXlcvVsZF9QqsXwubWdBJKZ5fuUBE0Clv6o2R7YNghCa2Ow
 2ogJKxJ/NRVLj4u/Brwsg7xRNA==
X-Google-Smtp-Source: ABdhPJyIIYiqC6X0daUp0/C3XBmvXHV/2gb0Wst70UEsxorWgQY84ckbjDlruDJSB/tmwHuR4d6vOA==
X-Received: by 2002:a0c:edb0:: with SMTP id h16mr79942924qvr.17.1637382366726; 
 Fri, 19 Nov 2021 20:26:06 -0800 (PST)
Received: from [192.168.45.37] (c-73-125-89-242.hsd1.fl.comcast.net.
 [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id t11sm993037qkp.56.2021.11.19.20.26.06
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 19 Nov 2021 20:26:06 -0800 (PST)
Message-ID: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@HIDDEN>
Date: Fri, 19 Nov 2021 23:26:05 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.1
Subject: Re: [PATCH 03/11] guix: node-build-system: Support compiling add-ons
 with node-gyp.
Content-Language: en-US
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>, 51838 <at> debbugs.gnu.org
References: <20211114125830.45427-1-philip@HIDDEN>
 <20211114130409.49241-1-philip@HIDDEN>
 <20211114130409.49241-2-philip@HIDDEN>
 <48018e12484d19466d9c6f253a8d7ebeae93e947.camel@HIDDEN>
From: Philip McGrath <philip@HIDDEN>
In-Reply-To: <48018e12484d19466d9c6f253a8d7ebeae93e947.camel@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.6 (/)
X-Debbugs-Envelope-To: 51838
Cc: Pierre Langlois <pierre.langlois@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.4 (/)

Hi!

On 11/14/21 15:44, Liliana Marie Prikler wrote:
> Looking at this patch, it does *a lot* at once and could probably be
> separated into more than one.  Particularly, I'd suggest providing
> capabilities in node-build-system first, then switching over to the new
> thing in node.

Thanks for these comments. Some of the things to which you drew my 
attention seem to have been workarounds for problems that had since been 
solved at a deeper level. Then, in particular, this comment:


 >> +(define* (configure-gyp #:key inputs #:allow-other-keys)
 >> +  "Run 'node-gyp configure' if we see a 'binding.gyp' file."
 >> +  (if (file-exists? "binding.gyp")
 >> +      (invoke (which "node-gyp") "configure")
 >> +      #t))
 >> +
 > You might want to make this part of configure itself, though I'm not
 > sure what the consensus is there when mixing different build system
 > styles.  (invoke (which ...) ) is also a pretty rare pattern, used in
 > only four locations so far.

prompted me to look more closely at why so much manual work was needed 
in the first place.

It turns out that the `npm install` in the `'configure` phase should 
have handled most of it automatically, but the Guix packages were 
deleting the configure phase to avoid checking for devDependencies that 
aren't in Guix (or that we just don't want, e.g. some dependencies of 
node-sqlite3).

In v2 of this series (which will follow this email), I've removed all of 
the `node-gyp`-specific build-side code and tried a more general 
solution, adding an `#:absent-packages` argument to instruct the 
`'patch-dependencies` phase to remove the specified packages from the 
"package.json" file. This means that the Guix package can still run 
`'configure`/`npm install`, checking properly for the packages that we 
*do* have/want and doing all of the other automatic work `npm install` 
does. I also like that listing the missing packages in the Guix package 
definition provides a sort of documentation of what is missing: for 
example, it is clear which packages could have their tests enabled with 
the addition of a `node-tap` package, without having to inspect all of 
the individual "package.json" files.

I've updated all of the existing Node.js packages that deleted their 
`'configure` phase to use `#:absent-dependencies` instead.

>> @@ -58,10 +62,13 @@ (define private-keywords
>>                                 `(("source" ,source))
>>                                 '())
>>                           ,@inputs
>> -
>>                           ;; Keep the standard inputs of 'gnu-build-
>> system'.
>>                           ,@(standard-packages)))
>>            (build-inputs `(("node" ,node)
>> +                         ("python" ,python)
>> +                        ;; We don't always need libuv, but the libuv
>> and
>> +                        ;; node versions need to match:
>> +                        ("libuv" ,@(assoc-ref (package-inputs node)
>> "libuv"))
>>                            ,@native-inputs))
>>            (outputs outputs)
>>            (build node-build)
> Will this python input always or often enough be needed?  What's the
> build system ratio on node like, gyp vs. anything else, particularly
> with packages close to the node core?

GYP is a Python program, and it (or at least node's fork of it) expects 
to have a python executable available to invoke with sub-programs. Since 
npm depends on node-gyp and GYP, it is pretty close to the core.

In v2, I've just had packages that use node-gyp add Python to their 
inputs. IIRC, that used to not be enough, but it seems underlying 
problems were fixed in the mean time.

An alternative approach would be to configure it using the npmrc file, 
as I do for `nodedir` in v2. I'm not sure that makes much difference 
either way, but in v2 I've tried to minimize the amount of 
`node-gyp`-specific handling.

-Philip




Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 14 Nov 2021 20:44:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 14 15:44:27 2021
Received: from localhost ([127.0.0.1]:51837 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mmMMR-0007WU-BB
	for submit <at> debbugs.gnu.org; Sun, 14 Nov 2021 15:44:26 -0500
Received: from mail-wr1-f67.google.com ([209.85.221.67]:37844)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liliana.prikler@HIDDEN>) id 1mmMMO-0007WE-8v
 for 51838 <at> debbugs.gnu.org; Sun, 14 Nov 2021 15:44:21 -0500
Received: by mail-wr1-f67.google.com with SMTP id b12so26567841wrh.4
 for <51838 <at> debbugs.gnu.org>; Sun, 14 Nov 2021 12:44:20 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=message-id:subject:from:to:cc:date:in-reply-to:references
 :user-agent:mime-version:content-transfer-encoding;
 bh=UwClZr4hyl5pH/iS3pEuOMGgq4vG7OlSKei5DkFZuFU=;
 b=pGWCUoAM6jbI4UYJKFoZ6WzznU0RuRS+0Jfum61jlkirkCgw3oA/bAeOL/OKEwMImx
 cwZeT+cXaR1lPiHL+sh8U9M2pt2+SwSXhadlVSJkKZ0ryrILl9gXzUSib5aB1L/k9olI
 Dclo/DDQv6JSGgxdmFV9WhUQsD80tCP4ox26hJVzoUxODhqSSJRBevYpVVsoXoeoXV9W
 5T3NNNOnra2mTgk8f4A3V9Yh1fg72KYiB7VdEA4rACN7owvNLkbuMUC1gJoE47sNN5xa
 2KXOd0vyfQ76bVbaOlEvym45lj8oC9dd58qopp3e2fP57yJt1ppmWqC7BkiZcKldInb2
 3Nzw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
 :references:user-agent:mime-version:content-transfer-encoding;
 bh=UwClZr4hyl5pH/iS3pEuOMGgq4vG7OlSKei5DkFZuFU=;
 b=7fbCPOeSYglJ5HjvBKoFrw2QbZfkyCsLcR1NI+U5M+QS0bE6gPcYPhkbkyeAM1zZnJ
 jv3OAEtKwuLffatl8v8F/OdUUfM/1dyXDmXxQ5q8yJNrcTeM/ruS8Vx2aZr97/Dhnf9R
 KjSYabLY0eBSZoPLtYdV3UK0s2FW/hbzwh/W5iK2Yn8B3s+4pclO0fNRomtDS3LuQLC2
 XYV5QFqkXbT1GA7wisHGW4E7jDAGIdeqJA60CbQvhnSljnvWxhyEEE8JYu5GndFwTnsh
 ZP+fC+N9JAhsYorGb6NyRTUf6RGO4Awym/XU1lpRNebaMCcujmuyCq5zAp6/Ut+F+H8e
 hRGw==
X-Gm-Message-State: AOAM53227x6PPoIr4tuVhS7Itme4iODL9l0SMU7vspiWIq78mAY8Pl76
 /36B5Ea28aKch+qcpbpaGkQ=
X-Google-Smtp-Source: ABdhPJz/1KviqTBRdN/i5UkhkmvBZcT/WLY0X946jW+qeuJ5XzPMKystUxYRygTOw/VWf03P2lmxzg==
X-Received: by 2002:adf:cf05:: with SMTP id o5mr41843863wrj.325.1636922654132; 
 Sun, 14 Nov 2021 12:44:14 -0800 (PST)
Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
 [85.127.52.93])
 by smtp.gmail.com with ESMTPSA id i17sm13339707wmq.48.2021.11.14.12.44.12
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 14 Nov 2021 12:44:13 -0800 (PST)
Message-ID: <48018e12484d19466d9c6f253a8d7ebeae93e947.camel@HIDDEN>
Subject: Re: [PATCH 03/11] guix: node-build-system: Support compiling
 add-ons with node-gyp.
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
To: Philip McGrath <philip@HIDDEN>, 51838 <at> debbugs.gnu.org
Date: Sun, 14 Nov 2021 21:44:11 +0100
In-Reply-To: <20211114130409.49241-2-philip@HIDDEN>
References: <20211114125830.45427-1-philip@HIDDEN>
 <20211114130409.49241-1-philip@HIDDEN>
 <20211114130409.49241-2-philip@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.2 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  Hi Philip Am Sonntag, den 14.11.2021, 08:04 -0500 schrieb
 Philip McGrath: > * gnu/packages/node.scm (node)[arguments]: Replace
 'patch-npm-shebang
 > and 'patch-node-shebang with a new 'patch-nested-shebangs that [...] 
 Content analysis details:   (1.3 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 1.3 RCVD_IN_VALIDITY_RPBL  RBL: Relay in Validity RPBL,
 https://senderscore.org/blocklistlookup/
 [209.85.221.67 listed in bl.score.senderscore.com]
 -0.0 SPF_PASS               SPF: sender matches SPF record
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (liliana.prikler[at]gmail.com)
 0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 -0.0 RCVD_IN_MSPIKE_H2      RBL: Average reputation (+2)
 [209.85.221.67 listed in wl.mailspike.net]
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
 no trust [209.85.221.67 listed in list.dnswl.org]
X-Debbugs-Envelope-To: 51838
Cc: Pierre Langlois <pierre.langlois@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.3 (/)

Hi Philip

Am Sonntag, den 14.11.2021, 08:04 -0500 schrieb Philip McGrath:
> * gnu/packages/node.scm (node)[arguments]: Replace 'patch-npm-shebang
> and 'patch-node-shebang with a new 'patch-nested-shebangs that also
> handles node-gyp and other shebangs under "/lib/node_modules".
> [inputs]: Add Python for node-gyp as "python-for-target".
> (node-lts)[inputs]: Likewise.
> (libnode)[arguments]: Adjust to delete 'patch-nested-shebangs rather
> than 'patch-npm-shebang and 'patch-node-shebang.
> * guix/build-system/node.scm (lower): Add optional #:python argument
> and corresponding implicit input. Add the version of libuv used
> as an input to the #:node package as a new implicit input.
> * guix/build/node-build-system.scm (set-node-gyp-paths): New
> function. Sets the "npm_config_nodedir" and "npm_config_python"
> environment variables. Adds the "node-gyp-bin" directory to "PATH".
> (configure-gyp): New function. Run `node-gyp configure` if we see
> a `binding.gyp` file.
> (%standard-phases): Add 'set-node-gyp-paths after 'set-paths.
> Add 'configure-gyp after 'configure.
> 
> Co-authored-by: Pierre Langlois <pierre.langlois@HIDDEN>
Looking at this patch, it does *a lot* at once and could probably be
separated into more than one.  Particularly, I'd suggest providing
capabilities in node-build-system first, then switching over to the new
thing in node.

> [...]
> --- a/guix/build-system/node.scm
> +++ b/guix/build-system/node.scm
> @@ -1,6 +1,8 @@
>  ;;; GNU Guix --- Functional package management for GNU
>  ;;; Copyright © 2016 Jelle Licht <jlicht@HIDDEN>
>  ;;; Copyright © 2019 Timothy Sample <samplet@HIDDEN>
> +;;; Copyright © 2021 Pierre Langlois <pierre.langlois@HIDDEN>
> +;;; Copyright © 2021 Philip McGrath <philip@HIDDEN>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -24,6 +26,7 @@ (define-module (guix build-system node)
>    #:use-module (guix search-paths)
>    #:use-module (guix build-system)
>    #:use-module (guix build-system gnu)
> +  #:use-module (guix build-system python)
>    #:use-module (ice-9 match)
>    #:export (%node-build-system-modules
>              node-build
> @@ -44,11 +47,12 @@ (define (default-node)
>  (define* (lower name
>                  #:key source inputs native-inputs outputs system
> target
>                  (node (default-node))
> +                (python (default-python)) ;; for node-gyp
>                  #:allow-other-keys
>                  #:rest arguments)
>    "Return a bag for NAME."
>    (define private-keywords
> -    '(#:source #:target #:node #:inputs #:native-inputs))
> +    '(#:source #:target #:node #:python #:inputs #:native-inputs))
>  
>    (and (not target)                    ;XXX: no cross-compilation
>         (bag
> @@ -58,10 +62,13 @@ (define private-keywords
>                                `(("source" ,source))
>                                '())
>                          ,@inputs
> -
>                          ;; Keep the standard inputs of 'gnu-build-
> system'.
>                          ,@(standard-packages)))
>           (build-inputs `(("node" ,node)
> +                         ("python" ,python)
> +                        ;; We don't always need libuv, but the libuv
> and
> +                        ;; node versions need to match:
> +                        ("libuv" ,@(assoc-ref (package-inputs node)
> "libuv"))
>                           ,@native-inputs))
>           (outputs outputs)
>           (build node-build)
Will this python input always or often enough be needed?  What's the
build system ratio on node like, gyp vs. anything else, particularly
with packages close to the node core?

> diff --git a/guix/build/node-build-system.scm b/guix/build/node-
> build-system.scm
> index 70a367618e..6aeb0149dd 100644
> --- a/guix/build/node-build-system.scm
> +++ b/guix/build/node-build-system.scm
> @@ -2,6 +2,8 @@
>  ;;; Copyright © 2015 David Thompson <davet@HIDDEN>
>  ;;; Copyright © 2016, 2020 Jelle Licht <jlicht@HIDDEN>
>  ;;; Copyright © 2019, 2021 Timothy Sample <samplet@HIDDEN>
> +;;; Copyright © 2021 Pierre Langlois <pierre.langlois@HIDDEN>
> +;;; Copyright © 2021 Philip McGrath <philip@HIDDEN>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -46,6 +48,19 @@ (define (set-home . _)
>                (format #t "set HOME to ~s~%" (getenv "HOME")))))))
>    #t)
>  
> +(define* (set-node-gyp-paths #:key inputs #:allow-other-keys)
> +  "Initialize environment variables needed for building native
> addons."
> +  (setenv "npm_config_nodedir" (assoc-ref inputs "node"))
> +  (setenv "npm_config_python" (assoc-ref inputs "python"))
> +  (setenv "PATH"
> +          (string-append (getenv "PATH")
> +                         ":"
> +                         ;; Put this at the end to make it easier to
> override,
> +                         ;; just in case that should ever be
> necessary:
> +                         (assoc-ref inputs "node")
> +                         "/lib/node_modules/npm/bin/node-gyp-bin"))
> +  #t)
> +
Is this a necessary step to build node modules?  If not can we skip
this step when packages don't need gyp?

>  (define (module-name module)
>    (let* ((package.json (string-append module "/package.json"))
>           (package-meta (call-with-input-file package.json read-
> json)))
> @@ -101,6 +116,12 @@ (define* (configure #:key outputs inputs
> #:allow-other-keys)
>      (invoke npm "--offline" "--ignore-scripts" "install")
>      #t))
>  
> +(define* (configure-gyp #:key inputs #:allow-other-keys)
> +  "Run 'node-gyp configure' if we see a 'binding.gyp' file."
> +  (if (file-exists? "binding.gyp")
> +      (invoke (which "node-gyp") "configure")
> +      #t))
> +
You might want to make this part of configure itself, though I'm not
sure what the consensus is there when mixing different build system
styles.  (invoke (which ...) ) is also a pretty rare pattern, used in
only four locations so far.

Also, while better than the previous thing in that it actually checks
whether we have something gyp-esque at hand, I'd still prefer users
being able to not run this portion through some flag.  See e.g. #:use-
setuptools? in python or #:glib-or-gtk? in meson.

Cheers





Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 14 Nov 2021 13:05:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 14 08:05:20 2021
Received: from localhost ([127.0.0.1]:49429 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mmFCC-00051F-AX
	for submit <at> debbugs.gnu.org; Sun, 14 Nov 2021 08:05:20 -0500
Received: from mail-qt1-f173.google.com ([209.85.160.173]:36853)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1mmFC4-0004zq-QD
 for 51838 <at> debbugs.gnu.org; Sun, 14 Nov 2021 08:05:13 -0500
Received: by mail-qt1-f173.google.com with SMTP id t11so13028618qtw.3
 for <51838 <at> debbugs.gnu.org>; Sun, 14 Nov 2021 05:05:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=Mm+lkF3s7vmyz5i9SafAkKzLv4bJQwoN4dzhIbTMME0=;
 b=RWEZpwTAVP+QGm67qq2HtXFkPxVQAkLhc3/40smb96OTCyirrPB3PjDAkJ561JQeG6
 VUvmp0za5Bh6PrbDJXIlCUz7ZJ8NbZ3LLzXRoZq1o+csm+RYXtLyjre4Vs3G9eXdhNL0
 MaRvTWjp2mzEQvtAOeOFCWwfd43qUZCwvnZ7RYId8Qpnd84ofWOINKRnMaTTJjoVZtuO
 Top2uEyeZV8+q3px9Qi5zNnVDpb8gEhpncFXe5E6jN35yfl+vHhXLBltXQj+iST5j+yG
 D94wr3jFI1486l4BZAVNDiYPLgf+0Thn+jaqa5N0kKXbkXwNdVebzIu7YiIdRc9WK3xr
 1ykw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=Mm+lkF3s7vmyz5i9SafAkKzLv4bJQwoN4dzhIbTMME0=;
 b=FsXDYJu4J7DgKbMkE1oKlcXyugCoJyHHbzWrjQpZDaNUuKxOpG2KLUP/3Wx5RyXEyr
 CV7svcFvgoqRb5VdgelEM0l+RXnhA78nZNnliYonKjqH5UYjBgqRCbzr9GT76jbIVoWJ
 qVnb8PDOi2euo+ZYQwjjTq1JQZFhwlsp7HvKxi0ZDmrGBjKtVmdB+UsVwcqIKs6ylgs3
 UWNFb3NcU2Q2kdBRb89tQUb3Ol7OoK83rbIN986ErIgTME+ezIIjjobYkNajrOYN6UTn
 jD2AmXN/2uJqq0FWbe/5QglpsyZbcqnQv++xqK/GD+jRmvxxXEGXqnY6LXfKBBA5/VN1
 8spA==
X-Gm-Message-State: AOAM531qo9YNoCMpbDMKNqIcLCQOV6odKS5cUwTgzQTLY+a86eKemIHD
 bqWdPkfoj6Wj5qmmx+iFG6Q4Aqr6K1AbX/Np
X-Google-Smtp-Source: ABdhPJylstt+1BR/Bh0r/SQGvfzDPgRZdwKD/wPuZ0rIGUxzbRqGCWEHT3bVdOiFOTFH+Cou9nFY7A==
X-Received: by 2002:a05:622a:391:: with SMTP id
 j17mr32922586qtx.228.1636895107297; 
 Sun, 14 Nov 2021 05:05:07 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id o17sm5867239qtv.30.2021.11.14.05.05.06
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 14 Nov 2021 05:05:07 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH 11/11] gnu: Add node-sqlite3.
Date: Sun, 14 Nov 2021 08:04:09 -0500
Message-Id: <20211114130409.49241-10-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211114130409.49241-1-philip@HIDDEN>
References: <20211114125830.45427-1-philip@HIDDEN>
 <20211114130409.49241-1-philip@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.6 (/)
X-Debbugs-Envelope-To: 51838
Cc: Philip McGrath <philip@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.4 (/)

* gnu/packages/node-xyz.scm (node-sqlite3): New variable.
---
 gnu/packages/node-xyz.scm | 114 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 114 insertions(+)

diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
index 8aa93122df..d30b6f6e04 100644
--- a/gnu/packages/node-xyz.scm
+++ b/gnu/packages/node-xyz.scm
@@ -22,6 +22,8 @@
 
 (define-module (gnu packages node-xyz)
   #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (gnu packages sqlite)
+  #:use-module (guix gexp)
   #:use-module (guix packages)
   #:use-module (guix git-download)
   #:use-module (guix build-system node))
@@ -636,3 +638,115 @@ (define-public node-addon-api
 @code{libuv} (included in a project via @code{#include <uv.h>}) are not
 ABI-stable across Node.js major versions.")
     (license license:expat)))
+
+(define-public node-sqlite3
+  (package
+    (name "node-sqlite3")
+    (version "5.0.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/mapbox/node-sqlite3")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0sbbzzli282nxyfha10zx0k5m8hdp0sf3ipl59khjb7wm449j86h"))
+       (snippet
+        (with-imported-modules '((guix build utils))
+          #~(begin
+              (use-modules (guix build utils))
+              ;; unbundle sqlite
+              '(for-each delete-file-recursively
+                         (find-files "deps" gzip-file?)))))))
+    (inputs
+     `(("node-addon-api" ,node-addon-api)
+       ("sqlite" ,sqlite)))
+    (build-system node-build-system)
+    (arguments
+     `(#:tests?
+       #f ; FIXME: tests depend on node-mocha
+       #:modules
+       ((guix build node-build-system)
+        (guix build json)
+        (srfi srfi-1)
+        (ice-9 match)
+        (guix build utils))
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'configure 'npm-config-sqlite
+           (lambda* (#:key inputs #:allow-other-keys)
+             (setenv "npm_config_sqlite" (assoc-ref inputs "sqlite"))))
+         (add-after 'unpack 'un-cloud-ify
+           ;; Normally, this is "built" using @mapbox/node-pre-gyp,
+           ;; which publishes or downloads pre-built binaries
+           ;; or falls back to building from source.
+           ;; Here, we patch out all of that and just build directly.
+           ;; It would be better to patch a version of @mapbox/node-pre-gyp
+           ;; that always builds from source, but there are a number
+           ;; of dependencies that need to be packaged or removed.
+           (lambda args
+             (with-atomic-file-replacement "package.json"
+               (lambda (in out)
+                 (let ((js (read-json in)))
+                   (match (assoc-ref js "binary")
+                     (('@ . alist)
+                      (setenv "GYP_DEFINES"
+                              (string-append
+                               "module_name="
+                               (assoc-ref alist "module_name")
+                               " "
+                               "module_path="
+                               (assoc-ref alist "module_path")))))
+                   (write-json
+                    (fold (match-lambda*
+                            (((key update) js)
+                             (assoc-set! js
+                                         key
+                                         (match (assoc-ref js key)
+                                           (('@ . alist)
+                                            (cons '@ (update alist)))
+                                           (other
+                                            (update other))))))
+                          js
+                          `(("dependencies"
+                             ,(lambda (deps)
+                                (assoc-remove!
+                                 (assoc-remove! deps "@mapbox/node-pre-gyp")
+                                 "node-pre-gyp")))
+                            ("devDependencies"
+                             ,(lambda (deps)
+                                (assoc-remove!
+                                 (assoc-remove! deps "aws-sdk")
+                                 "@mapbox/cloudfriend")))
+                            ("scripts"
+                             ,(lambda (scripts)
+                                ;; install script would use node-pre-gyp
+                                (assoc-remove! scripts "install")))))
+                    out))))))
+         (add-after 'un-cloud-ify 'remove-missing-dev-deps
+           ;; Remove some missing testing/linting dependencies
+           ;; so we don't have to skip the configure phase entirely.
+           (lambda args
+             (with-atomic-file-replacement "package.json"
+               (lambda (in out)
+                 (write-json
+                  (let ((js (read-json in)))
+                    (assoc-set!
+                     (assoc-remove!
+                      (assoc-remove! (assoc-remove! js "peerDependencies")
+                                     "peerDependenciesMeta")
+                      "optionalDependencies")
+                     "devDependencies"
+                     (match (assoc-ref js "devDependencies")
+                       (('@ . deps)
+                        (cons '@ (assoc-remove! (assoc-remove! deps "eslint")
+                                                "mocha"))))))
+                  out))))))))
+    (home-page "https://github.com/mapbox/node-sqlite3")
+    (synopsis "Asynchronous, non-blocking SQLite3 bindings for Node.js")
+    (description
+     "The Node.js add-on @code{node-sqlite3} provides a set of a asynchronous,
+non-blocking bindings for SQLite3, written in modern C++ and tested for memory
+leaks.")
+     (license license:bsd-3)))
-- 
2.32.0





Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 14 Nov 2021 13:05:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 14 08:05:20 2021
Received: from localhost ([127.0.0.1]:49427 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mmFCB-00051D-Vt
	for submit <at> debbugs.gnu.org; Sun, 14 Nov 2021 08:05:20 -0500
Received: from mail-qk1-f175.google.com ([209.85.222.175]:40951)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1mmFC4-0004zj-0e
 for 51838 <at> debbugs.gnu.org; Sun, 14 Nov 2021 08:05:12 -0500
Received: by mail-qk1-f175.google.com with SMTP id p4so5493268qkm.7
 for <51838 <at> debbugs.gnu.org>; Sun, 14 Nov 2021 05:05:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=SXzQQq6uVWKvPzgJSFx8iSTsMZUBZgTO2S/Hj22t5tU=;
 b=ABgP2V2Eo10i71tP28TLL2AghvSj3yA0eee+b1rJXX7gWG4t9VMxKZHOslkqylI1DJ
 Icv6QXfHaXHa+jcNpw/dAU6u3rwNaRDFIP3qb5XO9hTLcLQcM1sRJtb8SapJol7/spKo
 8ldKINWYZd1dtY1ntR2L0keoCeJXiXqclbyCtJ0LN6I+MM9OyRVhyo5PYfT//tPIZPmf
 hXA+/7yTGPXZmZLLvFNjkHVZVnYAAzJ3rfROiNHw078lKUN+QgL9tmpFtYgYsVgb+Oh2
 91UQZS03N4P6H/ysr8O+rhJ9aiEufdFR7oIG1po7f9f2T/3iStufvMxWb58bGeW09tXG
 y6DA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=SXzQQq6uVWKvPzgJSFx8iSTsMZUBZgTO2S/Hj22t5tU=;
 b=Dps+TI+yg0ERNFdo9S6vjmmYRaQ67yRF3hsO7fAEKqCOiyEHWChTGRUPus9JwDFNX8
 bzQnSUhlnskIUVM7WQ+eESqGXm0tZuaWMI66TJkSTMUdeXTjB8PH19v7Au0dfWmRMSBN
 CGMFFpVbM4+OW1QgGz13yTTY0VP1iFCzK+Zfb/BDNd5ppmQ+AH3VTGL2o8EadYePHOpP
 dEICpFg0/v4rb8tdJqql83+v4MuA1pfeMycepOMUO0mfeAAYlGe4Amks0gvY9iG7UvtV
 GtBsVSEEU4JHa5LglUMXImqzZGe+hlsiOhSKolw/ZYJjQdu/uBI+WFUQNA+XCKIkr0Bs
 6NUQ==
X-Gm-Message-State: AOAM5322q2PFp32iAoDhf5VIS6jGC5Votle8568OCdINhEicT1PDZKCE
 wyGWQ9o88n3FBZe7hnq9vKhUfYbJt1XAh6hV
X-Google-Smtp-Source: ABdhPJzD+wz+2zAtfEg3ndj3T8oykT48Nvt50mKCmWRNgvA8g5D9NpNH35mGtI50Ts8a2cXG8/xDDA==
X-Received: by 2002:a05:620a:710:: with SMTP id
 16mr23895161qkc.379.1636895106401; 
 Sun, 14 Nov 2021 05:05:06 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id x10sm5205812qkn.41.2021.11.14.05.05.06
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 14 Nov 2021 05:05:06 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH 10/11] gnu: Add node-addon-api.
Date: Sun, 14 Nov 2021 08:04:08 -0500
Message-Id: <20211114130409.49241-9-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211114130409.49241-1-philip@HIDDEN>
References: <20211114125830.45427-1-philip@HIDDEN>
 <20211114130409.49241-1-philip@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 51838
Cc: Philip McGrath <philip@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

* gnu/packages/node-xyz.scm (node-addon-api): New variable.
---
 gnu/packages/node-xyz.scm | 46 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
index 29ad14f810..8aa93122df 100644
--- a/gnu/packages/node-xyz.scm
+++ b/gnu/packages/node-xyz.scm
@@ -590,3 +590,49 @@ (define-public node-nan
 This project also contains some helper utilities that make addon development a
 bit more pleasant.")
     (license license:expat)))
+
+(define-public node-addon-api
+  (package
+    (name "node-addon-api")
+    (version "4.2.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/nodejs/node-addon-api")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1bhvfi2m9nxfz418s619914vmidcnrzbjv6l9nid476c3zlpazch"))))
+    (build-system node-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         ;; Ignore numerous missing devDependencies:
+         (delete 'configure)
+         (add-after 'unpack 'skip-js-tests
+           ;; We can't run the js-based tests,
+           ;; but we can still do the C++ parts
+           (lambda args
+             (substitute* "package.json"
+               (("\"test\": \"node test\"")
+                "\"test\": \"echo stopping after pretest on Guix\"")))))))
+    (home-page "https://github.com/nodejs/node-addon-api")
+    (synopsis "Node.js API (Node-API) header-only C++ wrappers")
+    (description "This module contains header-only C++ wrapper classes which
+simplify the use of the C based Node-API provided by Node.js when using C++.
+It provides a C++ object model and exception handling semantics with low
+overhead.
+
+Node-API is an ABI stable C interface provided by Node.js for building native
+addons.  It is intended to insulate native addons from changes in the
+underlying JavaScript engine and allow modules compiled for one version to run
+on later versions of Node.js without recompilation.  The @code{node-addon-api}
+module, which is not part of Node.js, preserves the benefits of the Node-API
+as it consists only of inline code that depends only on the stable API
+provided by Node-API.
+
+It is important to remember that @emph{other} Node.js interfaces such as
+@code{libuv} (included in a project via @code{#include <uv.h>}) are not
+ABI-stable across Node.js major versions.")
+    (license license:expat)))
-- 
2.32.0





Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 14 Nov 2021 13:05:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 14 08:05:14 2021
Received: from localhost ([127.0.0.1]:49425 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mmFC5-00050p-Bj
	for submit <at> debbugs.gnu.org; Sun, 14 Nov 2021 08:05:13 -0500
Received: from mail-qt1-f176.google.com ([209.85.160.176]:41510)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1mmFC3-0004zf-36
 for 51838 <at> debbugs.gnu.org; Sun, 14 Nov 2021 08:05:11 -0500
Received: by mail-qt1-f176.google.com with SMTP id v22so8366661qtx.8
 for <51838 <at> debbugs.gnu.org>; Sun, 14 Nov 2021 05:05:11 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=kTreQd5w/4G329UIlhKNwBXTChGXK/RdArBW5+Q+OgE=;
 b=jx1OPHAsqqsEoPXPzgUZ6kd8czQUCoYIcD1E66etWoT3VmmSSR7B8jDFhqBKZZ++AE
 vs3P6lmiGHncJeP/Ymc5dWNeFbUnBiFSiMnS87SdtX71C2GTh1BY5vZobv2a9CToehj+
 r1bxib5Qqr/5HFZOZWQ7oZTqgH7j/l3ne41p66XY7B7APcumCJej7EYLT34Vz5bgFj2S
 y1NxpWPNnzmIy+qRMb/M5bLrYJaoCfRtwj5psdGm6cMsYDY1HVQQGaK1VNFQ21uQ/CU0
 EEatZt/U1/tBgsQu30HHGqq64dUfkISISlMFS9eOLTDZDZL6fHPaicuBVBiNDiZ8anE+
 RJVA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=kTreQd5w/4G329UIlhKNwBXTChGXK/RdArBW5+Q+OgE=;
 b=IyQ5j0AxfMBSE7SGNBiOX5ofEWALvSqVONq5CEsr2+QmGJLpnktyOgYVVxKQtX8PKJ
 /um/TAkK+l2dOvDsXb5vOP4RljgUQx5m4deqguv1pxZ9aJUsrfkFm874xu/VmX4eFwWI
 ZDrEg0/iszprL+1vzgBAe5cF2BHR9ZgU68Tuoem+uHzf4wms0YEQiwYdg1H9C4JkxT75
 r+zxO+uJqnr00JJj3ntSiQzuCGCB8cFmygNZP6aPXKmHjg+HWDHWY6kyPYNs95DMH9B7
 7ZMomfFiXXF16E293REfSL1CH+AwAby8IjFyEjgGsnAMFIZo+Lww110axJDfSxhsNO2a
 v4Rw==
X-Gm-Message-State: AOAM532f9F1eucjuGFZx5Knt+RPyl+qaWgZ3i2VCFflxCeMTGP05HCSN
 5hYuotRpyKnYwoxPbrn0YeM2goDEkKjolSFt
X-Google-Smtp-Source: ABdhPJz32t7OPALqYz7e4Wt8nl/6268VCbemlyiUm2hKEJ6nHPuNIYFT6kVL0jbZro/qOXqy0tuijg==
X-Received: by 2002:ac8:7fd6:: with SMTP id b22mr29825552qtk.26.1636895105610; 
 Sun, 14 Nov 2021 05:05:05 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id w10sm5861192qkp.121.2021.11.14.05.05.05
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 14 Nov 2021 05:05:05 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH 09/11] gnu: Add node-openzwave-shared.
Date: Sun, 14 Nov 2021 08:04:07 -0500
Message-Id: <20211114130409.49241-8-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211114130409.49241-1-philip@HIDDEN>
References: <20211114125830.45427-1-philip@HIDDEN>
 <20211114130409.49241-1-philip@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 51838
Cc: Philip McGrath <philip@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

* gnu/packages/zwave.scm (node-openzwave-shared): New variable.
---
 gnu/packages/zwave.scm | 55 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 55 insertions(+)

diff --git a/gnu/packages/zwave.scm b/gnu/packages/zwave.scm
index 2019ec32df..39028b4f34 100644
--- a/gnu/packages/zwave.scm
+++ b/gnu/packages/zwave.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2019 Ludovic Courtès <ludo@HIDDEN>
+;;; Copyright © 2021 Philip McGrath <philip@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -21,8 +22,10 @@ (define-module (gnu packages zwave)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix git-download)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system node)
   #:use-module (gnu packages)
   #:use-module (gnu packages base)
+  #:use-module (gnu packages node-xyz)
   #:use-module (gnu packages libusb)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages perl)
@@ -88,3 +91,55 @@ (define-public open-zwave
 and respond to devices on a Z-Wave network, without requiring in-depth
 knowledge of the Z-Wave protocol.")
     (license license:lgpl3+)))
+
+(define-public node-openzwave-shared
+  (package
+    (name "node-openzwave-shared")
+    (version "1.7.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/OpenZWave/node-openzwave-shared")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1bqqy12dzqj05j9wsh50dmn84dddmhz0gjzvd3y20z4hpy1v8rsc"))))
+    (inputs
+     `(("open-zwave" ,open-zwave)
+       ("node-nan" ,node-nan)))
+    (native-inputs
+     `(("which" ,which)
+       ("pkg-config" ,pkg-config)))
+    (build-system node-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'build
+           (lambda* (#:key inputs #:allow-other-keys)
+             (invoke (which "node-gyp") "build"))))))
+    (home-page "https://github.com/OpenZWave/node-openzwave-shared")
+    (synopsis "Node.js bindings for OpenZWave")
+    (description
+     "With the @code{node-openzwave-shared} package, you can easily control
+and manage your Z-Wave devices (lights, dimmers, blinds, you name it) from
+within Node.js applications.  This library also supports secure
+devices (e.g. door locks) that require encryption.  All widely used Node.js
+versions are supported with the help of @code{node-nan}.
+
+This library is currently able to:
+@itemize @bullet
+@item
+scan a Z-Wave network and report on connected devices;
+@item
+write values to Z-Wave nodes;
+@item
+monitor the network for changes;
+@item
+heal nodes and/or the network; and
+@item
+perform management tasks: add or remove nodes, replace failed nodes,
+manage their group associations, etc.
+@end itemize")
+    (license license:isc)))
-- 
2.32.0





Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 14 Nov 2021 13:05:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 14 08:05:13 2021
Received: from localhost ([127.0.0.1]:49423 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mmFC4-00050f-Ub
	for submit <at> debbugs.gnu.org; Sun, 14 Nov 2021 08:05:13 -0500
Received: from mail-qt1-f172.google.com ([209.85.160.172]:37844)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1mmFC2-0004zd-23
 for 51838 <at> debbugs.gnu.org; Sun, 14 Nov 2021 08:05:10 -0500
Received: by mail-qt1-f172.google.com with SMTP id f20so12719503qtb.4
 for <51838 <at> debbugs.gnu.org>; Sun, 14 Nov 2021 05:05:10 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=u2xClz8o/NWA/XyzlTiRcbhKjw1oPv9cLFZsxKjf9j4=;
 b=PUFTC+lYWVvu/I99ZbqpJrUJsNw0QYzTbgw3A8Uu4nl6V5Bxw2lk19E4QU/thHUVEr
 6/05bk3sfht/EIRS72LhZfi3LsdTq2s2PD5zwCc0uUuglsrmmkEax0cnB2cwJqRp0M1s
 swPm0EUGWcZCh/XhSTwpe3u8cCDu8288jBqEqXeQY5orPb6afb7b2i4K80q/TJxYYy2m
 c2t79mQyOT/uwQC97CXCNADhxA0ZRA2OgSlPLdLZWo3HteqVDjmZs6RVgl2eEvqsmYNs
 Wm4nQBQK6/UtgQmuPCia9A0EUcrfzOCDZeWAWEeO5Ordy0RqEDKTBfDEx5iilK0O4dxD
 4vgQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=u2xClz8o/NWA/XyzlTiRcbhKjw1oPv9cLFZsxKjf9j4=;
 b=RUWbs22LtNpaEWJNd90ImjPD6jOh8eQkykk7zZSIB3nbSLoUPSyOeCyfLQ57fVNQ2p
 hx9xwjYPRBX0yAvNOLP5fqABIzVENe9OBhoK+jIsNiOFOkodxMGfHsuAN5OTan61+IOP
 adifYNDbbCTD5R1E5C9Q/zrYrBrZgJNdvRBgMHzp1mgRZ8vJnNW1EvL6yvX0zo7+Aod2
 47kqAzY/6LWgxsw0yrb7fLdamE3b5qr11LOSVMwDj65nUC5/8OWGKuam/Sp3Kg6+2NlC
 aaDKaqT9qrhhLCV165/5gkE/eU364810N582ceZIYOLynXshDnPjT77cO82eTJCd3rc0
 xXAw==
X-Gm-Message-State: AOAM533WJXdJjui0pTTO7+JoiErIbAu9tsR2NG+Ed25vzGcpKyA6iDgX
 Ynnz0qlpGly9H2o7oGqYfgIRiJCpMEITuHaZ
X-Google-Smtp-Source: ABdhPJwj5grvZBGH/pq6LptjLFm6kVjnn+VOFA26FBebiSSiZOu4eApNImuyOf23itfAeKcr+yA+rg==
X-Received: by 2002:a05:622a:1708:: with SMTP id
 h8mr2831865qtk.318.1636895104524; 
 Sun, 14 Nov 2021 05:05:04 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id j20sm4095878qko.117.2021.11.14.05.05.04
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 14 Nov 2021 05:05:04 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH 08/11] gnu: Add node-nan.
Date: Sun, 14 Nov 2021 08:04:06 -0500
Message-Id: <20211114130409.49241-7-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211114130409.49241-1-philip@HIDDEN>
References: <20211114125830.45427-1-philip@HIDDEN>
 <20211114130409.49241-1-philip@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 51838
Cc: Philip McGrath <philip@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

* gnu/packages/node-xyz.scm (node-nan): New variable.
---
 gnu/packages/node-xyz.scm | 41 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
index d0b4d1fa98..29ad14f810 100644
--- a/gnu/packages/node-xyz.scm
+++ b/gnu/packages/node-xyz.scm
@@ -549,3 +549,44 @@ (define-public node-irc
     (description "@code{node-irc} is an IRC client library for Node.js.
 It has functions for joining, parting, talking, and many other IRC commands.")
     (license license:gpl3+)))
+
+(define-public node-nan
+  (package
+    (name "node-nan")
+    (version "2.15.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/nodejs/nan")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "18xslh9va5ld872scrp5y4251ax9s3c6qh0lnl1200lpzbsxy7yd"))))
+    (build-system node-build-system)
+    (arguments
+     `(#:tests?
+       ;; We can't run the npm-driven tests,
+       ;; but a number of C++ tests do run anyway:
+       #f
+       #:phases
+       (modify-phases %standard-phases
+         ;; Ignore missing devDependencies (e.g. "tap", for tests):
+         (delete 'configure))))
+    (inputs
+     `(("readable-stream" ,node-readable-stream)))
+    (home-page "https://github.com/nodejs/nan")
+    (synopsis "Native Abstractions for Node.js")
+    (description "A header file filled with macro and utility goodness for
+making add-on development for Node.js easier across versions 0.8, 0.10, 0.12,
+1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15 and 16.
+
+Thanks to the crazy changes in V8 (and some in Node core), keeping native
+addons compiling happily across versions, particularly 0.10 to 0.12 to 4.0, is
+a minor nightmare.  The goal of this project is to store all logic necessary
+to develop native Node.js addons without having to inspect
+@code{NODE_MODULE_VERSION} and get yourself into a macro-tangle.
+
+This project also contains some helper utilities that make addon development a
+bit more pleasant.")
+    (license license:expat)))
-- 
2.32.0





Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 14 Nov 2021 13:05:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 14 08:05:12 2021
Received: from localhost ([127.0.0.1]:49420 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mmFC4-00050Y-Kt
	for submit <at> debbugs.gnu.org; Sun, 14 Nov 2021 08:05:12 -0500
Received: from mail-qt1-f173.google.com ([209.85.160.173]:39556)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1mmFC1-0004zb-2U
 for 51838 <at> debbugs.gnu.org; Sun, 14 Nov 2021 08:05:09 -0500
Received: by mail-qt1-f173.google.com with SMTP id l8so13026558qtk.6
 for <51838 <at> debbugs.gnu.org>; Sun, 14 Nov 2021 05:05:09 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=jrlqo0ktA38dI9D+A1vV8hAFb9aiap+mkgHc5Wm0dXw=;
 b=CT4vFro7NxsimoAsh4Dqh+zbKzPvsApa3CZ+jtJWIUWMuugoQUfZuCwmkIuUEk7DFO
 7rm83wmvS7M5bJ9vy3ps/TOOkIU7h4l1VyV49CJDsPbANVWMrlpBiyA5bntszntvK47I
 Uqn5+x7GPCwuFNC3QDWBgqjcF3xwXldBskQMZfU13YH0Ri0AsgklBp1nafoQ1x2eoNTV
 DGjf1D9CCo/8QaOwEwuDLdxMC5Uj15ynff7/qdZgc9gwYVq43YRBLqc9XGyKaCN3LBTB
 B6jV0aUfLC5o1O71WvB9bhgh3n3S4ARwgOhxMxgbluY4btt1JWy0hdbW1HwdKfWBkUAk
 CXrg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=jrlqo0ktA38dI9D+A1vV8hAFb9aiap+mkgHc5Wm0dXw=;
 b=5fV/mbKJxX2KYVsrlXiw3Jit+Xx6buKWMzvS19XNVySYivUpG9Lczq2H2feYdIUdfB
 xGD/BOfltuq5AUEWYe0+73HetilPyDTsm0XFyU2Q+thWQCFYkn9YOnp8tqr8MEn5szAO
 JZrGa7XT4vDV3DoHjqk1WPXRpeVuvoQWh3oylamvtIfWN0rokfwZJCwAykHFnkJXvYMN
 24TIsZ8UThAXxtdyAYX4zcKBEdgVfGrBDXtKO6l+qv+tJ9cHUzHVCK/X7+UdoM3mOjPx
 kZtMQn8Np8g0qk+kQ3kl3W2VUzmBbSFgZQfZfT2HoXcdDc91C0VGyBneG2jW4EE/94TX
 cbOQ==
X-Gm-Message-State: AOAM532iBDZLcaWvIUA2FARkbQESGcPurv8qv73zLAnap3qpDetBbwLx
 I3jWcaFsIykO9LrSsr3Hfgb5fM/1+/NX76cq
X-Google-Smtp-Source: ABdhPJxlxNeQTWz9spmmcCEVm+vAOO55vtm1Zdln7NBclmNrq0caGNEeH7Zt7BETvbDWikEgxGK9Rw==
X-Received: by 2002:a05:622a:178c:: with SMTP id
 s12mr19423883qtk.156.1636895103637; 
 Sun, 14 Nov 2021 05:05:03 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id c22sm1912076qtd.76.2021.11.14.05.05.03
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 14 Nov 2021 05:05:03 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH 07/11] gnu: Add node-readable-stream.
Date: Sun, 14 Nov 2021 08:04:05 -0500
Message-Id: <20211114130409.49241-6-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211114130409.49241-1-philip@HIDDEN>
References: <20211114125830.45427-1-philip@HIDDEN>
 <20211114130409.49241-1-philip@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.6 (/)
X-Debbugs-Envelope-To: 51838
Cc: Philip McGrath <philip@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.4 (/)

* gnu/packages/node-xyz.scm (node-readable-stream): New variable.
---
 gnu/packages/node-xyz.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
index a5ca5631c7..d0b4d1fa98 100644
--- a/gnu/packages/node-xyz.scm
+++ b/gnu/packages/node-xyz.scm
@@ -454,6 +454,44 @@ (define-public node-string-decoder
 Node-core.")
     (license license:expat)))
 
+(define-public node-readable-stream
+  (package
+    (name "node-readable-stream")
+    (version "3.6.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/nodejs/readable-stream")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0ybl4cdgsm9c5jq3xq8s01201jk8w0yakh63hlclsfbcdfqhd9ri"))))
+    (build-system node-build-system)
+    (arguments
+     `(#:tests?
+       #f
+       #:phases
+       (modify-phases %standard-phases
+         ;; Ignore numerous missing devDependencies
+         (delete 'configure))))
+    (inputs
+     `(("node-util-deprecate" ,node-util-deprecate)
+       ("node-string-decoder" ,node-string-decoder)
+       ("node-inherits" ,node-inherits)))
+    (home-page
+     "https://github.com/nodejs/readable-stream")
+    (synopsis
+     "Node.js core streams for userland")
+    (description
+     "This package is a mirror of the streams implementations in Node.js.
+
+If you want to guarantee a stable streams base, regardless of what version of
+Node you (or the users of your libraries) are using, use
+@code{readable-stream} only and avoid the @code{stream} module in Node-core.")
+    (license license:expat)))
+
 (define-public node-irc-colors
   (package
     (name "node-irc-colors")
-- 
2.32.0





Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 14 Nov 2021 13:05:12 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 14 08:05:12 2021
Received: from localhost ([127.0.0.1]:49418 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mmFC4-00050S-C8
	for submit <at> debbugs.gnu.org; Sun, 14 Nov 2021 08:05:12 -0500
Received: from mail-qk1-f179.google.com ([209.85.222.179]:42846)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1mmFC0-0004za-BV
 for 51838 <at> debbugs.gnu.org; Sun, 14 Nov 2021 08:05:08 -0500
Received: by mail-qk1-f179.google.com with SMTP id g28so9456988qkk.9
 for <51838 <at> debbugs.gnu.org>; Sun, 14 Nov 2021 05:05:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=XUItu1cqgaQ0wQ3knf6hPChRORITPcdgx3ExsZCJ08s=;
 b=bgFUX1hSwzTUXKEO4XJ+FQZZI9Nl6dYJ7R708MTUGyJjMEB6aeWqToY4586geDGQRZ
 UNGWjxo93/nY08Pis3Njs6rWqWpLstoM4tdPPUge5Wa44vjx0mFMHeEvfenF6Wgtf/E3
 oqGZbmNCmEyBNOqPpTyiomfSrru+6boc0UzRTZaSKrcge7TekoJ6Hup6s669XvFiE3zJ
 DOEYGpA1V6KACKBiyjo6cMU5PNYGC6S2uUtfGwqJ+WdsWtFm2flPk9qDvJOD/GJsM5OO
 2Iw5cxRn6Ga0Umyex8BtKgV0di4mbWnjrvRF4hLgntvXb0P2EJTfji5UAyjnI3nftUWa
 npSg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=XUItu1cqgaQ0wQ3knf6hPChRORITPcdgx3ExsZCJ08s=;
 b=hNUGde9tOh57nc6uYagbyF+iIK+oKSEM6pYLpg7Slva9jYSOd99ifEhnnlghhgtr2K
 /OB1hxfim48agnhedthY2zx4r7QKp+1vo1jfLzbCUHN/OtNDfbp/fW4GFS1PJf96Vxso
 5JZlotzeHeyeW7UoKsVPnHD10XlUWCGwjVZc7e3EAGUIduNZHFBCx0m4rpsoHW/9VUsA
 zidUeP8McC/YRtGqHzFVITEEehEM6bbYAd7rf0sKkK1lmIwX83gcwKRy0QFW1X6yfioM
 pbWzz+JrV2HXHWye0gi0kl3K5mAj0lSyWTC+ysDhCooIRI0fgpiQCJIAs4SoQp99H03H
 9dqw==
X-Gm-Message-State: AOAM530CqmMB2NfIk5AETLR4I5y/SIhJ1t5dIalzH+1D4zSA/fHIu8u7
 3jYWXt5UFQf6yyOmO+3MvTDgLOvt03UEzwvn
X-Google-Smtp-Source: ABdhPJz+xeqHbYM3OmQJGOEIHuctG4B/mI40/TzRn+g/OMSO3QxQI7/j/uEo5LjlopBrWg2o60Y2eg==
X-Received: by 2002:a05:620a:3193:: with SMTP id
 bi19mr10848876qkb.521.1636895102867; 
 Sun, 14 Nov 2021 05:05:02 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id o1sm1749832qtw.1.2021.11.14.05.05.02
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 14 Nov 2021 05:05:02 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH 06/11] gnu: Add node-string-decoder.
Date: Sun, 14 Nov 2021 08:04:04 -0500
Message-Id: <20211114130409.49241-5-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211114130409.49241-1-philip@HIDDEN>
References: <20211114125830.45427-1-philip@HIDDEN>
 <20211114130409.49241-1-philip@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 51838
Cc: Philip McGrath <philip@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

* gnu/packages/node-xyz.scm (node-string-decoder): New variable.
---
 gnu/packages/node-xyz.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
index 44000e0568..a5ca5631c7 100644
--- a/gnu/packages/node-xyz.scm
+++ b/gnu/packages/node-xyz.scm
@@ -420,6 +420,40 @@ (define-public node-safe-buffer
 available.")
     (license license:expat)))
 
+(define-public node-string-decoder
+  (package
+    (name "node-string-decoder")
+    (version "1.3.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/nodejs/string_decoder")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0xxvyya9fl9rlkqwmxzqzbz4rdr3jgw4vf37hff7cgscxkhg266k"))))
+    (build-system node-build-system)
+    (arguments
+     `(#:tests?
+       #f
+       #:phases
+       (modify-phases %standard-phases
+         ;; Ignore missing tap dependency (for tests).
+         (delete 'configure))))
+    (inputs
+     `(("node-safe-buffer" ,node-safe-buffer)
+       ("node-inherits" ,node-inherits)))
+    (home-page
+     "https://github.com/nodejs/string_decoder")
+    (synopsis
+     "Node.js core @code{string_decoder} for userland")
+    (description
+     "This package is a mirror of the @code{string_decoder} implementation in
+Node-core.")
+    (license license:expat)))
+
 (define-public node-irc-colors
   (package
     (name "node-irc-colors")
-- 
2.32.0





Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 14 Nov 2021 13:05:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 14 08:05:09 2021
Received: from localhost ([127.0.0.1]:49412 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mmFC0-0004zx-VD
	for submit <at> debbugs.gnu.org; Sun, 14 Nov 2021 08:05:09 -0500
Received: from mail-qt1-f169.google.com ([209.85.160.169]:40755)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1mmFBy-0004z2-VE
 for 51838 <at> debbugs.gnu.org; Sun, 14 Nov 2021 08:05:07 -0500
Received: by mail-qt1-f169.google.com with SMTP id t34so13019500qtc.7
 for <51838 <at> debbugs.gnu.org>; Sun, 14 Nov 2021 05:05:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=3YNgChoYIEeF6YLJAhTCZpwJ34XxXRw0H6hcJMCPy0w=;
 b=Ees+BqEk9WXsJ3bh0nTigN60DtpujiIDE64jNz2UyKf3DhVPmkZd6CZRWNUbOsRw6f
 Y/TyBN9lNkmiHIBiWw8s4qtDmMJXmY5QMRJDIbL0zdwBcW8SHJQv2f/YTw5+PaRvo2rK
 1QNl/7azEGIHNqY+XMMUHF6Sx9OY37Oew684dEyC50w6GtfSbi7BPA0HPYeeepRj1vy6
 IVBcl84oxzZH4wvs987zfsMh/EjolostpPtD1eVucsO1f3XieZeXhlbFqK45xdvUH+uN
 4GOqI4rQfZgVMLE2F9EYLPRFzB86jPqM6ULREzPFvEQpUqAcwWg2VOmJOdvmXbOPOylS
 XUxQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=3YNgChoYIEeF6YLJAhTCZpwJ34XxXRw0H6hcJMCPy0w=;
 b=Z9WCJ8uSufrEENyqpmfOfGHPQRSEIzGN6qyt7rU9oD3uBf7yOAnWAsSnmkqOyBKgMs
 Xyy3bImi9jZicueCzb6/pPpGk9xu3x1sh7jdaR2WzJvFvTdnGRJ+aN2iYamRtSqVEg+D
 oyWA5v3UdKG3jo4aS8lt5TJKGkFVBHdJHJGPDEB52ys+x1S+DOE7eDPrenoV5y8O6MwR
 XERn1gZkVqcjWyLRDankLNQ0j3Zo5Pkua7LHMz87iJfxF3rnT0rjXiRy2QUjeMzVow6y
 zm1d+3NvWtkb8P9iW7J+/VkgCPq6Vc16WdP9E+hhcZv83kUstbBsi5l0fW2hzfgdAMuv
 iodg==
X-Gm-Message-State: AOAM533Vfi99569srLwjR2GCsj6WlQQ3eTzwPpM5jd3FCamtpo59IKcs
 FGh4ouGp/g9Wqzth0wlfaQuatboLCul/5XBW
X-Google-Smtp-Source: ABdhPJzZDLU0a543E33sf3C2GCE9xdK1f2StTGxoBAEAbXkWV1QgtGCvyK19TvbNYuyLt738B43zew==
X-Received: by 2002:a05:622a:3c9:: with SMTP id
 k9mr32399438qtx.42.1636895101670; 
 Sun, 14 Nov 2021 05:05:01 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id u9sm2953526qta.17.2021.11.14.05.05.01
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 14 Nov 2021 05:05:01 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH 05/11] gnu: Add node-safe-buffer.
Date: Sun, 14 Nov 2021 08:04:03 -0500
Message-Id: <20211114130409.49241-4-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211114130409.49241-1-philip@HIDDEN>
References: <20211114125830.45427-1-philip@HIDDEN>
 <20211114130409.49241-1-philip@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.6 (/)
X-Debbugs-Envelope-To: 51838
Cc: Philip McGrath <philip@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.4 (/)

* gnu/packages/node-xyz.scm (node-safe-buffer): New variable.
---
 gnu/packages/node-xyz.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
index da6affeb1f..44000e0568 100644
--- a/gnu/packages/node-xyz.scm
+++ b/gnu/packages/node-xyz.scm
@@ -390,6 +390,36 @@ (define-public node-inherits
 @code{inherits()}.")
     (license license:isc)))
 
+(define-public node-safe-buffer
+  (package
+    (name "node-safe-buffer")
+    (version "5.2.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/feross/safe-buffer")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0r26m0nl41h90ihnl2xf0cqs6z9z7jb87dl5j8yqb7887r9jlbpi"))))
+    (build-system node-build-system)
+    (arguments
+     `(#:tests?
+       #f
+       #:phases
+       (modify-phases %standard-phases
+         ;; Skip checking devDependencies, since we don't have tape.
+         (delete 'configure))))
+    (home-page
+     "https://github.com/feross/safe-buffer")
+    (synopsis "Safer Node.js Buffer API")
+    (description "A safe drop-in replacement the Node.js @code{Buffer} API
+that works in all versions of Node.js, using the built-in implementation when
+available.")
+    (license license:expat)))
+
 (define-public node-irc-colors
   (package
     (name "node-irc-colors")
-- 
2.32.0





Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 14 Nov 2021 13:05:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 14 08:05:02 2021
Received: from localhost ([127.0.0.1]:49408 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mmFBu-0004zH-Jc
	for submit <at> debbugs.gnu.org; Sun, 14 Nov 2021 08:05:02 -0500
Received: from mail-qt1-f180.google.com ([209.85.160.180]:39555)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1mmFBs-0004yf-Mt
 for 51838 <at> debbugs.gnu.org; Sun, 14 Nov 2021 08:05:01 -0500
Received: by mail-qt1-f180.google.com with SMTP id l8so13026249qtk.6
 for <51838 <at> debbugs.gnu.org>; Sun, 14 Nov 2021 05:05:00 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=iqTdawUDCxWVnjV77ShzbFdQTtsMNdg5MwDOK0B+IQo=;
 b=Xs/dqkrmVheOqJC2JofgTQ5edXwo1qZSGEus3czHjYGJJq+zUsd194LcvY2oKPcmIx
 NwrRtjFrrbA4n5LoT1Koq+A/elai8PW0Ke7qdsl7XWoRFr8sm+CAGxA+NPFnSFdfMZHr
 jlaZe5oQFehMZdzZJFn0QG5Nibc7cBxB4GW/OwbblLsZphKHQYvSu23NSW8ufvI1fvZ6
 jLnKYWqDD4+c+3BgS9CaWJMXvATp+72CApVwN4lmwrAPaVkFsp7m4lwGGlmEX7B6x4Ib
 SOo+SQcj7qRdCK+MjzWHku6yrMzg+RGccipK9hX2fAAi0qPwzyj+A4CCF/YLbuWwdui5
 R3qw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=iqTdawUDCxWVnjV77ShzbFdQTtsMNdg5MwDOK0B+IQo=;
 b=ALF3ZMDm0fOmIr8bPwY0+rIB27Kg1/o/q/ivRMDe+wLBKU9JzsaBSNDUkfN8EgeEoA
 KZq3f8TNcM6bqtPpUSkhAy4j/gIE1sRnLAUVyOI3t+v+uGfBypMmg3IoE7XHAmyTDiAY
 1UJFj3OP4JNbHFVaYzQ1km7gsYhnkzhDwina29C/yLdGpoVbA3sTnb7kVbwapyDE0f/l
 N9fOUDpKy/l7ln5E0WcsfHmr6qsWe98hL161oVb7RggBNGwonRowfhae6pW+4tY9ZoGK
 KgOZiNyEfXKhOJObW+CDhDVGMOK9WUqKDIIzBhxerSc1FWfc3EKWo6tiDwQIKS538mJs
 A47w==
X-Gm-Message-State: AOAM530mr7hoT9SSzJKvSvXvPo3Fz9q19nPRHxgJv8QKq813sI1WjZIG
 QtCVFrG03TTT5SZXfK9IN/6yWcG2cQjmagr1
X-Google-Smtp-Source: ABdhPJxDostP/FmKssMCnIzU4YlKD5ZpFbyEAwckfGpjzTvQD2AaLfD0VN/jUF55g9HqIQUzX1wG2g==
X-Received: by 2002:ac8:580b:: with SMTP id g11mr3249236qtg.268.1636895095228; 
 Sun, 14 Nov 2021 05:04:55 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id y8sm5616342qko.36.2021.11.14.05.04.54
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 14 Nov 2021 05:04:55 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH 04/11] gnu: Add node-inherits.
Date: Sun, 14 Nov 2021 08:04:02 -0500
Message-Id: <20211114130409.49241-3-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211114130409.49241-1-philip@HIDDEN>
References: <20211114125830.45427-1-philip@HIDDEN>
 <20211114130409.49241-1-philip@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.6 (/)
X-Debbugs-Envelope-To: 51838
Cc: Philip McGrath <philip@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.4 (/)

* gnu/packages/node-xyz.scm (node-inherits): New variable.
---
 gnu/packages/node-xyz.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
index 98c611f227..da6affeb1f 100644
--- a/gnu/packages/node-xyz.scm
+++ b/gnu/packages/node-xyz.scm
@@ -3,6 +3,7 @@
 ;;; Copyright © 2020 Giacomo Leidi <goodoldpaul@HIDDEN>
 ;;; Copyright © 2021 Noisytoot <noisytoot@HIDDEN>
 ;;; Copyright © 2021 Charles <charles.b.jackson@HIDDEN>
+;;; Copyright © 2021 Philip McGrath <philip@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -358,6 +359,37 @@ (define-public node-once
 if desired.")
     (license license:isc)))
 
+(define-public node-inherits
+  (package
+    (name "node-inherits")
+    (version "2.0.4")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/isaacs/inherits")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0cpsr5yqwkxpbbbbl0rwk4mcby6zbx841k2zb4c3gb1579i5wq9p"))))
+    (build-system node-build-system)
+    (arguments
+     `(#:tests?
+       #f
+       #:phases
+       (modify-phases %standard-phases
+         ;; Ignore our lack of tap (for tests) as with node-once.
+         (delete 'configure))))
+    (home-page
+     "https://github.com/isaacs/inherits")
+    (synopsis
+     "Browser-friendly inheritance Node.js")
+    (description
+     "Browser-friendly inheritance fully compatible with standard Node.js
+@code{inherits()}.")
+    (license license:isc)))
+
 (define-public node-irc-colors
   (package
     (name "node-irc-colors")
-- 
2.32.0





Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 14 Nov 2021 13:04:53 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 14 08:04:53 2021
Received: from localhost ([127.0.0.1]:49403 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mmFBh-0004yT-TQ
	for submit <at> debbugs.gnu.org; Sun, 14 Nov 2021 08:04:53 -0500
Received: from mail-qt1-f179.google.com ([209.85.160.179]:42601)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1mmFBf-0004yB-HW
 for 51838 <at> debbugs.gnu.org; Sun, 14 Nov 2021 08:04:48 -0500
Received: by mail-qt1-f179.google.com with SMTP id z9so12985814qtj.9
 for <51838 <at> debbugs.gnu.org>; Sun, 14 Nov 2021 05:04:47 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=caZtV6CtWt9On14XOLrO/yexC0cfBS35X0odEutD4b4=;
 b=PXyrGqKLU4kjSbHixDkyVchzDrhSSKOWt+KWtETMcuY78Tvb83xaCbb0910BxbiUJK
 17j+mN2u+Z/dLZAOG7icaqMFpYdb9ssbO/ThfEPmqbaMN0MWxNpOU+mttfYLjgTrhyF6
 acGpQKz4zwn1ycqggi3kl5sd1HJmYLFTtpBRfTdd4WYMBIw5BYDTegDU8YxXXRWzItPJ
 24MfnvAw76g8d0ecxPOBJJAbj/mhkQjwe7FChBZos5SXQwCk17czcN0WHS3MCGZTQ4rL
 ls2MpdKV/tjvDU4fKJpRk0Nbzm8Ewuy5Sbs+BJ0V0Y0L+W+ZLNl0/LSALogPIMMtHvpv
 ZzkQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=caZtV6CtWt9On14XOLrO/yexC0cfBS35X0odEutD4b4=;
 b=kAw1JR6XS0+vuP0c274tWft/zrzBA0c+RWFgaQDQ229tZDb7jBFGgwbQlbLiQ5byPX
 +9d7bxiUf6iiU+qTCC+PosGLmLpStFP9RM4kfvPHElhRUN9ePrd2tvndDeMUcc6PTot1
 ntXeiIKB5wut0ZFYanlXXNvzJ/J1CztswYsB/ETvZpGrjx8/QgCc4wds5U1X4iFlww68
 dy/wNA36N6dcMsqu5eTETobbd4RpAh2dg2tHONhKFH6F5KOxMvJFxoIEhdeqRo7kcUf1
 tvD/+SHwbko6wk8xyERP/q74oKyPKbQ7yLsAYbTFjfLwObG4JKv4k3qp0S9MQwWu9zyD
 Lfjg==
X-Gm-Message-State: AOAM5330SvcERw2yFwPPNBKwMYW/VP9xgnkWfBowZvd/9OifZLtbDxna
 nakB+Imn51u67xesrUBKOpO2+mTieHnsmDAh
X-Google-Smtp-Source: ABdhPJyIlnvXDJko1gERl+A2VYSbRGBNaAXRQZSpJEWEWBxBfGZJ/YQsmwCVdTEEV4XWSOGImyg+rA==
X-Received: by 2002:a05:622a:391:: with SMTP id
 j17mr32919655qtx.228.1636895082018; 
 Sun, 14 Nov 2021 05:04:42 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id u10sm6275419qtx.3.2021.11.14.05.04.41
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 14 Nov 2021 05:04:41 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH 03/11] guix: node-build-system: Support compiling add-ons with
 node-gyp.
Date: Sun, 14 Nov 2021 08:04:01 -0500
Message-Id: <20211114130409.49241-2-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211114130409.49241-1-philip@HIDDEN>
References: <20211114125830.45427-1-philip@HIDDEN>
 <20211114130409.49241-1-philip@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.6 (/)
X-Debbugs-Envelope-To: 51838
Cc: Pierre Langlois <pierre.langlois@HIDDEN>,
 Philip McGrath <philip@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.4 (/)

* gnu/packages/node.scm (node)[arguments]: Replace 'patch-npm-shebang
and 'patch-node-shebang with a new 'patch-nested-shebangs that also
handles node-gyp and other shebangs under "/lib/node_modules".
[inputs]: Add Python for node-gyp as "python-for-target".
(node-lts)[inputs]: Likewise.
(libnode)[arguments]: Adjust to delete 'patch-nested-shebangs rather
than 'patch-npm-shebang and 'patch-node-shebang.
* guix/build-system/node.scm (lower): Add optional #:python argument
and corresponding implicit input. Add the version of libuv used
as an input to the #:node package as a new implicit input.
* guix/build/node-build-system.scm (set-node-gyp-paths): New
function. Sets the "npm_config_nodedir" and "npm_config_python"
environment variables. Adds the "node-gyp-bin" directory to "PATH".
(configure-gyp): New function. Run `node-gyp configure` if we see
a `binding.gyp` file.
(%standard-phases): Add 'set-node-gyp-paths after 'set-paths.
Add 'configure-gyp after 'configure.

Co-authored-by: Pierre Langlois <pierre.langlois@HIDDEN>
---
 gnu/packages/node.scm            | 34 ++++++++++++++++----------------
 guix/build-system/node.scm       | 11 +++++++++--
 guix/build/node-build-system.scm | 23 +++++++++++++++++++++
 3 files changed, 49 insertions(+), 19 deletions(-)

diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index 89a9bc7533..ad5179426a 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -237,21 +237,20 @@ (define-public node
                             python
                             (string-append python "3")))
                       "configure" flags))))
-         (add-after 'patch-shebangs 'patch-npm-shebang
-           (lambda* (#:key outputs #:allow-other-keys)
-             (let* ((bindir (string-append (assoc-ref outputs "out")
-                                           "/bin"))
-                    (npm    (string-append bindir "/npm"))
-                    (target (readlink npm)))
-               (with-directory-excursion bindir
-                 (patch-shebang target (list bindir))))))
-         (add-after 'install 'patch-node-shebang
-           (lambda* (#:key outputs #:allow-other-keys)
-             (let* ((bindir (string-append (assoc-ref outputs "out")
-                                           "/bin"))
-                    (npx    (readlink (string-append bindir "/npx"))))
-               (with-directory-excursion bindir
-                 (patch-shebang npx (list bindir)))))))))
+         (add-after 'patch-shebangs 'patch-nested-shebangs
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (let* ((prefix (assoc-ref outputs "out"))
+                    (path (map (lambda (dir)
+                                 (string-append dir "/bin"))
+                               (list prefix
+                                     (assoc-ref inputs "python-for-target")))))
+               (for-each
+                (lambda (file)
+                  (patch-shebang file path))
+                (find-files (string-append prefix "/lib/node_modules")
+                            (lambda (file stat)
+                              (executable-file? file))
+                            #:stat lstat))))))))
     (native-inputs
      `(;; Runtime dependencies for binaries used as a bootstrap.
        ("c-ares" ,c-ares)
@@ -274,6 +273,7 @@ (define-public node
     (inputs
      `(("bash" ,bash-minimal)
        ("coreutils" ,coreutils)
+       ("python-for-target" ,python-wrapper) ;; for node-gyp (supports python3)
        ("c-ares" ,c-ares)
        ("http-parser" ,http-parser)
        ("icu4c" ,icu4c)
@@ -795,6 +795,7 @@ (define-public node-lts
     (inputs
      `(("bash" ,bash-minimal)
        ("coreutils" ,coreutils)
+       ("python-for-target" ,python-wrapper) ;; for node-gyp (supports python3)
        ("c-ares" ,c-ares)
        ("icu4c" ,icu4c-67)
        ("libuv" ,libuv-for-node)
@@ -813,5 +814,4 @@ (define-public libnode
         `(cons* "--shared" "--without-npm" ,flags))
        ((#:phases phases '%standard-phases)
         `(modify-phases ,phases
-           (delete 'patch-npm-shebang)
-           (delete 'patch-node-shebang)))))))
+           (delete 'patch-nested-shebangs)))))))
diff --git a/guix/build-system/node.scm b/guix/build-system/node.scm
index 98f63f87ef..fee4142a99 100644
--- a/guix/build-system/node.scm
+++ b/guix/build-system/node.scm
@@ -1,6 +1,8 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2016 Jelle Licht <jlicht@HIDDEN>
 ;;; Copyright © 2019 Timothy Sample <samplet@HIDDEN>
+;;; Copyright © 2021 Pierre Langlois <pierre.langlois@HIDDEN>
+;;; Copyright © 2021 Philip McGrath <philip@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -24,6 +26,7 @@ (define-module (guix build-system node)
   #:use-module (guix search-paths)
   #:use-module (guix build-system)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system python)
   #:use-module (ice-9 match)
   #:export (%node-build-system-modules
             node-build
@@ -44,11 +47,12 @@ (define (default-node)
 (define* (lower name
                 #:key source inputs native-inputs outputs system target
                 (node (default-node))
+                (python (default-python)) ;; for node-gyp
                 #:allow-other-keys
                 #:rest arguments)
   "Return a bag for NAME."
   (define private-keywords
-    '(#:source #:target #:node #:inputs #:native-inputs))
+    '(#:source #:target #:node #:python #:inputs #:native-inputs))
 
   (and (not target)                    ;XXX: no cross-compilation
        (bag
@@ -58,10 +62,13 @@ (define private-keywords
                               `(("source" ,source))
                               '())
                         ,@inputs
-
                         ;; Keep the standard inputs of 'gnu-build-system'.
                         ,@(standard-packages)))
          (build-inputs `(("node" ,node)
+                         ("python" ,python)
+                        ;; We don't always need libuv, but the libuv and
+                        ;; node versions need to match:
+                        ("libuv" ,@(assoc-ref (package-inputs node) "libuv"))
                          ,@native-inputs))
          (outputs outputs)
          (build node-build)
diff --git a/guix/build/node-build-system.scm b/guix/build/node-build-system.scm
index 70a367618e..6aeb0149dd 100644
--- a/guix/build/node-build-system.scm
+++ b/guix/build/node-build-system.scm
@@ -2,6 +2,8 @@
 ;;; Copyright © 2015 David Thompson <davet@HIDDEN>
 ;;; Copyright © 2016, 2020 Jelle Licht <jlicht@HIDDEN>
 ;;; Copyright © 2019, 2021 Timothy Sample <samplet@HIDDEN>
+;;; Copyright © 2021 Pierre Langlois <pierre.langlois@HIDDEN>
+;;; Copyright © 2021 Philip McGrath <philip@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -46,6 +48,19 @@ (define (set-home . _)
               (format #t "set HOME to ~s~%" (getenv "HOME")))))))
   #t)
 
+(define* (set-node-gyp-paths #:key inputs #:allow-other-keys)
+  "Initialize environment variables needed for building native addons."
+  (setenv "npm_config_nodedir" (assoc-ref inputs "node"))
+  (setenv "npm_config_python" (assoc-ref inputs "python"))
+  (setenv "PATH"
+          (string-append (getenv "PATH")
+                         ":"
+                         ;; Put this at the end to make it easier to override,
+                         ;; just in case that should ever be necessary:
+                         (assoc-ref inputs "node")
+                         "/lib/node_modules/npm/bin/node-gyp-bin"))
+  #t)
+
 (define (module-name module)
   (let* ((package.json (string-append module "/package.json"))
          (package-meta (call-with-input-file package.json read-json)))
@@ -101,6 +116,12 @@ (define* (configure #:key outputs inputs #:allow-other-keys)
     (invoke npm "--offline" "--ignore-scripts" "install")
     #t))
 
+(define* (configure-gyp #:key inputs #:allow-other-keys)
+  "Run 'node-gyp configure' if we see a 'binding.gyp' file."
+  (if (file-exists? "binding.gyp")
+      (invoke (which "node-gyp") "configure")
+      #t))
+
 (define* (build #:key inputs #:allow-other-keys)
   (let ((package-meta (call-with-input-file "package.json" read-json)))
     (if (and=> (assoc-ref package-meta "scripts")
@@ -144,9 +165,11 @@ (define* (install #:key outputs inputs #:allow-other-keys)
 
 (define %standard-phases
   (modify-phases gnu:%standard-phases
+    (add-after 'set-paths 'set-node-gyp-paths set-node-gyp-paths)
     (add-after 'unpack 'set-home set-home)
     (add-before 'configure 'patch-dependencies patch-dependencies)
     (replace 'configure configure)
+    (add-after 'configure 'configure-gyp configure-gyp)
     (replace 'build build)
     (replace 'check check)
     (add-before 'install 'repack repack)
-- 
2.32.0





Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 14 Nov 2021 13:04:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 14 08:04:34 2021
Received: from localhost ([127.0.0.1]:49400 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mmFBS-0004xx-LT
	for submit <at> debbugs.gnu.org; Sun, 14 Nov 2021 08:04:34 -0500
Received: from mail-qt1-f169.google.com ([209.85.160.169]:43644)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1mmFBP-0004xi-Aq
 for 51838 <at> debbugs.gnu.org; Sun, 14 Nov 2021 08:04:33 -0500
Received: by mail-qt1-f169.google.com with SMTP id q14so12993696qtx.10
 for <51838 <at> debbugs.gnu.org>; Sun, 14 Nov 2021 05:04:31 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=ZOWdzTy3Qu8bM2k6Fhc5GDGbC330WVG6B06/BR/Lh84=;
 b=GWzA21X8W6Ee0BxfcYEVQmORi5ZcppAZReLiinlItlHQHv+BV7BKDPc5GbB/kXxEAF
 BCHxXsn7oh8szk50fsRf15qKDtSAChspXrT7XuuG5RPWl6VdqFJwxo9UCiqeez9yXGWC
 bim4cdDQHmGKU2gSSWjUm2Wu0bzYQVSb54JSg7YoCt6zmOkfMVToKEas1IVUN19sWt5d
 cOdRJn30hNBH20WymtZSkjdirZ/h3FdzvDwOlssTja/5ef+aJd36aXPjmXsH3YD0W+0F
 wXsCya5TO1DEe9SoS8MRKuoWj4iV9eWf+F6IAFKys7VeCg2k4elTXUpIxTZGZyf+qkja
 nLDg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=ZOWdzTy3Qu8bM2k6Fhc5GDGbC330WVG6B06/BR/Lh84=;
 b=8AI+Wdn18MapQpZz9uTphKZwBG4XMWSvonWLqfLokYbRMD3dEZIumV8/vnRltJj8Y5
 GFANUvr5U8mWVIdtN64Y4Xc+z5sHoDMj9rddwFHPENN2NN0rCZaQFBxa4HdXEGoGAzt6
 tIGEKzVjJak4klpej1cViyFawUrm6q0p0SY+P/mMVWuDLMTu+WsMNcQK1t23rxNmehgh
 Eud1RnHc88AU8Uwc08sL3/tkq3RHnKmMjrufCuL/kPQOe7/Ne4mBl07HamFCSclMPwsN
 MdlcTixcJHhudQAbacsXl4ybVsNJnJQ8JhoSlonB92ouZXSaHPDaA0DTCNx97QqeTum1
 XHPA==
X-Gm-Message-State: AOAM531/qtoQYLllzUeClgRYEkUNwWFzrZZZQ1Ej7Lj+4mcHW7Bwz9wV
 yW5plLnb+AYfMqrieCJH6UMEWQL/mbd8MCBI
X-Google-Smtp-Source: ABdhPJw4S2JPCoEy+JP66rBndRmBWrKbOLdiMn0e44e8/qCW1Tx3n8L6p5YsSayMWa/J5LzaoZ5Mow==
X-Received: by 2002:a05:622a:152:: with SMTP id
 v18mr32401950qtw.380.1636895065769; 
 Sun, 14 Nov 2021 05:04:25 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id bm25sm5484137qkb.4.2021.11.14.05.04.25
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 14 Nov 2021 05:04:25 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH 02/11] gnu: node: Update to 10.24.1 for bootstrapping.
Date: Sun, 14 Nov 2021 08:04:00 -0500
Message-Id: <20211114130409.49241-1-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211114125830.45427-1-philip@HIDDEN>
References: <20211114125830.45427-1-philip@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.6 (/)
X-Debbugs-Envelope-To: 51838
Cc: Philip McGrath <philip@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.4 (/)

* gnu/packages/node.scm (node): Update to 10.24.1.
---
 gnu/packages/node.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index db1658f03d..89a9bc7533 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -57,14 +57,14 @@ (define-module (gnu packages node)
 (define-public node
   (package
     (name "node")
-    (version "10.24.0")
+    (version "10.24.1")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://nodejs.org/dist/v" version
                                   "/node-v" version ".tar.xz"))
               (sha256
                (base32
-                "1k1srdis23782hnd1ymgczs78x9gqhv77v0am7yb54gqcspp70hm"))
+                "032801kg24j04xmf09m0vxzlcz86sv21s24lv9l4cfv08k1c4byp"))
               (modules '((guix build utils)))
               (snippet
                `(begin
-- 
2.32.0





Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at 51838 <at> debbugs.gnu.org:


Received: (at 51838) by debbugs.gnu.org; 14 Nov 2021 12:59:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 14 07:59:03 2021
Received: from localhost ([127.0.0.1]:49387 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mmF67-0004o2-4w
	for submit <at> debbugs.gnu.org; Sun, 14 Nov 2021 07:59:03 -0500
Received: from mail-qt1-f180.google.com ([209.85.160.180]:33364)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1mmF65-0004nW-5j
 for 51838 <at> debbugs.gnu.org; Sun, 14 Nov 2021 07:59:01 -0500
Received: by mail-qt1-f180.google.com with SMTP id n15so13071631qta.0
 for <51838 <at> debbugs.gnu.org>; Sun, 14 Nov 2021 04:59:01 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=j2oH8wkCE8WAna0+WGKhXDeSFWHhrNWtN7zxLH0FIHo=;
 b=CIH0/GivEKKCGlo3eD0q0Ymu8kJ6mxCkr9UQGab5LmxPEZ61tX/rb8W6kSlgKURi9Z
 hqQJo7/Is1ChwpQnweiIlBuhu+sZRUlSK+d/XjUSzrz71Q+VrT2LFqyHJ2vklizwW0YM
 FzBx3Autzk0KeSfb8PxTPC6AHOGk57BZphYp7GB6974dPZEULlPEPMeB3Y42hokoiTZ9
 j5OL3heJKq5c01UU+9oi71hsvQ1v66tS1/FlwD0VRnuhuKJPE9X//+/KewYtnvzOUc8U
 wPikzTAWBwo5fwj1n16Ffvzioftu68QrjaeY4UzAu6FSD5T3UdiPRQf429AIeMjas+I7
 ULWA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=j2oH8wkCE8WAna0+WGKhXDeSFWHhrNWtN7zxLH0FIHo=;
 b=lyiPEC0qq0dhfmsWEsHxlmqty0HwP/IQZgZq1eTVhg/rmwDKTnvw0bGGBkunomF8Ah
 QTyNhWBOqcQgfLtiaXKeNEjuthi9PHCycC3VcDD/zO/D8ov16IoX4EWw1QChnEaT4/Fx
 9kboCRSHgdHZI4hqz+rpjEsCvsyp1jh2kaOw72Om8fX4Mmj+DeMjrTYcHauvyeUrbPOO
 rliQxfBiq3gPLIK/YJPBoECigBRvdZVYYIO71sDWTeSaxYMxELK2clpjUi0Jlmp5n+rW
 G8nNCF0oNpJyEBu3qFPcoLr7kXvPM4pPPzXHKK+G79pVcSGz7KpWSaek7BuALw9xfY3N
 aurw==
X-Gm-Message-State: AOAM5328yooLjam9P8X5BKBKOL9Xr5EtI+AeFfCQVb3Qp3Sh1Ic/MrT6
 0pjaFBGuw6+j1t/KSSwQN7fSBu8luZu8eXcT
X-Google-Smtp-Source: ABdhPJxstOYOCo/MHONt0IpQYqkaczpZclBs3RXf68QrI0MXIEutWJyKj/RnQPnQ6Dyb2QiBxxFo3g==
X-Received: by 2002:ac8:7d46:: with SMTP id h6mr17578185qtb.379.1636894735231; 
 Sun, 14 Nov 2021 04:58:55 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id p16sm6236063qtx.92.2021.11.14.04.58.54
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 14 Nov 2021 04:58:55 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: 51838 <at> debbugs.gnu.org
Subject: [PATCH 01/11] gnu: node: Avoid duplicating build phases.
Date: Sun, 14 Nov 2021 07:58:30 -0500
Message-Id: <20211114125830.45427-1-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20211114124151.36743-1-philip@HIDDEN>
References: <20211114124151.36743-1-philip@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.6 (/)
X-Debbugs-Envelope-To: 51838
Cc: Philip McGrath <philip@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.4 (/)

* gnu/packages/node.scm (node)[arguments]: Split 'patch-files phase
into 'patch-hardcoded-program-references and
'delete-problematic-tests. Adapt 'patch-hardcoded-program-references
and 'configure to work unmodified on node-lts, but don't try to
share 'delete-problematic-tests, because those details seem to change
too much between node versions.
(node, node-lts)[inputs]: Use bash-minimal rather than bash.
(node-lts)[arguments]: Inherit 'patch-hardcoded-program-references,
and 'configure phases from the bootstrap node.
Remove the 'patch-files phase, keeping its remaining
non-inherited work in a new 'replace-llhttp-sources phase.
---
 gnu/packages/node.scm | 105 +++++++++++++-----------------------------
 1 file changed, 32 insertions(+), 73 deletions(-)

diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index d0ffe8a398..db1658f03d 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2020, 2021 Pierre Langlois <pierre.langlois@HIDDEN>
 ;;; Copyright © 2020 Ricardo Wurmus <rekado@HIDDEN>
 ;;; Copyright © 2021 Simon Tournier <zimon.toutoune@HIDDEN>
+;;; Copyright © 2021 Philip McGrath <philip@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -105,14 +106,22 @@ (define-public node
        #:test-target "test-ci-js"
        #:phases
        (modify-phases %standard-phases
-         (add-before 'configure 'patch-files
+         (add-before 'configure 'patch-hardcoded-program-references
            (lambda* (#:key inputs #:allow-other-keys)
+
              ;; Fix hardcoded /bin/sh references.
-             (substitute* '("lib/child_process.js"
-                            "lib/internal/v8_prof_polyfill.js"
-                            "test/parallel/test-child-process-spawnsync-shell.js"
-                            "test/parallel/test-stdio-closed.js"
-                            "test/sequential/test-child-process-emfile.js")
+             (substitute*
+                 (let ((common
+                        '("lib/child_process.js"
+                          "lib/internal/v8_prof_polyfill.js"
+                          "test/parallel/test-child-process-spawnsync-shell.js"
+                          "test/parallel/test-stdio-closed.js"
+                          "test/sequential/test-child-process-emfile.js"))
+                       ;; not in bootstap node:
+                       (sigxfsz "test/parallel/test-fs-write-sigxfsz.js"))
+                   (if (file-exists? sigxfsz)
+                       (cons sigxfsz common)
+                       common))
                (("'/bin/sh'")
                 (string-append "'" (assoc-ref inputs "bash") "/bin/sh'")))
 
@@ -122,7 +131,10 @@ (define-public node
                             "test/parallel/test-child-process-exec-env.js")
                (("'/usr/bin/env'")
                 (string-append "'" (assoc-ref inputs "coreutils")
-                               "/bin/env'")))
+                               "/bin/env'")))))
+         (add-after 'patch-hardcoded-program-references
+             'delete-problematic-tests
+           (lambda* (#:key inputs #:allow-other-keys)
 
              ;; FIXME: These tests fail in the build container, but they don't
              ;; seem to be indicative of real problems in practice.
@@ -217,9 +229,13 @@ (define-public node
                (setenv "CXX" ,(cxx-for-target))
                (setenv "PKG_CONFIG" ,(pkg-config-for-target))
                (apply invoke
-                      (string-append (assoc-ref (or native-inputs inputs)
-                                                "python")
-                                     "/bin/python")
+                      (let ((python
+                             (string-append (assoc-ref (or native-inputs inputs)
+                                                       "python")
+                                            "/bin/python")))
+                        (if (file-exists? python)
+                            python
+                            (string-append python "3")))
                       "configure" flags))))
          (add-after 'patch-shebangs 'patch-npm-shebang
            (lambda* (#:key outputs #:allow-other-keys)
@@ -256,7 +272,7 @@ (define-public node
             (variable "NODE_PATH")
             (files '("lib/node_modules")))))
     (inputs
-     `(("bash" ,bash)
+     `(("bash" ,bash-minimal)
        ("coreutils" ,coreutils)
        ("c-ares" ,c-ares)
        ("http-parser" ,http-parser)
@@ -711,66 +727,8 @@ (define-public node-lts
                                    libuv "/lib:"
                                    zlib "/lib"
                                    "'],"))))))
-           (replace 'configure
-             ;; Node's configure script is actually a python script, so we can't
-             ;; run it with bash.
-             (lambda* (#:key outputs (configure-flags '()) native-inputs inputs
-                       #:allow-other-keys)
-               (let* ((prefix (assoc-ref outputs "out"))
-                      (xflags ,(if (%current-target-system)
-                                   `'("--cross-compiling"
-                                     ,(string-append
-                                       "--dest-cpu="
-                                       (match (%current-target-system)
-                                         ((? (cut string-prefix? "arm" <>))
-                                          "arm")
-                                         ((? (cut string-prefix? "aarch64" <>))
-                                          "arm64")
-                                         ((? (cut string-prefix? "i686" <>))
-                                          "ia32")
-                                         ((? (cut string-prefix? "x86_64" <>))
-                                          "x64")
-                                         ((? (cut string-prefix? "powerpc64" <>))
-                                          "ppc64")
-                                         (_ "unsupported"))))
-                                   ''()))
-                      (flags (cons
-                               (string-append "--prefix=" prefix)
-                               (append xflags configure-flags))))
-                 (format #t "build directory: ~s~%" (getcwd))
-                 (format #t "configure flags: ~s~%" flags)
-                 ;; Node's configure script expects the CC environment variable to
-                 ;; be set.
-                 (setenv "CC_host" "gcc")
-                 (setenv "CXX_host" "g++")
-                 (setenv "CC" ,(cc-for-target))
-                 (setenv "CXX" ,(cxx-for-target))
-                 (setenv "PKG_CONFIG" ,(pkg-config-for-target))
-                 (apply invoke
-                        (string-append (assoc-ref (or native-inputs inputs)
-                                                  "python")
-                                       "/bin/python3")
-                        "configure" flags))))
-           (replace 'patch-files
+           (replace 'delete-problematic-tests
              (lambda* (#:key inputs #:allow-other-keys)
-               ;; Fix hardcoded /bin/sh references.
-               (substitute* '("lib/child_process.js"
-                              "lib/internal/v8_prof_polyfill.js"
-                              "test/parallel/test-child-process-spawnsync-shell.js"
-                              "test/parallel/test-fs-write-sigxfsz.js"
-                              "test/parallel/test-stdio-closed.js"
-                              "test/sequential/test-child-process-emfile.js")
-                 (("'/bin/sh'")
-                  (string-append "'" (assoc-ref inputs "bash") "/bin/sh'")))
-
-               ;; Fix hardcoded /usr/bin/env references.
-               (substitute* '("test/parallel/test-child-process-default-options.js"
-                              "test/parallel/test-child-process-env.js"
-                              "test/parallel/test-child-process-exec-env.js")
-                 (("'/usr/bin/env'")
-                  (string-append "'" (assoc-ref inputs "coreutils")
-                                 "/bin/env'")))
-
                ;; FIXME: These tests fail in the build container, but they don't
                ;; seem to be indicative of real problems in practice.
                (for-each delete-file
@@ -806,8 +764,9 @@ (define-public node-lts
                ;; TODO: Regenerate certs instead.
                (for-each delete-file
                          '("test/parallel/test-tls-passphrase.js"
-                           "test/parallel/test-tls-server-verify.js"))
-
+                           "test/parallel/test-tls-server-verify.js"))))
+           (add-after 'delete-problematic-tests 'replace-llhttp-sources
+             (lambda* (#:key inputs #:allow-other-keys)
                ;; Replace pre-generated llhttp sources
                (let ((llhttp (assoc-ref inputs "llhttp")))
                  (copy-file (string-append llhttp "/src/llhttp.c")
@@ -834,7 +793,7 @@ (define-public node-lts
        ("python" ,python)
        ("util-linux" ,util-linux)))
     (inputs
-     `(("bash" ,bash)
+     `(("bash" ,bash-minimal)
        ("coreutils" ,coreutils)
        ("c-ares" ,c-ares)
        ("icu4c" ,icu4c-67)
-- 
2.32.0





Information forwarded to guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 14 Nov 2021 12:42:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 14 07:42:13 2021
Received: from localhost ([127.0.0.1]:49366 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mmEpp-0004Ke-Aw
	for submit <at> debbugs.gnu.org; Sun, 14 Nov 2021 07:42:13 -0500
Received: from lists.gnu.org ([209.51.188.17]:42278)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philip@HIDDEN>) id 1mmEpn-0004KV-HG
 for submit <at> debbugs.gnu.org; Sun, 14 Nov 2021 07:42:11 -0500
Received: from eggs.gnu.org ([209.51.188.92]:34790)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <philip@HIDDEN>)
 id 1mmEpn-0001ra-6A
 for guix-patches@HIDDEN; Sun, 14 Nov 2021 07:42:11 -0500
Received: from [2607:f8b0:4864:20::829] (port=35467
 helo=mail-qt1-x829.google.com)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <philip@HIDDEN>)
 id 1mmEpa-0007Rr-GN
 for guix-patches@HIDDEN; Sun, 14 Nov 2021 07:42:10 -0500
Received: by mail-qt1-x829.google.com with SMTP id j17so13012909qtx.2
 for <guix-patches@HIDDEN>; Sun, 14 Nov 2021 04:41:56 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=philipmcgrath.com; s=google;
 h=from:to:cc:subject:date:message-id:mime-version
 :content-transfer-encoding;
 bh=fd2XS7xL/uD+QIR1ubJy0Jx5AhsLDZMHFDqSi0Jsc5Y=;
 b=eO1kvBrk9RG/kzdprYOu3Xu/fmN3fHZf7LS5kMUKdLpqI5RKjlTplZlzyhwszzcl12
 iAxT3XilIk8rcdwgdlLSDzEpUmafr6M2QcDKNVKBLg8fLj3+fzzbPVcReHtYM8co3A3e
 NoTank7nNC/ANg7B+UYzSmu/+2yR2opiaq9Y3k3jYa4QCpyY56Yq9YiGlV8A6n7kcHE0
 uo3Ll2Mr7zKroO6Qnkj5CUocbkiahVCCJAfDTcQBf7c+IdcLnwMqJUALsUQ8ObODfA21
 w98dBLmaGVKGsEbSWGOSjfeWOWkATIg52nRYc1dzb1zr4zoFbWWsWDPZxIiIMxLj/89U
 Vn4A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
 :content-transfer-encoding;
 bh=fd2XS7xL/uD+QIR1ubJy0Jx5AhsLDZMHFDqSi0Jsc5Y=;
 b=2L0ZaMlhbGa+NIvua07y7IZIQ/n6N1O4CbpPO3xBBrPecJzGPV6fIqWFCaMRSZBGQ4
 pEZkKOwsAL4IMW88WJsrdiBkbs4HIacN8A7qUUL8JOAyRGI+clluY42+UlHMQSOddOkx
 kMvTr7NT1acfEwXrPt6B0f8LBSBf4JdNiPd4Nxblnf3iLv+gknpYM8y+xvLK+W8HKOOU
 rUxIDBT9SAOuIUUfmEffRsQ7fQjR04yJLkTfgOk7c4NThWRAJQFI/naYDIS6eskBG8Ns
 Vmh8HpWhDRwWJgiWbNlCPZIX1zHu+M8rJ5G5ETaySxAVFxEWk4Fa3EvrUcNm0opkVFZZ
 RYdw==
X-Gm-Message-State: AOAM5334MYy+3m+xJaEW4JGOB/SiU6sLHXSbW5jSuJaYh4wIOaPCAqDs
 12K/HaWb6GkqEpITQiNbA66OgLI+g2OK5GYQ
X-Google-Smtp-Source: ABdhPJwlFlHIEQ0A4VSmBcMcPqVrqIw++TK2bC9YylM9u6oJTXEcdSVMDDm1xvMFY7Mdgf5vKgJnmw==
X-Received: by 2002:a05:622a:20e:: with SMTP id
 b14mr26456357qtx.288.1636893715329; 
 Sun, 14 Nov 2021 04:41:55 -0800 (PST)
Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242])
 by smtp.gmail.com with ESMTPSA id y16sm5916760qtm.12.2021.11.14.04.41.54
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 14 Nov 2021 04:41:55 -0800 (PST)
From: Philip McGrath <philip@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH 00/11] guix: node-build-system: Support compiling add-ons with
 node-gyp.
Date: Sun, 14 Nov 2021 07:41:51 -0500
Message-Id: <20211114124151.36743-1-philip@HIDDEN>
X-Mailer: git-send-email 2.32.0
MIME-Version: 1.0
X-Debbugs-CC: Pierre Langlois <pierre.langlois@HIDDEN>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::829
 (failed)
Received-SPF: neutral client-ip=2607:f8b0:4864:20::829;
 envelope-from=philip@HIDDEN; helo=mail-qt1-x829.google.com
X-Spam_score_int: 0
X-Spam_score: -0.1
X-Spam_bar: /
X-Spam_report: (-0.1 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1,
 DKIM_SIGNED=0.1, PDS_HP_HELO_NORDNS=0.001, RDNS_NONE=0.793,
 SPF_HELO_NONE=0.001, SPF_NEUTRAL=0.779 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.6 (-)
X-Debbugs-Envelope-To: submit
Cc: Philip McGrath <philip@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)

This patch series adds support to `node-build-system` for building native
add-ons using `node-gyp`. To confirm that the changes to the build system
work, the patch series also adds two packages (plus a few dependencies)
representing two major ways of writing Node.js native add-ons:

 1. `node-openzwave-shared` uses `node-nan`: “Native Abstractions for Node.js”.

 2. `node-sqlite3` uses the Node-API via `node-addon-api`.

The patches are adapted from part of a series by Pierre Langlois
at <https://issues.guix.gnu.org/49946>: you can find discussion of an earlier
version of this spun-off series from <https://issues.guix.gnu.org/49946#71>
to <https://issues.guix.gnu.org/49946#83>.
They are also available in a Git repository
at <https://gitlab.com/philip1/guix-patches/-/tree/wip-node-npm-gyp-hist-9>.

In the earlier discussion, Pierre and I both thought it was quite confusing
that the Scheme variable `node` refers to the bootstrap Node.js, while
`node-lts` refers to the newer Node.js that a package specification of
`"node"` would resolve to. My analysis is
at <https://issues.guix.gnu.org/49946#75> (tl;dr it seems like an unintentional
mistake), and Pierre suggested a solution
in <https://issues.guix.gnu.org/49946#81>. I haven't taken that on in this patch
series, but I do think its worth considering.

Philip McGrath (11):
  gnu: node: Avoid duplicating build phases.
  gnu: node: Update to 10.24.1 for bootstrapping.
  guix: node-build-system: Support compiling add-ons with node-gyp.
  gnu: Add node-inherits.
  gnu: Add node-safe-buffer.
  gnu: Add node-string-decoder.
  gnu: Add node-readable-stream.
  gnu: Add node-nan.
  gnu: Add node-openzwave-shared.
  gnu: Add node-addon-api.
  gnu: Add node-sqlite3.

 gnu/packages/node-xyz.scm        | 335 +++++++++++++++++++++++++++++++
 gnu/packages/node.scm            | 143 +++++--------
 gnu/packages/zwave.scm           |  55 +++++
 guix/build-system/node.scm       |  11 +-
 guix/build/node-build-system.scm |  23 +++
 5 files changed, 473 insertions(+), 94 deletions(-)

-- 
2.32.0





Acknowledgement sent to Philip McGrath <philip@HIDDEN>:
New bug report received and forwarded. Copy sent to pierre.langlois@HIDDEN, guix-patches@HIDDEN. Full text available.
Report forwarded to pierre.langlois@HIDDEN, guix-patches@HIDDEN:
bug#51838; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Thu, 2 Dec 2021 21:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.