GNU bug report logs - #51890
Vigra: disable more failing tests on core-updates-frozen

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51890 in the body.
You can then email your comments to 51890 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: guix-patches <at> gnu.org
Subject: Vigra: disable more failing tests on core-updates-frozen
Date: Tue, 16 Nov 2021 11:12:23 +0000

[Message part 1 (text/plain, inline)]

Dear guix,

vigra fails to pass a few more tests on core-updates-frozen. I propose
that we discard them. What do you think?

Best regards,

Vivien

[0001-gnu-vigra-Disable-more-failing-tests.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 51890 <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: 51890 <at> debbugs.gnu.org
Subject: Re: Vigra: disable more failing tests on core-updates-frozen
Date: Wed, 17 Nov 2021 08:54:33 +0000

[Message part 1 (text/plain, inline)]

Sorry, I forgot some disabled tests in the changelog message.

Vivien

[0001-gnu-vigra-Disable-more-failing-tests.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 51890 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Vivien Kraus <vivien <at> planete-kraus.eu>
Cc: 51890 <at> debbugs.gnu.org, Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re: bug#51890: Vigra: disable more failing tests on
 core-updates-frozen
Date: Thu, 18 Nov 2021 10:09:50 +0100

Hi,

Vivien Kraus <vivien <at> planete-kraus.eu> skribis:

> From 4311c36dcd280ba385a3d0f33800428102bef0b8 Mon Sep 17 00:00:00 2001
> From: Vivien Kraus <vivien <at> planete-kraus.eu>
> Date: Tue, 16 Nov 2021 08:18:42 +0000
> Subject: [PATCH] gnu: vigra: Disable more failing tests.
>
> * gnu/packages/image.scm (vigra) [phase disable-broken-tests]: Also disable
> test2, test3, test_arraytypes and test_multidef.

Looks like it was worked around by disabling NumPy support in Vigra, in
commit 94b76dc85ca3098bf4ceb0f5b884b5708b9e8134.

I’m not sure how NumPy is used; is there a preference between these two
options (disabling flaky tests and removing the dependency on NumPy)?

Thanks,
Ludo’.

Message #14 received at 51890 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Ludovic Courtès <ludo <at> gnu.org>,
 Vivien Kraus <vivien <at> planete-kraus.eu>
Cc: 51890 <at> debbugs.gnu.org
Subject: Re: bug#51890: Vigra: disable more failing tests on core-updates-frozen
Date: Thu, 18 Nov 2021 09:17:03 +0000

On November 18, 2021 9:09:50 AM UTC, "Ludovic Courtès" <ludo <at> gnu.org> wrote:
>Hi,
>
>Vivien Kraus <vivien <at> planete-kraus.eu> skribis:
>
>> From 4311c36dcd280ba385a3d0f33800428102bef0b8 Mon Sep 17 00:00:00 2001
>> From: Vivien Kraus <vivien <at> planete-kraus.eu>
>> Date: Tue, 16 Nov 2021 08:18:42 +0000
>> Subject: [PATCH] gnu: vigra: Disable more failing tests.
>>
>> * gnu/packages/image.scm (vigra) [phase disable-broken-tests]: Also disable
>> test2, test3, test_arraytypes and test_multidef.
>
>Looks like it was worked around by disabling NumPy support in Vigra, in
>commit 94b76dc85ca3098bf4ceb0f5b884b5708b9e8134.
>
>I’m not sure how NumPy is used; is there a preference between these two
>options (disabling flaky tests and removing the dependency on NumPy)?
>
>Thanks,
>Ludo’.

It looked to me like vigra was limping along and numpy compatibility was being dragged along by patches here and there. When I built the dependencies of vigra nothing failed to build. I'm definitely not against reinstating support for numpy but I'm not sure just disabling the tests is the right way.

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Message #17 received at 51890 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: Ludovic Courtès <ludo <at> gnu.org>,
 Vivien Kraus <vivien <at> planete-kraus.eu>, 51890 <at> debbugs.gnu.org
Subject: Re: bug#51890: Vigra: disable more failing tests on
 core-updates-frozen
Date: Thu, 18 Nov 2021 08:18:38 -0500

Hello,

Efraim Flashner <efraim <at> flashner.co.il> writes:

> On November 18, 2021 9:09:50 AM UTC, "Ludovic Courtès" <ludo <at> gnu.org> wrote:
>>Hi,
>>
>>Vivien Kraus <vivien <at> planete-kraus.eu> skribis:
>>
>>> From 4311c36dcd280ba385a3d0f33800428102bef0b8 Mon Sep 17 00:00:00 2001
>>> From: Vivien Kraus <vivien <at> planete-kraus.eu>
>>> Date: Tue, 16 Nov 2021 08:18:42 +0000
>>> Subject: [PATCH] gnu: vigra: Disable more failing tests.
>>>
>>> * gnu/packages/image.scm (vigra) [phase disable-broken-tests]: Also disable
>>> test2, test3, test_arraytypes and test_multidef.
>>
>>Looks like it was worked around by disabling NumPy support in Vigra, in
>>commit 94b76dc85ca3098bf4ceb0f5b884b5708b9e8134.
>>
>>I’m not sure how NumPy is used; is there a preference between these two
>>options (disabling flaky tests and removing the dependency on NumPy)?
>>
>>Thanks,
>>Ludo’.
>
> It looked to me like vigra was limping along and numpy compatibility
> was being dragged along by patches here and there. When I built the
> dependencies of vigra nothing failed to build. I'm definitely not
> against reinstating support for numpy but I'm not sure just disabling
> the tests is the right way.

I know nothing about vigra, but judging from its description "[...] It
is an image processing and analysis library that puts its main emphasis
on customizable algorithms and data structures. [...]" it seems it'd
probably make good use of Numpy?  Not sure what are the consequences of
doing without; perhaps efficiency.

Thanks,

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.