GNU bug report logs - #51902
28.0.50; [PATCH] Get mh-e tests to pass

Previous Next

Package: emacs;

Reported by: dick <dick.r.chiang <at> gmail.com>

Date: Wed, 17 Nov 2021 00:21:02 UTC

Severity: normal

Tags: patch

Found in version 28.0.50

Done: Stephen Gildea <stepheng+emacs <at> gildea.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51902 in the body.
You can then email your comments to 51902 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#51902; Package emacs. (Wed, 17 Nov 2021 00:21:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to dick <dick.r.chiang <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 17 Nov 2021 00:21:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: dick <dick.r.chiang <at> gmail.com>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: 28.0.50; [PATCH] Get mh-e tests to pass
Date: Tue, 16 Nov 2021 19:20:16 -0500
[Message part 1 (text/plain, inline)]
Postscript to d89d5e0f94.  Until the patch for bug#51399 is
accepted, EMBA remains a non-entity.
[0001-Get-mh-e-tests-to-pass.patch (text/x-diff, inline)]
From eb2bf287b5b2389a7246e440f226449300c02a60 Mon Sep 17 00:00:00 2001
From: dickmao <dick.r.chiang <at> gmail.com>
Date: Tue, 16 Nov 2021 19:13:00 -0500
Subject: [PATCH] Get mh-e tests to pass

* test/lisp/mh-e/mh-utils-tests.el
(mh-folder-completion-function-08-plus-slash): Insulate against old
or decrepit mh.
(mh-folder-completion-function-09-plus-slash-tmp): Insulate against
old or decrepit mh.
---
 test/infra/gitlab-ci.yml         | 7 +++++++
 test/lisp/mh-e/mh-utils-tests.el | 8 ++++++++
 2 files changed, 15 insertions(+)

diff --git a/test/infra/gitlab-ci.yml b/test/infra/gitlab-ci.yml
index 001c779572..43897a9fe9 100644
--- a/test/infra/gitlab-ci.yml
+++ b/test/infra/gitlab-ci.yml
@@ -248,6 +248,13 @@ test-lisp-net-inotify:
     target: emacs-inotify
     make_params: "-C test check-lisp-net"
 
+test-lisp-mh-e-inotify:
+  stage: normal
+  extends: [.job-template, .test-template]
+  variables:
+    target: emacs-inotify
+    make_params: "-C test check-lisp-mh-e"
+
 build-image-filenotify-gio:
   stage: platform-images
   extends: [.job-template, .build-template, .filenotify-gio-template]
diff --git a/test/lisp/mh-e/mh-utils-tests.el b/test/lisp/mh-e/mh-utils-tests.el
index 0df4d44646..6f60d3b865 100644
--- a/test/lisp/mh-e/mh-utils-tests.el
+++ b/test/lisp/mh-e/mh-utils-tests.el
@@ -437,6 +437,10 @@ mh-folder-completion-function-07-rel-folder-slash-foo-slash
 
 (ert-deftest mh-folder-completion-function-08-plus-slash ()
   "Test `mh-folder-completion-function' with `+/'."
+  :expected-result '(satisfies (lambda (result)
+                                 (ert-test-result-type-p
+                                  result
+                                  (if mh-variant-in-use :passed :failed))))
   (mh-test-folder-completion-1 "+/" "+/" "tmp/" t)
     ;; case "bb"
     (with-mh-test-env
@@ -446,6 +450,10 @@ mh-folder-completion-function-08-plus-slash
 
 (ert-deftest mh-folder-completion-function-09-plus-slash-tmp ()
   "Test `mh-folder-completion-function' with `+/tmp'."
+  :expected-result '(satisfies (lambda (result)
+                                 (ert-test-result-type-p
+                                  result
+                                  (if mh-variant-in-use :passed :failed))))
   (mh-test-folder-completion-1 "+/tmp" "+/tmp/" "tmp/" t))
 
 (ert-deftest mh-folder-completion-function-10-plus-slash-abs-folder ()
-- 
2.26.2

[Message part 3 (text/plain, inline)]


In Commercial Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.30, cairo version 1.15.10)
 of 2021-11-16 built on dick
Repository revision: cf1a6159e01ddfddb599cd1d9bff67e38e0798dc
Repository branch: dev
Windowing system distributor 'The X.Org Foundation', version 11.0.11906000
System Description: Ubuntu 18.04.4 LTS

Configured using:
 'configure --prefix=/home/dick/.local --with-tree-sitter
 --enable-dumping-overwrite 'CFLAGS=-g3 -O2 -I/home/dick/.local/include/'
 LDFLAGS=-L/home/dick/.local/lib'
Configured features:
CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
TREE-SITTER LCMS2 LIBSELINUX LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG
SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XPM GTK3 ZLIB
Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Magit

Minor modes in effect:
  async-bytecomp-package-mode: t
  global-git-commit-mode: t
  shell-dirtrack-mode: t
  projectile-mode: t
  flx-ido-mode: t
  override-global-mode: t
  global-hl-line-mode: t
  winner-mode: t
  tooltip-mode: t
  show-paren-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
/home/dick/gomacro-mode/gomacro-mode hides /home/dick/.emacs.d/elpa/gomacro-mode-20200326.1103/gomacro-mode
/home/dick/.emacs.d/elpa/hydra-20170924.2259/lv hides /home/dick/.emacs.d/elpa/lv-20191106.1238/lv
/home/dick/.emacs.d/elpa/magit-3.3.0/magit-section-pkg hides /home/dick/.emacs.d/elpa/magit-section-3.3.0/magit-section-pkg
/home/dick/org-gcal.el/org-gcal hides /home/dick/.emacs.d/elpa/org-gcal-0.3/org-gcal
/home/dick/.emacs.d/lisp/json hides /home/dick/.local/share/emacs/28.0.50/lisp/json
/home/dick/.emacs.d/elpa/transient-0.3.6/transient hides /home/dick/.local/share/emacs/28.0.50/lisp/transient
/home/dick/.emacs.d/elpa/hierarchy-20171221.1151/hierarchy hides /home/dick/.local/share/emacs/28.0.50/lisp/emacs-lisp/hierarchy

Features:
(shadow emacsbug benchmark vc-git vc-dispatcher bug-reference face-remap
magit-patch-changelog magit-patch magit-submodule magit-obsolete magit-popup
async-bytecomp async magit-blame magit-stash magit-reflog magit-bisect
magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit
magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch
magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply
magit-wip magit-log which-func imenu magit-diff git-commit log-edit pcvs-util
magit-core magit-margin magit-transient magit-process with-editor server
magit-mode transient supercite regi bbdb-message sendmail footnote flow-fill
sort smiley smerge-mode diff diff-mode jka-compr mail-extr gnus-async gnus-ml
disp-table nndoc help-fns radix-tree cl-print debug backtrace find-func
gnus-dup gnus-demon nntp nnmairix nnml nnreddit gnus-topic request
virtualenvwrapper gud s json-rpc python tramp-sh tramp tramp-loaddefs trampver
tramp-integration files-x tramp-compat shell pcomplete ls-lisp format-spec
gnus-score score-mode gnus-bcklg gnus-srvr gnus-cite anaphora bbdb-mua
bbdb-com bbdb bbdb-site timezone gnus-delay gnus-draft gnus-cache gnus-agent
gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum shr
kinsoku svg dom nndraft nnmh gnus-group mm-url gnus-undo use-package
use-package-delight use-package-diminish gnus-start gnus-dbus dbus gnus-cloud
nnimap nnmail mail-source utf7 netrc nnoo parse-time iso8601 gnus-spec
gnus-int gnus-range gnus-win mm-archive message yank-media dired-x dired
dired-loaddefs rfc822 mml mml-sec epa epg rfc6068 epg-config mailabbrev
gmm-utils mailheader url-cache debbugs-gnu add-log debbugs soap-client
mm-decode mm-bodies mm-encode url-http url-auth url-gw network-stream gnutls
nsm rmc puny rng-xsd rng-dt rng-util xsd-regexp xml paredit-ext paredit subed
subed-vtt subed-srt subed-common subed-mpv subed-debug subed-config inf-ruby
ruby-mode smie company pcase haskell-interactive-mode
haskell-presentation-mode haskell-process haskell-session haskell-compile
haskell-mode haskell-cabal haskell-utils haskell-font-lock haskell-indentation
haskell-string haskell-sort-imports haskell-lexeme haskell-align-imports
haskell-complete-module haskell-ghc-support noutline outline flymake-proc
flymake warnings etags fileloop generator xref project dabbrev
haskell-customize hydra lv use-package-ensure solarized-theme
solarized-definitions projectile lisp-mnt mail-parse rfc2231 ibuf-ext ibuffer
ibuffer-loaddefs thingatpt magit-autorevert autorevert filenotify magit-git
magit-section magit-utils crm dash rx grep compile comint ansi-color gnus
nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils text-property-search time-date flx-ido flx
google-translate-default-ui google-translate-core-ui facemenu color ido
google-translate-core google-translate-tk google-translate-backend
use-package-bind-key bind-key auto-complete easy-mmode advice edmacro kmacro
popup cus-edit pp cus-load wid-edit emms-player-mplayer emms-player-simple
emms emms-compat cl-extra use-package-core derived hl-line winner ring
help-mode finder-inf json-reformat-autoloads json-snatcher-autoloads
sml-mode-autoloads tornado-template-mode-autoloads info package browse-url url
url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf
url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core
cl-macs eieio-loaddefs password-cache json map url-vars seq gv subr-x byte-opt
bytecomp byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc paren
electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt
fringe tree-sitter tabulated-list replace newcomment text-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer
select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese composite
emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple
abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp
files window text-properties overlay sha1 md5 base64 format env code-pages
mule custom widget keymap hashtable-print-readable backquote threads dbusbind
inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo
move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 589624 37366)
 (symbols 48 38225 3)
 (strings 32 146790 10938)
 (string-bytes 1 4842385)
 (vectors 16 59032)
 (vector-slots 8 735642 35369)
 (floats 8 591 1479)
 (intervals 56 4332 492)
 (buffers 992 24))

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51902; Package emacs. (Wed, 17 Nov 2021 08:08:02 GMT) Full text and rfc822 format available.

Message #8 received at 51902 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stephen Gildea <stepheng+emacs <at> gildea.com>
Cc: dick <dick.r.chiang <at> gmail.com>, 51902 <at> debbugs.gnu.org
Subject: Re: bug#51902: 28.0.50; [PATCH] Get mh-e tests to pass
Date: Wed, 17 Nov 2021 09:06:46 +0100
dick <dick.r.chiang <at> gmail.com> writes:

>  (ert-deftest mh-folder-completion-function-08-plus-slash ()
>    "Test `mh-folder-completion-function' with `+/'."
> +  :expected-result '(satisfies (lambda (result)
> +                                 (ert-test-result-type-p
> +                                  result
> +                                  (if mh-variant-in-use :passed :failed))))

Stephen, does this look OK to you, or should it be fixed a different
way?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51902; Package emacs. (Wed, 17 Nov 2021 08:41:02 GMT) Full text and rfc822 format available.

Message #11 received at 51902 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: dick <dick.r.chiang <at> gmail.com>
Cc: 51902 <at> debbugs.gnu.org
Subject: Re: bug#51902: 28.0.50; [PATCH] Get mh-e tests to pass
Date: Wed, 17 Nov 2021 09:40:10 +0100
dick <dick.r.chiang <at> gmail.com> writes:

> diff --git a/test/infra/gitlab-ci.yml b/test/infra/gitlab-ci.yml
> index 001c779572..43897a9fe9 100644
> --- a/test/infra/gitlab-ci.yml
> +++ b/test/infra/gitlab-ci.yml
> @@ -248,6 +248,13 @@ test-lisp-net-inotify:
>      target: emacs-inotify
>      make_params: "-C test check-lisp-net"
>
> +test-lisp-mh-e-inotify:
> +  stage: normal
> +  extends: [.job-template, .test-template]
> +  variables:
> +    target: emacs-inotify
> +    make_params: "-C test check-lisp-mh-e"
> +
>  build-image-filenotify-gio:
>    stage: platform-images
>    extends: [.job-template, .build-template, .filenotify-gio-template]

Looks OK to me. Perhaps it could be added prior test-lisp-net-inotify,
keeping alphabetical order?

Bonus points, if the rules for this job (and test-lisp-inotify,
test-lisp-net-inotify) could be adapted, that these jobs run only when
there are relevant changes.

Best regards, Michael.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51902; Package emacs. (Wed, 17 Nov 2021 14:48:01 GMT) Full text and rfc822 format available.

Message #14 received at 51902 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Gildea <stepheng+emacs <at> gildea.com>
To: Mike Kupfer <mkupfer <at> alum.berkeley.edu>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, dick <dick.r.chiang <at> gmail.com>,
 51902 <at> debbugs.gnu.org
Subject: Re: bug#51902: 28.0.50; [PATCH] Get mh-e tests to pass
Date: Wed, 17 Nov 2021 06:46:54 -0800
Mike, bug report https://debbugs.gnu.org/51902 causes me to notice that
our fix for "+/" works only with nmh.  It fails with GNU Mailutils and
with MH mocked out.

I can fix the mocks (and am sad I didn't think to test that before
committing the patch).

But what about mailutils?  I think you told me that you had to get a
bug in nmh fixed before this would work; perhaps mailutils has the same
bug?  If so, do we need to make an exception in the test as suggested
by this bug report: expect failure with mailutils?

 < Stephen




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51902; Package emacs. (Wed, 17 Nov 2021 16:18:02 GMT) Full text and rfc822 format available.

Message #17 received at 51902 <at> debbugs.gnu.org (full text, mbox):

From: Mike Kupfer <mkupfer <at> alum.berkeley.edu>
To: Stephen Gildea <stepheng+emacs <at> gildea.com>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, dick <dick.r.chiang <at> gmail.com>,
 51902 <at> debbugs.gnu.org
Subject: Re: bug#51902: 28.0.50; [PATCH] Get mh-e tests to pass
Date: Wed, 17 Nov 2021 08:16:54 -0800
Stephen Gildea wrote:

> Mike, bug report https://debbugs.gnu.org/51902 causes me to notice that
> our fix for "+/" works only with nmh.  It fails with GNU Mailutils and
> with MH mocked out.
> 
> I can fix the mocks (and am sad I didn't think to test that before
> committing the patch).

Ah.  So that explains the test failure that Lars reported on emacs-devel
(<871r3g7cdy.fsf <at> gnus.org>)?

> But what about mailutils?  I think you told me that you had to get a
> bug in nmh fixed before this would work; perhaps mailutils has the same
> bug?  If so, do we need to make an exception in the test as suggested
> by this bug report: expect failure with mailutils?

The bug was in an older version of Mailutils, where it was spewing
garbage from some internal buffer.  Sergey fixed it in Mailutils 3.7,
which was released in 2019.  So I'd configure the test to expect a pass
everywhere, once the mock environment is fixed.

Also, did you catch this comment from Stefan Kangas on emacs-devel:

> I've marked these tests as unstable for now (commit fc8c976298), please
> remove that tag when you fix them.

thanks,
mike




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51902; Package emacs. (Wed, 17 Nov 2021 16:25:01 GMT) Full text and rfc822 format available.

Message #20 received at 51902 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Gildea <stepheng+emacs <at> gildea.com>
To: Mike Kupfer <mkupfer <at> alum.berkeley.edu>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, dick <dick.r.chiang <at> gmail.com>,
 51902 <at> debbugs.gnu.org
Subject: Re: bug#51902: 28.0.50; [PATCH] Get mh-e tests to pass
Date: Wed, 17 Nov 2021 08:23:59 -0800
Mike Kupfer <mkupfer <at> alum.berkeley.edu> wrote:

>   The bug was in an older version of Mailutils, where it was spewing
>   garbage from some internal buffer.  Sergey fixed it in Mailutils 3.7,
>   which was released in 2019.  So I'd configure the test to expect a pass
>   everywhere, once the mock environment is fixed.

I get failure with both Mailutils 3.7 and 3.13.

>   Also, did you catch this comment from Stefan Kangas on emacs-devel:
>   
>   > I've marked these tests as unstable for now (commit fc8c976298), please
>   > remove that tag when you fix them.

Thanks, I had not seen the emacs-devel@ thread yet.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51902; Package emacs. (Wed, 17 Nov 2021 17:16:01 GMT) Full text and rfc822 format available.

Message #23 received at 51902 <at> debbugs.gnu.org (full text, mbox):

From: Mike Kupfer <mkupfer <at> alum.berkeley.edu>
To: Stephen Gildea <stepheng+emacs <at> gildea.com>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, dick <dick.r.chiang <at> gmail.com>,
 51902 <at> debbugs.gnu.org
Subject: Re: bug#51902: 28.0.50; [PATCH] Get mh-e tests to pass
Date: Wed, 17 Nov 2021 09:15:52 -0800
Stephen Gildea wrote:

> I get failure with both Mailutils 3.7 and 3.13.

Is it just the "+/" tests, or are there other failures?  My notes say I
got a clean run with the old mh-unit tests on Mailutils 3.5, except for
the "+/tmp" tests.  Based on my notes, I also had a copy of Mailutils
3.10, which I played with briefly and expected to pass the tests, but it
looks like I never actually ran the test suite on Mailutils 3.10.

In any case, it looks like we should mark the tests that fail with
Mailutils as expected to fail for that variant, and circle back later to
address them.

mike




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51902; Package emacs. (Wed, 17 Nov 2021 17:35:01 GMT) Full text and rfc822 format available.

Message #26 received at 51902 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Gildea <stepheng+emacs <at> gildea.com>
To: Mike Kupfer <mkupfer <at> alum.berkeley.edu>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, dick <dick.r.chiang <at> gmail.com>,
 51902 <at> debbugs.gnu.org
Subject: Re: bug#51902: 28.0.50; [PATCH] Get mh-e tests to pass
Date: Wed, 17 Nov 2021 09:34:05 -0800
Mike Kupfer <mkupfer <at> alum.berkeley.edu> wrote:

>   Stephen Gildea wrote:
>   
>   > I get failure with both Mailutils 3.7 and 3.13.
>   
>   Is it just the "+/" tests, or are there other failures?  ...

It is just the two newly-enabled "+/" tests that fail with Mailutils.

>   In any case, it looks like we should mark the tests that fail with
>   Mailutils as expected to fail for that variant, and circle back later to
>   address them.

I'll look into how to do this.  The approach in Dick's original patch
doesn't work.  ERT's :expected-result declaration needs to occur before
the test has determined the MH variant in use.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51902; Package emacs. (Wed, 17 Nov 2021 17:46:02 GMT) Full text and rfc822 format available.

Message #29 received at 51902 <at> debbugs.gnu.org (full text, mbox):

From: dick <dick.r.chiang <at> gmail.com>
To: Stephen Gildea <stepheng+emacs <at> gildea.com>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 51902 <at> debbugs.gnu.org,
 Mike Kupfer <mkupfer <at> alum.berkeley.edu>
Subject: Re: bug#51902: 28.0.50; [PATCH] Get mh-e tests to pass
Date: Wed, 17 Nov 2021 12:45:51 -0500
SG> I'll look into how to do this.  The approach in Dick's original patch
SG> doesn't work.  ERT's :expected-result declaration needs to occur before
SG> the test has determined the MH variant in use.

I'll make a note this Gildea fellow doesn't know of which he speaks.

I'll not lecture him, and let him figure things out on his own in due course.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51902; Package emacs. (Wed, 17 Nov 2021 19:40:02 GMT) Full text and rfc822 format available.

Message #32 received at 51902 <at> debbugs.gnu.org (full text, mbox):

From: Mike Kupfer <mkupfer <at> alum.berkeley.edu>
To: Stephen Gildea <stepheng+emacs <at> gildea.com>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, dick <dick.r.chiang <at> gmail.com>,
 51902 <at> debbugs.gnu.org
Subject: Re: bug#51902: 28.0.50; [PATCH] Get mh-e tests to pass
Date: Wed, 17 Nov 2021 11:39:49 -0800
Stephen Gildea wrote:

> Mike Kupfer <mkupfer <at> alum.berkeley.edu> wrote:
> 
> >   In any case, it looks like we should mark the tests that fail with
> >   Mailutils as expected to fail for that variant, and circle back later to
> >   address them.
> 
> I'll look into how to do this.  The approach in Dick's original patch
> doesn't work.  ERT's :expected-result declaration needs to occur before
> the test has determined the MH variant in use.

Well, if we can't figure out how to get that level of flexibility for
expected-result, does it work to just leave the test marked as unstable
for now?

mike




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51902; Package emacs. (Thu, 18 Nov 2021 08:25:01 GMT) Full text and rfc822 format available.

Message #35 received at 51902 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Stephen Gildea <stepheng+emacs <at> gildea.com>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, dick <dick.r.chiang <at> gmail.com>,
 51902 <at> debbugs.gnu.org, Mike Kupfer <mkupfer <at> alum.berkeley.edu>
Subject: Re: bug#51902: 28.0.50; [PATCH] Get mh-e tests to pass
Date: Thu, 18 Nov 2021 09:23:34 +0100
Stephen Gildea <stepheng+emacs <at> gildea.com> writes:

>>   In any case, it looks like we should mark the tests that fail with
>>   Mailutils as expected to fail for that variant, and circle back later to
>>   address them.
>
> I'll look into how to do this.  The approach in Dick's original patch
> doesn't work.  ERT's :expected-result declaration needs to occur before
> the test has determined the MH variant in use.

You can skip a test everywhere in its body with something like

(unless mh-variant-in-use
  (ert-skip "Unknown MH variant"))

Best regards, Michael.




Reply sent to Stephen Gildea <stepheng+emacs <at> gildea.com>:
You have taken responsibility. (Thu, 18 Nov 2021 16:31:01 GMT) Full text and rfc822 format available.

Notification sent to dick <dick.r.chiang <at> gmail.com>:
bug acknowledged by developer. (Thu, 18 Nov 2021 16:31:02 GMT) Full text and rfc822 format available.

Message #40 received at 51902-done <at> debbugs.gnu.org (full text, mbox):

From: Stephen Gildea <stepheng+emacs <at> gildea.com>
To: 51902-done <at> debbugs.gnu.org
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, dick <dick.r.chiang <at> gmail.com>,
 Mike Kupfer <mkupfer <at> alum.berkeley.edu>
Subject: Re: bug#51902: 28.0.50; [PATCH] Get mh-e tests to pass
Date: Thu, 18 Nov 2021 08:30:16 -0800
Michael Albinus <michael.albinus <at> gmx.de> wrote:

>   You can skip a test everywhere in its body with something like
>   
>   (unless mh-variant-in-use
>     (ert-skip "Unknown MH variant"))

Thanks for the suggestion, Michael.  I ended up using skip-unless,
which appears to be the documented wrapper around ert-skip.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 17 Dec 2021 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 130 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.