GNU bug report logs - #51915
[PATCH] home: services: Change computed-file to scheme-file.

Previous Next

Package: guix-patches;

Reported by: Andrew Tropin <andrew <at> trop.in>

Date: Wed, 17 Nov 2021 08:52:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51915 in the body.
You can then email your comments to 51915 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#51915; Package guix-patches. (Wed, 17 Nov 2021 08:52:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Andrew Tropin <andrew <at> trop.in>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 17 Nov 2021 08:52:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: Ludovic Courtès <ludo <at> gnu.org>, guix-patches <at> gnu.org
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>
Subject: [PATCH] home: services: Change computed-file to scheme-file.
Date: Wed, 17 Nov 2021 11:22:43 +0300
[Message part 1 (text/plain, inline)]
* gnu/home/services.scm (compute-on-first-login-script): Use
'scheme-file' instead of 'computed-file'.
---
It seems there was a problem with 4dcec60fa6a93dbc93bef2cdb91e3633c705579e:

--8<---------------cut here---------------start------------->8---
guix time-machine --commit=4dcec60fa6a93dbc93bef2cdb91e3633c705579e -- home build -e "((@ (gnu home) home-environment))"
guix home: error: reference to invalid output 'out' of derivation '/gnu/store/a6cwlz5yibi7w3pfm60j26inf434ard2-on-first-login.drv'
--8<---------------cut here---------------end--------------->8---

This patch should fix it.

 gnu/home/services.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/home/services.scm b/gnu/home/services.scm
index 992e522fa2..0deaadaf3e 100644
--- a/gnu/home/services.scm
+++ b/gnu/home/services.scm
@@ -275,7 +275,7 @@ (define home-files-service-type
 will be put in @file{~/.guix-home/files}.")))
 
 (define (compute-on-first-login-script _ gexps)
-  (computed-file
+  (scheme-file
    "on-first-login"
    #~(let* ((xdg-runtime-dir (or (getenv "XDG_RUNTIME_DIR")
                                  (format #f "/run/user/~a" (getuid))))
-- 
2.33.1

[signature.asc (application/pgp-signature, inline)]

Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Thu, 18 Nov 2021 08:40:01 GMT) Full text and rfc822 format available.

Notification sent to Andrew Tropin <andrew <at> trop.in>:
bug acknowledged by developer. (Thu, 18 Nov 2021 08:40:02 GMT) Full text and rfc822 format available.

Message #10 received at 51915-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Andrew Tropin <andrew <at> trop.in>
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>, 51915-done <at> debbugs.gnu.org
Subject: Re: bug#51915: [PATCH] home: services: Change computed-file to
 scheme-file.
Date: Thu, 18 Nov 2021 09:39:40 +0100
Hi,

Andrew Tropin <andrew <at> trop.in> skribis:

> --- a/gnu/home/services.scm
> +++ b/gnu/home/services.scm
> @@ -275,7 +275,7 @@ (define home-files-service-type
>  will be put in @file{~/.guix-home/files}.")))
>  
>  (define (compute-on-first-login-script _ gexps)
> -  (computed-file
> +  (scheme-file
>     "on-first-login"

This was fixed in e5d8302b2ce596a0518ea5bd79b338f68a3246eb (with
‘program-file’.)  Apologies for the mistake.

Thanks,
Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#51915; Package guix-patches. (Thu, 18 Nov 2021 09:03:02 GMT) Full text and rfc822 format available.

Message #13 received at 51915-done <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>, 51915-done <at> debbugs.gnu.org
Subject: Re: bug#51915: [PATCH] home: services: Change computed-file to
 scheme-file.
Date: Thu, 18 Nov 2021 12:02:42 +0300
[Message part 1 (text/plain, inline)]
On 2021-11-18 09:39, Ludovic Courtès wrote:

> Hi,
>
> Andrew Tropin <andrew <at> trop.in> skribis:
>
>> --- a/gnu/home/services.scm
>> +++ b/gnu/home/services.scm
>> @@ -275,7 +275,7 @@ (define home-files-service-type
>>  will be put in @file{~/.guix-home/files}.")))
>>  
>>  (define (compute-on-first-login-script _ gexps)
>> -  (computed-file
>> +  (scheme-file
>>     "on-first-login"
>
> This was fixed in e5d8302b2ce596a0518ea5bd79b338f68a3246eb (with
> ‘program-file’.)  Apologies for the mistake.

Thank you very much for the fix! :)

>
> Thanks,
> Ludo’.

-- 
Best regards,
Andrew Tropin
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 16 Dec 2021 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 93 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.