GNU bug report logs -
#51920
[PATCH] gnu: Add inkbox.
Previous Next
Reported by: phodina <phodina <at> protonmail.com>
Date: Wed, 17 Nov 2021 11:51:02 UTC
Severity: normal
Tags: patch
Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51920 in the body.
You can then email your comments to 51920 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org
:
bug#51920
; Package
guix-patches
.
(Wed, 17 Nov 2021 11:51:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
phodina <phodina <at> protonmail.com>
:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org
.
(Wed, 17 Nov 2021 11:51:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/qt.scm (inkbox): New variable.
diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index 4625d2220d..0f1744d8e8 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -3021,6 +3021,42 @@ (define-public python-pyside-2-tools
"Contains lupdate, rcc and uic tools for PySide2")
(license license:gpl2)))
+(define-public inkbox
+ (package
+ (name "inkbox")
+ (version "1.7")
+ (source (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://alpinekobox.ddns.net/InkBox/inkbox/")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "126cqn0ixcn608lv2hd9f7zmzj4g448bnpxc7wv9cvg83qqajh5n"))))
+ (build-system qt-build-system)
+ (arguments
+ '(#:tests? #f
+ #:make-flags
+ (list (string-append "PREFIX="
+ (assoc-ref %outputs "out")))
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'prefix-opt
+ (lambda* _
+ (substitute* "inkbox.pro"
+ (("/opt/\\$\\$\\{TARGET\\}") (string-append (assoc-ref %outputs "out"))))))
+ (replace 'configure
+ (lambda* (#:key make-flags #:allow-other-keys)
+ (apply invoke (cons "qmake" make-flags)))))))
+ (native-inputs
+ `(("qtbase" ,qtbase-5)))
+ (home-page "https://alpinekobox.ddns.net/InkBox/inkbox/")
+ (synopsis "EBook reader")
+ (description "This package provides InkBox eBook reader.")
+ (license license:gpl1)))
+
(define-public libqglviewer
(package
(name "libqglviewer")
--
2.33.0
Information forwarded
to
guix-patches <at> gnu.org
:
bug#51920
; Package
guix-patches
.
(Sun, 21 Nov 2021 20:54:02 GMT)
Full text and
rfc822 format available.
Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):
Hello,
phodina via Guix-patches via <guix-patches <at> gnu.org> writes:
> * gnu/packages/qt.scm (inkbox): New variable.
Thank you. Some comments follow.
First, this should go to "ebook.scm" instead of "qt.scm".
> + (source (origin
You should instead a newline before "(origin".
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://alpinekobox.ddns.net/InkBox/inkbox/")
> + (commit version)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "126cqn0ixcn608lv2hd9f7zmzj4g448bnpxc7wv9cvg83qqajh5n"))))
Nitpick: hash should go on the same line as base32.
> + (build-system qt-build-system)
> + (arguments
> + '(#:tests? #f
You should add a comment explaining why tests are disabled (i.e.: there
is no tests).
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'prefix-opt
> + (lambda* _
> + (substitute* "inkbox.pro"
> + (("/opt/\\$\\$\\{TARGET\\}") (string-append (assoc-ref %outputs "out"))))))
You should use (lambda* (#:key outputs #:allow-other-keys) ...) and then
(assoc-ref outputs "out") instead.
> + (replace 'configure
> + (lambda* (#:key make-flags #:allow-other-keys)
> + (apply invoke (cons "qmake" make-flags)))))))
> + (native-inputs
> + `(("qtbase" ,qtbase-5)))
Does it fail with qtbase 6?
> + (license license:gpl1)))
License is actually gpl3, according to LICENSE file.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
Information forwarded
to
guix-patches <at> gnu.org
:
bug#51920
; Package
guix-patches
.
(Sun, 21 Nov 2021 20:54:03 GMT)
Full text and
rfc822 format available.
Information forwarded
to
guix-patches <at> gnu.org
:
bug#51920
; Package
guix-patches
.
(Sun, 28 Nov 2021 19:14:02 GMT)
Full text and
rfc822 format available.
Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hi Nicolas,
> Hello,
>
> phodina via Guix-patches via guix-patches <at> gnu.org writes:
>
> > - gnu/packages/qt.scm (inkbox): New variable.
>
> Thank you. Some comments follow.
>
> First, this should go to "ebook.scm" instead of "qt.scm".
Thanks, that is a better place to put it.
>
> > - (source (origin
>
> You should instead a newline before "(origin".
Fixed.
>
> > - (method git-fetch)
> >
> >
> > - (uri
> >
> >
> > - (git-reference
> >
> >
> > - (url "https://alpinekobox.ddns.net/InkBox/inkbox/")
> >
> >
> > - (commit version)))
> >
> >
> > - (file-name (git-file-name name version))
> >
> >
> > - (sha256
> >
> >
> > - (base32
> >
> >
> > - "126cqn0ixcn608lv2hd9f7zmzj4g448bnpxc7wv9cvg83qqajh5n"))))
> >
> >
>
> Nitpick: hash should go on the same line as base32.
Fixed.
>
> > - (build-system qt-build-system)
> > - (arguments
> > - '(#:tests? #f
> >
> >
>
> You should add a comment explaining why tests are disabled (i.e.: there
>
> is no tests).
Fixed.
>
> > - #:phases
> >
> >
> > - (modify-phases %standard-phases
> >
> >
> > - (add-after 'unpack 'prefix-opt
> >
> >
> > - (lambda* _
> >
> >
> > - (substitute* "inkbox.pro"
> >
> >
> > - (("/opt/\\\\$\\\\$\\\\{TARGET\\\\}") (string-append (assoc-ref %outputs "out"))))))
> >
> >
>
> You should use (lambda* (#:key outputs #:allow-other-keys) ...) and then
>
> (assoc-ref outputs "out") instead.
>
> > - (replace 'configure
> >
> >
> > - (lambda* (#:key make-flags #:allow-other-keys)
> >
Thanks, that is the correct syntax.
> >
> > - (apply invoke (cons "qmake" make-flags)))))))
> >
> >
> > - (native-inputs
> > - `(("qtbase" ,qtbase-5)))
> >
> >
>
> Does it fail with qtbase 6?
Unfortunately it does not compile though it shouldn't be that hard to port it. But here it is about packaging.
>
> > - (license license:gpl1)))
>
> License is actually gpl3, according to LICENSE file.
Sorry, my mistake.
>
> Could you send an updated patch?
>
> Regards,
> --------------------------------------------------------------------------------------------------
>
> Nicolas Goaziou
Thanks for the remarks!
----
Petr
[v2-0001-gnu-Add-inkbox.patch (text/x-patch, attachment)]
Information forwarded
to
guix-patches <at> gnu.org
:
bug#51920
; Package
guix-patches
.
(Sun, 28 Nov 2021 19:14:02 GMT)
Full text and
rfc822 format available.
Information forwarded
to
guix-patches <at> gnu.org
:
bug#51920
; Package
guix-patches
.
(Mon, 29 Nov 2021 21:22:01 GMT)
Full text and
rfc822 format available.
Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):
Hello,
phodina <phodina <at> protonmail.com> writes:
> Subject: [PATCH v2] gnu: Add inkbox.
Applied. Thank you.
Regards,
--
Nicolas Goaziou
Reply sent
to
Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
:
You have taken responsibility.
(Mon, 29 Nov 2021 21:22:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
phodina <phodina <at> protonmail.com>
:
bug acknowledged by developer.
(Mon, 29 Nov 2021 21:22:02 GMT)
Full text and
rfc822 format available.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Tue, 28 Dec 2021 12:24:04 GMT)
Full text and
rfc822 format available.
This bug report was last modified 2 years and 81 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.