GNU bug report logs - #51944
[PATCH] Shell2Batch: New Package

Previous Next

Package: guix-patches;

Reported by: Jacob Hrbek <kreyren <at> rixotstudio.cz>

Date: Thu, 18 Nov 2021 11:43:02 UTC

Severity: normal

Tags: patch

Done: Julien Lepiller <julien <at> lepiller.eu>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51944 in the body.
You can then email your comments to 51944 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#51944; Package guix-patches. (Thu, 18 Nov 2021 11:43:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Jacob Hrbek <kreyren <at> rixotstudio.cz>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 18 Nov 2021 11:43:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jacob Hrbek <kreyren <at> rixotstudio.cz>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] Shell2Batch: New Package
Date: Thu, 18 Nov 2021 11:41:45 +0000
[Message part 1 (text/plain, inline)]
DISCLAIMER: First time packaging things for guix, i have no idea what am i doing aAaAAaAAaAA

WARNING: Fails reproduction, no idea why, help me

-- Jacob "Kreyren" Hrbek

Sent with ProtonMail Secure Email.
[Message part 2 (text/html, inline)]
[shell2batch-0.4.2.patch (application/octet-stream, attachment)]
[publickey - kreyren@rixotstudio.cz - 0x1677DB82.asc (application/pgp-keys, attachment)]
[signature.asc (application/pgp-signature, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#51944; Package guix-patches. (Thu, 18 Nov 2021 11:49:01 GMT) Full text and rfc822 format available.

Message #8 received at 51944 <at> debbugs.gnu.org (full text, mbox):

From: Jacob Hrbek <kreyren <at> rixotstudio.cz>
To: "51944 <at> debbugs.gnu.org" <51944 <at> debbugs.gnu.org>
Subject: Build log
Date: Thu, 18 Nov 2021 11:48:27 +0000
[Message part 1 (text/plain, inline)]
-- Jacob "Kreyren" Hrbek

Sent with ProtonMail Secure Email.
[Message part 2 (text/html, inline)]
[shell2batch-0.4.2.build-log (application/octet-stream, attachment)]
[publickey - kreyren@rixotstudio.cz - 0x1677DB82.asc (application/pgp-keys, attachment)]
[signature.asc (application/pgp-signature, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#51944; Package guix-patches. (Thu, 18 Nov 2021 19:05:01 GMT) Full text and rfc822 format available.

Message #11 received at 51944 <at> debbugs.gnu.org (full text, mbox):

From: Jacob Hrbek <kreyren <at> rixotstudio.cz>
To: "51944 <at> debbugs.gnu.org" <51944 <at> debbugs.gnu.org>
Subject: New patch on roptat's request
Date: Thu, 18 Nov 2021 19:04:44 +0000
[Message part 1 (text/plain, inline)]
-- Jacob "Kreyren" Hrbek

Sent with ProtonMail Secure Email.
[Message part 2 (text/html, inline)]
[0001-shell2batch-New-package.patch (application/octet-stream, attachment)]
[publickey - kreyren@rixotstudio.cz - 0x1677DB82.asc (application/pgp-keys, attachment)]
[signature.asc (application/pgp-signature, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#51944; Package guix-patches. (Thu, 18 Nov 2021 19:33:01 GMT) Full text and rfc822 format available.

Message #14 received at 51944 <at> debbugs.gnu.org (full text, mbox):

From: david larsson <david.larsson <at> selfhosted.xyz>
To: Jacob Hrbek <kreyren <at> rixotstudio.cz>
Cc: Guix-patches <guix-patches-bounces+david.larsson=selfhosted.xyz <at> gnu.org>,
 51944 <at> debbugs.gnu.org
Subject: Re: [bug#51944] [PATCH] Shell2Batch: New Package
Date: Thu, 18 Nov 2021 20:32:08 +0100
On 2021-11-18 12:41, Jacob Hrbek wrote:
> DISCLAIMER: First time packaging things for guix, i have no idea what
> am i doing aAaAAaAAaAA
> WARNING: Fails reproduction, no idea why, help me
> 
> -- Jacob "Kreyren" Hrbek
> 
> Sent with ProtonMail [1] Secure Email.
> 
> 
> 
> Links:
> ------
> [1] https://protonmail.com/

Imn the synopsis you repeat the error "coverts", which should be 
"converts". Secondly, in the  description you may want to expand on the 
synopsis. I found the following somewhere in the source repo, which you 
could use as the description:

"While it is not really possible to take every shell script and 
automatically convert it to a windows batch file, this library provides 
a way to convert simple basic shell commands to windows batch commands."

Best regards,
David




Information forwarded to guix-patches <at> gnu.org:
bug#51944; Package guix-patches. (Thu, 18 Nov 2021 19:36:01 GMT) Full text and rfc822 format available.

Message #17 received at 51944 <at> debbugs.gnu.org (full text, mbox):

From: Jacob Hrbek <kreyren <at> rixotstudio.cz>
To: "51944 <at> debbugs.gnu.org" <51944 <at> debbugs.gnu.org>
Subject: Added skip-build as requested by rekado_
Date: Thu, 18 Nov 2021 19:34:53 +0000
[Message part 1 (text/plain, inline)]
-- Jacob "Kreyren" Hrbek

Sent with ProtonMail Secure Email.
[Message part 2 (text/html, inline)]
[0001-shell2batch-New-Package.patch (application/octet-stream, attachment)]
[publickey - kreyren@rixotstudio.cz - 0x1677DB82.asc (application/pgp-keys, attachment)]
[signature.asc (application/pgp-signature, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#51944; Package guix-patches. (Thu, 18 Nov 2021 19:40:01 GMT) Full text and rfc822 format available.

Message #20 received at 51944 <at> debbugs.gnu.org (full text, mbox):

From: Jacob Hrbek <kreyren <at> rixotstudio.cz>
To: david larsson <david.larsson <at> selfhosted.xyz>
Cc: Guix-patches <guix-patches-bounces+david.larsson=selfhosted.xyz <at> gnu.org>,
 51944 <at> debbugs.gnu.org
Subject: Re: [bug#51944] [PATCH] Shell2Batch: New Package
Date: Thu, 18 Nov 2021 19:39:07 +0000
[Message part 1 (text/plain, inline)]
Addressing https://issues.guix.gnu.org/51944#3


-- Jacob "Kreyren" Hrbek

Sent with ProtonMail Secure Email.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Thursday, November 18th, 2021 at 7:32 PM, david larsson <david.larsson <at> selfhosted.xyz> wrote:

> On 2021-11-18 12:41, Jacob Hrbek wrote:
> 

> > DISCLAIMER: First time packaging things for guix, i have no idea what
> > 

> > am i doing aAaAAaAAaAA
> > 

> > WARNING: Fails reproduction, no idea why, help me
> > 

> > -- Jacob "Kreyren" Hrbek
> > 

> > Sent with ProtonMail [1] Secure Email.
> > 

> > Links:
> > ------
> > 

> > [1] https://protonmail.com/
> 

> Imn the synopsis you repeat the error "coverts", which should be
> 

> "converts". Secondly, in the description you may want to expand on the
> 

> synopsis. I found the following somewhere in the source repo, which you
> 

> could use as the description:
> 

> "While it is not really possible to take every shell script and
> 

> automatically convert it to a windows batch file, this library provides
> 

> a way to convert simple basic shell commands to windows batch commands."
> 

> Best regards,
> 

> David
[0001-shell2batch-New-package.patch (application/octet-stream, attachment)]
[publickey - kreyren@rixotstudio.cz - 0x1677DB82.asc (application/pgp-keys, attachment)]
[signature.asc (application/pgp-signature, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#51944; Package guix-patches. (Thu, 18 Nov 2021 21:53:01 GMT) Full text and rfc822 format available.

Message #23 received at 51944 <at> debbugs.gnu.org (full text, mbox):

From: david larsson <david.larsson <at> selfhosted.xyz>
To: Jacob Hrbek <kreyren <at> rixotstudio.cz>
Cc: Guix-patches <guix-patches-bounces+david.larsson=selfhosted.xyz <at> gnu.org>,
 51944 <at> debbugs.gnu.org
Subject: Re: [bug#51944] [PATCH] Shell2Batch: New Package
Date: Thu, 18 Nov 2021 22:51:48 +0100
I should have also mentioned this part (my apologies):

"Synopses must start with a capital letter and must not end with a 
period." - 
https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html

your patch ends with a period in the synopsis. That needs fixed.

(I do not have commit access. Im just reviewing your patch to prepare it 
for being committed)

Best regards,
David




Reply sent to Julien Lepiller <julien <at> lepiller.eu>:
You have taken responsibility. (Thu, 18 Nov 2021 22:48:02 GMT) Full text and rfc822 format available.

Notification sent to Jacob Hrbek <kreyren <at> rixotstudio.cz>:
bug acknowledged by developer. (Thu, 18 Nov 2021 22:48:02 GMT) Full text and rfc822 format available.

Message #28 received at 51944-done <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: Jacob Hrbek <kreyren <at> rixotstudio.cz>
Cc: david larsson <david.larsson <at> selfhosted.xyz>, 51944-done <at> debbugs.gnu.org
Subject: Re: [bug#51944] [PATCH] Shell2Batch: New Package
Date: Thu, 18 Nov 2021 23:46:35 +0100
Thanks for the patch! Pushed to master as
92d6f17dfd449208a657a1a54e3a287ae22d1da8.

I took the liberty to fix some parts of it that didn't correspond to
our standards. Have a look at the packaging guidelines in the manual to
better understand:
https://guix.gnu.org/manual/devel/en/html_node/Packaging-Guidelines.html

First, I renamed the patch file to rust-shell2batch-lint-fix.patch, so
it starts with the name of the package. I also modified a little bit
your message in the patch, to reference the issue there too, format at
80 lines and simplify the wording. I also added the patch file to
dist_patch_DATA, in gnu/local.mk. Whenever you add a patch file, please
make sure to add a reference in gnu/local.mk. This is necessary for
correctly generating the release tarballs.

Then, I fixed a few things in the package itself: I replaced tabs with
spaces and removed the empty line at the end of the file. I changed the
synopsis a bit so it better aligns with the rest of guix and removed
the period at the end. I also changed the description, mostly to wrap
it at 80 characters.

Finally, I fixed the commit message so it respects our conventions.
You'll find more info in the link above, and a lot of examples in the
git log history.

Some of these issues would have been caught by "guix lint
rust-shell2batch", I encourage you to run it on your next submissions :)

Have fun with guix :D




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 17 Dec 2021 12:24:11 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 92 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.