GNU bug report logs - #51950
[PATCH 1/1] gnu: Add emacs-ddskk-with-nicola

Previous Next

Package: guix-patches;

Reported by: Taiju HIGASHI <higashi <at> taiju.info>

Date: Thu, 18 Nov 2021 14:51:03 UTC

Severity: normal

Tags: patch

Done: Liliana Marie Prikler <liliana.prikler <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51950 in the body.
You can then email your comments to 51950 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#51950; Package guix-patches. (Thu, 18 Nov 2021 14:51:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Taiju HIGASHI <higashi <at> taiju.info>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 18 Nov 2021 14:51:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Taiju HIGASHI <higashi <at> taiju.info>
To: guix-patches <at> gnu.org
Cc: Taiju HIGASHI <higashi <at> taiju.info>
Subject: [PATCH 1/1] gnu: Add emacs-ddskk-with-nicola
Date: Thu, 18 Nov 2021 23:01:59 +0900
---
 gnu/packages/emacs-xyz.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e141c390d8..0ca2bbc066 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -28635,6 +28635,35 @@ (define-public emacs-ddskk
 conversion program}, a Japanese input method on Emacs.")
       (license license:gpl2+))))
 
+(define-public emacs-ddskk-with-nicola
+  (package
+    (inherit emacs-ddskk)
+    (name "emacs-ddskk-with-nicola")
+    (synopsis "Simple Kana to Kanji conversion program (with NICOLA)")
+    (propagated-inputs
+     `(("emacs-ddskk" ,emacs-ddskk)))
+    (arguments
+     (substitute-keyword-arguments (package-arguments emacs-ddskk)
+       ((#:phases phases)
+        `(modify-phases ,phases
+           (add-after 'unpack 'chdir
+             (lambda _
+               (chdir "nicola")
+               #t))
+           (replace 'configure
+             (lambda* (#:key outputs #:allow-other-keys)
+               (let ((out (assoc-ref outputs "out")))
+                 (substitute* "Makefile"
+                   (("PREFIX = NONE")
+                    (string-append "PREFIX = " out))
+                   (("LISPDIR = NONE")
+                    (string-append "LISPDIR = " out "/share/emacs/site-lisp"))))
+               (make-file-writable "NICOLA-DDSKK-CFG")
+               (emacs-substitute-sexps "NICOLA-DDSKK-CFG"
+                 ("setq NICOLA-DDSKK_PREFIX" ""))
+               #t))
+           (delete 'check)))))))
+
 (define-public emacs-objed
   (package
     (name "emacs-objed")
-- 
2.33.1





Information forwarded to guix-patches <at> gnu.org:
bug#51950; Package guix-patches. (Thu, 18 Nov 2021 15:18:02 GMT) Full text and rfc822 format available.

Message #8 received at 51950 <at> debbugs.gnu.org (full text, mbox):

From: Taiju HIGASHI <higashi <at> taiju.info>
To: 51950 <at> debbugs.gnu.org
Subject: Re: [PATCH 1/1] gnu: Add emacs-ddskk-with-nicola
Date: Fri, 19 Nov 2021 00:17:31 +0900
I'm sorry.

I accidentally sent two e-mails to you.

The contents of the first email are quoted below.

----
Hi,

I'm a native speaker of Japanese.

There is emacs-ddskk in the gnu channel of Guix, but I usually use the kana
direct input method.

To use the kana direct input method with the ddskk emacs package, we need to
do the following steps after installing ddskk.
https://github.com/skk-dev/ddskk/tree/master/nicola#42-nicola-ddskk-%E3%81%AE%E3%82%A4%E3%83%B3%E3%82%B9%E3%83%88%E3%83%BC%E3%83%AB
(japanese)

With this patch, that will be no longer necessary.

I wanted to implement it with multiple outputs, but I couldn't figure out how
to implement it when there is a dependency between two outputs.

I'm new to Guix, so please let me know if there is a more appropriate
solution.

Thank you.




Information forwarded to guix-patches <at> gnu.org:
bug#51950; Package guix-patches. (Sun, 21 Nov 2021 08:55:01 GMT) Full text and rfc822 format available.

Message #11 received at 51950 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Taiju HIGASHI <higashi <at> taiju.info>, 51950 <at> debbugs.gnu.org
Subject: Re: [PATCH 1/1] gnu: Add emacs-ddskk-with-nicola
Date: Sun, 21 Nov 2021 09:54:47 +0100
Am Donnerstag, den 18.11.2021, 23:01 +0900 schrieb Taiju HIGASHI:
> ---
>  gnu/packages/emacs-xyz.scm | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index e141c390d8..0ca2bbc066 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -28635,6 +28635,35 @@ (define-public emacs-ddskk
>  conversion program}, a Japanese input method on Emacs.")
>        (license license:gpl2+))))
>  
> +(define-public emacs-ddskk-with-nicola
> +  (package
> +    (inherit emacs-ddskk)
> +    (name "emacs-ddskk-with-nicola")
> +    (synopsis "Simple Kana to Kanji conversion program (with
> NICOLA)")
> +    (propagated-inputs
> +     `(("emacs-ddskk" ,emacs-ddskk)))
> +    (arguments
> +     (substitute-keyword-arguments (package-arguments emacs-ddskk)
> +       ((#:phases phases)
> +        `(modify-phases ,phases
> +           (add-after 'unpack 'chdir
> +             (lambda _
> +               (chdir "nicola")
> +               #t))
> +           (replace 'configure
> +             (lambda* (#:key outputs #:allow-other-keys)
> +               (let ((out (assoc-ref outputs "out")))
> +                 (substitute* "Makefile"
> +                   (("PREFIX = NONE")
> +                    (string-append "PREFIX = " out))
> +                   (("LISPDIR = NONE")
> +                    (string-append "LISPDIR = " out
> "/share/emacs/site-lisp"))))
> +               (make-file-writable "NICOLA-DDSKK-CFG")
> +               (emacs-substitute-sexps "NICOLA-DDSKK-CFG"
> +                 ("setq NICOLA-DDSKK_PREFIX" ""))
> +               #t))
You don't need to patch the Makefile to set those variables, use
#:make-flags instead.
> +           (delete 'check)))))))
Again, use #:tests? and provide a comment as to why you're setting it
to #f.

Cheers





Information forwarded to guix-patches <at> gnu.org:
bug#51950; Package guix-patches. (Mon, 22 Nov 2021 03:00:02 GMT) Full text and rfc822 format available.

Message #14 received at 51950 <at> debbugs.gnu.org (full text, mbox):

From: Taiju HIGASHI <higashi <at> taiju.info>
To: liliana.prikler <at> gmail.com,
	51950 <at> debbugs.gnu.org
Cc: Taiju HIGASHI <higashi <at> taiju.info>
Subject: [PATCH v2] gnu: Add emacs-ddskk-with-nicola
Date: Mon, 22 Nov 2021 11:58:34 +0900
---
 gnu/packages/emacs-xyz.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d3338d45bd..7f82bace7b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -28631,6 +28631,34 @@ (define-public emacs-ddskk
 conversion program}, a Japanese input method on Emacs.")
       (license license:gpl2+))))
 
+(define-public emacs-ddskk-with-nicola
+  (package
+    (inherit emacs-ddskk)
+    (name "emacs-ddskk-with-nicola")
+    (synopsis "Simple Kana to Kanji conversion program (with NICOLA)")
+    (propagated-inputs
+     `(("emacs-ddskk" ,emacs-ddskk)))
+    (arguments
+     `(#:make-flags
+       (let ((out (assoc-ref %outputs "out")))
+         (append
+          (list (string-append "PREFIX=" out)
+                (string-append "LISPDIR=" out "/share/emacs/site-lisp"))))
+       #:tests? #f                      ; no test
+       ,@(substitute-keyword-arguments (package-arguments emacs-ddskk)
+           ((#:phases phases)
+            `(modify-phases ,phases
+               (add-after 'unpack 'chdir
+                 (lambda _
+                   (chdir "nicola")
+                   #t))
+               (replace 'configure
+                 (lambda* (#:key outputs #:allow-other-keys)
+                   (make-file-writable "NICOLA-DDSKK-CFG")
+                   (emacs-substitute-sexps "NICOLA-DDSKK-CFG"
+                     ("setq NICOLA-DDSKK_PREFIX" ""))
+                   #t)))))))))
+
 (define-public emacs-objed
   (package
     (name "emacs-objed")
-- 
2.33.1





Information forwarded to guix-patches <at> gnu.org:
bug#51950; Package guix-patches. (Mon, 22 Nov 2021 03:06:02 GMT) Full text and rfc822 format available.

Message #17 received at 51950 <at> debbugs.gnu.org (full text, mbox):

From: Taiju HIGASHI <higashi <at> taiju.info>
To: liliana.prikler <at> gmail.com, 51950 <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: Add emacs-ddskk-with-nicola
Date: Mon, 22 Nov 2021 12:05:11 +0900
Thanks for your review.
I've fixed it.




Information forwarded to guix-patches <at> gnu.org:
bug#51950; Package guix-patches. (Mon, 22 Nov 2021 03:17:02 GMT) Full text and rfc822 format available.

Message #20 received at 51950 <at> debbugs.gnu.org (full text, mbox):

From: Taiju HIGASHI <higashi <at> taiju.info>
To: 51950 <at> debbugs.gnu.org
Cc: Taiju HIGASHI <higashi <at> taiju.info>
Subject: [PATCH v3] gnu: Add emacs-ddskk-with-nicola
Date: Mon, 22 Nov 2021 12:16:27 +0900
---
 gnu/packages/emacs-xyz.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d3338d45bd..de0e94c7ee 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -28631,6 +28631,33 @@ (define-public emacs-ddskk
 conversion program}, a Japanese input method on Emacs.")
       (license license:gpl2+))))
 
+(define-public emacs-ddskk-with-nicola
+  (package
+    (inherit emacs-ddskk)
+    (name "emacs-ddskk-with-nicola")
+    (synopsis "Simple Kana to Kanji conversion program (with NICOLA)")
+    (propagated-inputs
+     `(("emacs-ddskk" ,emacs-ddskk)))
+    (arguments
+     `(#:make-flags
+       (let ((out (assoc-ref %outputs "out")))
+         (list (string-append "PREFIX=" out)
+               (string-append "LISPDIR=" out "/share/emacs/site-lisp")))
+       #:tests? #f                      ; no test
+       ,@(substitute-keyword-arguments (package-arguments emacs-ddskk)
+           ((#:phases phases)
+            `(modify-phases ,phases
+               (add-after 'unpack 'chdir
+                 (lambda _
+                   (chdir "nicola")
+                   #t))
+               (replace 'configure
+                 (lambda* (#:key outputs #:allow-other-keys)
+                   (make-file-writable "NICOLA-DDSKK-CFG")
+                   (emacs-substitute-sexps "NICOLA-DDSKK-CFG"
+                     ("setq NICOLA-DDSKK_PREFIX" ""))
+                   #t)))))))))
+
 (define-public emacs-objed
   (package
     (name "emacs-objed")
-- 
2.33.1





Information forwarded to guix-patches <at> gnu.org:
bug#51950; Package guix-patches. (Mon, 22 Nov 2021 03:19:01 GMT) Full text and rfc822 format available.

Message #23 received at 51950 <at> debbugs.gnu.org (full text, mbox):

From: Taiju HIGASHI <higashi <at> taiju.info>
To: 51950 <at> debbugs.gnu.org
Subject: Re: [PATCH v3] gnu: Add emacs-ddskk-with-nicola
Date: Mon, 22 Nov 2021 12:18:27 +0900
I'm sorry. Unnecessary `append` was left in the file, so I removed it.




Reply sent to Liliana Marie Prikler <liliana.prikler <at> gmail.com>:
You have taken responsibility. (Mon, 22 Nov 2021 20:38:02 GMT) Full text and rfc822 format available.

Notification sent to Taiju HIGASHI <higashi <at> taiju.info>:
bug acknowledged by developer. (Mon, 22 Nov 2021 20:38:02 GMT) Full text and rfc822 format available.

Message #28 received at 51950-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Taiju HIGASHI <higashi <at> taiju.info>, 51950-done <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: Add emacs-ddskk-with-nicola
Date: Mon, 22 Nov 2021 21:37:31 +0100
Pushed with minor adjustments to synopsis and description, as well as a
commit message.  

Thanks





Information forwarded to guix-patches <at> gnu.org:
bug#51950; Package guix-patches. (Thu, 25 Nov 2021 07:46:02 GMT) Full text and rfc822 format available.

Message #31 received at 51950-done <at> debbugs.gnu.org (full text, mbox):

From: Taiju HIGASHI <higashi <at> taiju.info>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 51950-done <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: Add emacs-ddskk-with-nicola
Date: Thu, 25 Nov 2021 16:45:39 +0900
Thank you for merge!

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Pushed with minor adjustments to synopsis and description, as well as a
> commit message.  
>
> Thanks




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 23 Dec 2021 12:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 86 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.