GNU bug report logs - #51953
[PATCH core-updates-frozen 0/2] Fix wlroots build with Meson 0.60.0

Previous Next

Package: guix-patches;

Reported by: Jack Hill <jackhill <at> jackhill.us>

Date: Thu, 18 Nov 2021 16:44:01 UTC

Severity: normal

Tags: patch

Done: Jack Hill <jackhill <at> jackhill.us>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51953 in the body.
You can then email your comments to 51953 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#51953; Package guix-patches. (Thu, 18 Nov 2021 16:44:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Jack Hill <jackhill <at> jackhill.us>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 18 Nov 2021 16:44:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: guix-patches <at> gnu.org
Subject: [PATCH core-updates-frozen 0/2] Fix wlroots build with Meson
 0.60.0
Date: Thu, 18 Nov 2021 11:43:39 -0500 (EST)
The build system now automatically detects which logind to use [0], and 
specifying the option is an error with Meson 0.60.0.

[0] https://gitlab.freedesktop.org/wlroots/wlroots/-/commit/30308e35fac0491ab777495e2ee7e472378d375a

While I was modifying the package, I also updated its home-page to point 
to the new freedesktop.org location.

Jack Hill (2):
  gnu: wlroots: Remove logind-provider configure option.
  gnu: wlroots: Update home page.

 gnu/packages/wm.scm | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

-- 
2.33.1




Information forwarded to guix-patches <at> gnu.org:
bug#51953; Package guix-patches. (Thu, 18 Nov 2021 16:46:02 GMT) Full text and rfc822 format available.

Message #8 received at 51953 <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: 51953 <at> debbugs.gnu.org
Subject: [PATCH core-updates-frozen 1/2] gnu: wlroots: Remove logind-provider
 configure option.
Date: Thu, 18 Nov 2021 11:44:58 -0500
* gnu/packages/wm.scm (wlroots)[arguments]: Remove #:configure-flags.
---
 gnu/packages/wm.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 7b7d04eb93..d3edfe3328 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -1480,8 +1480,7 @@ (define-public wlroots
         (base32 "1sshp3lvlkl1i670kxhwsb4xzxl8raz6769kqvgmxzcb63ns9ay1"))))
     (build-system meson-build-system)
     (arguments
-     `(#:configure-flags '("-Dlogind-provider=elogind")
-       #:phases
+     '(#:phases
        (modify-phases %standard-phases
          (add-before 'configure 'hardcode-paths
            (lambda* (#:key inputs #:allow-other-keys)
-- 
2.33.1





Information forwarded to guix-patches <at> gnu.org:
bug#51953; Package guix-patches. (Thu, 18 Nov 2021 16:46:02 GMT) Full text and rfc822 format available.

Message #11 received at 51953 <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: 51953 <at> debbugs.gnu.org
Subject: [PATCH core-updates-frozen 2/2] gnu: wlroots: Update home page.
Date: Thu, 18 Nov 2021 11:44:59 -0500
* gnu/packages/wm.scm (wlroots)[home-page]: Update it.
---
 gnu/packages/wm.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index d3edfe3328..a9e13d1cd8 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -1505,7 +1505,7 @@ (define-public wlroots
        ("xorg-server-xwayland" ,xorg-server-xwayland)))
     (native-inputs
      `(("pkg-config" ,pkg-config)))
-    (home-page "https://github.com/swaywm/wlroots")
+    (home-page "https://gitlab.freedesktop.org/wlroots/wlroots")
     (synopsis "Pluggable, composable, unopinionated modules for building a
 Wayland compositor")
     (description "wlroots is a set of pluggable, composable, unopinionated
-- 
2.33.1





Information forwarded to guix-patches <at> gnu.org:
bug#51953; Package guix-patches. (Thu, 18 Nov 2021 17:23:02 GMT) Full text and rfc822 format available.

Message #14 received at 51953 <at> debbugs.gnu.org (full text, mbox):

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: Jack Hill <jackhill <at> jackhill.us>, 51953 <at> debbugs.gnu.org
Cc: dev <at> jpoiret.xyz
Subject: Re: [bug#51953] [PATCH core-updates-frozen 0/2] Fix wlroots build
 with Meson 0.60.0
Date: Thu, 18 Nov 2021 17:22:54 +0000
Jack Hill <jackhill <at> jackhill.us> writes:

> The build system now automatically detects which logind to use [0], and 
> specifying the option is an error with Meson 0.60.0.
>
> [0] https://gitlab.freedesktop.org/wlroots/wlroots/-/commit/30308e35fac0491ab777495e2ee7e472378d375a

elogind is no longer a dependency of wlroots because of
https://gitlab.freedesktop.org/wlroots/wlroots/-/commit/d50bbf0bbc49a9a8e010668cd357aba968ae884b
included in 0.14.

It is a dependency of seatd though, and it should be propagated because
it is required by the pkg-config of seatd.  Since you still specified
elogind here, pkg-config was able to find it nonetheless but this isn't
the proper way to do it.

Best,
Josselin Poiret




Reply sent to Jack Hill <jackhill <at> jackhill.us>:
You have taken responsibility. (Fri, 19 Nov 2021 15:53:02 GMT) Full text and rfc822 format available.

Notification sent to Jack Hill <jackhill <at> jackhill.us>:
bug acknowledged by developer. (Fri, 19 Nov 2021 15:53:02 GMT) Full text and rfc822 format available.

Message #19 received at 51953-done <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: Josselin Poiret <dev <at> jpoiret.xyz>
Cc: 51953-done <at> debbugs.gnu.org
Subject: Re: [bug#51953] [PATCH core-updates-frozen 0/2] Fix wlroots build
 with Meson 0.60.0
Date: Fri, 19 Nov 2021 10:52:30 -0500 (EST)
On Thu, 18 Nov 2021, Josselin Poiret via Guix-patches via wrote:

> Jack Hill <jackhill <at> jackhill.us> writes:
>
>> The build system now automatically detects which logind to use [0], and
>> specifying the option is an error with Meson 0.60.0.
>>
>> [0] https://gitlab.freedesktop.org/wlroots/wlroots/-/commit/30308e35fac0491ab777495e2ee7e472378d375a
>
> elogind is no longer a dependency of wlroots because of
> https://gitlab.freedesktop.org/wlroots/wlroots/-/commit/d50bbf0bbc49a9a8e010668cd357aba968ae884b
> included in 0.14.
>
> It is a dependency of seatd though, and it should be propagated because
> it is required by the pkg-config of seatd.  Since you still specified
> elogind here, pkg-config was able to find it nonetheless but this isn't
> the proper way to do it.

Ah, thanks for pointing that out, and submitted the proper fix in #51972.

I'm closing this issue.

Best,
Jack




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 18 Dec 2021 12:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 91 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.