GNU bug report logs - #51965
[PATCH] Pass options from make to configure

Previous Next

Package: emacs;

Reported by: Gregory Heytings <gregory <at> heytings.org>

Date: Fri, 19 Nov 2021 09:12:01 UTC

Severity: normal

Tags: patch

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51965 in the body.
You can then email your comments to 51965 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#51965; Package emacs. (Fri, 19 Nov 2021 09:12:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Gregory Heytings <gregory <at> heytings.org>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 19 Nov 2021 09:12:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gregory Heytings <gregory <at> heytings.org>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Pass options from make to configure
Date: Fri, 19 Nov 2021 09:11:25 +0000
[Message part 1 (text/plain, inline)]
A 'make' in a repository clone builds Emacs with the default configuration 
options.  It would be useful if those who want to build Emacs with other 
configuration options they already know could do that without going 
through the three-step ./autogen.sh; ./configure <options>; make.  Patch 
attached, with which it becomes possible to just say e.g.:

make configure=--with-x-toolkit=lucid
[Pass-options-from-make-to-configure-through-a-variab.patch (text/x-diff, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51965; Package emacs. (Sat, 20 Nov 2021 09:54:02 GMT) Full text and rfc822 format available.

Message #8 received at 51965 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Gregory Heytings <gregory <at> heytings.org>
Cc: 51965 <at> debbugs.gnu.org
Subject: Re: bug#51965: [PATCH] Pass options from make to configure
Date: Sat, 20 Nov 2021 10:53:22 +0100
Gregory Heytings <gregory <at> heytings.org> writes:

> A 'make' in a repository clone builds Emacs with the default
> configuration options.  It would be useful if those who want to build
> Emacs with other configuration options they already know could do that
> without going through the three-step ./autogen.sh; ./configure
> <options>; make.  Patch attached, with which it becomes possible to
> just say e.g.:
>
> make configure=--with-x-toolkit=lucid

That sounds useful -- but if we add this, perhaps the normal Makefile
should also work this way?  That would be useful when doing bootstraps
with new configure options, which currently take two runs through
configure, which is a bore.  I.e.,

make configure=--with-x-toolkit=lucid bootstrap

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51965; Package emacs. (Tue, 23 Nov 2021 10:02:01 GMT) Full text and rfc822 format available.

Message #11 received at 51965 <at> debbugs.gnu.org (full text, mbox):

From: Gregory Heytings <gregory <at> heytings.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 51965 <at> debbugs.gnu.org
Subject: Re: bug#51965: [PATCH] Pass options from make to configure
Date: Tue, 23 Nov 2021 10:01:48 +0000
[Message part 1 (text/plain, inline)]
>> A 'make' in a repository clone builds Emacs with the default 
>> configuration options.  It would be useful if those who want to build 
>> Emacs with other configuration options they already know could do that 
>> without going through the three-step ./autogen.sh; ./configure 
>> <options>; make.  Patch attached, with which it becomes possible to 
>> just say e.g.:
>>
>> make configure=--with-x-toolkit=lucid
>
> That sounds useful -- but if we add this, perhaps the normal Makefile 
> should also work this way?  That would be useful when doing bootstraps 
> with new configure options, which currently take two runs through 
> configure, which is a bore.  I.e.,
>
> make configure=--with-x-toolkit=lucid bootstrap
>

Indeed, that makes sense.

I attach a patch with which it is possible to say, with both the 
GNUmakefile or the Makefile:

make bootstrap configure=--with-x-toolkit=lucid

and, to go back to the default configuration:

make bootstrap configure=default
[Pass-options-from-make-to-configure-through-a-variab.patch (text/x-diff, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51965; Package emacs. (Wed, 24 Nov 2021 06:59:02 GMT) Full text and rfc822 format available.

Message #14 received at 51965 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Gregory Heytings <gregory <at> heytings.org>
Cc: 51965 <at> debbugs.gnu.org
Subject: Re: bug#51965: [PATCH] Pass options from make to configure
Date: Wed, 24 Nov 2021 07:58:36 +0100
Gregory Heytings <gregory <at> heytings.org> writes:

> I attach a patch with which it is possible to say, with both the
> GNUmakefile or the Makefile:
>
> make bootstrap configure=--with-x-toolkit=lucid
>
> and, to go back to the default configuration:
>
> make bootstrap configure=default

Thanks; seems to work well here, so I've pushed it to Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




bug marked as fixed in version 29.1, send any further explanations to 51965 <at> debbugs.gnu.org and Gregory Heytings <gregory <at> heytings.org> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Wed, 24 Nov 2021 06:59:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 22 Dec 2021 12:24:09 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 97 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.