GNU bug report logs - #51973
[PATCH] gnu: mycli: Update to 1.24.1.

Previous Next

Package: guix-patches;

Reported by: jgart <jgart <at> dismail.de>

Date: Fri, 19 Nov 2021 11:21:02 UTC

Severity: normal

Tags: patch

Done: Arun Isaac <arunisaac <at> systemreboot.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51973 in the body.
You can then email your comments to 51973 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#51973; Package guix-patches. (Fri, 19 Nov 2021 11:21:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to jgart <jgart <at> dismail.de>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 19 Nov 2021 11:21:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] gnu: mycli: Update to 1.24.1.
Date: Fri, 19 Nov 2021 06:19:29 -0500
* gnu/packages/databases.scm (mycli): Update to 1.24.1.
[propagated-inputs]: Add missing dependencies.
---
 gnu/packages/databases.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index de161e1864..c1582c709a 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -145,6 +145,7 @@ (define-module (gnu packages databases)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages valgrind)
   #:use-module (gnu packages web)
+  #:use-module (gnu packages xdisorg)
   #:use-module (gnu packages xml)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
@@ -618,13 +619,13 @@ (define-public python2-pylibmc
 (define-public mycli
   (package
     (name "mycli")
-    (version "1.22.2")
+    (version "1.24.1")
     (source
       (origin
         (method url-fetch)
         (uri (pypi-uri "mycli" version))
         (sha256
-          (base32 "1lq2x95553vdmhw13cxcgsd2g2i32izhsb7hxd4m1iwf9b3msbpv"))))
+          (base32 "0rij9nw20zhqr7cqnkm8daw8b1wdc9zb6ny1ji9qz5557nz9i3bl"))))
     (build-system python-build-system)
     (arguments
      `(#:tests? #f))                    ; tests expect a running MySQL
@@ -634,8 +635,10 @@ (define-public mycli
         ("python-configobj" ,python-configobj)
         ("python-cryptography" ,python-cryptography)
         ("python-prompt-toolkit" ,python-prompt-toolkit)
+        ("python-pyaes" ,python-pyaes)
         ("python-pygments" ,python-pygments)
         ("python-pymysql" ,python-pymysql)
+        ("python-pyperclip" ,python-pyperclip)
         ("python-sqlparse" ,python-sqlparse)))
     (home-page "http://mycli.net")
     (synopsis
-- 
2.34.0





Reply sent to Arun Isaac <arunisaac <at> systemreboot.net>:
You have taken responsibility. (Fri, 19 Nov 2021 16:09:01 GMT) Full text and rfc822 format available.

Notification sent to jgart <jgart <at> dismail.de>:
bug acknowledged by developer. (Fri, 19 Nov 2021 16:09:01 GMT) Full text and rfc822 format available.

Message #10 received at 51973-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: jgart <jgart <at> dismail.de>
Cc: 51973-done <at> debbugs.gnu.org
Subject: Re: bug#51973: [PATCH] gnu: mycli: Update to 1.24.1.
Date: Fri, 19 Nov 2021 21:38:33 +0530
[Message part 1 (text/plain, inline)]
Hi jgart,

Thanks for the patch! I pushed it to master after adding a copyright
header and fixing your commit message as follows.

> [propagated-inputs]: Add missing dependencies.

^ In this line, I explicitly listed the new dependencies.

Regards,
Arun
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#51973; Package guix-patches. (Fri, 19 Nov 2021 17:46:01 GMT) Full text and rfc822 format available.

Message #13 received at 51973-done <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 51973-done <at> debbugs.gnu.org
Subject: Re: bug#51973: [PATCH] gnu: mycli: Update to 1.24.1.
Date: Fri, 19 Nov 2021 12:44:58 -0500
On Fri, 19 Nov 2021 21:38:33 +0530 Arun Isaac <arunisaac <at> systemreboot.net> wrote:
> 
> Hi jgart,
> 
> Thanks for the patch! I pushed it to master after adding a copyright
> header and fixing your commit message as follows.
> 
> > [propagated-inputs]: Add missing dependencies.
> 
> ^ In this line, I explicitly listed the new dependencies.

Hi Arun,

I'll make sure to list all inputs changed going forward and adding the copyright statement.

Do you happen to know when it is not required to add a copyright statement?

I think for under ~5-8 lines of code it is not required but I might be wrong on that.

Thank you for reviewing and merging the patch! Much appreciated.

all best,

jgart





Information forwarded to guix-patches <at> gnu.org:
bug#51973; Package guix-patches. (Mon, 22 Nov 2021 09:50:01 GMT) Full text and rfc822 format available.

Message #16 received at 51973-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: jgart <jgart <at> dismail.de>
Cc: 51973-done <at> debbugs.gnu.org
Subject: Re: bug#51973: [PATCH] gnu: mycli: Update to 1.24.1.
Date: Mon, 22 Nov 2021 15:18:47 +0530
[Message part 1 (text/plain, inline)]
Hi jgart,

> Do you happen to know when it is not required to add a copyright
> statement?

I add a copyright header all the time, even if only a single character
has been changed! It just seemed like the safest thing to do. I don't
know what the legal requirements are.

> I think for under ~5-8 lines of code it is not required but I might be
> wrong on that.

You can fit a lot into 5-8 lines of code. So, perhaps that is too high
for a minimum limit.

Regards,
Arun
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 20 Dec 2021 12:24:12 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 89 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.