GNU logs - #51981, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#51981] (no subject)
Resent-From: "Collin J. Doering" <collin@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 19 Nov 2021 20:18:01 +0000
Resent-Message-ID: <handler.51981.B.163735306123288 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 51981 <at> debbugs.gnu.org
User-agent: mu4e 1.6.10; emacs 27.2
From: "Collin J. Doering" <collin@HIDDEN>
Date: Fri, 19 Nov 2021 14:59:07 -0500
Message-ID: <87bl2f6gti.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=2607:f8b0:4864:20::f2a;
 envelope-from=collin@HIDDEN; helo=mail-qv1-xf2a.google.com
X-Spam_score_int: 5
X-Spam_score: 0.5
X-Spam_bar: /
X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,
 DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MISSING_SUBJECT=1.799,
 PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.6 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.4 (/)

Hi all,

This patch resolves an issue I discovered when attempting to cross-compile packages that use the go-build-system.

Namely, prior to this patch, running 'guix build --target=arm-unknown-linux-gnueabihf <go-package>' where '<go-package>' is some package that uses to go-build-system (for example, 'fzf'), would result in the following error in the build log:

--8<---------------cut here---------------start------------->8---
go install: cannot install cross-compiled binaries when GOBIN is set
Building 'github.com/junegunn/fzf' failed.
Here are the results of `go env`:
GO111MODULE="off"
GOARCH="arm"
GOBIN="/gnu/store/8xcs9vna6zyl814j78raynccm7mqqk0h-fzf-0.25.0/bin"
GOCACHE="/tmp/go-cache"
GOENV="/homeless-shelter/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/tmp/guix-build-fzf-0.25.0.drv-0"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/gnu/store/y5rwacd5l4q26pxis28wsmswj2603hkw-go-1.14.15"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/gnu/store/y5rwacd5l4q26pxis28wsmswj2603hkw-go-1.14.15/pkg/tool/linux_amd64"
GCCGO="gccgo"
GOARM="7"
AR="ar"
CC="/gnu/store/rn75fm7adgx3pw5j8pg3bczfqq1y17lk-gcc-7.5.0/bin/gcc"
CXX="g++"
CGO_ENABLED="0"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -marm -fmessage-length=0 -fdebug-prefix-map=/tmp/guix-build-fzf-0.25.0.drv-0/go-build219362912=/tmp/go-build -gno-record-gcc-switches"
command "go" "install" "-v" "-x" "-ldflags=-s -w" "github.com/junegunn/fzf" failed with status 1
--8<---------------cut here---------------end--------------->8---

The important bit is the first line, which indicates that 'GOBIN' cannot be set when cross-compiling. This has been the case in go from what I can tell for numerous years (atleast 2019).

This patch removes the setting of 'GOBIN' and adjusts the go-build-systems build function to us 'go build' instead of 'go install'.

Collin J. Doering (1):
  build: Fix cross compilation for go-build-system

 guix/build/go-build-system.scm | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

-- 
2.33.1

-- 
Collin J. Doering

http://rekahsoft.ca
http://blog.rekahsoft.ca
http://git.rekahsoft.ca

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: "Collin J. Doering" <collin@HIDDEN>
Subject: bug#51981: Acknowledgement ((no subject))
Message-ID: <handler.51981.B.163735306123288.ack <at> debbugs.gnu.org>
References: <87bl2f6gti.fsf@HIDDEN>
X-Gnu-PR-Message: ack 51981
X-Gnu-PR-Package: guix-patches
Reply-To: 51981 <at> debbugs.gnu.org
Date: Fri, 19 Nov 2021 20:18:01 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 51981 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
51981: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D51981
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#51981] [PATCH 1/1] build: Fix cross compilation for go-build-system
References: <87bl2f6gti.fsf@HIDDEN>
In-Reply-To: <87bl2f6gti.fsf@HIDDEN>
Resent-From: "Collin J. Doering" <collin@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 19 Nov 2021 20:39:01 +0000
Resent-Message-ID: <handler.51981.B51981.163735428825577 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 51981 <at> debbugs.gnu.org
User-agent: mu4e 1.6.10; emacs 27.2
From: "Collin J. Doering" <collin@HIDDEN>
Date: Fri, 19 Nov 2021 15:37:34 -0500
Message-ID: <877dd36fvc.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

---
 guix/build/go-build-system.scm | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/guix/build/go-build-system.scm b/guix/build/go-build-system.scm
index 4768ee8562..f36e98f47a 100644
--- a/guix/build/go-build-system.scm
+++ b/guix/build/go-build-system.scm
@@ -148,7 +148,6 @@ (define* (setup-go-environment #:key inputs outputs goos goarch #:allow-other-ke
   ;; currently support modules, so turn modules off to continue using the old
   ;; GOPATH behavior.
   (setenv "GO111MODULE" "off")
-  (setenv "GOBIN" (string-append (assoc-ref outputs "out") "/bin"))

   ;; Make sure we're building for the correct architecture and OS targets
   ;; that Guix targets.
@@ -234,14 +233,19 @@ (define (go-inputs inputs)
                 (_ #f))
               inputs))))

-(define* (build #:key import-path build-flags #:allow-other-keys)
+(define* (build #:key outputs import-path build-flags #:allow-other-keys)
   "Build the package named by IMPORT-PATH."
   (with-throw-handler
     #t
     (lambda _
-      (apply invoke "go" "install"
+      (apply invoke "go" "build"
               "-v" ; print the name of packages as they are compiled
               "-x" ; print each command as it is invoked
+              ;; Set the output path for the build
+              (string-append "-o="
+                (assoc-ref outputs "out") "/bin/"
+                (package-name->name+version
+                  (strip-store-file-name (assoc-ref outputs "out"))))
               ;; Respectively, strip the symbol table and debug
               ;; information, and the DWARF symbol table.
               "-ldflags=-s -w"
-- 
2.33.1

-- 
Collin J. Doering

http://rekahsoft.ca
http://blog.rekahsoft.ca
http://git.rekahsoft.ca

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 19 Nov 2021 20:48:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 15:48:41 2021
Received: from localhost ([127.0.0.1]:40630 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moAoL-0006yf-Mw
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 15:48:41 -0500
Received: from mail-qk1-f174.google.com ([209.85.222.174]:40582)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <collin@HIDDEN>) id 1moAoJ-0006yL-Vv
 for control <at> debbugs.gnu.org; Fri, 19 Nov 2021 15:48:41 -0500
Received: by mail-qk1-f174.google.com with SMTP id p4so11481287qkm.7
 for <control <at> debbugs.gnu.org>; Fri, 19 Nov 2021 12:48:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rekahsoft.ca; s=google;
 h=user-agent:from:to:subject:date:message-id:mime-version;
 bh=nklc7hb4RAfS6n5IIfT5wnKsqhg+VEKCWz58H/2A+Nw=;
 b=hgP2brUsVuKHG2ms7ub5w8MtDTj+oJkpRVa+/rRG2wTqwdRrCEJF8pGwHXftWwYnbS
 pS9adUQiI6F6QXJrraKgRIbd/rldFp0SCRIEK6pu0J1pCVFGZ5KOwAWYm3LLmJVSJuxR
 zDCnJ1nhM7t2o/AqC0YbtIp0yhjWY36a9P8RM27WJ8kQQ4vA//gsGV6OuEze98kqnReN
 /Dz3932xCCzyzOPzhBhuvhHJZuIj1ggr/dz4WAPDlfqgW18t3+HU59HzMda4BfQNehSb
 vaJ3o62du/+lkYiABo6ERUyn39r+UhrYrkNrbZ6ll0jNEjTM6EQoYR7nSrSmtqEJgUR5
 t7Mg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:user-agent:from:to:subject:date:message-id
 :mime-version;
 bh=nklc7hb4RAfS6n5IIfT5wnKsqhg+VEKCWz58H/2A+Nw=;
 b=klN4x7nyyesBN8IV8VDlwLrDUYKfrfAgrRKtgoM21CuPx6t2E2TymuDO4UeQ/KFdkw
 +GDARdmHMyJcDuNE5gqZGXGKTzayOyrpr3/SszQ96YS0mHBwfLmKY8h3s5ro5q89Rk6q
 IyBgkJTvSA7/C+2Z+a4gvlUGw8eFIZEXBczfig5oV2oIsio7urovSa8rhyMq/tVvhkwH
 j/gV8z3mtVSJIcbQmRM0BTAcyEn8Nj2ZsnW88ExmUExhVbReRURLpL0RCUUZat5rMfhQ
 LP3kmZ3cs/PrIWdNPZARbGUzkvRFFjUId7Vx1pfiDYWXMhDGabtsm3rL2sc01l2BbykH
 XByw==
X-Gm-Message-State: AOAM533LTBZikW91QnUkAA5ObdIeNCvpSqIdY9YYvju5NfKs+C8s7pe6
 0Qye44i4NXdZ2QW3swfA3foKlmfA8Tm4Kw==
X-Google-Smtp-Source: ABdhPJw/TwyzCt/YfDUTB+iLf5SkiWBo7ajv012UOCpw0SAEO+AANzoUzxgTytaZO+QH2dRLNjdeqQ==
X-Received: by 2002:a05:620a:1479:: with SMTP id
 j25mr31412804qkl.139.1637354914132; 
 Fri, 19 Nov 2021 12:48:34 -0800 (PST)
Received: from rekahsoft-work
 (cpe0008a20f982f-cm64777d666260.cpe.net.cable.rogers.com. [99.255.210.233])
 by smtp.gmail.com with ESMTPSA id m4sm433529qtu.87.2021.11.19.12.48.33
 for <control <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 19 Nov 2021 12:48:33 -0800 (PST)
User-agent: mu4e 1.6.10; emacs 27.2
From: "Collin J. Doering" <collin@HIDDEN>
To: control <at> debbugs.gnu.org
Subject: Adjust title
Date: Fri, 19 Nov 2021 15:46:32 -0500
Message-ID: <8735nr6fdr.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

retitle 51981 [PATCH 0/1] Fix cross-compilation of packages that use go-build-system

-- 
Collin J. Doering

http://rekahsoft.ca
http://blog.rekahsoft.ca
http://git.rekahsoft.ca

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 19 Nov 2021 21:16:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 19 16:16:38 2021
Received: from localhost ([127.0.0.1]:40677 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1moBFO-0001Ze-MN
	for submit <at> debbugs.gnu.org; Fri, 19 Nov 2021 16:16:38 -0500
Received: from mail-qk1-f182.google.com ([209.85.222.182]:33436)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <collin@HIDDEN>) id 1moBFN-0001ZQ-2g
 for control <at> debbugs.gnu.org; Fri, 19 Nov 2021 16:16:37 -0500
Received: by mail-qk1-f182.google.com with SMTP id de30so11617797qkb.0
 for <control <at> debbugs.gnu.org>; Fri, 19 Nov 2021 13:16:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rekahsoft.ca; s=google;
 h=user-agent:from:to:subject:date:message-id:mime-version;
 bh=osa5trQ+Aky2jVgAxr8ZEBmUuv1PGLDTVHUyx6dvmGE=;
 b=ZxSIt5cFb9MLz88T0bL0T/9bGY5Ms8BRNXYUVEhtlBsuOg3ycGnR8Qr+MJYpcZ1Lsa
 bCkBZsu5JdY9msCa0IH35TJiAr3es5UvI4QW9XboV2MDODAEdNGTy4e44FTebyUjC3wd
 5Mi33sy9ZdM0YSG8cb5mBETwI4j4zUsvcXJpg1Z09dYNzIFZwXAsmG6mNIjijVzYV5u5
 mng1C8j/8N72R9lh1zVEHucMwWhaV64Ha5D2LOCJLwdtub0euzF7ETI3Uj1InQaloii+
 qMIpl3+BZ8B7NM9Y7049TdQbGItmB0TTyonuKic+hCRKGfOVlGPokcLfijnd41ZLqNYZ
 YJsQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:user-agent:from:to:subject:date:message-id
 :mime-version;
 bh=osa5trQ+Aky2jVgAxr8ZEBmUuv1PGLDTVHUyx6dvmGE=;
 b=JpGo4nZ+3eCOWZP+X3m4I5VNDhK/p3lvuWPgwM/YIOT9fwn+y4aYoHzQGaUEff/B56
 +osJ10uer0f6mDBOo/hdCPf7qhWaWlSOOf8uMRLJakug2C5NUVApI99cKB6wamaILCVF
 ADrfWFf/QHVvfIzEG3V+FuD50wVxqIVBgVOWcB54gCSdV6KMQD9jcpY2cnKZ+7SpG4ET
 Uha/hpx9qPo+XtNDXfz/VIRSy1PjuTzX7nsd8FAscPcRXX8BGnSQHWYJwxCYOeoSJNrP
 QnpiR03bb+CvqVzy+Z0gZPW5XjMN4P/SqWVhqgQXFOjHbfn6Rston+/8a1g5lD52OtQ6
 gzVA==
X-Gm-Message-State: AOAM530XdvL+ttP08Qn71dUB7DoTD2pP6lACYQnkMo/H4tJrp78kICfV
 L9ByjtajWEVKjJxajSFNnDG8LFBcZBOoTQ==
X-Google-Smtp-Source: ABdhPJwsJvTLb3qGwHRQgjf708NsnvqsZahXsR925XdbgfkDEfl3TfhuiZTMYAsHShh8Qr6cFOx1aA==
X-Received: by 2002:a37:f90a:: with SMTP id l10mr29869456qkj.402.1637356591480; 
 Fri, 19 Nov 2021 13:16:31 -0800 (PST)
Received: from rekahsoft-work
 (cpe0008a20f982f-cm64777d666260.cpe.net.cable.rogers.com. [99.255.210.233])
 by smtp.gmail.com with ESMTPSA id h5sm524297qkn.62.2021.11.19.13.16.30
 for <control <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 19 Nov 2021 13:16:31 -0800 (PST)
User-agent: mu4e 1.6.10; emacs 27.2
From: "Collin J. Doering" <collin@HIDDEN>
To: control <at> debbugs.gnu.org
Subject: Add patch tag
Date: Fri, 19 Nov 2021 16:15:49 -0500
Message-ID: <87pmqv4ziq.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tags 51981 patch

-- 
Collin J. Doering

http://rekahsoft.ca
http://blog.rekahsoft.ca
http://git.rekahsoft.ca

Last modified: Fri, 19 Nov 2021 21:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.