GNU bug report logs - #51987
[PATCH] [core-updates-frozen] gnu: ledger: Remove failing test output.

Previous Next

Package: guix-patches;

Reported by: John Kehayias <john.kehayias <at> protonmail.com>

Date: Fri, 19 Nov 2021 22:48:01 UTC

Severity: normal

Tags: patch

Done: Guillaume Le Vaillant <glv <at> posteo.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51987 in the body.
You can then email your comments to 51987 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#51987; Package guix-patches. (Fri, 19 Nov 2021 22:48:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to John Kehayias <john.kehayias <at> protonmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 19 Nov 2021 22:48:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] [core-updates-frozen] gnu: ledger: Remove failing test output.
Date: Fri, 19 Nov 2021 22:47:09 +0000
[Message part 1 (text/plain, inline)]
Hello,

I'm not sure why, but ledger started failing one of its test on core-updates-frozen. The test is for the error when trying to use a nonexistent file (as far as I can tell) and it fails in the error message reporting the path of the file without the leading "./". Output of the test below. The patch removes this test from ledger.

359/396 Test #359: RegressTest_BF3C1F82-2 ................................***Failed    0.04 sec
FAILURE in error output from /tmp/guix-build-ledger-3.2.1.drv-0/source/test/regress/BF3C1F82-2.test:
--
$ledger -f - reg
--
  @@ -1,2 +1,2 @@

   While parsing file "", line 2:

  -Error: File to include was not found: "./non-existent-ledger-file-BF3C1F82"

  +Error: File to include was not found: "non-existent-ledger-file-BF3C1F82"

E[BF3C1F82-2.test]STDERR:
b''
FAILURE in error output from /tmp/guix-build-ledger-3.2.1.drv-0/source/test/regress/BF3C1F82-2.test:
--
$ledger -f /dev/stdin reg
--
  @@ -1,2 +1,2 @@

   While parsing file "", line 2:

  -Error: File to include was not found: "./non-existent-ledger-file-BF3C1F82"

  +Error: File to include was not found: "non-existent-ledger-file-BF3C1F82"

E[BF3C1F82-2.test]STDERR:
b''

FAILED (2)

Thanks,
John
[0001-gnu-ledger-Remove-failing-test-output.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#51987; Package guix-patches. (Sat, 20 Nov 2021 09:27:01 GMT) Full text and rfc822 format available.

Message #8 received at 51987 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: John Kehayias <john.kehayias <at> protonmail.com>
Cc: 51987 <at> debbugs.gnu.org
Subject: Re: [bug#51987] [PATCH] [core-updates-frozen] gnu: ledger: Remove
 failing test output.
Date: Sat, 20 Nov 2021 09:19:45 +0000
[Message part 1 (text/plain, inline)]
John Kehayias via Guix-patches via <guix-patches <at> gnu.org> skribis:

> Hello,
>
> I'm not sure why, but ledger started failing one of its test on core-updates-frozen. The test is for the error when trying to use a nonexistent file (as far as I can tell) and it fails in the error message reporting the path of the file without the leading "./". Output of the test below. The patch removes this test from ledger.
>
> 359/396 Test #359: RegressTest_BF3C1F82-2 ................................***Failed    0.04 sec
> FAILURE in error output from /tmp/guix-build-ledger-3.2.1.drv-0/source/test/regress/BF3C1F82-2.test:
> --
> $ledger -f - reg
> --
>   @@ -1,2 +1,2 @@
>
>    While parsing file "", line 2:
>
>   -Error: File to include was not found: "./non-existent-ledger-file-BF3C1F82"
>
>   +Error: File to include was not found: "non-existent-ledger-file-BF3C1F82"
>
> E[BF3C1F82-2.test]STDERR:
> b''
> FAILURE in error output from /tmp/guix-build-ledger-3.2.1.drv-0/source/test/regress/BF3C1F82-2.test:
> --
> $ledger -f /dev/stdin reg

Hi,

Instead of adding a patch removing the file, wouldn't it be simpler to just add a phase
calling '(delete-file "test/...")'?
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#51987; Package guix-patches. (Sat, 20 Nov 2021 18:09:02 GMT) Full text and rfc822 format available.

Message #11 received at 51987 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Guillaume Le Vaillant <glv <at> posteo.net>
Cc: 51987 <at> debbugs.gnu.org
Subject: Re: [bug#51987] [PATCH] [core-updates-frozen] gnu: ledger: Remove
 failing test output.
Date: Sat, 20 Nov 2021 18:08:15 +0000
[Message part 1 (text/plain, inline)]
Hello,

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Saturday, November 20th, 2021 at 4:19 AM, Guillaume Le Vaillant wrote:

> Instead of adding a patch removing the file, wouldn't it be simpler to just add a phase
> calling '(delete-file "test/...")'?

That's a very good point, much easier! I've attached v2 of the patch (commit message also had a typo before) where I used a snippet to remove the file. I haven't written a snippet before but seemed like a clean and explicit way to do the source modification here.

Hope that's better!

John
[0001-gnu-ledger-Remove-failing-test-output.patch (text/x-patch, attachment)]

Reply sent to Guillaume Le Vaillant <glv <at> posteo.net>:
You have taken responsibility. (Sat, 20 Nov 2021 18:28:02 GMT) Full text and rfc822 format available.

Notification sent to John Kehayias <john.kehayias <at> protonmail.com>:
bug acknowledged by developer. (Sat, 20 Nov 2021 18:28:02 GMT) Full text and rfc822 format available.

Message #16 received at 51987-done <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: John Kehayias <john.kehayias <at> protonmail.com>
Cc: 51987-done <at> debbugs.gnu.org
Subject: Re: [bug#51987] [PATCH] [core-updates-frozen] gnu: ledger: Remove
 failing test output.
Date: Sat, 20 Nov 2021 18:26:33 +0000
[Message part 1 (text/plain, inline)]
Patch pushed as c51667d52ed40b70cd15ff890141bff98f5e0d9a.
Thanks.
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 19 Dec 2021 12:24:09 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 90 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.