GNU bug report logs - #51990
[PATCH] gnu: Add emacs-bazel.

Previous Next

Package: guix-patches;

Reported by: Brian Kubisiak <brian <at> kubisiak.com>

Date: Sat, 20 Nov 2021 01:45:02 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51990 in the body.
You can then email your comments to 51990 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#51990; Package guix-patches. (Sat, 20 Nov 2021 01:45:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Brian Kubisiak <brian <at> kubisiak.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 20 Nov 2021 01:45:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brian Kubisiak <brian <at> kubisiak.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-bazel.
Date: Fri, 19 Nov 2021 16:14:24 -0800
* gnu/packages/emacs-xyz (emacs-bazel): New variable.

Signed-off-by: Brian Kubisiak <brian <at> kubisiak.com>
---
 gnu/packages/emacs-xyz.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 7f895b9321..15d57ad964 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -12844,6 +12844,25 @@ (define-public emacs-gn-mode
 are common in Chromium-derived projects.")
     (license license:bsd-3)))
 
+(define-public emacs-bazel
+  (package
+    (name "emacs-bazel")
+    (version "20211031.1941")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://melpa.org/packages/bazel-"
+                           version ".el"))
+       (sha256
+        (base32 "185wqxcdk5c5d25vla3wgijwqs542dbqwnj47bnh5hvlna2il6ca"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/bazelbuild/emacs-bazel-mode")
+    (synopsis "Bazel support for Emacs")
+    (description
+     "This package provides support for the Bazel build system.  See
+@uref{https://bazel.build/} for background on Bazel.")
+    (license license:asl2.0)))
+
 (define-public emacs-gntp
   (package
     (name "emacs-gntp")
-- 
2.32.0






Information forwarded to guix-patches <at> gnu.org:
bug#51990; Package guix-patches. (Sun, 21 Nov 2021 20:32:02 GMT) Full text and rfc822 format available.

Message #8 received at 51990 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Brian Kubisiak <brian <at> kubisiak.com>
Cc: 51990 <at> debbugs.gnu.org
Subject: Re: [bug#51990] [PATCH] gnu: Add emacs-bazel.
Date: Sun, 21 Nov 2021 21:30:52 +0100
Hello,

Brian Kubisiak <brian <at> kubisiak.com> writes:

> * gnu/packages/emacs-xyz (emacs-bazel): New variable.

Thank you. Some comments follow.
>
> Signed-off-by: Brian Kubisiak <brian <at> kubisiak.com>

We don't sign our own commits. So the line above is not necessary.

> +(define-public emacs-bazel
> +  (package
> +    (name "emacs-bazel")
> +    (version "20211031.1941")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://melpa.org/packages/bazel-"
> +                           version ".el"))

We don't trust MELPA as a reliable source. Could you use git-fetch
instead, and get source files from upstream instead?

Also, the version is "O", according to "Version" keyword in "bazel.el"
file.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou




Information forwarded to guix-patches <at> gnu.org:
bug#51990; Package guix-patches. (Tue, 23 Nov 2021 00:28:02 GMT) Full text and rfc822 format available.

Message #11 received at 51990 <at> debbugs.gnu.org (full text, mbox):

From: Brian Kubisiak <brian <at> kubisiak.com>
To: 51990 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add emacs-bazel.
Date: Mon, 22 Nov 2021 16:27:19 -0800
* gnu/packages/emacs-xyz (emacs-bazel): New variable.
---
 gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d3338d45bd..801f603b5e 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -12844,6 +12844,30 @@ (define-public emacs-gn-mode
 are common in Chromium-derived projects.")
     (license license:bsd-3)))
 
+(define-public emacs-bazel
+  ;; From 2021-11-21.
+  ;; No releases available.
+  (let ((commit "cdb2643dba39fe2bd64ba3b190b94d1ef1d83b18")
+        (revision "0"))
+    (package
+      (name "emacs-bazel")
+      (version (git-version "0" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/bazelbuild/emacs-bazel-mode")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32 "0ln06dprnivx9zxm6n23ppyx7x4kbn0f85pxwvkq32aq7wnqz82m"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/bazelbuild/emacs-bazel-mode")
+      (synopsis "Bazel support for Emacs")
+      (description
+       "This package provides support for the Bazel build system.  See
+@uref{https://bazel.build/} for background on Bazel.")
+      (license license:asl2.0))))
+
 (define-public emacs-gntp
   (package
     (name "emacs-gntp")
-- 
2.32.0






Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Tue, 23 Nov 2021 09:32:30 GMT) Full text and rfc822 format available.

Notification sent to Brian Kubisiak <brian <at> kubisiak.com>:
bug acknowledged by developer. (Tue, 23 Nov 2021 09:32:38 GMT) Full text and rfc822 format available.

Message #16 received at 51990-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Brian Kubisiak <brian <at> kubisiak.com>
Cc: 51990-done <at> debbugs.gnu.org
Subject: Re: [bug#51990] [PATCH] gnu: Add emacs-bazel.
Date: Tue, 23 Nov 2021 10:30:40 +0100
Hello,

Brian Kubisiak <brian <at> kubisiak.com> writes:

> * gnu/packages/emacs-xyz (emacs-bazel): New variable.

I added a copyright line for you and applied your patch. Thanks.

Regards,
-- 
Nicolas Goaziou




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 21 Dec 2021 12:24:12 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 88 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.