GNU bug report logs - #52027
[PATCH] Add lz4json

Previous Next

Package: guix-patches;

Reported by: Baptiste Strazzulla <bstrazzull <at> hotmail.fr>

Date: Sun, 21 Nov 2021 20:17:02 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52027 in the body.
You can then email your comments to 52027 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#52027; Package guix-patches. (Sun, 21 Nov 2021 20:17:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Baptiste Strazzulla <bstrazzull <at> hotmail.fr>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 21 Nov 2021 20:17:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Baptiste Strazzulla <bstrazzull <at> hotmail.fr>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] Add lz4json
Date: Sun, 21 Nov 2021 19:55:22 +0000
[Message part 1 (text/plain, inline)]
Hello,

I couldn't figure out a license for this package. It says " * Copyright (c) 2014 Intel Corporation" in the source. I don't even know if it's an actual license. In any case, it doesn't seem really engaging and there's no mention of it in `licenses.scm`… How shall I proceed?

Kind regards,
Baptiste
[Message part 2 (text/html, inline)]
[0001-gnu-Add-lz4json.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#52027; Package guix-patches. (Sun, 21 Nov 2021 20:28:02 GMT) Full text and rfc822 format available.

Message #8 received at 52027 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Baptiste Strazzulla <bstrazzull <at> hotmail.fr>
Cc: 52027 <at> debbugs.gnu.org
Subject: Re: [bug#52027] [PATCH] Add lz4json
Date: Sun, 21 Nov 2021 21:27:28 +0100
Hello,

Baptiste Strazzulla <bstrazzull <at> hotmail.fr> writes:

> I couldn't figure out a license for this package. It says " *
> Copyright (c) 2014 Intel Corporation" in the source. I don't even know
> if it's an actual license.
> In any case, it doesn't seem really
> engaging and there's no mention of it in `licenses.scm`… How shall
> I proceed?

The license is below, in the lz4jsoncat.c header. It's bsd-2


> +(define-public lz4json
> +  (package
> +    (name "lz4json")
> +    (version "2")
> +    (home-page "https://github.com/andikleen/lz4json")

This should be moved right before the synopsis field.

> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri
> +        (git-reference (url home-page) (commit (string-append "v" version))))

(url ...) should provide the github URL and not re-use the home-page.
Also there should be newline characters before and after the url field.

> +    (arguments
> +     '(#:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure)
> +         (delete 'check)
> +         (replace 'install

Could you add comment explaining why 'configure' is deleted (probably
because there is no configure script) and 'install' is replaced
(probably because upstream provides no install script either).

Instead of deleting `check', you should use:

  #:tests? #false

instead.

> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (bin (string-append out "/bin"))
> +                    (man (string-append out "/share/man/man1")))
> +               (install-file "lz4jsoncat" bin)
> +               (install-file "lz4jsoncat.1" man))
> +             #t)))

You can remove the trailing boolean at the end of the phase.

> +       #:make-flags '("CC=gcc")))

The above is not cross-compilation friendly. It should become

  `(,(string-append "CC=" (cc-for-target)))

instead.

> +    (synopsis "C decompress tool for mozilla lz4json format")
> +    (description
> +     "A little utility to unpack lz4json files as generated by Firefox's
> +bookmark backups and session restore.  This is a different format from what
> +the normal lz4 utility expects.  The data is dumped to stdout.")

The description should consist of full sentences. So it may start as

  @code{lz4json} is a little utility to unpack lz4json files…

> +    (license license:gpl3+)))

This should be license:bsd-2.

Thanks for your work. Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou




Information forwarded to guix-patches <at> gnu.org:
bug#52027; Package guix-patches. (Sun, 21 Nov 2021 21:55:02 GMT) Full text and rfc822 format available.

Message #11 received at 52027 <at> debbugs.gnu.org (full text, mbox):

From: Baptiste Strazzulla <bstrazzull <at> hotmail.fr>
To: "52027 <at> debbugs.gnu.org" <52027 <at> debbugs.gnu.org>
Subject: [bug#52027] [PATCH] Add lz4json
Date: Sun, 21 Nov 2021 21:54:28 +0000
[Message part 1 (text/plain, inline)]
Here is the revised version.

Regards again
[Message part 2 (text/html, inline)]
[0001-gnu-Add-lz4json.patch (text/x-patch, attachment)]

Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Mon, 22 Nov 2021 10:26:02 GMT) Full text and rfc822 format available.

Notification sent to Baptiste Strazzulla <bstrazzull <at> hotmail.fr>:
bug acknowledged by developer. (Mon, 22 Nov 2021 10:26:02 GMT) Full text and rfc822 format available.

Message #16 received at 52027-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Baptiste Strazzulla <bstrazzull <at> hotmail.fr>
Cc: 52027-done <at> debbugs.gnu.org
Subject: Re: [bug#52027] [PATCH] Add lz4json
Date: Mon, 22 Nov 2021 11:24:55 +0100
Hello,

Baptiste Strazzulla <bstrazzull <at> hotmail.fr> writes:

> Here is the revised version.

Thank you. I added a copyright line for you in gnuzilla.scm and applied
your patch, with the minor tweaks below.

> Subject: [PATCH] gnu: Add lz4json

I added a final full stop to the line.

> * gnu/packages/gnuzilla.scm (lz4json)
>   New variable

I wrote:

  * gnu/packages/gnuzilla.scm (lz4json): New variable.

Regards,
-- 
Nicolas Goaziou




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 20 Dec 2021 12:24:09 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 89 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.