GNU bug report logs - #52030
[PATCH] gnu: Add feather font

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52030 in the body.
You can then email your comments to 52030 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jaft <jaft.r <at> outlook.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add feather font
Date: Mon, 22 Nov 2021 04:26:55 +0000 (UTC)

* gnu/packages/fonts.scm (feather): Add Feather iconfont by AT-UI

The foundry, AT-UI, has a hyphen but https://guix.gnu.org/manual/en/html_node/Fonts.html
seems to implicitly imply the foundry wouldn't have hyphens so I removed them,
for the package name (font-atui-feather).

---
gnu/packages/fonts.scm | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index c3ad57f203..2a46e08d9d 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -42,6 +42,7 @@
 ;;; Copyright © 2021 Sergiu Ivanov <sivanov <at> colimite.fr>
 ;;; Copyright © 2021 Sarah Morgensen <iskarian <at> mgsn.dev>
 ;;; Copyright © 2021 Paul A. Patience <paul <at> apatience.com>
+;;; Copyright © 2021 Wamm K. D. <jaft.r <at> outlook.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2285,3 +2286,19 @@ (define-public font-overpass
 Overpass includes proportional and monospace variants.")
     (license (list license:silofl1.1
                    license:lgpl2.1))))
+
+(define-public font-atui-feather
+  (package
+    (name "font-atui-feather")
+    (version "0")
+    (source (origin
+              (method url-fetch/zipbomb)
+              (uri "https://github.com/AT-UI/feather-font/archive/refs/heads/master.zip")
+              (sha256 (base32 "0lp1m1a47s56rj0q6nj8j5snkbw8jq3q7zwdzf86sbbglq170inh"))))
+    (build-system font-build-system)
+    (home-page "https://at-ui.github.io/feather-font/")
+    (synopsis "Iconfont version of Feather")
+    (description "Feather is a collection of simply beautiful open source icons.
+Each icon is designed on a 24x24 grid with an emphasis on simplicity, consistency,
+and readability.  This package bundles those icons into a font.")
+    (license license:expat)))

Message #8 received at 52030 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Jaft <jaft.r <at> outlook.com>
Cc: 52030 <at> debbugs.gnu.org
Subject: Re: bug#52030: [PATCH] gnu: Add feather font
Date: Fri, 10 Dec 2021 15:28:32 +0100

Hi Jaft,

Jaft <jaft.r <at> outlook.com> skribis:

> * gnu/packages/fonts.scm (feather): Add Feather iconfont by AT-UI
>
> The foundry, AT-UI, has a hyphen but https://guix.gnu.org/manual/en/html_node/Fonts.html
> seems to implicitly imply the foundry wouldn't have hyphens so I removed them,
> for the package name (font-atui-feather).

I think it’s fine either way.

> +    (name "font-atui-feather")
> +    (version "0")
> +    (source (origin
> +              (method url-fetch/zipbomb)
> +              (uri "https://github.com/AT-UI/feather-font/archive/refs/heads/master.zip")
> +              (sha256 (base32 "0lp1m1a47s56rj0q6nj8j5snkbw8jq3q7zwdzf86sbbglq170inh"))))

Note that ‘master.zip’ changes at each commit (and its content can also
change even if the HEAD commit is unchanged because it’s a generated
file.)

Could you instead change it to refer to a non-generated zip file, or use
‘git-fetch’ to obtain a checkout?

You may also need to adjust the version string.

> +    (build-system font-build-system)
> +    (home-page "https://at-ui.github.io/feather-font/")
> +    (synopsis "Iconfont version of Feather")
> +    (description "Feather is a collection of simply beautiful open source icons.

Everything is free software/data in Guix, so you can remove “open
source”.  :-)

Could you send an updated patch?  Preferably as a attachment to make
sure it’s not mangled on its way.

Thanks in advance!

Ludo’.

Message #11 received at 52030 <at> debbugs.gnu.org (full text, mbox):

From: Jaft <jaft.r <at> outlook.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: "52030 <at> debbugs.gnu.org" <52030 <at> debbugs.gnu.org>
Subject: Re: bug#52030: [PATCH] gnu: Add feather font
Date: Thu, 16 Dec 2021 21:24:33 +0000 (UTC)

[Message part 1 (text/plain, inline)]

> On Friday, December 10, 2021, 08:28:42 AM CST, Ludovic Courtès <ludo <at> gnu.org> wrote: 
>
>
>
>
>
> Hi Jaft,
>
> > +    (name "font-atui-feather")
> > +    (version "0")
> > +    (source (origin
> > +              (method url-fetch/zipbomb)
> > +              (uri "https://github.com/AT-UI/feather-font/archive/refs/heads/master.zip")
> > +              (sha256 (base32 "0lp1m1a47s56rj0q6nj8j5snkbw8jq3q7zwdzf86sbbglq170inh"))))
>
> Note that ‘master.zip’ changes at each commit (and its content can also
> change even if the HEAD commit is unchanged because it’s a generated
> file.)
>
> Could you instead change it to refer to a non-generated zip file, or use
> ‘git-fetch’ to obtain a checkout?
>
> You may also need to adjust the version string.

Huh; sorry about that. I knew that and yet completely missed it, when writing this up. The repo. doesn't have any tags or releases (maybe that's what my brain was thinking when it originally used master) so I've just pointed it to the latest commit they'd made, in the revision.

> > +    (build-system font-build-system)
> > +    (home-page "https://at-ui.github.io/feather-font/")
> > +    (synopsis "Iconfont version of Feather")
> +    (description "Feather is a collection of simply beautiful open source icons.
>
> Everything is free software/data in Guix, so you can remove “open
> source”.  :-)

Haha; oh, right: fair point. Removed.

> Could you send an updated patch?  Preferably as a attachment to make
> sure it’s not mangled on its way.
>
> Thanks in advance!
>
> Ludo’.

For some reason, I only remembered the part of the documentation that says you can submit the patch in the body of the E-mail but, double-checking my memory, it definitely also lists being able to send the patch as an attachment. I'll start doing that as others have mentioned mangling, as well.

[feather2.patch (text/x-patch, attachment)]

Message #14 received at 52030 <at> debbugs.gnu.org (full text, mbox):

From: Jaft <jaft.r <at> outlook.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: "52030 <at> debbugs.gnu.org" <52030 <at> debbugs.gnu.org>
Subject: Re: bug#52030: [PATCH] gnu: Add feather font
Date: Sun, 27 Feb 2022 03:32:28 +0000 (UTC)

I don't know if it's generally considered poor etiquette to do this but just bumping this E-mail thread, as I believe I've done the required changes and, theoretically, this patch should be all ready to just go.

Message #19 received at 52030-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Jaft <jaft.r <at> outlook.com>
Cc: "52030 <at> debbugs.gnu.org" <52030-done <at> debbugs.gnu.org>
Subject: Re: bug#52030: [PATCH] gnu: Add feather font
Date: Sun, 27 Feb 2022 22:40:29 +0100

Hi,

Jaft <jaft.r <at> outlook.com> skribis:

> For some reason, I only remembered the part of the documentation that says you can submit the patch in the body of the E-mail but, double-checking my memory, it definitely also lists being able to send the patch as an attachment. I'll start doing that as others have mentioned mangling, as well.
>
> * gnu/packages/fonts.scm (feather): Add Feather iconfont by AT-UI

[...]

> +(define-public font-atui-feather
> +  (package
> +    (name "font-atui-feather")
> +    (version "0")
> +    (source (origin
> +            (method git-fetch)
> +            (uri (git-reference
> +                  (commit "c51fe7cedbcf2cbf4f1b993cef5d8def612dec1d")
> +                  (url "https://github.com/AT-UI/feather-font/")))
> +            (sha256 (base32 "0hk12bjlsh0j6kd0sz3nwax259afdi6dxws4x88yz5ssxic1ng2j"))))
> +    (build-system font-build-system)
> +    (home-page "https://at-ui.github.io/feather-font/")
> +    (synopsis "Iconfont version of Feather")
> +    (description "Feather is a collection of simply beautiful icons.
> +Each icon is designed on a 24x24 grid with an emphasis on simplicity, consistency,
> +and readability.  This package bundles those icons into a font.")
> +    (license license:expat)))

I’ve (finally!) committed a tweaked version that includes a ‘version’
field following the guidelines in
<https://guix.gnu.org/manual/devel/en/html_node/Version-Numbers.html>,
also addressing another ‘guix lint’ warning about the origin.

Jaft <jaft.r <at> outlook.com> skribis:

> I don't know if it's generally considered poor etiquette to do this but just bumping this E-mail thread, as I believe I've done the required changes and, theoretically, this patch should be all ready to just go.

No, you were right to ping me; apologies for missing your earlier email.

In the future, it’s even more convenient for us if you can send a patch
created with ‘git send-email’.

Thank you, and sorry for the delay!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.