GNU bug report logs - #52062
[PATCH] gnu: system: Make old-style swap use default flags

Previous Next

Package: guix-patches;

Reported by: Josselin Poiret <dev <at> jpoiret.xyz>

Date: Tue, 23 Nov 2021 17:58:02 UTC

Severity: normal

Tags: patch

Done: Josselin Poiret <dev <at> jpoiret.xyz>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52062 in the body.
You can then email your comments to 52062 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#52062; Package guix-patches. (Tue, 23 Nov 2021 17:58:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Josselin Poiret <dev <at> jpoiret.xyz>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 23 Nov 2021 17:58:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: guix-patches <at> gnu.org
Cc: Josselin Poiret <dev <at> jpoiret.xyz>
Subject: [PATCH] gnu: system: Make old-style swap use default flags
Date: Tue, 23 Nov 2021 17:56:46 +0000
* gnu/services/base.scm (swap-service-type): Fix it.
---
 gnu/services/base.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index 20736eb13f..ba01f5d764 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -2225,8 +2225,10 @@ (define device-lookup
                      (and device
                           (begin
                             (restart-on-EINTR (swapon device
-                                                      #$(swap-space->flags-bit-mask
-                                                         swap)))
+                                                      #$(if (swap-space? swap)
+                                                            (swap-space->flags-bit-mask
+                                                             swap)
+                                                            0)))
                             #t)))))
         (stop #~(lambda _
                   (let ((device #$device-lookup))
-- 
2.33.1





Reply sent to Josselin Poiret <dev <at> jpoiret.xyz>:
You have taken responsibility. (Tue, 23 Nov 2021 18:09:02 GMT) Full text and rfc822 format available.

Notification sent to Josselin Poiret <dev <at> jpoiret.xyz>:
bug acknowledged by developer. (Tue, 23 Nov 2021 18:09:02 GMT) Full text and rfc822 format available.

Message #10 received at 52062-done <at> debbugs.gnu.org (full text, mbox):

From: Josselin Poiret <dev <at> jpoiret.xyz>
Cc: dev <at> jpoiret.xyz, 52062-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: system: Make old-style swap use default flags
Date: Tue, 23 Nov 2021 18:08:46 +0000
Pushed as d48b404cf577cbfcd29b294e193a4db0c3e580b1 by Tobias.

Sorry for this omission, I wonder how that got past my tests.  Maybe
`guix system vm` removes swap-devices?

Best,
Josselin Poiret




Information forwarded to guix-patches <at> gnu.org:
bug#52062; Package guix-patches. (Tue, 23 Nov 2021 19:52:02 GMT) Full text and rfc822 format available.

Message #13 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Josselin Poiret <dev <at> jpoiret.xyz>
Cc: 52062-done <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: bug#52062: [PATCH] gnu: system: Make old-style swap use default
 flags
Date: Tue, 23 Nov 2021 20:51:01 +0100
[Message part 1 (text/plain, inline)]
Josselin Poiret via Guix-patches via 写道:
> Sorry for this omission, I wonder how that got past my tests. 
> Maybe
> `guix system vm` removes swap-devices?

More: 
https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/system/vm.scm#n647

Kind regards,

T G-R
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#52062; Package guix-patches. (Tue, 23 Nov 2021 19:52:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 22 Dec 2021 12:24:09 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 87 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.