GNU bug report logs - #52068
[PATCH] [core-updates-frozen] gnu: libostree: Build with libsoup 2.

Previous Next

Package: guix-patches;

Reported by: John Kehayias <john.kehayias <at> protonmail.com>

Date: Tue, 23 Nov 2021 23:14:02 UTC

Severity: normal

Tags: patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52068 in the body.
You can then email your comments to 52068 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#52068; Package guix-patches. (Tue, 23 Nov 2021 23:14:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to John Kehayias <john.kehayias <at> protonmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 23 Nov 2021 23:14:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] [core-updates-frozen] gnu: libostree: Build with libsoup 2.
Date: Tue, 23 Nov 2021 23:13:04 +0000
[Message part 1 (text/plain, inline)]
Hello,

libostree should be built with libsoup-2 (doesn't support libsoup 3 currently) to have HTTP support. This was noticed due to Flatpak updates failing with "This version of ostree was built without libsoup or libcurl, and cannot fetch over HTTP". In the build log of ostree (eg https://ci.guix.gnu.org/build/1775196/log/raw ) you can see that it will report no HTTP backend with libsoup 3, but properly shows libsoup when libsoup-2 is provided as an input as in this patch.

I've checked libostree builds and that Flatpak built with this version successfully can download over HTTP. Thanks to jackhill on IRC for spotting the configuration error of ostree when we both hit the Flatpak update bug.

(Also, I added my copyright line as I forgot it on earlier Flatpak updates around the p11-kit workaround and version updates.)

Happily running on core-updates-frozen,
John
[0001-gnu-libostree-Build-with-libsoup-2.patch (text/x-patch, attachment)]

Reply sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
You have taken responsibility. (Wed, 24 Nov 2021 06:09:01 GMT) Full text and rfc822 format available.

Notification sent to John Kehayias <john.kehayias <at> protonmail.com>:
bug acknowledged by developer. (Wed, 24 Nov 2021 06:09:02 GMT) Full text and rfc822 format available.

Message #10 received at 52068-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: John Kehayias <john.kehayias <at> protonmail.com>
Cc: 52068-done <at> debbugs.gnu.org
Subject: Re: bug#52068: [PATCH] [core-updates-frozen] gnu: libostree: Build
 with libsoup 2.
Date: Wed, 24 Nov 2021 01:08:04 -0500
Hello John!

John Kehayias <john.kehayias <at> protonmail.com> writes:

> Hello,
>
> libostree should be built with libsoup-2 (doesn't support libsoup 3
> currently) to have HTTP support. This was noticed due to Flatpak
> updates failing with "This version of ostree was built without libsoup
> or libcurl, and cannot fetch over HTTP". In the build log of ostree
> (eg https://ci.guix.gnu.org/build/1775196/log/raw ) you can see that
> it will report no HTTP backend with libsoup 3, but properly shows
> libsoup when libsoup-2 is provided as an input as in this patch.
>
> I've checked libostree builds and that Flatpak built with this version
> successfully can download over HTTP. Thanks to jackhill on IRC for
> spotting the configuration error of ostree when we both hit the
> Flatpak update bug.

Neat, thanks for taking care of it.  Pushed as
93d1f8e5fc78bd82e8920d25b3e52a2d22528c17, and I updated libostree to
4d41c3beefa44d0ec30aa7108bc3979aa95c15e0 in the following commit.

> (Also, I added my copyright line as I forgot it on earlier Flatpak
> updates around the p11-kit workaround and version updates.)

Perfect!

Happy hacking,

Maxim




Information forwarded to guix-patches <at> gnu.org:
bug#52068; Package guix-patches. (Wed, 24 Nov 2021 06:27:01 GMT) Full text and rfc822 format available.

Message #13 received at 52068-done <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 52068-done <at> debbugs.gnu.org
Subject: Re: bug#52068: [PATCH] [core-updates-frozen] gnu: libostree: Build
 with libsoup 2.
Date: Wed, 24 Nov 2021 06:25:52 +0000
Hi Maxim!

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Wednesday, November 24th, 2021 at 1:08 AM, Maxim Cournoyer wrote:

> Hello John!
>
> John Kehayias john.kehayias <at> protonmail.com writes:
>
> > Hello,
> >
> > libostree should be built with libsoup-2 (doesn't support libsoup 3
> > currently) to have HTTP support. This was noticed due to Flatpak
> > updates failing with "This version of ostree was built without libsoup
> > or libcurl, and cannot fetch over HTTP". In the build log of ostree
> > (eg https://ci.guix.gnu.org/build/1775196/log/raw ) you can see that
> > it will report no HTTP backend with libsoup 3, but properly shows
> > libsoup when libsoup-2 is provided as an input as in this patch.
> >
> > I've checked libostree builds and that Flatpak built with this version
> > successfully can download over HTTP. Thanks to jackhill on IRC for
> > spotting the configuration error of ostree when we both hit the
> > Flatpak update bug.
>
> Neat, thanks for taking care of it. Pushed as
> 93d1f8e5fc78bd82e8920d25b3e52a2d22528c17, and I updated libostree to
> 4d41c3beefa44d0ec30aa7108bc3979aa95c15e0 in the following commit.
>
Great, and thanks for catching the update too!

> > (Also, I added my copyright line as I forgot it on earlier Flatpak
> > updates around the p11-kit workaround and version updates.)
>
> Perfect!
>

Thanks! Looks like we are closing in on that big merge finally!

John




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 22 Dec 2021 12:24:10 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 87 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.