GNU bug report logs - #52104
29.0.50; sometimes ispell-message does not check the Subject field

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52104 in the body.
You can then email your comments to 52104 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Peter Münster <pm <at> a16n.net>
To: Emacs Bugs <bug-gnu-emacs <at> gnu.org>
Subject: 29.0.50; sometimes ispell-message does not check the Subject field
Date: Thu, 25 Nov 2021 14:41:20 +0100

[Message part 1 (text/plain, inline)]

Hi,

ispell-message does not check Subject fields, when it finds a sequence
with "re ". And in French, there are a lot of words ending with "re"...

Please find attached a patch, that fixes the problem.

The "Re: " is hardcoded here, just as in message-reply.

Kind regards,
-- 
           Peter

[my.patch (text/x-patch, inline)]

commit 686bd0550797d0ec6225267914cef5cb0e5a61f6
Author: Peter Münster <pm <at> a16n.net>
Date:   Thu Nov 25 14:25:18 2021 +0100

    Fix spelling of subject line
    
    * lisp/textmodes/ispell.el (ispell-message): Only subjects starting with
    "Re: " are real replies.

diff --git a/lisp/textmodes/ispell.el b/lisp/textmodes/ispell.el
index 4087f7e5f2..ce8a82cda7 100644
--- a/lisp/textmodes/ispell.el
+++ b/lisp/textmodes/ispell.el
@@ -3977,7 +3977,7 @@ ispell-message
 	    (if (re-search-forward "^Subject: *" end-of-headers t)
 		(progn
 		  (goto-char (match-end 0))
-		  (if (and (not (looking-at ".*Re\\>"))
+		  (if (and (not (looking-at "Re: "))
 			   (not (looking-at "\\[")))
 		      (progn
 			(setq case-fold-search old-case-fold-search)

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 52104 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Peter Münster <pm <at> a16n.net>
Cc: 52104 <at> debbugs.gnu.org
Subject: Re: bug#52104: 29.0.50; sometimes ispell-message does not check the
 Subject field
Date: Mon, 29 Nov 2021 17:09:50 +0100

Peter Münster <pm <at> a16n.net> writes:

> ispell-message does not check Subject fields, when it finds a sequence
> with "re ". And in French, there are a lot of words ending with "re"...
>
> Please find attached a patch, that fixes the problem.
>
> The "Re: " is hardcoded here, just as in message-reply.

...

-		  (if (and (not (looking-at ".*Re\\>"))
+		  (if (and (not (looking-at "Re: "))

I think this is too strict -- there may not be a : after the Re, and
there is often some locale-specific mistranslation of Re somewhere.  So
I think the right fix here is ".*\\<Re\\>", which I've done in Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.