GNU bug report logs - #52105
comp-tests.el causes byte-compiler warnings

Previous Next

Package: emacs;

Reported by: Stephen Gildea <stepheng+emacs <at> gildea.com>

Date: Thu, 25 Nov 2021 14:11:03 UTC

Severity: normal

Tags: patch

Found in version 28.0.60

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52105 in the body.
You can then email your comments to 52105 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#52105; Package emacs. (Thu, 25 Nov 2021 14:11:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to Stephen Gildea <stepheng+emacs <at> gildea.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 25 Nov 2021 14:11:04 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stephen Gildea <stepheng+emacs <at> gildea.com>
To: submit <at> debbugs.gnu.org
Subject: comp-tests.el causes byte-compiler warnings
Date: Thu, 25 Nov 2021 06:10:15 -0800
[Message part 1 (text/plain, inline)]
Package: emacs
Version: 28.0.60
Tags: patch

The following small patch eliminates all the compile-time warnings
from comp-tests.el.

This patch is against the master branch, but since the patch changes only
test/, perhaps you would like me to re-work it for the emacs-28 branch.


[comp-tests-eliminate-compiler-warnings.patch (text/x-diff, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#52105; Package emacs. (Thu, 25 Nov 2021 16:59:01 GMT) Full text and rfc822 format available.

Message #8 received at 52105 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Stephen Gildea <stepheng+emacs <at> gildea.com>
Cc: 52105 <at> debbugs.gnu.org
Subject: Re: bug#52105: comp-tests.el causes byte-compiler warnings
Date: Thu, 25 Nov 2021 16:58:51 +0000
Stephen Gildea <stepheng+emacs <at> gildea.com> writes:

> Package: emacs
> Version: 28.0.60
> Tags: patch
>
> The following small patch eliminates all the compile-time warnings
> from comp-tests.el.
>
> This patch is against the master branch, but since the patch changes only
> test/, perhaps you would like me to re-work it for the emacs-28 branch.

Hi Stephen,

thanks for the patch, LGTM.

For the emacs-28 subject I let Eli or Lars speak.

Regards

  Andrea





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#52105; Package emacs. (Thu, 25 Nov 2021 18:22:01 GMT) Full text and rfc822 format available.

Message #11 received at 52105 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Andrea Corallo <akrl <at> sdf.org>
Cc: 52105 <at> debbugs.gnu.org, stepheng+emacs <at> gildea.com
Subject: Re: bug#52105: comp-tests.el causes byte-compiler warnings
Date: Thu, 25 Nov 2021 20:20:56 +0200
> From: Andrea Corallo <akrl <at> sdf.org>
> Date: Thu, 25 Nov 2021 16:58:51 +0000
> Cc: 52105 <at> debbugs.gnu.org
> 
> > The following small patch eliminates all the compile-time warnings
> > from comp-tests.el.
> >
> > This patch is against the master branch, but since the patch changes only
> > test/, perhaps you would like me to re-work it for the emacs-28 branch.
> 
> Hi Stephen,
> 
> thanks for the patch, LGTM.
> 
> For the emacs-28 subject I let Eli or Lars speak.

I see no reason to install this on the release branch.  Master is
good enough, IMO.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#52105; Package emacs. (Mon, 29 Nov 2021 16:06:02 GMT) Full text and rfc822 format available.

Message #14 received at 52105 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: stepheng+emacs <at> gildea.com, 52105 <at> debbugs.gnu.org,
 Andrea Corallo <akrl <at> sdf.org>
Subject: Re: bug#52105: comp-tests.el causes byte-compiler warnings
Date: Mon, 29 Nov 2021 17:04:59 +0100
Eli Zaretskii <eliz <at> gnu.org> writes:

> I see no reason to install this on the release branch.  Master is
> good enough, IMO.

And it seems like the patch was pushed, but the bug report was left
open, so I'm closing it now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




bug marked as fixed in version 29.1, send any further explanations to 52105 <at> debbugs.gnu.org and Stephen Gildea <stepheng+emacs <at> gildea.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Mon, 29 Nov 2021 16:06:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 28 Dec 2021 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 81 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.