GNU bug report logs - #52113
[PATCH] gnu: Add pnmixer

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52113 in the body.
You can then email your comments to 52113 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jaft <jaft.r <at> outlook.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add pnmixer
Date: Thu, 25 Nov 2021 19:48:08 +0000 (UTC)

* gnu/packages/gtk.scm (pnmixer):Add PNMixer
---
gnu/packages/gtk.scm | 39 +++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index 4e427deaef..782dfebdb2 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -27,6 +27,7 @@
 ;;; Copyright © 2020 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
 ;;; Copyright © 2021 Leo Famulari <leo <at> famulari.name>
 ;;; Copyright © 2021 Simon Streit <simon <at> netpanic.org>
+;;; Copyright © 2021 Wamm K. D. <jaft.r <at> outlook.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -50,6 +51,7 @@ (define-module (gnu packages gtk)
   #:use-module (guix download)
   #:use-module (guix git-download)
   #:use-module ((guix build utils) #:select (alist-replace))
+  #:use-module (guix build-system cmake)
   #:use-module (guix build-system glib-or-gtk)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system meson)
@@ -2474,3 +2476,40 @@ (define-public volctl
     ;; XXX: 'setup.py' says "GPLv2" but nothing says "version 2 only".  Is
     ;; GPLv2+ intended?
     (license license:gpl2)))
+
+(define-public pnmixer
+  (let ([version "0.7.2"])
+    (package
+      (name "pnmixer")
+      (version version)
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/nicklan/pnmixer/")
+                      (commit (string-append "v" version))))
+                (file-name (git-file-name name version))
+                (sha256 (base32
+                         "0416pa933ddf4b7ph9zxhk5jppkk7ppcq1aqph6xsrfnka4yb148"))
+                (modules '((guix build utils)))))
+    (build-system cmake-build-system)
+    (arguments `(#:phases (modify-phases %standard-phases (delete 'check))))
+    (native-inputs `(("pkg-config" ,pkg-config)
+                     ("gettext" ,gettext-minimal)))
+    (inputs `(("alsa-lib" ,alsa-lib)
+              ("glib" ,glib)
+              ("libx11" ,libx11)
+              ("gtk+" ,gtk+)
+              ("libnotify" ,libnotify)))
+    (home-page "https://github.com/nicklan/pnmixer/")
+    (synopsis "Simple mixer application designed to run in your system tray")
+    (description "PNMixer is a simple mixer application designed to run in your
+system tray.  It integrates nicely into desktop environments that don't have a
+panel that supports applets and therefore can't run a mixer applet.  In
+particular, it's been used quite a lot with fbpanel and tint2 but should run
+fine in any system tray.
+
+PNMixer is designed to work on systems that use ALSA for sound management.  Any
+other sound driver like OSS or FFADO are, currently, not supported.  There is no
+official PulseAudio support, at the moment, but it seems that PNMixer behaves
+quite well anyway when PA is running.")
+    (license license:gpl3))))

Message #8 received at 52113 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Jaft <jaft.r <at> outlook.com>
Cc: 52113 <at> debbugs.gnu.org
Subject: Re: [bug#52113] [PATCH] gnu: Add pnmixer
Date: Sun, 05 Dec 2021 21:43:20 +0100

Hello,

Jaft <jaft.r <at> outlook.com> writes:

> * gnu/packages/gtk.scm (pnmixer):Add PNMixer

Thank you. Some comments follow.

> +(define-public pnmixer
> +  (let ([version "0.7.2"])

Nitpick: we don't use square brackets for let. Besides, you do not need
a binding here, you just need to hard-code it in the version field.

> +    (package
> +      (name "pnmixer")
> +      (version version)
> +      (source (origin

Could you move origin below source?

> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/nicklan/pnmixer/")
> +                      (commit (string-append "v" version))))
> +                (file-name (git-file-name name version))
> +                (sha256 (base32
> +                         "0416pa933ddf4b7ph9zxhk5jppkk7ppcq1aqph6xsrfnka4yb148"))

Could you move base32 below sha256 and put the hash string in front of base32?

> +                (modules '((guix build utils)))))

The modules part is not required. You can remove it.

> +    (build-system cmake-build-system)
> +    (arguments `(#:phases (modify-phases %standard-phases (delete 'check))))

The correct way to do this is to add a "#:tests? #f" argument, with
a comment explaining why you are disabling tests.

> +    (native-inputs `(("pkg-config" ,pkg-config)
> +                     ("gettext" ,gettext-minimal)))

Native inputs should be ordered alphabetically. Besides, the list should
be moved on the line below native-inputs.

> +    (inputs `(("alsa-lib" ,alsa-lib)
> +              ("glib" ,glib)
> +              ("libx11" ,libx11)
> +              ("gtk+" ,gtk+)
> +              ("libnotify" ,libnotify)))

Ditto: please order inputs alphabetically and move them below the inputs
field name.

> +    (home-page "https://github.com/nicklan/pnmixer/")
> +    (synopsis "Simple mixer application designed to run in your system tray")

Nitpick: you can remove "your" in the synopsis

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Message #11 received at 52113 <at> debbugs.gnu.org (full text, mbox):

From: Jaft <jaft.r <at> outlook.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: "52113 <at> debbugs.gnu.org" <52113 <at> debbugs.gnu.org>
Subject: Re: [bug#52113] [PATCH] gnu: Add pnmixer
Date: Thu, 16 Dec 2021 21:40:09 +0000 (UTC)

[Message part 1 (text/plain, inline)]

> On Sunday, December 5, 2021, 02:43:27 PM CST, Nicolas Goaziou <mail <at> nicolasgoaziou.fr> wrote: 
>
>
>
>
>
> Hello,
>
> Jaft <jaft.r <at> outlook.com> writes:
> 
> > * gnu/packages/gtk.scm (pnmixer):Add PNMixer
>
> Thank you. Some comments follow.
>
> > +(define-public pnmixer
> > +  (let ([version "0.7.2"])
>
> Nitpick: we don't use square brackets for let. Besides, you do not need
> a binding here, you just need to hard-code it in the version field.

Bah; sorry about that. It was mentioned to me, before, and I must've forgotten to change it before I sent this out. I probably should check my other patch submissions around this time as I probably forgot for those, as well…

> Could you send an updated patch?
>
> Regards,
> -- 
> Nicolas Goaziou

Thanks a ton for looking at my patch; all updates should've been applied and I've attached the new patch to this E-mail.

[pnmixer2.patch (text/x-patch, attachment)]

Message #16 received at 52113-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Jaft <jaft.r <at> outlook.com>
Cc: "52113-done <at> debbugs.gnu.org" <52113-done <at> debbugs.gnu.org>
Subject: Re: [bug#52113] [PATCH] gnu: Add pnmixer
Date: Fri, 17 Dec 2021 09:06:50 +0100

Hello,

Jaft <jaft.r <at> outlook.com> writes:

> Thanks a ton for looking at my patch; all updates should've been
> applied and I've attached the new patch to this E-mail.

Thanks.

I completed the commit message, used new inputs style, and applied your
patch.

Regards,
-- 
Nicolas Goaziou

Message #19 received at 52113-done <at> debbugs.gnu.org (full text, mbox):

From: Jaft <jaft.r <at> outlook.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: "52113-done <at> debbugs.gnu.org" <52113-done <at> debbugs.gnu.org>
Subject: Re: [bug#52113] [PATCH] gnu: Add pnmixer
Date: Fri, 17 Dec 2021 10:34:22 +0000 (UTC)

Awesome; thanks so much, Nicolas!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.