X-Loop: help-debbugs@HIDDEN Subject: bug#52137: committer.scm wrong type passed to car Resent-From: Jack Hill <jackhill@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-guix@HIDDEN Resent-Date: Sat, 27 Nov 2021 06:42:02 +0000 Resent-Message-ID: <handler.52137.B.163799528712177 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: report 52137 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 52137 <at> debbugs.gnu.org Cc: Ricardo Wurmus <rekado@HIDDEN> X-Debbugs-Original-To: bug-guix@HIDDEN Received: via spool by submit <at> debbugs.gnu.org id=B.163799528712177 (code B ref -1); Sat, 27 Nov 2021 06:42:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Nov 2021 06:41:27 +0000 Received: from localhost ([127.0.0.1]:32784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mqrOo-0003AL-SD for submit <at> debbugs.gnu.org; Sat, 27 Nov 2021 01:41:27 -0500 Received: from lists.gnu.org ([209.51.188.17]:49388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <jackhill@HIDDEN>) id 1mqrOn-0003AE-IJ for submit <at> debbugs.gnu.org; Sat, 27 Nov 2021 01:41:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45158) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <jackhill@HIDDEN>) id 1mqrOm-0002H5-Bn for bug-guix@HIDDEN; Sat, 27 Nov 2021 01:41:24 -0500 Received: from minsky.hcoop.net ([104.248.1.95]:40422) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <jackhill@HIDDEN>) id 1mqrOk-00057o-7A for bug-guix@HIDDEN; Sat, 27 Nov 2021 01:41:23 -0500 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <jackhill@HIDDEN>) id 1mqrOj-0001LW-24; Sat, 27 Nov 2021 01:41:21 -0500 Date: Sat, 27 Nov 2021 01:41:20 -0500 (EST) From: Jack Hill <jackhill@HIDDEN> X-X-Sender: jackhill@HIDDEN Message-ID: <alpine.DEB.2.21.2111270133030.13935@HIDDEN> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="925712948-877446296-1637995281=:13935" Received-SPF: pass client-ip=104.248.1.95; envelope-from=jackhill@HIDDEN; helo=minsky.hcoop.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.4 (--) This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --925712948-877446296-1637995281=:13935 Content-Type: text/plain; format=flowed; charset=UTF-8 Content-Transfer-Encoding: 8BIT Hi Guix and Ricardo, Running the etc/commiter.scm script with the diff of a patch that I recently submitted [0] results in the backtrace below. This might be because I was holding the script wrong, but it would be nice to provide a more friendly message for people like me who don't remember how to use it properly. [0] https://issues.guix.gnu.org/52134#1 jackhill@leyden ~/repos/guix [env]$ git status On branch committer-test Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git restore <file>..." to discard changes in working directory) modified: gnu/packages/web-browsers.scm no changes added to commit (use "git add" and/or "git commit -a") jackhill@leyden ~/repos/guix [env]$ git diff diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm index 7ea2a9a9ec..50a41309d3 100644 --- a/gnu/packages/web-browsers.scm +++ b/gnu/packages/web-browsers.scm @@ -51,6 +51,7 @@ (define-module (gnu packages web-browsers) #:use-module (gnu packages) #:use-module (gnu packages autotools) #:use-module (gnu packages backup) + #:use-module (gnu packages base) #:use-module (gnu packages bison) #:use-module (gnu packages compression) #:use-module (gnu packages curl) @@ -125,10 +126,12 @@ (define-public midori (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap))))) (native-inputs - `(("glib:bin" ,glib "bin") + `(("desktop-file-utils" ,desktop-file-utils) ;for tests + ("glib:bin" ,glib "bin") ("gtk+:bin" ,gtk+ "bin") ("intltool" ,intltool) - ("pkg-config" ,pkg-config))) + ("pkg-config" ,pkg-config) + ("which" ,which))) ;for tests (inputs `(("adwaita-icon-theme" ,adwaita-icon-theme) ("gcr" ,gcr) @@ -139,10 +142,9 @@ (define-public midori ("json-glib" ,json-glib) ("libarchive" ,libarchive) ("libpeas" ,libpeas) - ("libsoup" ,libsoup) ("sqlite" ,sqlite) ("vala" ,vala) - ("webkitgtk" ,webkitgtk))) + ("webkitgtk" ,webkitgtk-with-libsoup2))) (synopsis "Lightweight graphical web browser") (description "@code{Midori} is a lightweight, Webkit-based web browser. It features integration with GTK+3, configurable web search engine, bookmark jackhill@leyden ~/repos/guix [env]$ ./etc/committer.scm Backtrace: 5 (primitive-load "/home/jackhill/repos/guix/./etc/commit…") In srfi/srfi-1.scm: 634:9 4 (for-each #<procedure 7fefd554e4c0 at ice-9/eval.scm:3…> …) In ice-9/eval.scm: 619:8 3 (_ #(#(#(#(#(#(#(#(#(#(#(…) …) …) …) …) …) …) …) …) …) …)) 619:8 2 (_ #(#(#(#<directory (guile-user) 7fefd7cbbc80>) # …) …)) 626:19 1 (_ #(#(#(#<directory (guile-user) 7fefd7cbbc80>) # …) …)) In unknown file: 0 (car ()) ERROR: In procedure car: In procedure car: Wrong type (expecting pair): () Aborting commit due to empty commit message. --925712948-877446296-1637995281=:13935--
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Jack Hill <jackhill@HIDDEN> Subject: bug#52137: Acknowledgement (committer.scm wrong type passed to car) Message-ID: <handler.52137.B.163799528712177.ack <at> debbugs.gnu.org> References: <alpine.DEB.2.21.2111270133030.13935@HIDDEN> X-Gnu-PR-Message: ack 52137 X-Gnu-PR-Package: guix Reply-To: 52137 <at> debbugs.gnu.org Date: Sat, 27 Nov 2021 06:42:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-guix@HIDDEN If you wish to submit further information on this problem, please send it to 52137 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 52137: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D52137 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN Subject: bug#52137: committer.scm wrong type passed to car Resent-From: Ricardo Wurmus <rekado@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-guix@HIDDEN Resent-Date: Sat, 27 Nov 2021 08:51:02 +0000 Resent-Message-ID: <handler.52137.B.16380030571694 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 52137 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Jack Hill <jackhill@HIDDEN> Cc: 52137 <at> debbugs.gnu.org X-Debbugs-Original-Cc: bug-guix@HIDDEN Received: via spool by submit <at> debbugs.gnu.org id=B.16380030571694 (code B ref -1); Sat, 27 Nov 2021 08:51:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Nov 2021 08:50:57 +0000 Received: from localhost ([127.0.0.1]:32894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mqtQ8-0000RG-Nc for submit <at> debbugs.gnu.org; Sat, 27 Nov 2021 03:50:56 -0500 Received: from lists.gnu.org ([209.51.188.17]:46334) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <rekado@HIDDEN>) id 1mqtQ6-0000R8-Fe for submit <at> debbugs.gnu.org; Sat, 27 Nov 2021 03:50:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <rekado@HIDDEN>) id 1mqtQ6-0004Ee-8F for bug-guix@HIDDEN; Sat, 27 Nov 2021 03:50:54 -0500 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21105) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <rekado@HIDDEN>) id 1mqtQ4-00032g-AU for bug-guix@HIDDEN; Sat, 27 Nov 2021 03:50:53 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1638003048; cv=none; d=zohomail.com; s=zohoarc; b=ZYOLG9sjmKxAO6TaoAzrs/yetEZYs3M+cAt1JstT5MYj/SY4hgW6Pw/UfT0g1MNApCX+X0kfJBcZxaKc9tWJdnHg7qUknehseyF/3WCTcgXIqWnjfq5cuQkwIi2ZTQau3htqhkYLi1hxLeFN5uptCOIgSn+pqeZjG0hm9EBNTpE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1638003048; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Met9r35KB090xkpqlBccFxNtYMukaigCsKBRWB3suzc=; b=EqHDiK2zZjOOK1jXKi54vVN6F9iWCUQSaMT8wDLZiHJNO7Ys9DqpP1j1cIDAKcJohhOep18AsVNenftze254+Wu1YvZ3QpGS2hJu4qX45/wjtzhVHVfWj3DVqngUT5peaFurMtytmcjf3FKp3e+z3KmhoqX+vglySEXb20Mh9Q4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@HIDDEN; dmarc=pass header.from=<rekado@HIDDEN> DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1638003048; s=zoho; d=elephly.net; i=rekado@HIDDEN; h=References:From:To:Cc:Subject:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=Met9r35KB090xkpqlBccFxNtYMukaigCsKBRWB3suzc=; b=K17Icw0++YkPjbrbKOGajfrQU5gqfTcb/Y9sLDaPE9L5uYSVVLLydIm6mmh1Ij54 H8fyY5mQ1BJFrpL5tHjArYFplYOnHkkHvH8SNVTm0KaUHObhr80o6AaxolxahPTUcvl KYi/tHeQpL9wFmiGaBJnkmFFyWz8akUcixl1xCX8= Received: from localhost (p4fd5a75b.dip0.t-ipconnect.de [79.213.167.91]) by mx.zohomail.com with SMTPS id 1638003043641244.82142285938676; Sat, 27 Nov 2021 00:50:43 -0800 (PST) References: <alpine.DEB.2.21.2111270133030.13935@HIDDEN> User-agent: mu4e 1.6.10; emacs 28.0.50 From: Ricardo Wurmus <rekado@HIDDEN> Date: Sat, 27 Nov 2021 09:48:42 +0100 In-reply-to: <alpine.DEB.2.21.2111270133030.13935@HIDDEN> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Message-ID: <87r1b2oucg.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.188.51; envelope-from=rekado@HIDDEN; helo=sender4-of-o51.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) Hi Jack, > Running the etc/commiter.scm script with the diff of a patch=20 > that I > recently submitted [0] results in the backtrace below. This=20 > might be > because I was holding the script wrong, but it would be nice to > provide a more friendly message for people like me who don't=20 > remember > how to use it properly. Thanks for the report! It=E2=80=99s probably the change in the module header. When I first wrote= =20 committer.scm I intended to use it to automate simple package=20 updates (for mass updates of CRAN packages). That never required=20 changes to the module header. I=E2=80=99m sure this can be fixed by=20 merely ignoring changes to that form. --=20 Ricardo
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.