GNU bug report logs -
#52198
[core-updates-frozen] [PATCH] gnu: ghc: Fix build on i686-linux.
Previous Next
Reported by: zimoun <zimon.toutoune <at> gmail.com>
Date: Tue, 30 Nov 2021 11:15:02 UTC
Severity: normal
Tags: patch
Done: Lars-Dominik Braun <lars <at> 6xq.net>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52198 in the body.
You can then email your comments to 52198 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
lars <at> 6xq.net, guix-patches <at> gnu.org
:
bug#52198
; Package
guix-patches
.
(Tue, 30 Nov 2021 11:15:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
zimoun <zimon.toutoune <at> gmail.com>
:
New bug report received and forwarded. Copy sent to
lars <at> 6xq.net, guix-patches <at> gnu.org
.
(Tue, 30 Nov 2021 11:15:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/haskell.scm (ghc-8.10)[arguments]<#:phases>: Fix failing test.
---
gnu/packages/haskell.scm | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
index 69a806e635..d3db023f08 100644
--- a/gnu/packages/haskell.scm
+++ b/gnu/packages/haskell.scm
@@ -22,6 +22,7 @@
;;; Copyright © 2020 Marius Bakke <mbakke <at> fastmail.com>
;;; Copyright © 2021 Matthew James Kraai <kraai <at> ftbfs.org>
;;; Copyright © 2021 Xinglu Chen <public <at> yoctocell.xyz>
+;;; Copyright © 2021 Simon Tournier <zimon.toutoune <at> gmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -711,12 +712,18 @@ (define-public ghc-8.10
(("\\]\\), " all)
(string-append all "expect_broken(0)], ")))))
;; TODO: Turn this into an undconditional patch on the next rebuild.
- ,@(if (string=? "i686-linux" (%current-system))
+ ,@(if (string-prefix? "i686" (or (%current-target-system)
+ (%current-system)))
'((add-after 'skip-more-tests 'skip-failing-tests-i686
(lambda _
(substitute* '("testsuite/tests/codeGen/should_compile/all.T")
(("(test\\('T15155l', )when\\(unregisterised\\(\\), skip\\)" all before)
- (string-append before "when(arch('i386'), skip)"))))))
+ (string-append before "when(arch('i386'), skip)")))
+ ;; Unexpected failures:
+ ;; quasiquotation/T14028.run T14028 [bad stderr] (dyn)
+ (substitute* '("testsuite/tests/quasiquotation/all.T")
+ (("unless\\(config.have_ext_interp, skip\\),")
+ "unless(config.have_ext_interp, skip), when(arch('i386'), skip),")))))
'())))))
(native-search-paths (list (search-path-specification
(variable "GHC_PACKAGE_PATH")
base-commit: f22dfba53032c59fb260173143abf0e4e9a4f1e1
--
2.33.1
Changed bug title to '[core-updates-frozen] [PATCH] gnu: ghc: Fix build on i686-linux.' from '[PATCH] gnu: ghc: Fix build on i686-linux.'
Request was from
zimoun <zimon.toutoune <at> gmail.com>
to
control <at> debbugs.gnu.org
.
(Tue, 30 Nov 2021 15:51:01 GMT)
Full text and
rfc822 format available.
Reply sent
to
Lars-Dominik Braun <lars <at> 6xq.net>
:
You have taken responsibility.
(Tue, 30 Nov 2021 15:58:01 GMT)
Full text and
rfc822 format available.
Notification sent
to
zimoun <zimon.toutoune <at> gmail.com>
:
bug acknowledged by developer.
(Tue, 30 Nov 2021 15:58:02 GMT)
Full text and
rfc822 format available.
Message #12 received at 52198-done <at> debbugs.gnu.org (full text, mbox):
Hi zimoun,
I locally built ghc <at> 8.10 and this test indeed fails without/succeeds
with the patch. There’s also an issue over at the GHC tracker
about this failure, so I’m assuming it’s safe to skip:
https://gitlab.haskell.org/ghc/ghc/-/issues/17300
I pushed this patch to core-updates-frozen as
afc4945d44aeb6750b980abddbfda66f6ccb6b18. Thank you!
Cheers,
Lars
Information forwarded
to
guix-patches <at> gnu.org
:
bug#52198
; Package
guix-patches
.
(Tue, 30 Nov 2021 16:04:02 GMT)
Full text and
rfc822 format available.
Message #15 received at 52198-done <at> debbugs.gnu.org (full text, mbox):
Hi Lars,
On Tue, 30 Nov 2021 at 16:57, Lars-Dominik Braun <lars <at> 6xq.net> wrote:
> I locally built ghc <at> 8.10 and this test indeed fails without/succeeds
> with the patch. There’s also an issue over at the GHC tracker
> about this failure, so I’m assuming it’s safe to skip:
> https://gitlab.haskell.org/ghc/ghc/-/issues/17300
I have compiled some ghc-* packages for i686 in order to check and
until now, everything is ok. Let the CI rebuild everything and then
fix case per case; hoping this failing test about 'quasiquotation'
would not lead to reveal breakage of leaves.
> I pushed this patch to core-updates-frozen as
> afc4945d44aeb6750b980abddbfda66f6ccb6b18. Thank you!
Thanks.
Cheers,
simon
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Wed, 29 Dec 2021 12:24:11 GMT)
Full text and
rfc822 format available.
This bug report was last modified 2 years and 80 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.