GNU bug report logs - #52200
29.0.50; image-dired-cmd-create-standard-thumbnail-options

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Peter Münster <pm@HIDDEN>; dated Tue, 30 Nov 2021 16:25:01 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 52200 <at> debbugs.gnu.org:


Received: (at 52200) by debbugs.gnu.org; 14 Jan 2022 07:59:54 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 14 02:59:54 2022
Received: from localhost ([127.0.0.1]:35367 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1n8HV4-0001ai-9S
	for submit <at> debbugs.gnu.org; Fri, 14 Jan 2022 02:59:54 -0500
Received: from server.a16n.net ([178.33.238.77]:37434)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <pm@HIDDEN>) id 1n8HV2-0001aM-9E
 for 52200 <at> debbugs.gnu.org; Fri, 14 Jan 2022 02:59:52 -0500
Received: from ws.localdomain (arennes-658-1-128-154.w90-32.abo.wanadoo.fr
 [90.32.1.154])
 by server.a16n.net (Postfix) with ESMTPSA id BA82243E05EF;
 Fri, 14 Jan 2022 08:59:44 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=a16n.net; s=a16n;
 t=1642147184; bh=NhmnGUhBxRNiUngL0a6Ec8oiJVhbsQa7+s/ntqv1Bvc=;
 h=From:To:Cc:Subject:References:Date:In-Reply-To;
 b=fK+yc7zdZbTGzeX3dXRNvJn73ydIOcPZZwiul4/GmZCbVmXZKtFhEBENO1mouofDA
 p66S4pfMs0wyQMNC6Vwm2mMCO76bg+4zi3BIKNcLuWqMQXOxnhwcN/UIgbqpJ4RGKb
 f6z6dN2uYkR2OPmvvMo/jgMvq9lIMmFsORgUVxaPi5sB7pG7MNVRutf3K1FEjjw9T+
 iz1gt+Rwo7X/H2VCO3RkB+SWG8qBkqdw4v5AKy97oKh1o7w+9/g5nIcjtWZ6BWRr7q
 THvYF+RQyQofPem3Le1ZoWeApelNBGHlnq7GOyvCOgso3+mMq2sf5xCnKPc9RoklxH
 8s194CkwlLVsg==
Received: by ws.localdomain (Postfix, from userid 1000)
 id 51DCB20560; Fri, 14 Jan 2022 08:59:44 +0100 (CET)
From: =?utf-8?Q?Peter_M=C3=BCnster?= <pm@HIDDEN>
To: Stefan Kangas <stefan@HIDDEN>
Subject: Re: bug#52200: 29.0.50;
 image-dired-cmd-create-standard-thumbnail-options
References: <87o861k3x9.fsf@HIDDEN>
 <CADwFkmnr-8nNYAjkCPhgURG0xCAjCdn=Dkg33oc8J43WYiQu=A@HIDDEN>
Date: Fri, 14 Jan 2022 08:59:44 +0100
In-Reply-To: <CADwFkmnr-8nNYAjkCPhgURG0xCAjCdn=Dkg33oc8J43WYiQu=A@HIDDEN>
 (Stefan Kangas's message of "Wed, 8 Dec 2021 18:01:50 -0800")
Message-ID: <87sftq4uj3.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha1; protocol="application/pgp-signature"
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 52200
Cc: 52200 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 08 2021, Stefan Kangas wrote:

> Perhaps we could make this unconditional, but then what should we do
> about `image-dired-cmd-pngcrush-options'?  Should the options be removed
> from there?

I don't know...


>> - If gm is used, then the "convert" command should be added.
>
> Yes, I think you are right.

Ok, could you add this part of the patch then please?

TIA,
=2D-=20
           Peter

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iGoEARECACoWIQS/5hHRBUjla4uZVXU6jitvQ7HLaAUCYeEtcAwccG1AYTE2bi5u
ZXQACgkQOo4rb0Oxy2i/+gCeNpjR/1hoJUQNVOSUVHmMh06R/FIAn01nj6DhVyrz
HX/EscYkwtGIkhHm
=1uWT
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#52200; Package emacs. Full text available.

Message received at 52200 <at> debbugs.gnu.org:


Received: (at 52200) by debbugs.gnu.org; 9 Dec 2021 02:01:58 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 08 21:01:58 2021
Received: from localhost ([127.0.0.1]:41973 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mv8kw-0003qM-J5
	for submit <at> debbugs.gnu.org; Wed, 08 Dec 2021 21:01:58 -0500
Received: from mail-pg1-f178.google.com ([209.85.215.178]:38858)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1mv8ku-0003q7-K6
 for 52200 <at> debbugs.gnu.org; Wed, 08 Dec 2021 21:01:57 -0500
Received: by mail-pg1-f178.google.com with SMTP id s137so3701907pgs.5
 for <52200 <at> debbugs.gnu.org>; Wed, 08 Dec 2021 18:01:56 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:in-reply-to:references:user-agent
 :mime-version:date:message-id:subject:to:cc
 :content-transfer-encoding;
 bh=hx5FWoh6n6lcio0yf2uidLCh1iDFAgKeed0vml538ec=;
 b=akCKo2K6j3ZqpXNBneQ5KPWQrTFRqDy5fxeNCOXqDBvio3qFBBVYDlsBnCJCxNVEqe
 //hfzH0m970W8jHgwN2CqvnCO6qgGBV//r7E2Fx5SSxjSxMRtFq11VjiWnoCqrhFd6I+
 6hS1NA7TDWkPh13xpCuL/HhG8eTCEJMqMCG7O8DH30wBJEayNVHyFGa5pLzik3dHevXh
 8j6flKHaysba0YSqlTupvp/LFp47TxjcnFnmGV/5RXGyelKuZv1kjgx61I+Givjx9pRl
 X1ZU8Q7u6Y3ffLMmB/QqeQhdid0epSrv3iVonZgZbULIO8AerYVKzcxrNBvHn3gLm9hV
 00nQ==
X-Gm-Message-State: AOAM53255O07OCrM/HMDf1ma60jJ2QviFyjBCGijiQmLwSpcf7khnsed
 fsOjidApPkzJqXNKJKq5M1PF5Osxy9aF1v52clntF2JJ
X-Google-Smtp-Source: ABdhPJwUnkXS5ZDyebNyyl9E09qanONwBziWQZDyN5cunvYcZ5LkuQ4Slls7XKMxcbBczBUTqNu1sjAESsqir6hL/5E=
X-Received: by 2002:aa7:8283:0:b0:49f:a0d0:abcf with SMTP id
 s3-20020aa78283000000b0049fa0d0abcfmr9081575pfm.70.1639015310656; Wed, 08 Dec
 2021 18:01:50 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Wed, 8 Dec 2021 18:01:50 -0800
From: Stefan Kangas <stefan@HIDDEN>
In-Reply-To: =?UTF-8?B?PDg3bzg2MWszeDkuZnNmQGExNm4ubmV0PiAoIlBldGVyIE3DvG5zdGVyIidzIG1l?=
 =?UTF-8?B?c3NhZ2Ugb2YgIlR1ZSwgMzAgTm92IDIwMjEgMTc6MjQ6MDIgKzAxMDAiKQ==?=
References: <87o861k3x9.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Date: Wed, 8 Dec 2021 18:01:50 -0800
Message-ID: <CADwFkmnr-8nNYAjkCPhgURG0xCAjCdn=Dkg33oc8J43WYiQu=A@HIDDEN>
Subject: Re: bug#52200: 29.0.50;
 image-dired-cmd-create-standard-thumbnail-options
To: =?UTF-8?Q?Peter_M=C3=BCnster?= <pm@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.5 (/)
X-Debbugs-Envelope-To: 52200
Cc: 52200 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

Peter M=C3=BCnster <pm@HIDDEN> writes:

> I'm a bit confused about
> image-dired-cmd-create-standard-thumbnail-options:
>
> - It seems, that it's not used with pngcrush or pngnq, so this test is
>   perhaps useless:
>   (unless (or image-dired-cmd-pngcrush-program
>               image-dired-cmd-pngnq-program) ...

I think the intention is that we shouldn't insert those text fields
twice.  See the removed code in commit 36b9973dec65 and also
`image-dired-cmd-pngcrush-options'.

Perhaps we could make this unconditional, but then what should we do
about `image-dired-cmd-pngcrush-options'?  Should the options be removed
from there?

> - If gm is used, then the "convert" command should be added.

Yes, I think you are right.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#52200; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 30 Nov 2021 16:24:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 30 11:24:15 2021
Received: from localhost ([127.0.0.1]:42236 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ms5vP-00039j-PG
	for submit <at> debbugs.gnu.org; Tue, 30 Nov 2021 11:24:15 -0500
Received: from lists.gnu.org ([209.51.188.17]:56886)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <pm@HIDDEN>) id 1ms5vO-00039a-W4
 for submit <at> debbugs.gnu.org; Tue, 30 Nov 2021 11:24:11 -0500
Received: from eggs.gnu.org ([209.51.188.92]:44956)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <pm@HIDDEN>) id 1ms5vO-0002MU-3s
 for bug-gnu-emacs@HIDDEN; Tue, 30 Nov 2021 11:24:10 -0500
Received: from server.a16n.net ([178.33.238.77]:38618)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <pm@HIDDEN>) id 1ms5vL-00022n-5r
 for bug-gnu-emacs@HIDDEN; Tue, 30 Nov 2021 11:24:08 -0500
Received: from ws.localdomain (lfbn-ren-1-2050-95.w92-167.abo.wanadoo.fr
 [92.167.129.95])
 by server.a16n.net (Postfix) with ESMTPSA id BFBA943E0536
 for <bug-gnu-emacs@HIDDEN>; Tue, 30 Nov 2021 17:24:03 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=a16n.net; s=a16n;
 t=1638289443; bh=a74GUQD/8xq8gufI8RNRDfctK4KONc2BXVrnBbVPNio=;
 h=From:To:Subject:Date;
 b=VDB1fMeOT8SyLGClKTodLpEEJUrzFHLdSq70TnFp02fAKfP9Fb5F6qlnXY3viTznL
 FMYW3qZ4qPbNzwiXkvDEu4dLGAGwPMiU05bZ8xriA78Sv3j5xdZaXZU+ny+5BdnmG2
 vODNvh1MFkOPl/hXpazDNMLke9UiJObEd1QV5p0/wpnT2aNfhhQmqMdJ3RZeEhmgVs
 DRzyQfgsMO7gwGZRoEhAH6qHcKYh4r0k5dkDm28l7iU/LtXeSbZ/Ei781hxSOIuTKK
 Q7P+roOk9FX5fpv2+zjjtkqEzkDUNLf2VbOuefl8HqIUdWHI6vf/Rc/cPFodlwdn6Q
 y8juzMu9xPQSQ==
Received: by ws.localdomain (Postfix, from userid 1000)
 id 1EF9A20547; Tue, 30 Nov 2021 17:24:03 +0100 (CET)
From: =?utf-8?Q?Peter_M=C3=BCnster?= <pm@HIDDEN>
To: Emacs Bugs <bug-gnu-emacs@HIDDEN>
Subject: 29.0.50; image-dired-cmd-create-standard-thumbnail-options
Date: Tue, 30 Nov 2021 17:24:02 +0100
Message-ID: <87o861k3x9.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="==-=-=";
 micalg=pgp-sha1; protocol="application/pgp-signature"
Received-SPF: pass client-ip=178.33.238.77; envelope-from=pm@HIDDEN;
 helo=server.a16n.net
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

--==-=-=
Content-Type: multipart/mixed; boundary="=-=-="

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

I'm a bit confused about
image-dired-cmd-create-standard-thumbnail-options:

=2D It seems, that it's not used with pngcrush or pngnq, so this test is
  perhaps useless:
  (unless (or image-dired-cmd-pngcrush-program
              image-dired-cmd-pngnq-program) ...
=2D If gm is used, then the "convert" command should be added.

The attached patch works for me, but probably I'm missing something...

=2D-=20
           Peter

--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline; filename=my.patch
Content-Transfer-Encoding: quoted-printable

diff --git a/lisp/image-dired.el b/lisp/image-dired.el
index 47a44a4a60..159f6a3b97 100644
=2D-- a/lisp/image-dired.el
+++ b/lisp/image-dired.el
@@ -302,19 +302,17 @@ image-dired-cmd-optipng-options
   :link '(url-link "man:optipng(1)"))
=20
 (defcustom image-dired-cmd-create-standard-thumbnail-options
=2D  (append '("-size" "%wx%h" "%f[0]")
=2D          (unless (or image-dired-cmd-pngcrush-program
=2D                      image-dired-cmd-pngnq-program)
=2D            (list
=2D             "-set" "Thumb::MTime" "%m"
=2D             "-set" "Thumb::URI" "file://%f"
=2D             "-set" "Description" "Thumbnail of file://%f"
=2D             "-set" "Software" (emacs-version)))
=2D          '("-thumbnail" "%wx%h>" "png:%t"))
+  (let ((opts (list "-size" "%wx%h" "%f[0]"
+              "-set" "Thumb::MTime" "%m"
+              "-set" "Thumb::URI" "file://%f"
+              "-set" "Description" "Thumbnail of file://%f"
+              "-set" "Software" (emacs-version)
+              "-thumbnail" "%wx%h>" "png:%t")))
+      (if (executable-find "gm") (cons "convert" opts) opts))
   "Options for creating thumbnails according to the Thumbnail Managing Sta=
ndard.
 Available format specifiers are the same as in
 `image-dired-cmd-create-thumbnail-options', with %m for file modification =
time."
=2D  :version "26.1"
+  :version "29.1"
   :type '(repeat (string :tag "Argument")))
=20
 (defcustom image-dired-cmd-rotate-original-program

--=-=-=--

--==-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iGoEARECACoWIQS/5hHRBUjla4uZVXU6jitvQ7HLaAUCYaZQIgwccG1AYTE2bi5u
ZXQACgkQOo4rb0Oxy2g4GACbBStorLQ/zxyHPFpZdkjW1aDSAoEAn3X++siPtEzP
I76O0ZvUyqCs8pQN
=2B5B
-----END PGP SIGNATURE-----
--==-=-=--




Acknowledgement sent to Peter Münster <pm@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#52200; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Fri, 14 Jan 2022 08:15:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.