GNU bug report logs - #52260
Fix compilation error in feature/pgtk branch

Previous Next

Package: emacs;

Reported by: Koen van Greevenbroek <koen_devel <at> posteo.net>

Date: Fri, 3 Dec 2021 14:23:02 UTC

Severity: normal

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52260 in the body.
You can then email your comments to 52260 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#52260; Package emacs. (Fri, 03 Dec 2021 14:23:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Koen van Greevenbroek <koen_devel <at> posteo.net>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 03 Dec 2021 14:23:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Koen van Greevenbroek <koen_devel <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Subject: Fix compilation error in feature/pgtk branch
Date: Fri, 03 Dec 2021 09:20:53 +0000
Hi,

I was just trying to compile the latest version of the pgtk branch when
I noticed that commit 901938109f introduced a regression: two empty
switch cases will result in a compilation error. My suggested fix is
the following:

Fix compilation error due to empty switch cases

modified   src/pgtkterm.c
@@ -4276,6 +4276,7 @@ set_fullscreen_state (struct frame *f)
 
     case FULLSCREEN_WIDTH:
     case FULLSCREEN_HEIGHT:
+	;
       /* Not supported by gtk. Ignore them. */
     }


This fixes the compilation error for me; I don't know if there is a
more idiomatic way of solving this.

Kind regards,

Koen van Greevenbroek




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#52260; Package emacs. (Fri, 03 Dec 2021 17:13:02 GMT) Full text and rfc822 format available.

Message #8 received at 52260 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Koen van Greevenbroek <koen_devel <at> posteo.net>
Cc: 52260 <at> debbugs.gnu.org
Subject: Re: bug#52260: Fix compilation error in feature/pgtk branch
Date: Fri, 03 Dec 2021 18:12:48 +0100
Koen van Greevenbroek <koen_devel <at> posteo.net> writes:

> I was just trying to compile the latest version of the pgtk branch when
> I noticed that commit 901938109f introduced a regression: two empty
> switch cases will result in a compilation error. My suggested fix is
> the following:
>
> Fix compilation error due to empty switch cases
>
> modified   src/pgtkterm.c
> @@ -4276,6 +4276,7 @@ set_fullscreen_state (struct frame *f)
>
>      case FULLSCREEN_WIDTH:
>      case FULLSCREEN_HEIGHT:
> +	;
>        /* Not supported by gtk. Ignore them. */
>      }
>
> This fixes the compilation error for me; I don't know if there is a
> more idiomatic way of solving this.

I think adding a "break;" is the normal way to do it, so I've now done
this on the pgtk branch.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




bug marked as fixed in version 29.1, send any further explanations to 52260 <at> debbugs.gnu.org and Koen van Greevenbroek <koen_devel <at> posteo.net> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Fri, 03 Dec 2021 17:14:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 01 Jan 2022 12:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 77 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.