GNU bug report logs - #52279
[PATCH] gnu: Add emacs-cc-mode.

Previous Next

Package: guix-patches;

Reported by: Liliana Marie Prikler <liliana.prikler <at> gmail.com>

Date: Sat, 4 Dec 2021 17:31:02 UTC

Severity: normal

Tags: patch

Merged with 52127

Done: Liliana Marie Prikler <liliana.prikler <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52279 in the body.
You can then email your comments to 52279 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#52279; Package guix-patches. (Sat, 04 Dec 2021 17:31:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Liliana Marie Prikler <liliana.prikler <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 04 Dec 2021 17:31:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: guix-patches <at> gnu.org, 52278 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add emacs-cc-mode.
Date: Fri, 26 Nov 2021 17:43:40 +0100
* gnu/packages/emacs-xyz.scm (emacs-cc-mode): New variable.
---
 gnu/packages/emacs-xyz.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 865e0b52d9..962696d8ce 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -13838,6 +13838,41 @@ (define-public emacs-boon
 reached with the right hand.")
     (license license:gpl3+)))
 
+(define-public emacs-cc-mode
+  (package
+   (name "emacs-cc-mode")
+   (version "5.35")
+   (source
+    (origin
+     (method hg-fetch)
+     (uri (hg-reference
+           (url "http://hg.code.sf.net/p/cc-mode/cc-mode")
+           (changeset
+            (string-append "Release_"
+                           (string-replace-substring version "." "_")))))
+     (file-name (hg-file-name name version))
+     (sha256
+      (base32 "03cvl61baccx57zd62nz2wy4hvij5hl2syg7byaxgrs4c7grr414"))))
+   (build-system emacs-build-system)
+   (arguments
+    '(#:tests? #t
+      #:test-command '("make" "test")
+      #:phases
+      (modify-phases %standard-phases
+        (add-before 'install 'make-info
+          (lambda _
+            (invoke "make" "info"))))))
+   (native-inputs
+    `(("texinfo" ,texinfo)))
+   (home-page "http://cc-mode.sourceforge.net/")
+   (synopsis "Framework for creating major modes for C-style languages")
+   (description
+    "CC Mode is an Emacs and XEmacs mode for editing C and other languages with
+similar syntax; currently C++, Objective-C, Java, CORBA's IDL, Pike, and AWK.
+It's a standard package in both Emacs and XEmacs.  This package provides the
+upstream release rather than the version bundled with Emacs.")
+   (license license:gpl3+)))
+
 (define-public emacs-csharp-mode
   (package
     (name "emacs-csharp-mode")
-- 
2.34.0






Merged 52127 52279. Request was from Liliana Marie Prikler <liliana.prikler <at> gmail.com> to control <at> debbugs.gnu.org. (Sat, 04 Dec 2021 17:45:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#52279; Package guix-patches. (Sat, 04 Dec 2021 17:49:01 GMT) Full text and rfc822 format available.

Message #10 received at 52279 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 52279 <at> debbugs.gnu.org, 52278 <at> debbugs.gnu.org
Subject: Re: [bug#52279] [PATCH] gnu: Add emacs-cc-mode.
Date: Sat, 04 Dec 2021 18:48:15 +0100
Hello,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> * gnu/packages/emacs-xyz.scm (emacs-cc-mode): New variable.

Thank you.

LGTM, barring one comment below:

> +    "CC Mode is an Emacs and XEmacs mode for editing C and other languages with
> +similar syntax; currently C++, Objective-C, Java, CORBA's IDL, Pike, and AWK.
> +It's a standard package in both Emacs and XEmacs.  This package provides the
> +upstream release rather than the version bundled with Emacs.")

We didn't add the last sentences for other packages in the same
situation (e.g., Tramp, Org…). I think you should remove it.

Regards,
-- 
Nicolas Goaziou




Information forwarded to guix-patches <at> gnu.org:
bug#52279; Package guix-patches. (Sat, 04 Dec 2021 18:29:02 GMT) Full text and rfc822 format available.

Message #13 received at 52279 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 52279 <at> debbugs.gnu.org
Subject: Re: [bug#52279] [PATCH] gnu: Add emacs-cc-mode.
Date: Sat, 04 Dec 2021 19:28:22 +0100
Am Samstag, den 04.12.2021, 18:48 +0100 schrieb Nicolas Goaziou:
> Hello,
> 
> Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:
> 
> > * gnu/packages/emacs-xyz.scm (emacs-cc-mode): New variable.
> 
> Thank you.
> 
> LGTM, barring one comment below:
> 
> > +    "CC Mode is an Emacs and XEmacs mode for editing C and other
> > languages with
> > +similar syntax; currently C++, Objective-C, Java, CORBA's IDL,
> > Pike, and AWK.
> > +It's a standard package in both Emacs and XEmacs.  This package
> > provides the
> > +upstream release rather than the version bundled with Emacs.")
> 
> We didn't add the last sentences for other packages in the same
> situation (e.g., Tramp, Org…). I think you should remove it.
Thanks for the review, but this was sent in error; the "real" cc-mode
patch was sent as 52127 first (but is identical to this one).  I'll
still push it with that adjustment if there's nothing else, though.

Cheers





bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 08 Jan 2022 12:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 81 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.