GNU bug report logs - #52281
28.0.90; batch-byte-compile breaking up warnings in batch mode

Previous Next

Package: emacs;

Reported by: Philipp Stephani <p.stephani2 <at> gmail.com>

Date: Sat, 4 Dec 2021 18:25:02 UTC

Severity: normal

Tags: moreinfo

Found in version 28.0.90

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52281 in the body.
You can then email your comments to 52281 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#52281; Package emacs. (Sat, 04 Dec 2021 18:25:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Philipp Stephani <p.stephani2 <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sat, 04 Dec 2021 18:25:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.90; batch-byte-compile breaking up warnings in batch mode
Date: Sat, 04 Dec 2021 19:24:21 +0100
Create a file with a long filename like:

$ cat /tmp/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.el
(defun f () (g))

Then, byte-compile it in batch mode:

emacs -Q -batch -f batch-byte-compile /tmp/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.el 

In end of data:
/tmp/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.el:1:14:
    Warning: the function ‘g’ is not known to be defined.

Note the line break after the column number.

For comparison, errors aren't broken up:

emacs -Q -batch -l bytecomp -eval '(setq byte-compile-error-on-warn t)' -f batch-byte-compile /tmp/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.el 

In toplevel form:
/tmp/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.el:2:1: Error: the function ‘g’ is not known to be defined.

This is inconsistent, and causes parsers (such as Emacs's compilation
mode) to incorrectly parse these messages.  I think messages in batch
mode should never be broken up.


In GNU Emacs 28.0.90 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.16.0)
 of 2021-12-04
Repository revision: fef3e6006188d1ef2cdc70a45982d6aebb6ee722
Repository branch: emacs-28
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Debian GNU/Linux rodete

Configured using:
 'configure --enable-gcc-warnings=warn-only
 --enable-gtk-deprecation-warnings --without-pop --with-mailutils
 --enable-checking=all --enable-check-lisp-object-type --with-modules
 'CFLAGS=-O0 -ggdb3''

Configured features:
CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG SECCOMP
SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB

Important settings:
  value of $LC_TIME: en_DK.utf8
  value of $LANG: en_US.utf8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc dired dired-loaddefs rfc822
mml mml-sec epa epg rfc6068 epg-config gnus-util rmail rmail-loaddefs
time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils phst skeleton derived edmacro kmacro pcase ffap
thingatpt url url-proxy url-privacy url-expand url-methods url-history
url-cookie url-domsuf url-util url-parse auth-source cl-seq eieio
eieio-core cl-macs eieio-loaddefs password-cache json map url-vars
mailcap rx gnutls puny dbus xml subr-x seq byte-opt gv bytecomp
byte-compile cconv compile text-property-search comint ansi-color ring
cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify
ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button
loaddefs faces cus-face macroexp files window text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote threads dbusbind inotify
dynamic-setting system-font-setting font-render-setting cairo
move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 69226 5598)
 (symbols 48 8490 3)
 (strings 32 24685 1944)
 (string-bytes 1 798236)
 (vectors 16 15586)
 (vector-slots 8 206638 7724)
 (floats 8 27 32)
 (intervals 56 228 0)
 (buffers 992 11))

-- 
Google Germany GmbH
Erika-Mann-Straße 33
80636 München

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich.  Falls Sie diese fälschlicherweise erhalten haben
sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie
alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail
an die falsche Person gesendet wurde.

This e-mail is confidential.  If you received this communication by mistake,
please don’t forward it to anyone else, please erase all copies and
attachments, and please let me know that it has gone to the wrong person.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#52281; Package emacs. (Sat, 04 Dec 2021 20:00:01 GMT) Full text and rfc822 format available.

Message #8 received at 52281 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 52281 <at> debbugs.gnu.org
Subject: Re: bug#52281: 28.0.90; batch-byte-compile breaking up warnings in
 batch mode
Date: Sat, 04 Dec 2021 20:59:13 +0100
Philipp Stephani <p.stephani2 <at> gmail.com> writes:

> This is inconsistent, and causes parsers (such as Emacs's compilation
> mode) to incorrectly parse these messages.  I think messages in batch
> mode should never be broken up.

The following should fix the issue:

diff --git a/lisp/emacs-lisp/warnings.el b/lisp/emacs-lisp/warnings.el
index 36b275e2d3..1d061364a0 100644
--- a/lisp/emacs-lisp/warnings.el
+++ b/lisp/emacs-lisp/warnings.el
@@ -307,7 +307,9 @@ display-warning
                                'type 'warning-suppress-log-warning
                                'warning-type type))
               (funcall newline)
-	      (when (and warning-fill-prefix (not (string-search "\n" message)))
+	      (when (and warning-fill-prefix
+                         (not (string-search "\n" message))
+                         (not noninteractive))
 		(let ((fill-prefix warning-fill-prefix)
 		      (fill-column warning-fill-column))
 		  (fill-region start (point))))

Does anybody have an opinion here? 

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Added tag(s) moreinfo. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sat, 04 Dec 2021 20:00:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#52281; Package emacs. (Mon, 06 Dec 2021 01:11:01 GMT) Full text and rfc822 format available.

Message #13 received at 52281 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Philipp Stephani <p.stephani2 <at> gmail.com>, 52281 <at> debbugs.gnu.org
Subject: Re: bug#52281: 28.0.90; batch-byte-compile breaking up warnings in
 batch mode
Date: Mon, 6 Dec 2021 02:10:45 +0100
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Philipp Stephani <p.stephani2 <at> gmail.com> writes:
>
>> This is inconsistent, and causes parsers (such as Emacs's compilation
>> mode) to incorrectly parse these messages.  I think messages in batch
>> mode should never be broken up.
>
> The following should fix the issue:
[snip]
> Does anybody have an opinion here?

I agree that these warnings should not be broken up in batch mode.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#52281; Package emacs. (Mon, 06 Dec 2021 01:24:02 GMT) Full text and rfc822 format available.

Message #16 received at 52281 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: Philipp Stephani <p.stephani2 <at> gmail.com>, 52281 <at> debbugs.gnu.org
Subject: Re: bug#52281: 28.0.90; batch-byte-compile breaking up warnings in
 batch mode
Date: Mon, 06 Dec 2021 02:23:42 +0100
Stefan Kangas <stefan <at> marxist.se> writes:

> I agree that these warnings should not be broken up in batch mode.

OK; pushed to Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




bug marked as fixed in version 29.1, send any further explanations to 52281 <at> debbugs.gnu.org and Philipp Stephani <p.stephani2 <at> gmail.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Mon, 06 Dec 2021 01:24:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#52281; Package emacs. (Mon, 06 Dec 2021 01:43:01 GMT) Full text and rfc822 format available.

Message #21 received at 52281 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Philipp Stephani <p.stephani2 <at> gmail.com>, 52281 <at> debbugs.gnu.org
Subject: Re: bug#52281: 28.0.90; batch-byte-compile breaking up warnings in
 batch mode
Date: Mon, 6 Dec 2021 02:42:43 +0100
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Stefan Kangas <stefan <at> marxist.se> writes:
>
>> I agree that these warnings should not be broken up in batch mode.
>
> OK; pushed to Emacs 29.

Thanks.

For posterity, let me just add that the principal reason for me to agree
here is that more than once have I had to struggle to grep or search for
these warnings due to messages being broken up over several lines.

I also remember seeing some issues when adding tests for these warnings
in bytecomp-tests.el.  I can't remember the details, but I think that it
was something like having to make some of the regexps less specific as
certain parts could end up on the wrong line.  That was not a massive
pain to debug or anything, but it was also just not fun.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#52281; Package emacs. (Mon, 06 Dec 2021 09:19:02 GMT) Full text and rfc822 format available.

Message #24 received at 52281 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 52281 <at> debbugs.gnu.org, Stefan Kangas <stefan <at> marxist.se>
Subject: Re: bug#52281: 28.0.90; batch-byte-compile breaking up warnings in
 batch mode
Date: Mon, 6 Dec 2021 10:17:53 +0100
Am Mo., 6. Dez. 2021 um 02:23 Uhr schrieb Lars Ingebrigtsen <larsi <at> gnus.org>:
>
> Stefan Kangas <stefan <at> marxist.se> writes:
>
> > I agree that these warnings should not be broken up in batch mode.
>
> OK; pushed to Emacs 29.

Thanks.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 03 Jan 2022 12:24:09 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 75 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.