GNU bug report logs - #52303
[PATCH] Remove not defined face info-menu-5 from manoj-dark theme

Previous Next

Package: emacs;

Reported by: "Y. E." <yet <at> ego.team>

Date: Sun, 5 Dec 2021 18:09:02 UTC

Severity: normal

Tags: patch

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52303 in the body.
You can then email your comments to 52303 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#52303; Package emacs. (Sun, 05 Dec 2021 18:09:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to "Y. E." <yet <at> ego.team>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 05 Dec 2021 18:09:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Y. E. <yet <at> ego.team>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Remove not defined face info-menu-5 from manoj-dark theme
Date: Sun, 05 Dec 2021 19:43:55 +0200
[Message part 1 (text/plain, inline)]
Tags: patch

Hello,

The face 'info-menu-5' was obsoleted in favor to 'info-menu-star' back
in 2005 (185cff95450).

This patch suggests removal of the not defined face and not updating it,
because the de facto used 'info-menu-star' default value has served the
theme users during the last years.

A side-question: do I still need to add "Copyright-paperwork-exempt:
yes" to the minor commits even if I have the CA completed?

Thanks,
YE


[0001-etc-themes-manoj-dark-theme.el-Remove-not-defined-fa.patch (text/patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#52303; Package emacs. (Sun, 05 Dec 2021 21:20:01 GMT) Full text and rfc822 format available.

Message #8 received at 52303 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Y. E. <yet <at> ego.team>
Cc: 52303 <at> debbugs.gnu.org
Subject: Re: bug#52303: [PATCH] Remove not defined face info-menu-5 from
 manoj-dark theme
Date: Sun, 05 Dec 2021 22:19:06 +0100
Y. E. <yet <at> ego.team> writes:

> The face 'info-menu-5' was obsoleted in favor to 'info-menu-star' back
> in 2005 (185cff95450).
>
> This patch suggests removal of the not defined face and not updating it,
> because the de facto used 'info-menu-star' default value has served the
> theme users during the last years.

Thanks; applied to Emacs 29.

> A side-question: do I still need to add "Copyright-paperwork-exempt:
> yes" to the minor commits even if I have the CA completed?

Nope.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




bug marked as fixed in version 29.1, send any further explanations to 52303 <at> debbugs.gnu.org and "Y. E." <yet <at> ego.team> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sun, 05 Dec 2021 21:20:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#52303; Package emacs. (Tue, 07 Dec 2021 10:19:01 GMT) Full text and rfc822 format available.

Message #13 received at 52303 <at> debbugs.gnu.org (full text, mbox):

From: Y. E. <yet <at> ego.team>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 52303 <at> debbugs.gnu.org, yet <at> ego.team
Subject: Re: bug#52303: [PATCH] Remove not defined face info-menu-5 from
 manoj-dark theme
Date: Tue, 07 Dec 2021 12:18:09 +0200
Hi Lars,

The pushed commit message caught my attention: it seems both the
suggested commit message and the corrected one got into.

See d3d8a6ccda7, and also 0d8e9588e1c, 6620d03e334.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#52303; Package emacs. (Tue, 07 Dec 2021 20:24:02 GMT) Full text and rfc822 format available.

Message #16 received at 52303 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Y. E. <yet <at> ego.team>
Cc: 52303 <at> debbugs.gnu.org
Subject: Re: bug#52303: [PATCH] Remove not defined face info-menu-5 from
 manoj-dark theme
Date: Tue, 07 Dec 2021 21:23:45 +0100
Y. E. <yet <at> ego.team> writes:

> The pushed commit message caught my attention: it seems both the
> suggested commit message and the corrected one got into.
>
> See d3d8a6ccda7, and also 0d8e9588e1c, 6620d03e334.

Sorry, I don't understand what you mean here.

Is there something that should be changed?  If so, can you suggest a
patch to do so?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#52303; Package emacs. (Wed, 08 Dec 2021 10:15:01 GMT) Full text and rfc822 format available.

Message #19 received at 52303 <at> debbugs.gnu.org (full text, mbox):

From: Y. E. <yet <at> ego.team>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 52303 <at> debbugs.gnu.org, yet <at> ego.team
Subject: Re: bug#52303: [PATCH] Remove not defined face info-menu-5 from
 manoj-dark theme
Date: Wed, 08 Dec 2021 12:14:05 +0200
>
>> The pushed commit message caught my attention: it seems both the
>> suggested commit message and the corrected one got into.
>>
>> See d3d8a6ccda7, and also 0d8e9588e1c, 6620d03e334.
>
> Sorry, I don't understand what you mean here.

Ah, sorry, I wasn't clear enough.

The mentioned commit messages seem to contain accidentally duplicated
content. For example, see the part of the `git show d3d8a6ccda7' output:

Date:   Sun Dec 5 22:18:18 2021 +0100

    ; * etc/themes/manoj-dark-theme.el: Remove not defined face info-menu-5
    
    * etc/themes/manoj-dark-theme.el (manoj-dark): Remove reference to
    face removed in 2005 (bug#52303).

diff --git a/etc/themes/manoj-dark-theme.el b/etc/themes/manoj-dark-theme.el

> Is there something that should be changed?

My guess was I should have notified you, in case this indeed was a kind
of a typo or broken automation. (I didn't see/notice such commit
messages in Emacs commit history before.)

Best,
YE




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#52303; Package emacs. (Thu, 09 Dec 2021 01:13:02 GMT) Full text and rfc822 format available.

Message #22 received at 52303 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Y. E. <yet <at> ego.team>
Cc: 52303 <at> debbugs.gnu.org
Subject: Re: bug#52303: [PATCH] Remove not defined face info-menu-5 from
 manoj-dark theme
Date: Thu, 09 Dec 2021 02:11:53 +0100
Y. E. <yet <at> ego.team> writes:

> The mentioned commit messages seem to contain accidentally duplicated
> content. For example, see the part of the `git show d3d8a6ccda7' output:
>
> Date:   Sun Dec 5 22:18:18 2021 +0100
>
>     ; * etc/themes/manoj-dark-theme.el: Remove not defined face info-menu-5
>
>     * etc/themes/manoj-dark-theme.el (manoj-dark): Remove reference to
>     face removed in 2005 (bug#52303).
>
> diff --git a/etc/themes/manoj-dark-theme.el b/etc/themes/manoj-dark-theme.el
>
>> Is there something that should be changed?
>
> My guess was I should have notified you, in case this indeed was a kind
> of a typo or broken automation. (I didn't see/notice such commit
> messages in Emacs commit history before.)

Do you mean that the commit message here is wrong?  I still don't quite
understand what you mean.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#52303; Package emacs. (Thu, 09 Dec 2021 10:37:02 GMT) Full text and rfc822 format available.

Message #25 received at 52303 <at> debbugs.gnu.org (full text, mbox):

From: Y. E. <yet <at> ego.team>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 52303 <at> debbugs.gnu.org, yet <at> ego.team
Subject: Re: bug#52303: [PATCH] Remove not defined face info-menu-5 from
 manoj-dark theme
Date: Thu, 09 Dec 2021 12:36:30 +0200
>> The mentioned commit messages seem to contain accidentally duplicated
>> content. For example, see the part of the `git show d3d8a6ccda7' output:
>>
>> Date:   Sun Dec 5 22:18:18 2021 +0100
>>
>>     ; * etc/themes/manoj-dark-theme.el: Remove not defined face info-menu-5
>>
>>     * etc/themes/manoj-dark-theme.el (manoj-dark): Remove reference to
>>     face removed in 2005 (bug#52303).
>>
>> diff --git a/etc/themes/manoj-dark-theme.el b/etc/themes/manoj-dark-theme.el
>>
>>> Is there something that should be changed?
>>
>> My guess was I should have notified you, in case this indeed was a kind
>> of a typo or broken automation. (I didn't see/notice such commit
>> messages in Emacs commit history before.)
>
> Do you mean that the commit message here is wrong?  I still don't quite
> understand what you mean.

Yes, it seemed so to me: the two lines of the commit message saying
basically the same thing. If it's correct, then what purpose does it
serve?

Thanks.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#52303; Package emacs. (Fri, 10 Dec 2021 00:37:01 GMT) Full text and rfc822 format available.

Message #28 received at 52303 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Y. E. <yet <at> ego.team>
Cc: 52303 <at> debbugs.gnu.org
Subject: Re: bug#52303: [PATCH] Remove not defined face info-menu-5 from
 manoj-dark theme
Date: Fri, 10 Dec 2021 01:35:59 +0100
Y. E. <yet <at> ego.team> writes:

> Yes, it seemed so to me: the two lines of the commit message saying
> basically the same thing. If it's correct, then what purpose does it
> serve?

The first is the summary line, and the rest is the ChangeLog style text.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#52303; Package emacs. (Fri, 10 Dec 2021 10:54:01 GMT) Full text and rfc822 format available.

Message #31 received at 52303 <at> debbugs.gnu.org (full text, mbox):

From: Y. E. <yet <at> ego.team>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 52303 <at> debbugs.gnu.org, yet <at> ego.team
Subject: Re: bug#52303: [PATCH] Remove not defined face info-menu-5 from
 manoj-dark theme
Date: Fri, 10 Dec 2021 12:52:53 +0200
> The first is the summary line, and the rest is the ChangeLog style text.

I'm glad there's no issue.

Thank you,
YE





bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 07 Jan 2022 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 71 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.