GNU bug report logs - #52322
`make --question info` always fails

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52322 in the body.
You can then email your comments to 52322 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: `make --question info` always fails
Date: Mon, 6 Dec 2021 01:54:15 +0100

This command on emacs-28 and master always fails:

    make --question info

Here is a reproducer:

    make info && make --question info || echo "failed"

This breaks the `make-dist` script, where we rely on `make --question
info' returning 0 to continue.  I had to comment out that line to
produce the first pretest.

I have bisected this error to the following commit:

    fddd63f8b854f6bfa91403f69ba694ccb54197bc is the first bad commit
    commit fddd63f8b854f6bfa91403f69ba694ccb54197bc
    Author: Glenn Morris <rgm <at> gnu.org>
    Date:   Fri Feb 26 19:28:43 2021 -0800

        Distribute the real source for some doc/misc manuals (bug#45143)

        * doc/misc/modus-themes.texi, doc/misc/org.texi:
        Remove generated files from repository.
        * doc/misc/Makefile.in: Add rules for building .texi from .org.
        (ORG_SRC, abs_top_builddir, EMACS, emacs):
        New variables.
        (org_template): New template.
        (orgclean): New phony target.
        * Makefile.in (info): Depend on lisp.
        * lisp/org/ox-texinfo.el (org-texinfo-export-to-texinfo-batch):
        New function.
        * doc/misc/org.org, doc/misc/org-setup.org: New files.
        Import from https://code.orgmode.org d8e8a97a14.

Message #8 received at 52322 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 52322 <at> debbugs.gnu.org
Subject: Re: bug#52322: `make --question info` always fails
Date: Mon, 06 Dec 2021 11:42:24 -0500

ISTM that src/Makefile.in has a problem, in that it wants globals.h to
be newer than gl-stamp, but the rule that generates globals.h ensures
the opposite is always true. So it always tries to rebuild globals.h
(even if it is a no-op).

Working around that, one is left with the issue that compile-clean
always runs, and make can't tell that it can be a no-op.

Perhaps just get rid of the --question test.

Message #11 received at 52322 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 52322 <at> debbugs.gnu.org
Subject: Re: bug#52322: `make --question info` always fails
Date: Mon, 6 Dec 2021 21:57:57 +0100

Glenn Morris <rgm <at> gnu.org> writes:

> ISTM that src/Makefile.in has a problem, in that it wants globals.h to
> be newer than gl-stamp, but the rule that generates globals.h ensures
> the opposite is always true. So it always tries to rebuild globals.h
> (even if it is a no-op).
>
> Working around that, one is left with the issue that compile-clean
> always runs, and make can't tell that it can be a no-op.
>
> Perhaps just get rid of the --question test.

Fine by me.  AFAICT, we will run "make info" anyways.

Any other comments?

Message #14 received at 52322 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 52322 <at> debbugs.gnu.org
Subject: Re: bug#52322: `make --question info` always fails
Date: Mon, 13 Dec 2021 18:23:20 -0800

[Message part 1 (text/plain, inline)]

close 52322 28.1
thanks

Stefan Kangas <stefan <at> marxist.se> writes:

> Glenn Morris <rgm <at> gnu.org> writes:
>
>> Perhaps just get rid of the --question test.
>
> Fine by me.  AFAICT, we will run "make info" anyways.
>
> Any other comments?

There have been no further comments within over a week, so I've
installed the attached patch on the emacs-28 branch (commit 9de8eec3bc).

[0001-make-dist-Don-t-run-make-question-info-.-Bug-52322.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.