GNU bug report logs - #52359
[PATCH] gnu: python2-bottle: Remove package.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52359 in the body.
You can then email your comments to 52359 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] gnu: python2-bottle: Remove package.
Date: Tue,  7 Dec 2021 16:00:07 -0500

* gnu/packages/python-web.scm (python2-bottle): Delete variable.
---
 gnu/packages/python-web.scm | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index d4a785b2fc..fb23054489 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -4170,9 +4170,6 @@ (define-public python-bottle
     (description "@code{python-bottle} is a WSGI framework for small web-applications.")
     (license license:expat)))
 
-(define-public python2-bottle
-  (package-with-python2 python-bottle))
-
 (define-public python-wtforms
   (package
     (name "python-wtforms")
-- 
2.34.0

Message #8 received at 52359 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: jgart <jgart <at> dismail.de>
Cc: 52359 <at> debbugs.gnu.org
Subject: Re: bug#52359: [PATCH] gnu: python2-bottle: Remove package.
Date: Sun, 19 Dec 2021 23:25:06 +0100

Hi,

jgart <jgart <at> dismail.de> skribis:

> * gnu/packages/python-web.scm (python2-bottle): Delete variable.

Apparently it still has users so we can’t remove it yet:

--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env  guix refresh -l python2-bottle
Building the following 2 packages would ensure 3 dependent packages are rebuilt: h-client <at> 0.0a0-138 virtaal <at> 0.7.1
--8<---------------cut here---------------end--------------->8---

Ludo’.

Message #11 received at 52359 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 52359 <at> debbugs.gnu.org
Subject: Re: bug#52359: [PATCH] gnu: python2-bottle: Remove package.
Date: Sun, 19 Dec 2021 17:58:16 -0500

On Sun, 19 Dec 2021 23:25:06 +0100 Ludovic Courtès <ludo <at> gnu.org> wrote:
> Hi,
> 
> jgart <jgart <at> dismail.de> skribis:
> 
> > * gnu/packages/python-web.scm (python2-bottle): Delete variable.
> 
> Apparently it still has users so we can’t remove it yet:

Hi Ludo,

Thanks for the review!

The best way to check is with `guix refresh --list-dependent python2-bottle`?

Or, you're referring to the fact that there are still users using the
python2 version of bottle itself?

Also, when upgrading a package, what is your workflow for testing and making 
sure you don't break a dependent package?

Do you also build all packages listed in the output of 
`guix refresh --list-dependent package-name` before sending a patch?

My experience with this issue is when I updated python-jedi recently. 
I sent the patch.  It got accepted. (Un)relatedly, I tried installing
bpython a day later and bpython was broken. My first guess is that the
upgrade of python-jedi broke the current version of bpython in master. I
wasn't thinking about bpython when I was upgrading python-jedi.

Could any of the above be mentioned in the cookbook or the manual? Excuse me if
I TDLR'ed that part.

Any advice is much appreciated.

> 
> --8<---------------cut here---------------start------------->8---
> $ ./pre-inst-env  guix refresh -l python2-bottle
> Building the following 2 packages would ensure 3 dependent packages are rebuilt: h-client <at> 0.0a0-138 virtaal <at> 0.7.1
> --8<---------------cut here---------------end--------------->8---
> 
> Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.