GNU bug report logs -
#52472
[PATCH] gnu: Add libtree
Previous Next
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52472 in the body.
You can then email your comments to 52472 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org:
bug#52472; Package
guix-patches.
(Mon, 13 Dec 2021 20:43:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
poptsov.artyom <at> gmail.com (Artyom V. Poptsov):
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org.
(Mon, 13 Dec 2021 20:43:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hello Guixers,
this patch adds libtree[1] v3.0.0-rc6.
- avp
References:
1: https://github.com/haampie/libtree
[0001-gnu-Add-libtree.patch (text/x-diff, attachment)]
[Message part 3 (text/plain, inline)]
--
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#52472; Package
guix-patches.
(Sat, 18 Dec 2021 08:04:01 GMT)
Full text and
rfc822 format available.
Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
I've updated libtree to v3.0.1.
- Artyom
[0001-gnu-Add-libtree.patch (text/x-diff, attachment)]
[Message part 3 (text/plain, inline)]
--
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#52472; Package
guix-patches.
(Sun, 19 Dec 2021 09:49:02 GMT)
Full text and
rfc822 format available.
Message #11 received at 52472 <at> debbugs.gnu.org (full text, mbox):
Hey Artyom,
> ;;; Copyright © 2021 Solene Rapenne <solene <at> perso.pw>
> +;;; Copyright © 2021 Artyom V. Poptsov <poptsov.artyom <at> gmail.com>
> +
No need for an extra new-line here.
> + (lambda* (#:key outputs #:allow-other-keys)
> + (substitute* "Makefile"
> + (("\\$\\(DESTDIR\\)\\$\\(BINDIR\\)")
> + (format #f "~a/bin/" (assoc-ref outputs "out")))
> + (("\\$\\(DESTDIR\\)\\$\\(SHAREDIR\\)")
> + (format #f "~a/share/" (assoc-ref outputs "out"))))))
You can now write:
--8<---------------cut here---------------start------------->8---
,#~(modify-phases %standard-phases
(delete 'check)
(delete 'configure)
(add-before 'build 'patch
(lambda* (#:key outputs #:allow-other-keys)
(substitute* "Makefile"
(("\\$\\(DESTDIR\\)\\$\\(BINDIR\\)")
(string-append #$output "/bin/"))
(("\\$\\(DESTDIR\\)\\$\\(SHAREDIR\\)")
(string-append #$output "/share/")))))
--8<---------------cut here---------------end--------------->8---
> + (replace 'build
> + (lambda _
> + (setenv "CC" "gcc")
That would break cross-compilation. You should use something like:
--8<---------------cut here---------------start------------->8---
(string-append "CC=" ,(cc-for-target)).
--8<---------------cut here---------------end--------------->8---
> + (setenv "LDFLAGS" "-static")
Why are we building a static version of the program?
There's also this linter warning:
gnu/packages/linux.scm:8649:14: libtree <at> 3.0.1: synopsis should start with an upper-case letter or digit
Thanks,
Mathieu
Information forwarded
to
guix-patches <at> gnu.org:
bug#52472; Package
guix-patches.
(Sun, 19 Dec 2021 12:52:02 GMT)
Full text and
rfc822 format available.
Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):
Sorry if this is overwhelming, but also:
Le 19 décembre 2021 04:48:28 GMT-05:00, Mathieu Othacehe <othacehe <at> gnu.org> a écrit :
>
>Hey Artyom,
>
>> ;;; Copyright © 2021 Solene Rapenne <solene <at> perso.pw>
>> +;;; Copyright © 2021 Artyom V. Poptsov <poptsov.artyom <at> gmail.com>
>> +
>
>No need for an extra new-line here.
>
>> + (lambda* (#:key outputs #:allow-other-keys)
>> + (substitute* "Makefile"
>> + (("\\$\\(DESTDIR\\)\\$\\(BINDIR\\)")
>> + (format #f "~a/bin/" (assoc-ref outputs "out")))
>> + (("\\$\\(DESTDIR\\)\\$\\(SHAREDIR\\)")
>> + (format #f "~a/share/" (assoc-ref outputs "out"))))))
>
>You can now write:
>
>--8<---------------cut here---------------start------------->8---
> ,#~(modify-phases %standard-phases
> (delete 'check)
> (delete 'configure)
> (add-before 'build 'patch
> (lambda* (#:key outputs #:allow-other-keys)
> (substitute* "Makefile"
> (("\\$\\(DESTDIR\\)\\$\\(BINDIR\\)")
> (string-append #$output "/bin/"))
> (("\\$\\(DESTDIR\\)\\$\\(SHAREDIR\\)")
> (string-append #$output "/share/")))))
>--8<---------------cut here---------------end--------------->8---
>
Don't remove the check phase. Use #:tests? #f instead and add a comment explaining why. If the tests fail, we should fix them, not put them under the rug ;)
Maybe it would be easier to pass BINDIR, SHAREDIR and CC with #:make-flags?
>> + (replace 'build
>> + (lambda _
>> + (setenv "CC" "gcc")
>
>That would break cross-compilation. You should use something like:
>
>--8<---------------cut here---------------start------------->8---
>(string-append "CC=" ,(cc-for-target)).
>--8<---------------cut here---------------end--------------->8---
>
>> + (setenv "LDFLAGS" "-static")
>
>Why are we building a static version of the program?
>
>There's also this linter warning:
>
>gnu/packages/linux.scm:8649:14: libtree <at> 3.0.1: synopsis should start with an upper-case letter or digit
>
>Thanks,
>
>Mathieu
>
Could you send a new patch with these changes? Don't hesitate to ask if you're a bit lost or need help on some points :)
Information forwarded
to
guix-patches <at> gnu.org:
bug#52472; Package
guix-patches.
(Sun, 19 Dec 2021 12:52:02 GMT)
Full text and
rfc822 format available.
Information forwarded
to
guix-patches <at> gnu.org:
bug#52472; Package
guix-patches.
(Thu, 13 Jan 2022 03:31:01 GMT)
Full text and
rfc822 format available.
Message #20 received at 52472 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hello,
this is the updated version of the patch with changes suggested by
Mathieu Othacehe and Julien Lepiller.
A note for Mathieu: I used to build libtree with "-static" flag as it is
recommended by the official documentation. But libtree builds fine
without the flag so I removed it.
Thanks,
- Artyom
[0001-gnu-Add-libtree.patch (text/x-diff, attachment)]
[Message part 3 (text/plain, inline)]
--
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#52472; Package
guix-patches.
(Thu, 13 Jan 2022 03:32:02 GMT)
Full text and
rfc822 format available.
Information forwarded
to
guix-patches <at> gnu.org:
bug#52472; Package
guix-patches.
(Thu, 13 Jan 2022 07:39:02 GMT)
Full text and
rfc822 format available.
Message #26 received at 52472 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hi,
Artyom V. Poptsov schreef op do 13-01-2022 om 06:30 [+0300]:
> + (list #:tests? #f
There's a check target in
<https://github.com/haampie/libtree/blob/master/Makefile>
and a bunch of tests in
<https://github.com/haampie/libtree/tree/master/tests>.
Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#52472; Package
guix-patches.
(Thu, 13 Jan 2022 17:20:02 GMT)
Full text and
rfc822 format available.
Message #29 received at 52472 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hello Maxime,
to my understanding some libtree tests (namely 07 and 08) are made in
such way that they finish with a non-zero code when they pass, that
makes Guix stop during the build with an error. For example, the test
"07_origin_is_relative_to_symlink_location_not_realpath" expects that
libtree will fail. I checked a compiled "exe" file from a failed build
and got this:
--8<---------------cut here---------------start------------->8---
$ libtree /tmp/guix-build-libtree-3.0.1.drv-0/source/tests/07_origin_is_relative_to_symlink_location_not_realpath/exe
exe
└── libg.so [runpath]
└── libf.so not found
┊ Paths considered in this order:
┊ 1. rpath is skipped because runpath was set
┊ 2. LD_LIBRARY_PATH was not set
┊ 3. runpath:
┊ /tmp/guix-build-libtree-3.0.1.drv-0/source/tests/07_origin_is_relative_to_symlink_location_not_realpath/b
┊ 4. ld config files:
┊ /usr/lib/x86_64-linux-gnu/libfakeroot
┊ /usr/local/lib
┊ /usr/local/lib/x86_64-linux-gnu
┊ /lib/x86_64-linux-gnu
┊ /usr/lib/x86_64-linux-gnu
┊ /lib32
┊ /usr/lib32
┊ 5. Standard paths:
┊ /lib
┊ /lib64
┊ /usr/lib
┊ /usr/lib64
Error [/tmp/guix-build-libtree-3.0.1.drv-0/source/tests/07_origin_is_relative_to_symlink_location_not_realpath/exe]: Not all dependencies were found
$ echo $?
28
--8<---------------cut here---------------end--------------->8---
Yet libtree itself seems to work fine after installation from Guix.
Here's an example of the output for a correct binary:
--8<---------------cut here---------------start------------->8---
$ libtree guix-daemon
guix-daemon
├── libz.so.1 [runpath]
├── libbz2.so.1.0 [runpath]
├── libgcrypt.so.20 [runpath]
│ └── libgpg-error.so.0 [runpath]
└── libsqlite3.so.0 [runpath]
--8<---------------cut here---------------end--------------->8---
I suggest that we keep "#f" for tests unless the libtree author fix this
behavior.
For now I opened an issue for libtree:
https://github.com/haampie/libtree/issues/65
Thanks!
- Artyom
--
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#52472; Package
guix-patches.
(Thu, 13 Jan 2022 17:38:02 GMT)
Full text and
rfc822 format available.
Message #32 received at 52472 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Artyom V. Poptsov schreef op do 13-01-2022 om 20:18 [+0300]:
> [...]
>
> I suggest that we keep "#f" for tests unless the libtree author fix this
> behavior.
>
> For now I opened an issue for libtree:
> https://github.com/haampie/libtree/issues/65
Seems reasonable to me, though I would add a comment
;; See <https://github.com/haampie/libtree/issues/65>
next to the #:tests? #false such that the reasons won't be lost to
time.
Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#52472; Package
guix-patches.
(Thu, 13 Jan 2022 17:52:02 GMT)
Full text and
rfc822 format available.
Message #35 received at 52472 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hello,
> Seems reasonable to me, though I would add a comment
> ;; See <https://github.com/haampie/libtree/issues/65>
> next to the #:tests? #false such that the reasons won't be lost to
> time.
I added the comment.
- Artyom
[0001-gnu-Add-libtree.patch (text/x-diff, attachment)]
[Message part 3 (text/plain, inline)]
--
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#52472; Package
guix-patches.
(Mon, 17 Jan 2022 18:11:02 GMT)
Full text and
rfc822 format available.
Message #38 received at 52472 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hello,
meanwhile the libtree author fixed the tests in 3.0.2:
https://github.com/haampie/libtree/issues/65
So I've updated the patch to add libtree 3.0.2.
Thanks,
- Artyom
[0001-gnu-Add-libtree.patch (text/x-diff, attachment)]
[Message part 3 (text/plain, inline)]
--
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#52472; Package
guix-patches.
(Mon, 17 Jan 2022 19:03:01 GMT)
Full text and
rfc822 format available.
Message #41 received at 52472 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hi,
Artyom V. Poptsov schreef op ma 17-01-2022 om 21:09 [+0300]:
> + (list #:tests? #t
Tests can almost never be run when cross-compiling,
so this needs to be #false when cross-compiling. This should
be detected by the 'tests-true' linter. I suggest removing '#:tests?
#t’.
> + #~(list (string-append "CC=" #$(cc-for-target))
> + "PREFIX=/"
> + (string-append "DESTDIR=" #$output))
Guix doesn't do staged installation
(https://www.gnu.org/software/automake/manual/html_node/DESTDIR.html).
Doing (string-append "PREFIX=" $output) and dropping DESTDIR=... should
suffice.
Greetings,
Maxime
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#52472; Package
guix-patches.
(Mon, 17 Jan 2022 19:15:02 GMT)
Full text and
rfc822 format available.
Message #44 received at 52472 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hello,
> I suggest removing '#:tests?
Okay, done.
> Guix doesn't do staged installation
Unfortunately it seems to me that libtree fails when I remove
'(string-append "DESTDIR=" #$output)' from the make flags.
The reason is this code from libtree Makefile:
--8<---------------cut here---------------start------------->8---
install: all
mkdir -p $(DESTDIR)$(BINDIR)
cp -p libtree $(DESTDIR)$(BINDIR)
mkdir -p $(DESTDIR)$(SHAREDIR)/man/man1
cp -p doc/libtree.1 $(DESTDIR)$(SHAREDIR)/man/man1
--8<---------------cut here---------------end--------------->8---
As you can see it's using 'DESTDIR' as prefix for the installation.
- Artyom
[0001-gnu-Add-libtree.patch (text/x-diff, attachment)]
[Message part 3 (text/plain, inline)]
--
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#52472; Package
guix-patches.
(Mon, 17 Jan 2022 19:24:01 GMT)
Full text and
rfc822 format available.
Message #47 received at 52472 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hi,
Artyom V. Poptsov schreef op ma 17-01-2022 om 22:14 [+0300]:
> [...]
> > Guix doesn't do staged installation
>
> Unfortunately it seems to me that libtree fails when I remove
> '(string-append "DESTDIR=" #$output)' from the make flags.
>
> The reason is this code from libtree Makefile:
>
> --8<---------------cut here---------------start------------->8---
> install: all
> mkdir -p $(DESTDIR)$(BINDIR)
> cp -p libtree $(DESTDIR)$(BINDIR)
> mkdir -p $(DESTDIR)$(SHAREDIR)/man/man1
> cp -p doc/libtree.1 $(DESTDIR)$(SHAREDIR)/man/man1
> --8<---------------cut here---------------end--------------->8---
>
> As you can see it's using 'DESTDIR' as prefix for the installation.
SHAREDIR is set to $(PREFIX)/share in the Makefile.
It seems to work for me, the attached package definition builds
and the store item has a man page and a binary.
Greetings,
Maxime.
[libtree.scm (text/x-scheme, inline)]
(use-modules (guix packages) (guix) (guix git-download) (guix build-system gnu)
((guix licenses) #:prefix license:))
(define-public libtree
(package
(name "libtree")
(version "3.0.2")
(source
(origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/haampie/libtree")
(commit (string-append "v" version))))
(file-name (git-file-name name version))
(sha256
(base32 "072624anz9g01mp5vfkahfmzy0nb7axg5rwk3n1yrdm4hr3d4zrb"))))
(arguments
(list #:make-flags
;; NOTE: Official documentation recommends to build libtree with
;; "-static" flag.
#~(list (string-append "CC=" #$(cc-for-target))
(string-append "PREFIX=" #$output))
#:phases
#~(modify-phases %standard-phases
(delete 'configure)
(replace 'build
(lambda* (#:key make-flags #:allow-other-keys)
(apply invoke "make" make-flags))))))
(build-system gnu-build-system)
(home-page "https://github.com/haampie/libtree")
(synopsis "Show output of @command{ldd} as a tree")
(description
"This tool turns @command{ldd} into a tree and explains how shared
libraries are found or why they cannot be located.")
(license license:expat)))
libtree
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#52472; Package
guix-patches.
(Fri, 28 Jan 2022 18:31:01 GMT)
Full text and
rfc822 format available.
Message #50 received at 52472 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hello,
sorry for bugging you but are there any problems left with the package
that I should solve? As far as I understand now the package is fine and
can be merged to Guix. Am I mistaken?
Thanks!
- Artyom
--
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#52472; Package
guix-patches.
(Fri, 28 Jan 2022 18:55:02 GMT)
Full text and
rfc822 format available.
Message #53 received at 52472 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Artyom V. Poptsov schreef op vr 28-01-2022 om 21:30 [+0300]:
> Hello,
>
> sorry for bugging you but are there any problems left with the package
> that I should solve? As far as I understand now the package is fine and
> can be merged to Guix. Am I mistaken?
As I wrote in <https://issues.guix.gnu.org/52472#12>, setting DESTDIR
is unnecessary. I haven't seen a revised patch not setting DESTDIR.
Aside from that, the patch looks reasonable. However, I didn't look at
all the source code (for hash mismatches etc.).
Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#52472; Package
guix-patches.
(Fri, 04 Feb 2022 18:26:01 GMT)
Full text and
rfc822 format available.
Message #56 received at 52472 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hello Maxime!
I think I figured out how to properly remove DESTDIR setting in my
libtree patch.
Please find the updated patch attached.
- Artyom
[0001-gnu-Add-libtree.patch (text/x-diff, attachment)]
[Message part 3 (text/plain, inline)]
--
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#52472; Package
guix-patches.
(Fri, 04 Feb 2022 19:20:02 GMT)
Full text and
rfc822 format available.
Message #59 received at 52472 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Artyom V. Poptsov schreef op vr 04-02-2022 om 21:25 [+0300]:
> Hello Maxime!
>
> I think I figured out how to properly remove DESTDIR setting in my
> libtree patch.
>
> Please find the updated patch attached.
Unless libtree's Makefile doesn't support parallel compilation,
replacing the build phase has now become unnecessary, right?
The attached simplified package definition builds succesfully for me.
The patch seems to be ready now, I believe?
Greetings,
Maxime (not a committer)
[libtree.scm (text/x-scheme, attachment)]
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#52472; Package
guix-patches.
(Sat, 05 Feb 2022 05:51:01 GMT)
Full text and
rfc822 format available.
Message #62 received at 52472 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hello Maxime,
sorry but libtree refuses to build when I use your patch instead of mine:
--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env guix build libtree --check --no-offload
;;; note: source file /home/avp/src/dist/guix/gnu/packages/linux.scm
;;; newer than compiled /home/avp/src/dist/guix/gnu/packages/linux.go
The following derivation will be built:
/gnu/store/2ndjq2b7z1wqwx6mv91ygkslaziz1sw6-libtree-3.0.2.drv
guix build: error: some outputs of `/gnu/store/2ndjq2b7z1wqwx6mv91ygkslaziz1sw6-libtree-3.0.2.drv' are not valid, so checking is not possible
--8<---------------cut here---------------end--------------->8---
> The patch seems to be ready now, I believe?
Are you asking me or the Guix community? If you're asking me, I think
that since libtree builds and runs OK with my last patch it is ready for
the merge.
But I'd love to hear feedback from the community as well; if someone
find another flaw in the patch I'll try to fix it.
Thanks,
- Artyom
--
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#52472; Package
guix-patches.
(Sat, 05 Feb 2022 10:57:01 GMT)
Full text and
rfc822 format available.
Message #65 received at 52472 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Artyom V. Poptsov schreef op za 05-02-2022 om 08:50 [+0300]:
> sorry but libtree refuses to build when I use your patch instead of
> mine:
>
> --8<---------------cut here---------------start------------->8---
> $ ./pre-inst-env guix build libtree --check --no-offload
> ;;; note: source file /home/avp/src/dist/guix/gnu/packages/linux.scm
> ;;; newer than compiled
> /home/avp/src/dist/guix/gnu/packages/linux.go
> The following derivation will be built:
> /gnu/store/2ndjq2b7z1wqwx6mv91ygkslaziz1sw6-libtree-3.0.2.drv
> guix build: error: some outputs of
> `/gnu/store/2ndjq2b7z1wqwx6mv91ygkslaziz1sw6-libtree-3.0.2.drv' are
> not valid, so checking is not possible
> --8<---------------cut here---------------end--------------->8---
I've seen this before (for something non-libtree), IIUC you can only
run '--check' after it has been built (or substituted) for the first
time.
Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#52472; Package
guix-patches.
(Sat, 05 Feb 2022 11:35:02 GMT)
Full text and
rfc822 format available.
Message #68 received at 52472 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hello Maxime!
> I've seen this before (for something non-libtree), IIUC you can only
> run '--check' after it has been built (or substituted) for the first
> time.
Thanks for pointing that out, I overlooked this little detail somehow.
When I removed '--check' from Guix options it built libtree without
errors with your version of the patch.
Please find the updated patch attached.
- Artyom
[0001-gnu-Add-libtree.patch (text/x-diff, attachment)]
[Message part 3 (text/plain, inline)]
--
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F
[signature.asc (application/pgp-signature, inline)]
Reply sent
to
Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility.
(Wed, 09 Mar 2022 22:08:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
poptsov.artyom <at> gmail.com (Artyom V. Poptsov):
bug acknowledged by developer.
(Wed, 09 Mar 2022 22:08:02 GMT)
Full text and
rfc822 format available.
Message #73 received at 52472-done <at> debbugs.gnu.org (full text, mbox):
Hi Artyom and all,
"Artyom V. Poptsov" <poptsov.artyom <at> gmail.com> skribis:
> * gnu/packages/linux.scm (libtree): New variable.
Finally applied.
Thanks you and thanks everyone for reviewing!
Ludo’.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org.
(Thu, 07 Apr 2022 11:24:06 GMT)
Full text and
rfc822 format available.
This bug report was last modified 2 years and 19 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.