GNU bug report logs - #52530
[PATCH core-updates-frozen] WIP: Add rust-gtk4 and dependencies

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52530 in the body.
You can then email your comments to 52530 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicholas von Klitzing <nicholas <at> nvk.pm>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH core-updates-frozen] WIP: Add rust-gtk4 and dependencies
Date: Wed, 15 Dec 2021 23:05:27 +0000

[Message part 1 (text/plain, inline)]

Hello Guix!

These are my WIP patches to add the gtk4 crates. Several Gnome and Gtk applications depend on this crate (Authenticator, Fractal, Shortwave, etc).

I based the patches on c-u-f because the master branch isn't building on my machine for unrelated reasons I have yet to explore. Regardless, there should be no conflicts.

Several of the dependency package definitions are unedited from `guix import`, so please do let me know if you think I should change them.

Looking forward to your feedback!

Kind regards,
Nicholas von Klitzing

[0029-add-copyright.patch (text/x-patch, attachment)]

[0027-gnu-Add-rust-cairo-rs-0.14.patch (text/x-patch, attachment)]

[0025-gnu-Add-rust-glib-sys-0.14.patch (text/x-patch, attachment)]

[0023-gnu-Add-rust-cfg-expr-0.8.patch (text/x-patch, attachment)]

[0019-gnu-Add-rust-glib-macros-0.14.patch (text/x-patch, attachment)]

[0015-gnu-Add-rust-gdk-pixbuf-sys-0.14.patch (text/x-patch, attachment)]

[0017-gnu-Add-rust-field-offset-0.3.patch (text/x-patch, attachment)]

[0011-gnu-Add-rust-gdk4-sys-0.3.patch (text/x-patch, attachment)]

[0009-gnu-Add-rust-pango-sys-0.14.patch (text/x-patch, attachment)]

[0028-gnu-Add-rust-gtk4-0.3.patch (text/x-patch, attachment)]

[0007-gnu-Add-rust-cfg-expr-0.9.patch (text/x-patch, attachment)]

[0001-gnu-Add-rust-gtk4-sys-0.3.patch (text/x-patch, attachment)]

[0020-gnu-Add-rust-glib-0.14.patch (text/x-patch, attachment)]

[0022-gnu-Add-rust-target-lexicon-0.12.patch (text/x-patch, attachment)]

[0014-gnu-Add-rust-gio-sys-0.14.patch (text/x-patch, attachment)]

[0006-gnu-Add-rust-pango-0.14.patch (text/x-patch, attachment)]

[0004-gnu-Add-rust-gsk4-0.3.patch (text/x-patch, attachment)]

[0002-gnu-Add-rust-gtk4-macros-0.3.patch (text/x-patch, attachment)]

[0021-gnu-Add-rust-freetype-0.7.patch (text/x-patch, attachment)]

[0013-gnu-Add-rust-gio-0.14.patch (text/x-patch, attachment)]

[0003-gnu-Add-rust-gsk4-sys-0.3.patch (text/x-patch, attachment)]

[0005-gnu-Add-rust-graphene-rs-0.14.patch (text/x-patch, attachment)]

[0026-gnu-Add-rust-cairo-sys-rs-0.14.patch (text/x-patch, attachment)]

[0024-gnu-Add-rust-system-deps-3.patch (text/x-patch, attachment)]

[0016-gnu-Add-rust-gdk-pixbuf-0.14.patch (text/x-patch, attachment)]

[0018-gnu-Add-rust-gobject-sys-0.14.patch (text/x-patch, attachment)]

[0012-gnu-Add-rust-gdk4-0.3.patch (text/x-patch, attachment)]

[0010-gnu-Add-rust-graphene-sys-0.14.patch (text/x-patch, attachment)]

[0008-gnu-Add-rust-system-deps-5.patch (text/x-patch, attachment)]

Message #8 received at 52530 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Nicholas von Klitzing <nicholas <at> nvk.pm>
Cc: 52530 <at> debbugs.gnu.org
Subject: Re: bug#52530: [PATCH core-updates-frozen] WIP: Add rust-gtk4 and
 dependencies
Date: Sat, 18 Dec 2021 23:42:44 -0500

Hi Nicholas,

Nicholas von Klitzing <nicholas <at> nvk.pm> writes:

> Hello Guix!
>
> These are my WIP patches to add the gtk4 crates. Several Gnome and Gtk applications depend on this crate (Authenticator, Fractal, Shortwave, etc).
>
> I based the patches on c-u-f because the master branch isn't building on my machine for unrelated reasons I have yet to explore. Regardless, there should be no conflicts.
>
> Several of the dependency package definitions are unedited from `guix import`, so please do let me know if you think I should change them.

Yes, the packages need a proper synopsis and description (stylized with
Texinfo) for inclusion.  Make sure 'guix lint' is happy with them as
well, and have a read at info '(guix)Contributing', particularly the
'Synopses andDescriptions' subsection.

Thank you!

Maxim

Message #11 received at 52530 <at> debbugs.gnu.org (full text, mbox):

From: Nicholas von Klitzing <nicholas <at> nvk.pm>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 52530 <at> debbugs.gnu.org
Subject: Re: bug#52530: [PATCH core-updates-frozen] WIP: Add rust-gtk4 and
 dependencies
Date: Sat, 08 Jan 2022 09:10:33 +0000

Hi Maxim,

I was looking reading through the Guix Contributing guide and found that several of the recommendations are not being used by many packages.

For example, many of the packaged rust crates only have a one-line synopsis and a one-line description, where the description is basically just the synopsis with a few extra verbs added.

Is the style mentioned above acceptable or would you recommend I do something else?

Best,
Nicholas

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Sunday, December 19th, 2021 at 4:42 AM, Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:

> Hi Nicholas,
>
> Nicholas von Klitzing nicholas <at> nvk.pm writes:
>
> > Hello Guix!
> >
> > These are my WIP patches to add the gtk4 crates. Several Gnome and Gtk applications depend on this crate (Authenticator, Fractal, Shortwave, etc).
> >
> > I based the patches on c-u-f because the master branch isn't building on my machine for unrelated reasons I have yet to explore. Regardless, there should be no conflicts.
> >
> > Several of the dependency package definitions are unedited from `guix import`, so please do let me know if you think I should change them.
>
> Yes, the packages need a proper synopsis and description (stylized with
>
> Texinfo) for inclusion. Make sure 'guix lint' is happy with them as
>
> well, and have a read at info '(guix)Contributing', particularly the
>
> 'Synopses andDescriptions' subsection.
>
> Thank you!
>
> Maxim

Message #14 received at 52530 <at> debbugs.gnu.org (full text, mbox):

From: Herman Rimm <herman <at> rimm.ee>
To: 52530 <at> debbugs.gnu.org
Cc: Herman Rimm <herman <at> rimm.ee>
Subject: [PATCH] gnu: Add rust-gtk4 and dependencies.
Date: Sun, 24 Dec 2023 16:27:30 +0100

* gnu/packages/crates-gtk.scm (rust-gdk4-0.6): New variable.
(rust-graphene-rs-0.17): New variable.
(rust-graphene-sys-0.17): New variable.
(rust-gsk4-0.6): New variable.
(rust-gsk4-sys-0.6): New variable.
(rust-gtk4-0.6): New variable.
(rust-gtk4-macros-0.6): New variable.
(rust-gtk4-sys-0.6): New variable.
---
Hello,

Should each package be added in a separate patch?

The latest gtk4-rs version is 0.7, I chose 0.6 because it has more
compatible dependencies. gtk4-rs can be updated to 0.7 together with
those dependencies. For the new packages, guix lint notes the newer
version and that the source is not archived on Software Heritage etc..

The package descriptions are still single sentences, so it can't be
merged. But I mail this patch for people who would like to use newer
gtk4-rs packages despite that. Please improve the descriptions if you
feel like it.

Cheers,
Herman Rimm

 gnu/packages/crates-gtk.scm | 291 ++++++++++++++++++++++++++++++++++++
 1 file changed, 291 insertions(+)

diff --git a/gnu/packages/crates-gtk.scm b/gnu/packages/crates-gtk.scm
index 266a513dc2..0c275b739e 100644
--- a/gnu/packages/crates-gtk.scm
+++ b/gnu/packages/crates-gtk.scm
@@ -4,6 +4,7 @@
 ;;; Copyright © 2022 Petr Hodina <phodina <at> protonmail.com>
 ;;; Copyright © 2022 Aleksandr Vityazev <avityazev <at> posteo.org>
 ;;; Copyright © 2023 Steve George <steve <at> futurile.net>
+;;; Copyright © 2023 Herman Rimm <herman <at> rimm.ee>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -860,6 +861,68 @@ (define-public rust-gdk-sys-0.9
        (("rust-shell-words" ,rust-shell-words-0.1)
         ("rust-tempfile" ,rust-tempfile-3))))))
 
+(define-public rust-gdk4-0.6
+  (package
+    (name "rust-gdk4")
+    (version "0.6.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (crate-uri "gdk4" version))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32 "1zri4z8nxsp88mvk8vhk6xqpc4g1l69zi9w1z3fkwvm211jgkay3"))))
+    (build-system cargo-build-system)
+    (arguments
+     `(#:tests? #f ;`Errors` cannot be formatted with the default formatter.
+       #:cargo-inputs (("rust-bitflags" ,rust-bitflags-1)
+                       ("rust-cairo-rs" ,rust-cairo-rs-0.17)
+                       ("rust-gdk-pixbuf" ,rust-gdk-pixbuf-0.17)
+                       ("rust-gdk4-sys" ,rust-gdk4-sys-0.6)
+                       ("rust-gio" ,rust-gio-0.17)
+                       ("rust-glib" ,rust-glib-0.17)
+                       ("rust-libc" ,rust-libc-0.2)
+                       ("rust-pango" ,rust-pango-0.17))
+       #:cargo-development-inputs (("rust-gir-format-check" ,rust-gir-format-check-0.1))))
+    (native-inputs (list pkg-config))
+    (inputs (list cairo gdk-pixbuf glib gtk pango))
+    (home-page "https://gtk-rs.org/")
+    (synopsis "Rust bindings of the GDK 4 library")
+    (description "This package provides the Rust bindings of the GDK 4
+library.")
+    (license license:expat)))
+
+(define-public rust-gdk4-sys-0.6
+  (package
+    (name "rust-gdk4-sys")
+    (version "0.6.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (crate-uri "gdk4-sys" version))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32 "0r7dm9vyzg2xlzdgxqa190gd1403mhw4q09x754rq24cc2hjmj8v"))))
+    (build-system cargo-build-system)
+    (arguments
+     `(#:cargo-inputs (("rust-cairo-sys-rs" ,rust-cairo-sys-rs-0.17)
+                       ("rust-gdk-pixbuf-sys" ,rust-gdk-pixbuf-sys-0.17)
+                       ("rust-gio-sys" ,rust-gio-sys-0.17)
+                       ("rust-glib-sys" ,rust-glib-sys-0.17)
+                       ("rust-gobject-sys" ,rust-gobject-sys-0.17)
+                       ("rust-libc" ,rust-libc-0.2)
+                       ("rust-pango-sys" ,rust-pango-sys-0.17)
+                       ("rust-pkg-config" ,rust-pkg-config-0.3)
+                       ("rust-system-deps" ,rust-system-deps-6))
+       #:cargo-development-inputs (("rust-shell-words" ,rust-shell-words-1)
+                                   ("rust-tempfile" ,rust-tempfile-3))))
+    (native-inputs (list pkg-config))
+    (inputs (list cairo gdk-pixbuf glib gtk pango))
+    (home-page "https://gtk-rs.org/")
+    (synopsis "FFI bindings of GDK 4")
+    (description "This package provides the FFI bindings of GDK 4.")
+    (license license:expat)))
+
 (define-public rust-gio-0.17
   (package
     (name "rust-gio")
@@ -1711,6 +1774,130 @@ (define-public rust-gobject-sys-0.9
        (("rust-shell-words" ,rust-shell-words-0.1)
         ("rust-tempfile" ,rust-tempfile-3))))))
 
+(define-public rust-graphene-rs-0.17
+  (package
+    (name "rust-graphene-rs")
+    (version "0.17.10")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (crate-uri "graphene-rs" version))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32 "1na0kg5q746kpg0x8hic06rqknbjs9050i85idafsnav4q0vpx6y"))))
+    (build-system cargo-build-system)
+    (arguments
+     `(#:tests? #f ;`Errors` cannot be formatted with the default formatter.
+       #:cargo-inputs (("rust-glib" ,rust-glib-0.17)
+                       ("rust-graphene-sys" ,rust-graphene-sys-0.17)
+                       ("rust-libc" ,rust-libc-0.2))
+       #:cargo-development-inputs (("rust-gir-format-check" ,rust-gir-format-check-0.1))))
+    (native-inputs (list pkg-config))
+    (inputs (list glib graphene))
+    (home-page "https://gtk-rs.org/")
+    (synopsis "Rust bindings for the Graphene library")
+    (description "This package provides the Rust bindings for the Graphene
+library.")
+    (license license:expat)))
+
+(define-public rust-graphene-sys-0.17
+  (package
+    (name "rust-graphene-sys")
+    (version "0.17.10")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (crate-uri "graphene-sys" version))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32 "07dj19zwffl0h8qjs7lxf3czb5p2myixj2zadkiparkags0zqmhq"))))
+    (build-system cargo-build-system)
+    (arguments
+     `(#:cargo-inputs (("rust-glib-sys" ,rust-glib-sys-0.17)
+                       ("rust-libc" ,rust-libc-0.2)
+                       ("rust-pkg-config" ,rust-pkg-config-0.3)
+                       ("rust-system-deps" ,rust-system-deps-6))
+       #:cargo-development-inputs (("rust-shell-words" ,rust-shell-words-1)
+                                   ("rust-tempfile" ,rust-tempfile-3))))
+    (native-inputs (list pkg-config))
+    (inputs (list glib graphene))
+    (home-page "https://gtk-rs.org/")
+    (synopsis "FFI bindings to libgraphene-1.0")
+    (description "This package provides FFI bindings to libgraphene-1.0.")
+    (license license:expat)))
+
+(define-public rust-gsk4-0.6
+  (package
+    (name "rust-gsk4")
+    (version "0.6.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (crate-uri "gsk4" version))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32 "0g1srhahmhdl6rqbz98bawzf1gp6hf9m4y4rvbi1bb3wz92fy0bg"))))
+    (build-system cargo-build-system)
+    (arguments
+     `(#:tests? #f ;`Errors` cannot be formatted with the default formatter.
+       #:cargo-inputs (("rust-bitflags" ,rust-bitflags-1)
+                       ("rust-cairo-rs" ,rust-cairo-rs-0.17)
+                       ("rust-gdk4" ,rust-gdk4-0.6)
+                       ("rust-glib" ,rust-glib-0.17)
+                       ("rust-graphene-rs" ,rust-graphene-rs-0.17)
+                       ("rust-gsk4-sys" ,rust-gsk4-sys-0.6)
+                       ("rust-libc" ,rust-libc-0.2)
+                       ("rust-pango" ,rust-pango-0.17))
+       #:cargo-development-inputs (("rust-gir-format-check" ,rust-gir-format-check-0.1))))
+    (native-inputs (list pkg-config))
+    (inputs (list cairo
+                  gdk-pixbuf
+                  glib
+                  graphene
+                  gtk
+                  pango))
+    (home-page "https://gtk-rs.org/")
+    (synopsis "Rust bindings of the GSK 4 library")
+    (description "This package provides the Rust bindings of the GSK 4
+library.")
+    (license license:expat)))
+
+(define-public rust-gsk4-sys-0.6
+  (package
+    (name "rust-gsk4-sys")
+    (version "0.6.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (crate-uri "gsk4-sys" version))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32 "1c013zdd0yzcfmkz1gj28dbfz2zmypi8baimjk9264yg9pxq8yn0"))))
+    (build-system cargo-build-system)
+    (arguments
+     `(#:tests? #f ;tests FAILED
+       #:cargo-inputs (("rust-cairo-sys-rs" ,rust-cairo-sys-rs-0.17)
+                       ("rust-gdk4-sys" ,rust-gdk4-sys-0.6)
+                       ("rust-glib-sys" ,rust-glib-sys-0.17)
+                       ("rust-gobject-sys" ,rust-gobject-sys-0.17)
+                       ("rust-graphene-sys" ,rust-graphene-sys-0.17)
+                       ("rust-libc" ,rust-libc-0.2)
+                       ("rust-pango-sys" ,rust-pango-sys-0.17)
+                       ("rust-system-deps" ,rust-system-deps-6))
+       #:cargo-development-inputs (("rust-shell-words" ,rust-shell-words-1)
+                                   ("rust-tempfile" ,rust-tempfile-3))))
+    (native-inputs (list pkg-config))
+    (inputs (list cairo
+                  gdk-pixbuf
+                  glib
+                  graphene
+                  gtk
+                  pango))
+    (home-page "https://gtk-rs.org/")
+    (synopsis "FFI bindings of GSK 4")
+    (description "This package provides the FFI bindings of GSK 4.")
+    (license license:expat)))
+
 (define-public rust-gstreamer-0.18
   (package
     (name "rust-gstreamer")
@@ -2187,6 +2374,110 @@ (define-public rust-gtk3-macros-0.14
 library.")
     (license license:expat)))
 
+(define-public rust-gtk4-0.6
+  (package
+    (name "rust-gtk4")
+    (version "0.6.6")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (crate-uri "gtk4" version))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32 "12y8ck3y555mvv65lwm7l19f23wycq68ngwql0afyp6p9jh352mj"))))
+    (build-system cargo-build-system)
+    (arguments
+     `(#:tests? #f ;`Errors` cannot be formatted with the default formatter.
+       #:cargo-inputs (("rust-bitflags" ,rust-bitflags-1)
+                       ("rust-cairo-rs" ,rust-cairo-rs-0.17)
+                       ("rust-field-offset" ,rust-field-offset-0.3)
+                       ("rust-futures-channel" ,rust-futures-channel-0.3)
+                       ("rust-gdk-pixbuf" ,rust-gdk-pixbuf-0.17)
+                       ("rust-gdk4" ,rust-gdk4-0.6)
+                       ("rust-gio" ,rust-gio-0.17)
+                       ("rust-glib" ,rust-glib-0.17)
+                       ("rust-graphene-rs" ,rust-graphene-rs-0.17)
+                       ("rust-gsk4" ,rust-gsk4-0.6)
+                       ("rust-gtk4-macros" ,rust-gtk4-macros-0.6)
+                       ("rust-gtk4-sys" ,rust-gtk4-sys-0.6)
+                       ("rust-libc" ,rust-libc-0.2)
+                       ("rust-once-cell" ,rust-once-cell-1)
+                       ("rust-pango" ,rust-pango-0.17))
+       #:cargo-development-inputs (("rust-gir-format-check" ,rust-gir-format-check-0.1))))
+    (native-inputs (list pkg-config))
+    (inputs (list cairo gdk-pixbuf glib gtk pango))
+    (home-page "https://gtk-rs.org/")
+    (synopsis "Rust bindings of the GTK 4 library")
+    (description "This package provides Rust bindings of the GTK 4
+library.")
+    (license license:expat)))
+
+(define-public rust-gtk4-macros-0.6
+  (package
+    (name "rust-gtk4-macros")
+    (version "0.6.6")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (crate-uri "gtk4-macros" version))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32 "03shq84fvay3zqdccr2j22v6kkdi8fj4v61dakpd6xhgaxhnnkba"))))
+    (build-system cargo-build-system)
+    (arguments
+     `(#:tests? #f ;tests FAILED
+       #:cargo-inputs (("rust-anyhow" ,rust-anyhow-1)
+                       ("rust-proc-macro-crate" ,rust-proc-macro-crate-1)
+                       ("rust-proc-macro-error" ,rust-proc-macro-error-1)
+                       ("rust-proc-macro2" ,rust-proc-macro2-1)
+                       ("rust-quick-xml" ,rust-quick-xml-0.27)
+                       ("rust-quote" ,rust-quote-1)
+                       ("rust-syn" ,rust-syn-1))
+       #:cargo-development-inputs (("rust-futures-channel" ,rust-futures-channel-0.3)
+                                   ("rust-futures-util" ,rust-futures-util-0.3)
+                                   ("rust-gtk4" ,rust-gtk4-0.6)
+                                   ("rust-trybuild2" ,rust-trybuild2-1))))
+    (native-inputs (list pkg-config))
+    (inputs (list gtk))
+    (home-page "https://gtk-rs.org/")
+    (synopsis "Macros helpers for GTK 4 bindings")
+    (description "This package provides macros helpers for GTK 4 bindings.")
+    (license license:expat)))
+
+(define-public rust-gtk4-sys-0.6
+  (package
+    (name "rust-gtk4-sys")
+    (version "0.6.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (crate-uri "gtk4-sys" version))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32 "0bz26ix7pl4d1m63zacaw1vw5021vm5r7wn7fsg02zmh0zvq70jz"))))
+    (build-system cargo-build-system)
+    (arguments
+     `(#:tests? #f
+       #:cargo-inputs (("rust-cairo-sys-rs" ,rust-cairo-sys-rs-0.17)
+                       ("rust-gdk-pixbuf-sys" ,rust-gdk-pixbuf-sys-0.17)
+                       ("rust-gdk4-sys" ,rust-gdk4-sys-0.6)
+                       ("rust-gio-sys" ,rust-gio-sys-0.17)
+                       ("rust-glib-sys" ,rust-glib-sys-0.17)
+                       ("rust-gobject-sys" ,rust-gobject-sys-0.17)
+                       ("rust-graphene-sys" ,rust-graphene-sys-0.17)
+                       ("rust-gsk4-sys" ,rust-gsk4-sys-0.6)
+                       ("rust-libc" ,rust-libc-0.2)
+                       ("rust-pango-sys" ,rust-pango-sys-0.17)
+                       ("rust-system-deps" ,rust-system-deps-6))
+       #:cargo-development-inputs (("rust-shell-words" ,rust-shell-words-1)
+                                   ("rust-tempfile" ,rust-tempfile-3))))
+    (native-inputs (list pkg-config))
+    (inputs (list cairo gdk-pixbuf glib gtk pango))
+    (home-page "https://gtk-rs.org/")
+    (synopsis "FFI bindings of GTK 4")
+    (description "This package provides the FFI bindings of GTK 4.")
+    (license license:expat)))
+
 (define-public rust-pango-0.17
   (package
     (name "rust-pango")

base-commit: 0d13d095420861022e68e87ceebd5e037e12a8b3
-- 
2.41.0

Message #17 received at 52530 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Herman Rimm <herman <at> rimm.ee>
Cc: 52530 <at> debbugs.gnu.org, Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re: bug#52530: [PATCH core-updates-frozen] WIP: Add rust-gtk4 and
 dependencies
Date: Sun, 21 Jan 2024 23:46:43 -0500

Hi Herman,

Herman Rimm <herman <at> rimm.ee> writes:

> * gnu/packages/crates-gtk.scm (rust-gdk4-0.6): New variable.
> (rust-graphene-rs-0.17): New variable.
> (rust-graphene-sys-0.17): New variable.
> (rust-gsk4-0.6): New variable.
> (rust-gsk4-sys-0.6): New variable.
> (rust-gtk4-0.6): New variable.
> (rust-gtk4-macros-0.6): New variable.
> (rust-gtk4-sys-0.6): New variable.
> ---
> Hello,
>
> Should each package be added in a separate patch?

That's our convention, yes!  Could you please send a v2 with one package
per commit?

> The latest gtk4-rs version is 0.7, I chose 0.6 because it has more
> compatible dependencies. gtk4-rs can be updated to 0.7 together with
> those dependencies. For the new packages, guix lint notes the newer
> version and that the source is not archived on Software Heritage etc..
>
> The package descriptions are still single sentences, so it can't be
> merged. But I mail this patch for people who would like to use newer
> gtk4-rs packages despite that. Please improve the descriptions if you
> feel like it.

It'd be nice if you could write a few more words about what features
these packages provides and try a bit harder for the tests (at least to
the point where a more detailed comment about the situation can be
written than "tests failed").

-- 
Thanks,
Maxim

Message #20 received at 52530 <at> debbugs.gnu.org (full text, mbox):

From: Herman Rimm <herman <at> rimm.ee>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, 52530 <at> debbugs.gnu.org
Subject: Re: bug#52530: [PATCH core-updates-frozen] WIP: Add rust-gtk4 and
 dependencies
Date: Thu, 25 Jan 2024 18:47:03 +0100

Hi Maxim,

Apologies, it seems rust-gtk4-rs and dependency packages were also
written by Sergio Pastor Pérez and merged into rust-team. Aside from the
descriptions and comments, the diff is:

diff --git a/gnu/packages/crates-gtk.scm b/gnu/packages/crates-gtk.scm
index 51f02788d3..6d419c0318 100644
--- a/gnu/packages/crates-gtk.scm
+++ b/gnu/packages/crates-gtk.scm
@@ -2660,14 +2660,13 @@ (define-public rust-gtk4-macros-0.7
                        ("rust-proc-macro2" ,rust-proc-macro2-1)
                        ("rust-quick-xml" ,rust-quick-xml-0.30)
                        ("rust-quote" ,rust-quote-1)
-                       ("rust-gtk4" ,rust-gtk4-0.7)
                        ("rust-syn" ,rust-syn-1))
        #:cargo-development-inputs (("rust-futures-channel" ,rust-futures-channel-0.3)
                                    ("rust-futures-util" ,rust-futures-util-0.3)
                                    ("rust-gtk4" ,rust-gtk4-0.7)
                                    ("rust-trybuild2" ,rust-trybuild2-1))))
     (native-inputs (list pkg-config))
-    (inputs (list gdk-pixbuf gtk))
+    (inputs (list gtk))
     (home-page "https://gtk-rs.org/")
     (synopsis "Macros helpers for GTK 4 bindings")
     (description "Macros helpers for GTK 4 bindings.")

You can close this thread (or could I?).

Cheers,
Herman

Message #25 received at 52530-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Herman Rimm <herman <at> rimm.ee>
Cc: 52530-done <at> debbugs.gnu.org
Subject: Re: bug#52530: [PATCH core-updates-frozen] WIP: Add rust-gtk4 and
 dependencies
Date: Fri, 26 Jan 2024 22:15:33 -0500

Hi Herman,

Herman Rimm <herman <at> rimm.ee> writes:

> Hi Maxim,
>
> Apologies, it seems rust-gtk4-rs and dependency packages were also
> written by Sergio Pastor Pérez and merged into rust-team. Aside from the
> descriptions and comments, the diff is:
>
> diff --git a/gnu/packages/crates-gtk.scm b/gnu/packages/crates-gtk.scm
> index 51f02788d3..6d419c0318 100644
> --- a/gnu/packages/crates-gtk.scm
> +++ b/gnu/packages/crates-gtk.scm
> @@ -2660,14 +2660,13 @@ (define-public rust-gtk4-macros-0.7
>                         ("rust-proc-macro2" ,rust-proc-macro2-1)
>                         ("rust-quick-xml" ,rust-quick-xml-0.30)
>                         ("rust-quote" ,rust-quote-1)
> -                       ("rust-gtk4" ,rust-gtk4-0.7)
>                         ("rust-syn" ,rust-syn-1))
>         #:cargo-development-inputs (("rust-futures-channel" ,rust-futures-channel-0.3)
>                                     ("rust-futures-util" ,rust-futures-util-0.3)
>                                     ("rust-gtk4" ,rust-gtk4-0.7)
>                                     ("rust-trybuild2" ,rust-trybuild2-1))))
>      (native-inputs (list pkg-config))
> -    (inputs (list gdk-pixbuf gtk))
> +    (inputs (list gtk))
>      (home-page "https://gtk-rs.org/")
>      (synopsis "Macros helpers for GTK 4 bindings")
>      (description "Macros helpers for GTK 4 bindings.")
>
> You can close this thread (or could I?).

Thanks for the heads-up.  I'm closing this thread by replying to
52530-done <at> debbugs.gnu.org in CC.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.