GNU bug report logs - #52607
[PATCH] gnu: Add myrddin.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52607 in the body.
You can then email your comments to 52607 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: Jorge Acereda <jacereda <at> gmail.com>, Guix Together <jgart <at> dismail.de>,
 Raghav Gururajan <rg <at> raghavgururajan.name>
Subject: [PATCH] gnu: Add myrddin.
Date: Sat, 18 Dec 2021 15:16:36 -0500

From: Guix Together <jgart <at> dismail.de>

Hi Guixers,

This is one of the packages that we worked on in the packaging meetup today.

all best,

jgart

* gnu/local.mk (GNU_SYSTEM_MODULES): Add myrddin.scm.
* gnu/packages/myrddin.scm: New file.

Co-authored-by: jgart <jgart <at> dismail.de>
Co-authored-by: Jorge Acereda <jacereda <at> gmail.com>
Co-authored-by: Raghav Gururajan <rg <at> raghavgururajan.name>
---
 gnu/local.mk             |  1 +
 gnu/packages/myrddin.scm | 66 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 67 insertions(+)
 create mode 100644 gnu/packages/myrddin.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index 76403bbdf9..7eb3eb3d33 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -411,6 +411,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/music.scm			\
   %D%/packages/musl.scm				\
   %D%/packages/mtools.scm			\
+  %D%/packages/myrddin.scm			\
   %D%/packages/nano.scm				\
   %D%/packages/ncdu.scm				\
   %D%/packages/ncurses.scm			\
diff --git a/gnu/packages/myrddin.scm b/gnu/packages/myrddin.scm
new file mode 100644
index 0000000000..0633fb4fb2
--- /dev/null
+++ b/gnu/packages/myrddin.scm
@@ -0,0 +1,66 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2021 Guix Together <jgart <at> dismail.de>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages myrddin)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix utils)
+  #:use-module (guix download)
+  #:use-module (guix git-download)
+  #:use-module (gnu packages bison)
+  #:use-module (gnu packages pkg-config)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages))
+
+(define-public myrddin
+  (package
+    (name "myrddin")
+    (version "0.3.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri
+        (git-reference
+         (url "https://github.com/oridb/mc")
+         (commit (string-append "r" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0acqqz74ypmjvi1yqz7g1ymyk3mmkzwqgmdd3s7s287bdy4a72gc"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:make-flags
+       (list
+        (string-append "CC=" ,(cc-for-target))
+        (string-append "PREFIX=" %output))
+       #:phases
+       (modify-phases %standard-phases
+        (replace 'build
+          (lambda* (#:key make-flags #:allow-other-keys)
+            (apply invoke "make" "bootstrap" make-flags)
+            (apply invoke "make" make-flags))))))
+    (native-inputs
+     (list bison pkg-config))
+    (home-page "https://myrlang.org")
+    (synopsis "Systems language that is both powerful and fun to use")
+    (description
+"Myrddin is a systems language that is both powerful and fun to
+use.  It aims for C like low level control, a lightweight high quality
+implementation, and features you may find familiar from languages like
+like rust and ocaml.  This combination makes Myrddin suitable for anything
+ranging from desktop applications, to embedded systems and potentially
+even kernel development.")
+    (license license:expat)))
-- 
2.34.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: jgart via Guix-patches via <guix-patches <at> gnu.org>, 52607 <at> debbugs.gnu.org
Cc: Guix Together <jgart <at> dismail.de>, Jorge Acereda <jacereda <at> gmail.com>,
 Raghav Gururajan <rg <at> raghavgururajan.name>
Subject: Re: [bug#52607] [PATCH] gnu: Add myrddin.
Date: Thu, 23 Dec 2021 14:32:18 +0100

[Message part 1 (text/plain, inline)]

Hi,

jgart via schrieb am Samstag der 18. Dezember 2021 um 15:16 -05:

> Hi Guixers,
>
> This is one of the packages that we worked on in the packaging meetup today.
>
> all best,
>
> jgart

This part should go under the “---” line, otherwise they will be part of
the commit message.

> * gnu/local.mk (GNU_SYSTEM_MODULES): Add myrddin.scm.
> * gnu/packages/myrddin.scm: New file.
>
> Co-authored-by: jgart <jgart <at> dismail.de>
> Co-authored-by: Jorge Acereda <jacereda <at> gmail.com>
> Co-authored-by: Raghav Gururajan <rg <at> raghavgururajan.name>
> ---
>  gnu/local.mk             |  1 +
>  gnu/packages/myrddin.scm | 66 ++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 67 insertions(+)
>  create mode 100644 gnu/packages/myrddin.scm
>
> diff --git a/gnu/packages/myrddin.scm b/gnu/packages/myrddin.scm
> new file mode 100644
> index 0000000000..0633fb4fb2
> --- /dev/null
> +++ b/gnu/packages/myrddin.scm
> @@ -0,0 +1,66 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2021 Guix Together <jgart <at> dismail.de>

I am not a laywer, but is “Guix Together” a legal entity?  It’s probably
better to put the authors’ names here instead.

> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages myrddin)
> +  #:use-module (guix build-system gnu)
> +  #:use-module (guix utils)
> +  #:use-module (guix download)
> +  #:use-module (guix git-download)
> +  #:use-module (gnu packages bison)
> +  #:use-module (gnu packages pkg-config)
> +  #:use-module ((guix licenses) #:prefix license:)
> +  #:use-module (guix packages))
> +
> +(define-public myrddin
> +  (package
> +    (name "myrddin")
> +    (version "0.3.1")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri
> +        (git-reference
> +         (url "https://github.com/oridb/mc")
> +         (commit (string-append "r" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "0acqqz74ypmjvi1yqz7g1ymyk3mmkzwqgmdd3s7s287bdy4a72gc"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:make-flags
> +       (list
> +        (string-append "CC=" ,(cc-for-target))
> +        (string-append "PREFIX=" %output))

Nitpick: The new Gexp style could be used instead.

--8<---------------cut here---------------start------------->8---
(list
 #:make-flags
 #~(list (string-append "CC=" #$(cc-for-target))
         (string-append "PREFIX=" #$output))
 #:phases
 '(modify-phases %standard-phases
     (replace 'build
       (lambda* (#:key make-flags #:allow-other-keys)
         (apply invoke "make" "bootstrap" make-flags)
         (apply invoke "make" make-flags)))))
--8<---------------cut here---------------end--------------->8---

> +       #:phases
> +       (modify-phases %standard-phases
> +        (replace 'build
> +          (lambda* (#:key make-flags #:allow-other-keys)
> +            (apply invoke "make" "bootstrap" make-flags)
> +            (apply invoke "make" make-flags))))))

The ‘parallel-build?’ flag should also be respected.

> +    (native-inputs
> +     (list bison pkg-config))
> +    (home-page "https://myrlang.org")
> +    (synopsis "Systems language that is both powerful and fun to use")

This sounds like an advert; I suggest

  “Programming language that aims for control and simplicity”
  
> +    (description
> +"Myrddin is a systems language that is both powerful and fun to
> +use.  It aims for C like low level control, a lightweight high quality

Again, “fun” is probably not the best word.  “high quality” is
subjective and as a user, it doesn’t really tell me anything.

> +implementation, and features you may find familiar from languages like
> +like rust and ocaml.  This combination makes Myrddin suitable for anything

Capitalize “Rust” and “OCaml”.

Package builds fine!

--8<---------------cut here---------------start------------->8---
Result of running `guix review 20211218201635.17995-1-jgart <at> dismail.de': (still a WIP)

  Successfully built 1 out of 1 package(s).

  No lint warnings were emitted.
--8<---------------cut here---------------end--------------->8---

[signature.asc (application/pgp-signature, inline)]

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: jgart via Guix-patches via <guix-patches <at> gnu.org>
Cc: Jorge Acereda <jacereda <at> gmail.com>, 52607-done <at> debbugs.gnu.org,
 jgart <jgart <at> dismail.de>, Raghav Gururajan <rg <at> raghavgururajan.name>
Subject: Re: [bug#52607] [PATCH] gnu: Add myrddin.
Date: Fri, 14 Jan 2022 22:17:50 +0100

Hello,

jgart via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/local.mk (GNU_SYSTEM_MODULES): Add myrddin.scm.
> * gnu/packages/myrddin.scm: New file.
I gexp-ified the package definition, tweaked the synopsis and
description, and applied your patch.

Thanks.

Regards,
-- 
Nicolas Goaziou

Message #22 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: Raghav Gururajan <rg <at> raghavgururajan.name>, 52607-done <at> debbugs.gnu.org,
 Jorge Acereda <jacereda <at> gmail.com>,
 jgart via Guix-patches via <guix-patches <at> gnu.org>
Subject: Re: [bug#52607] [PATCH] gnu: Add myrddin.
Date: Fri, 14 Jan 2022 16:26:24 -0500

On Fri, 14 Jan 2022 22:17:50 +0100 Nicolas Goaziou <mail <at> nicolasgoaziou.fr> wrote:
> Hello,
> 
> jgart via Guix-patches via <guix-patches <at> gnu.org> writes:
> 
> > * gnu/local.mk (GNU_SYSTEM_MODULES): Add myrddin.scm.
> > * gnu/packages/myrddin.scm: New file.
> I gexp-ified the package definition, tweaked the synopsis and
> description, and applied your patch.
> 
> Thanks.
> 
> Regards,
> -- 
> Nicolas Goaziou

Thank you so much! 

I removed it from guixrus now:

https://git.sr.ht/~whereiseveryone/guixrus/commit/e91e3c463ebad8048ec9a3e99f8ceb52ce534f48

all best,

jgart

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.