GNU bug report logs - #5264
23.1; `repeat' should not hard-code the set of affected commands

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Severity: minor; Reported by: "Drew Adams" <drew.adams@HIDDEN>; dated Tue, 6 Oct 2009 18:55:07 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 5264 <at> debbugs.gnu.org:


Received: (at 5264) by debbugs.gnu.org; 27 Apr 2016 21:17:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 27 17:17:48 2016
Received: from localhost ([127.0.0.1]:50814 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1avWqB-0003Jy-P9
	for submit <at> debbugs.gnu.org; Wed, 27 Apr 2016 17:17:47 -0400
Received: from hermes.netfonds.no ([80.91.224.195]:50639)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1avWqA-0003Jr-Dq
 for 5264 <at> debbugs.gnu.org; Wed, 27 Apr 2016 17:17:46 -0400
Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse)
 by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <larsi@HIDDEN>)
 id 1avWq7-0003jV-T4; Wed, 27 Apr 2016 23:17:45 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: "Drew Adams" <drew.adams@HIDDEN>
Subject: Re: bug#5264: 23.1;
 `repeat' should not hard-code the set of affected commands
References: <829F48EB8E68453A956D490A63FD97CB@HIDDEN>
Date: Wed, 27 Apr 2016 23:17:43 +0200
In-Reply-To: <829F48EB8E68453A956D490A63FD97CB@HIDDEN> (Drew Adams's
 message of "Thu, 24 Dec 2009 07:30:20 -0800")
Message-ID: <87a8keu4y0.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 5264
Cc: 5264 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.0 (/)

"Drew Adams" <drew.adams@HIDDEN> writes:

> In the definition of command `repeat':
>
> (if (memq last-repeatable-command
>     '(exit-minibuffer
>       minibuffer-complete-and-exit
>       self-insert-and-exit))
>
> This list of affected commands should not be hard-coded.  If user code
> uses different functions from `exit-minibuffer' and
> `minibuffer-complete-and-exit', then users must redefine `repeat' to
> accommodate this command difference.  The `repeat' definition should
> be more flexible than that.
>
> This list of commands should be treated the same way we treat the list
> of dangerous commands (`repeat-too-dangerous'): define a variable
> whose value is the list of commands - do not hard-code the list.

But what it is this does?  If `last-repeatable-command' is any of these
commands, then we...  repeat the first command in `command-history'
instead?  What does that do, exactly?

    (if (memq last-repeatable-command '(exit-minibuffer
					minibuffer-complete-and-exit
					self-insert-and-exit))
        (let ((repeat-command (car command-history)))
          (repeat-message "Repeating %S" repeat-command)
          (eval repeat-command))
      (if (null repeat-arg)
          (repeat-message "Repeating command %S" last-repeatable-command)
        (setq current-prefix-arg repeat-arg)
        (repeat-message
	 "Repeating command %S %S" repeat-arg last-repeatable-command))


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#5264; Package emacs. Full text available.

Message received at 5264 <at> debbugs.gnu.org:


Received: (at 5264) by debbugs.gnu.org; 10 Feb 2014 03:29:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 09 22:29:46 2014
Received: from localhost ([127.0.0.1]:33164 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1WChZ3-0005ML-Nd
	for submit <at> debbugs.gnu.org; Sun, 09 Feb 2014 22:29:45 -0500
Received: from hermes.netfonds.no ([80.91.224.195]:52972)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <larsi@HIDDEN>) id 1WChZ1-0005MC-Gq
 for 5264 <at> debbugs.gnu.org; Sun, 09 Feb 2014 22:29:44 -0500
Received: from [204.14.154.233] (helo=building.gnus.org)
 by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.72) (envelope-from <larsi@HIDDEN>)
 id 1WChYk-00056B-RO; Mon, 10 Feb 2014 04:29:27 +0100
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: "Drew Adams" <drew.adams@HIDDEN>
Subject: Re: bug#5264: 23.1;
 `repeat' should not hard-code the set of affected commands
References: <829F48EB8E68453A956D490A63FD97CB@HIDDEN>
Date: Sun, 09 Feb 2014 19:28:14 -0800
In-Reply-To: <829F48EB8E68453A956D490A63FD97CB@HIDDEN> (Drew Adams's
 message of "Thu, 24 Dec 2009 07:30:20 -0800")
Message-ID: <87a9dzhcj5.fsf@HIDDEN>
User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.3.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-MailScanner-ID: 1WChYk-00056B-RO
X-Netfonds-MailScanner: Found to be clean
X-Netfonds-MailScanner-From: larsi@HIDDEN
MailScanner-NULL-Check: 1392607767.38854@zG8nOgjOyRdNFjQzaxxFOw
X-Spam-Status: No
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 5264
Cc: 5264 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.0 (/)

"Drew Adams" <drew.adams@HIDDEN> writes:

> In the definition of command `repeat':
>
> (if (memq last-repeatable-command
>     '(exit-minibuffer
>       minibuffer-complete-and-exit
>       self-insert-and-exit))

[...]

> This list of commands should be treated the same way we treat the list
> of dangerous commands (`repeat-too-dangerous'): define a variable
> whose value is the list of commands - do not hard-code the list.

I agree, but probably not during the feature freeze.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#5264; Package emacs. Full text available.

Message received at (unknown):


Received: (at unknown) by unknown; unknown
	id 1NNpki-0002rK-2L
	for mharc-bug-gnu-emacs@HIDDEN; Thu, 24 Dec 2009 10:37:24 -0500
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NNpkf-0002pv-Tq
	for bug-gnu-emacs@HIDDEN; Thu, 24 Dec 2009 10:37:22 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NNpkb-0002lg-Bu
	for bug-gnu-emacs@HIDDEN; Thu, 24 Dec 2009 10:37:21 -0500
Received: from [199.232.76.173] (port=34432 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NNpka-0002lW-Te
	for bug-gnu-emacs@HIDDEN; Thu, 24 Dec 2009 10:37:16 -0500
Received: from debbugs.gnu.org ([140.186.70.43]:49872)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <Debian-debbugs <at> debbugs.gnu.org>)
	id 1NNpka-0007du-Jn
	for bug-gnu-emacs@HIDDEN; Thu, 24 Dec 2009 10:37:16 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69)
	(envelope-from <Debian-debbugs <at> debbugs.gnu.org>)
	id 1NNpgU-0003Q6-V5; Thu, 24 Dec 2009 10:33:02 -0500
X-Loop: bug-gnu-emacs@HIDDEN
Mail-Followup-To: "Drew Adams" <drew.adams@HIDDEN>, 5264 <at> debbugs.gnu.org
Resent-From: "Drew Adams" <drew.adams@HIDDEN>
Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Resent-To: owner <at> debbugs.gnu.org
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 24 Dec 2009 15:33:02 +0000
Resent-Message-ID: <handler.5264.B.126166876313117 <at> debbugs.gnu.org>
Resent-Sender: bug-gnu-emacs@HIDDEN
X-Emacs-PR-Message: report 5264
X-Emacs-PR-Package: emacs
X-Emacs-PR-Keywords: 
Received: via spool by submit <at> debbugs.gnu.org id=B.126166876313117
	(code B ref -1); Thu, 24 Dec 2009 15:33:02 +0000
Received: (at submit) by debbugs.gnu.org; 24 Dec 2009 15:32:43 +0000
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1NNpgB-0003PV-2i
	for submit <at> debbugs.gnu.org; Thu, 24 Dec 2009 10:32:43 -0500
Received: from fencepost.gnu.org ([140.186.70.10])
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <drew.adams@HIDDEN>) id 1NNpg8-0003PB-TM
	for submit <at> debbugs.gnu.org; Thu, 24 Dec 2009 10:32:41 -0500
Received: from mail.gnu.org ([199.232.76.166]:56316 helo=mx10.gnu.org)
	by fencepost.gnu.org with esmtp (Exim 4.69)
	(envelope-from <drew.adams@HIDDEN>) id 1NNpfy-0001HX-In
	for submit <at> debbugs.gnu.org; Thu, 24 Dec 2009 10:32:31 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <drew.adams@HIDDEN>) id 1NNpfu-0007BK-Ug
	for submit <at> debbugs.gnu.org; Thu, 24 Dec 2009 10:32:30 -0500
Received: from lists.gnu.org ([199.232.76.165]:40747)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <drew.adams@HIDDEN>) id 1NNpfu-0007BE-OR
	for submit <at> debbugs.gnu.org; Thu, 24 Dec 2009 10:32:26 -0500
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NNpfu-00010D-Kf
	for bug-gnu-emacs@HIDDEN; Thu, 24 Dec 2009 10:32:26 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NNpfp-0000yF-Vj
	for bug-gnu-emacs@HIDDEN; Thu, 24 Dec 2009 10:32:26 -0500
Received: from [199.232.76.173] (port=34527 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NNpfp-0000y7-MU
	for bug-gnu-emacs@HIDDEN; Thu, 24 Dec 2009 10:32:21 -0500
Received: from rcsinet12.oracle.com ([148.87.113.124]:35165)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <drew.adams@HIDDEN>) id 1NNpfp-0007Ae-AK
	for bug-gnu-emacs@HIDDEN; Thu, 24 Dec 2009 10:32:21 -0500
Received: from rcsinet15.oracle.com (rcsinet15.oracle.com [148.87.113.117])
	by rcsinet12.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id
	nBOFWH2c011246
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <bug-gnu-emacs@HIDDEN>; Thu, 24 Dec 2009 15:32:18 GMT
Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158])
	by rcsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id
	nBODf2oX012956
	for <bug-gnu-emacs@HIDDEN>; Thu, 24 Dec 2009 15:32:16 GMT
Received: from abhmt012.oracle.com by acsmt353.oracle.com
	with ESMTP id 1224973391261668618; Thu, 24 Dec 2009 07:30:18 -0800
Received: from dradamslap1 (/141.144.169.90)
	by default (Oracle Beehive Gateway v4.0)
	with ESMTP ; Thu, 24 Dec 2009 07:30:18 -0800
From: "Drew Adams" <drew.adams@HIDDEN>
To: <bug-gnu-emacs@HIDDEN>
Date: Thu, 24 Dec 2009 07:30:20 -0800
Message-ID: <829F48EB8E68453A956D490A63FD97CB@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Office Outlook 11
Thread-Index: AcqErgCfNNgUAAl6TMiS09oG56VnLg==
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579
X-Source-IP: acsmt358.oracle.com [141.146.40.158]
X-Auth-Type: Internal IP
X-CT-RefId: str=0001.0A090209.4B338980.01F3:SCFMA4539814,ss=1,fgs=0
X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3)
X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6,
	seldom 2.4 (older, 4)
X-Spam-Score: -5.3 (-----)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -5.6 (-----)
Resent-Date: Thu, 24 Dec 2009 10:33:02 -0500
X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3)
Cc: 
Subject: bug#5264: 23.1; `repeat' should not hard-code the set of affected commands
X-BeenThere: bug-gnu-emacs@HIDDEN
Reply-To: Drew Adams <drew.adams@HIDDEN>, 5264 <at> debbugs.gnu.org
List-Id: "Bug reports for GNU Emacs,
	the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>,
	<mailto:bug-gnu-emacs-request@HIDDEN?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/bug-gnu-emacs>
List-Post: <mailto:bug-gnu-emacs@HIDDEN>
List-Help: <mailto:bug-gnu-emacs-request@HIDDEN?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>,
	<mailto:bug-gnu-emacs-request@HIDDEN?subject=subscribe>
X-List-Received-Date: Thu, 24 Dec 2009 15:37:22 -0000

emacs -Q
 
In the definition of command `repeat':
 
(if (memq last-repeatable-command
    '(exit-minibuffer
      minibuffer-complete-and-exit
      self-insert-and-exit))
 
This list of affected commands should not be hard-coded.  If user code
uses different functions from `exit-minibuffer' and
`minibuffer-complete-and-exit', then users must redefine `repeat' to
accommodate this command difference.  The `repeat' definition should
be more flexible than that.
 
This list of commands should be treated the same way we treat the list
of dangerous commands (`repeat-too-dangerous'): define a variable
whose value is the list of commands - do not hard-code the list.
 
 
 
In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600)
 of 2009-07-29 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4)'
 

Report forwarded to bug-submit-list@HIDDEN, svenjoac@HIDDEN, Emacs Bugs <bug-gnu-emacs@HIDDEN>:
bug#5264; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Wed, 27 Apr 2016 21:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.