GNU bug report logs - #52671
glibc patch causes crash on failure to find path to executable

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52671 in the body.
You can then email your comments to 52671 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ivan Kozlov <kanichos <at> yandex.ru>
To: bug-guix <at> gnu.org
Subject: glibc patch causes crash on failure to find path to executable
Date: Mon, 20 Dec 2021 01:14:38 +0300

glibc-dl-cache.patch causes segmentation fault when _dl_get_origin fails (which should be harmless unless there is $ORIGIN in RUNPATH). I found this when running a dynamically linked executable as ‘init’, before /proc was mounted. There needs to be an origin != (char *)-1 check.

Message #8 received at 52671 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Ivan Kozlov <kanichos <at> yandex.ru>
Cc: 52671 <at> debbugs.gnu.org
Subject: Re: bug#52671: glibc patch causes crash on failure to find path to
 executable
Date: Mon, 20 Dec 2021 22:38:23 +0100

Hi,

Ivan Kozlov <kanichos <at> yandex.ru> skribis:

> glibc-dl-cache.patch causes segmentation fault when _dl_get_origin fails (which should be harmless unless there is $ORIGIN in RUNPATH). I found this when running a dynamically linked executable as ‘init’, before /proc was mounted. There needs to be an origin != (char *)-1 check.

Ouch.  Would you like to send a patch against glibc-dl-cache.patch?

Thanks,
Ludo’.

Message #13 received at 52671 <at> debbugs.gnu.org (full text, mbox):

From: Ivan Kozlov <kanichos <at> yandex.ru>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 52671 <at> debbugs.gnu.org
Subject: Re:bug#52671: glibc patch causes crash on failure to find path to
 executable
Date: Thu, 13 Jan 2022 01:04:34 +0300

Just in case, http://debbugs.gnu.org/cgi/bugreport.cgi?bug=52693 addresses this.

Message #18 received at 52671-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Ivan Kozlov <kanichos <at> yandex.ru>
Cc: 52693-done <at> debbugs.gnu.org, 52671-done <at> debbugs.gnu.org
Subject: Re: bug#52693: [PATCH] gnu: glibc: Handle failure to find $ORIGIN.
Date: Mon, 30 Jan 2023 00:34:40 +0100

Hi Ivan,

Ivan Kozlov <kanichos <at> yandex.ru> skribis:

> Fixes <https://issues.guix.gnu.org/52671>.
>
> * gnu/packages/patches/glibc-dl-cache.patch: Check pointer returned by '_dl_get_origin' for failure indication.

Somehow we forgot about this patch for a whole year, and it turns out I
stumbled upon the bug again just hours ago¹.

Now pushed to ‘core-updates’ as
edb8c09addd186d9538d43b12af74d6c7aeea082.

Thanks again, and apologies for the delay!

Ludo’.

¹ https://issues.guix.gnu.org/61156

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.