GNU bug report logs -
#52697
29.0.50; pgtk: wrong initial frame parameter values
Previous Next
Reported by: Stephen Berman <stephen.berman <at> gmx.net>
Date: Tue, 21 Dec 2021 09:06:02 UTC
Severity: normal
Found in version 29.0.50
Done: Stephen Berman <stephen.berman <at> gmx.net>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52697 in the body.
You can then email your comments to 52697 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#52697
; Package
emacs
.
(Tue, 21 Dec 2021 09:06:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Stephen Berman <stephen.berman <at> gmx.net>
:
New bug report received and forwarded. Copy sent to
bug-gnu-emacs <at> gnu.org
.
(Tue, 21 Dec 2021 09:06:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
With Emacs built from master without pgtk, I start with -Q and evaluate
the following sexps, yielding the results shown:
(alist-get 'left (frame-parameters))
939
(alist-get 'top (frame-parameters))
371
With Emacs built from master with pgtk, I start with -Q and evaluate
the same sexps, yielding the following results:
(alist-get 'left (frame-parameters))
0
(alist-get 'top (frame-parameters))
0
The results in the non-pgtk build are correct: the frame is in the
middle of the screen, not in the upper left corner. This is with Xfce
and the xfwm4 window manager.
In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.29, cairo version 1.17.4)
of 2021-12-20 built on strobelfs
Repository revision: de797bb853e85e3cc3c9ec71f51e4e78e41af4ab
Repository branch: master
Windowing system distributor 'System Description: Linux From Scratch 10.2-rc1
Configured using:
'configure --with-pgtk 'CFLAGS=-Og -g3''
Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LCMS2 LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PGTK PNG RSVG
SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP XIM GTK3
ZLIB
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#52697
; Package
emacs
.
(Tue, 08 Feb 2022 11:59:01 GMT)
Full text and
rfc822 format available.
Message #8 received at 52697 <at> debbugs.gnu.org (full text, mbox):
Stephen Berman <stephen.berman <at> gmx.net> writes:
> With Emacs built from master without pgtk, I start with -Q and evaluate
> the following sexps, yielding the results shown:
>
> (alist-get 'left (frame-parameters))
> 939
>
> (alist-get 'top (frame-parameters))
> 371
>
> With Emacs built from master with pgtk, I start with -Q and evaluate
> the same sexps, yielding the following results:
>
> (alist-get 'left (frame-parameters))
> 0
>
> (alist-get 'top (frame-parameters))
> 0
>
> The results in the non-pgtk build are correct: the frame is in the
> middle of the screen, not in the upper left corner. This is with Xfce
> and the xfwm4 window manager.
Thanks, should be fixed now on master.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#52697
; Package
emacs
.
(Tue, 08 Feb 2022 12:49:02 GMT)
Full text and
rfc822 format available.
Message #11 received at 52697 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Tue, 08 Feb 2022 19:57:56 +0800 Po Lu <luangruo <at> yahoo.com> wrote:
> Stephen Berman <stephen.berman <at> gmx.net> writes:
>
>> With Emacs built from master without pgtk, I start with -Q and evaluate
>> the following sexps, yielding the results shown:
>>
>> (alist-get 'left (frame-parameters))
>> 939
>>
>> (alist-get 'top (frame-parameters))
>> 371
>>
>> With Emacs built from master with pgtk, I start with -Q and evaluate
>> the same sexps, yielding the following results:
>>
>> (alist-get 'left (frame-parameters))
>> 0
>>
>> (alist-get 'top (frame-parameters))
>> 0
>>
>> The results in the non-pgtk build are correct: the frame is in the
>> middle of the screen, not in the upper left corner. This is with Xfce
>> and the xfwm4 window manager.
>
> Thanks, should be fixed now on master.
Thanks very much, I confirm your patch essentially fixes the bug, except
for mistakenly switching the top and left parameters:
[Message part 2 (text/x-patch, inline)]
diff --git a/src/pgtkterm.c b/src/pgtkterm.c
index e9fd5f83b7..8faffe94d4 100644
--- a/src/pgtkterm.c
+++ b/src/pgtkterm.c
@@ -5552,7 +5552,7 @@ configure_event (GtkWidget *widget,
if (f->win_gravity == NorthWestGravity)
gtk_window_get_position (GTK_WINDOW (widget),
- &f->top_pos, &f->left_pos);
+ &f->left_pos, &f->top_pos);
else
{
f->top_pos = event->configure.y;
[Message part 3 (text/plain, inline)]
Steve Berman
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#52697
; Package
emacs
.
(Tue, 08 Feb 2022 13:40:01 GMT)
Full text and
rfc822 format available.
Message #14 received at 52697 <at> debbugs.gnu.org (full text, mbox):
Stephen Berman <stephen.berman <at> gmx.net> writes:
> Thanks very much, I confirm your patch essentially fixes the bug, except
> for mistakenly switching the top and left parameters:
>
> diff --git a/src/pgtkterm.c b/src/pgtkterm.c
> index e9fd5f83b7..8faffe94d4 100644
> --- a/src/pgtkterm.c
> +++ b/src/pgtkterm.c
> @@ -5552,7 +5552,7 @@ configure_event (GtkWidget *widget,
>
> if (f->win_gravity == NorthWestGravity)
> gtk_window_get_position (GTK_WINDOW (widget),
> - &f->top_pos, &f->left_pos);
> + &f->left_pos, &f->top_pos);
> else
> {
> f->top_pos = event->configure.y;
>
>
> Steve Berman
Thanks, should be fixed now on master.
Reply sent
to
Stephen Berman <stephen.berman <at> gmx.net>
:
You have taken responsibility.
(Tue, 08 Feb 2022 14:13:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
Stephen Berman <stephen.berman <at> gmx.net>
:
bug acknowledged by developer.
(Tue, 08 Feb 2022 14:13:02 GMT)
Full text and
rfc822 format available.
Message #19 received at 52697-done <at> debbugs.gnu.org (full text, mbox):
On Tue, 08 Feb 2022 21:39:17 +0800 Po Lu <luangruo <at> yahoo.com> wrote:
> Stephen Berman <stephen.berman <at> gmx.net> writes:
>
>> Thanks very much, I confirm your patch essentially fixes the bug, except
>> for mistakenly switching the top and left parameters:
>>
>> diff --git a/src/pgtkterm.c b/src/pgtkterm.c
>> index e9fd5f83b7..8faffe94d4 100644
>> --- a/src/pgtkterm.c
>> +++ b/src/pgtkterm.c
>> @@ -5552,7 +5552,7 @@ configure_event (GtkWidget *widget,
>>
>> if (f->win_gravity == NorthWestGravity)
>> gtk_window_get_position (GTK_WINDOW (widget),
>> - &f->top_pos, &f->left_pos);
>> + &f->left_pos, &f->top_pos);
>> else
>> {
>> f->top_pos = event->configure.y;
>>
>>
>> Steve Berman
>
> Thanks, should be fixed now on master.
Thanks, with that I'm closing the bug.
Steve Berman
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Wed, 09 Mar 2022 12:24:11 GMT)
Full text and
rfc822 format available.
This bug report was last modified 2 years and 40 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.