GNU bug report logs - #52716
[PATCH] channels: Add 'branch' to 'channel->code' output.

Previous Next

Package: guix-patches;

Reported by: Brice Waegeneire <brice <at> waegenei.re>

Date: Tue, 21 Dec 2021 20:57:02 UTC

Severity: normal

Tags: patch

Done: Brice Waegeneire <brice <at> waegenei.re>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52716 in the body.
You can then email your comments to 52716 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#52716; Package guix-patches. (Tue, 21 Dec 2021 20:57:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Brice Waegeneire <brice <at> waegenei.re>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 21 Dec 2021 20:57:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: guix-patches <at> gnu.org
Subject: [PATCH] channels: Add 'branch' to 'channel->code' output.
Date: Tue, 21 Dec 2021 21:56:01 +0100

* guix/channels.scm (channel->code): Add 'branch' to output.
---
 guix/channels.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/guix/channels.scm b/guix/channels.scm
index e4e0428eb5..5f47834c10 100644
--- a/guix/channels.scm
+++ b/guix/channels.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2018, 2019, 2020, 2021 Ludovic Courtès <ludo <at> gnu.org>
 ;;; Copyright © 2018 Ricardo Wurmus <rekado <at> elephly.net>
 ;;; Copyright © 2019 Jan (janneke) Nieuwenhuizen <janneke <at> gnu.org>
+;;; Copyright © 2021 Brice Waegeneire <brice <at> waegenei.re>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1009,7 +1010,8 @@ (define* (channel->code channel #:key (include-introduction? #t))
     `(channel
       (name ',(channel-name channel))
       (url ,(channel-url channel))
+      (branch ,(channel-branch channel))
       (commit ,(channel-commit channel))
       ,@(if intro
             `((introduction (make-channel-introduction

-- 
2.34.0
Information forwarded to guix-patches <at> gnu.org:
bug#52716; Package guix-patches. (Thu, 23 Dec 2021 16:46:02 GMT) Full text and rfc822 format available.

Message #8 received at 52716 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: 52716 <at> debbugs.gnu.org
Subject: Re: bug#52716: [PATCH] channels: Add 'branch' to 'channel->code'
 output.
Date: Thu, 23 Dec 2021 17:45:24 +0100

Hello Brice,

> * guix/channels.scm (channel->code): Add 'branch' to output.

Seems fine!

Thanks,

Mathieu
Reply sent to Brice Waegeneire <brice <at> waegenei.re>:
You have taken responsibility. (Sat, 25 Dec 2021 18:51:01 GMT) Full text and rfc822 format available.
Notification sent to Brice Waegeneire <brice <at> waegenei.re>:
bug acknowledged by developer. (Sat, 25 Dec 2021 18:51:02 GMT) Full text and rfc822 format available.

Message #13 received at 52716-close <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 52716-close <at> debbugs.gnu.org
Subject: Re: bug#52716: [PATCH] channels: Add 'branch' to 'channel->code'
 output.
Date: Sat, 25 Dec 2021 19:50:34 +0100

Hello Mathieu,

Mathieu Othacehe <othacehe <at> gnu.org> writes:

>> * guix/channels.scm (channel->code): Add 'branch' to output.
>
> Seems fine!

Thank you for the review, pushed as b891f8519dbea5457d9ad154974b1ab1459b4b8b.

Cheers
- Brice
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 23 Jan 2022 12:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 2 years and 88 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.